Re: R200 minor cleanups

2007-05-14 Thread Oliver McFadden
My thoughts are, we should unify the really common stuff... but I don't think it's possible to unify r200_tex.c and r300_tex.c. The hardware is different, and the file would end up with an #ifdef on every 3rd line; it doesn't make sense here. Just for really common code it does. I don't know what

Re: R200 minor cleanups

2007-05-14 Thread Jerome Glisse
On 5/14/07, Christoph Brill <[EMAIL PROTECTED]> wrote: > Am Montag, den 14.05.2007, 22:53 +0200 schrieb Roland Scheidegger: > > Christoph Brill wrote: > > > Hi, > > > > > > find attached some minor cleanups I did while comparing r200 and r300 > > > code. Most of them are indention and cosmetical ch

Re: R200 minor cleanups

2007-05-14 Thread Christoph Brill
Am Montag, den 14.05.2007, 22:53 +0200 schrieb Roland Scheidegger: > Christoph Brill wrote: > > Hi, > > > > find attached some minor cleanups I did while comparing r200 and r300 > > code. Most of them are indention and cosmetical changes. Only real > > changes are that I replaced som > > > > if (

Re: R200 minor cleanups

2007-05-14 Thread Roland Scheidegger
Christoph Brill wrote: > Hi, > > find attached some minor cleanups I did while comparing r200 and r300 > code. Most of them are indention and cosmetical changes. Only real > changes are that I replaced som > > if (0) > > with > > if (R200_DEBUG & DEBUG_TEXTURE) > > It generally reduces the dif

R200 minor cleanups

2007-05-14 Thread Christoph Brill
Hi, find attached some minor cleanups I did while comparing r200 and r300 code. Most of them are indention and cosmetical changes. Only real changes are that I replaced som if (0) with if (R200_DEBUG & DEBUG_TEXTURE) It generally reduces the diff between r200 and r300. That's it. Review and c

Re: My bug is six months old and I don't even know if anyone's read it

2007-05-14 Thread Jerome Glisse
On 5/14/07, Joseph Mulloy <[EMAIL PROTECTED]> wrote: > At this point I am very annoyed at the fact that the composite > extension still does not work on my laptop. I am still unable to use > Beryl or Compiz. I submitted this bug over 6 months ago and as far as > I can tell it's been completely igno