[Dri-devel] flickering colors on r200 - patch

2004-01-08 Thread Roland Scheidegger
Based on the idea of Felix Kühling that the order in which state atoms are emitted might be important on the radeon, I thought maybe it might be important on the r200 as well, even though there are no lockups. With the attached patch indeed the random color flashings seem to be gone (at least in

Re: [Dri-devel] 2.4.23: user/kernel pointer bugs (drivers/char/vt.c, drivers/char/drm/gamma_dma.c)

2004-01-08 Thread Alan Cox
On Gwe, 2004-01-09 at 00:39, Eric Anholt wrote: > Uhoh, the SiS is my fault. I'll take a look soon. Thats ok - I found it because I screwed up textures on your sis6326 code 8) --- This SF.net email is sponsored by: Perforce Software. Perforc

Re: [Dri-devel] 2.4.23: user/kernel pointer bugs (drivers/char/vt.c, drivers/char/drm/gamma_dma.c)

2004-01-08 Thread Eric Anholt
On Thu, 2004-01-08 at 15:52, Alan Cox wrote: > On Iau, 2004-01-08 at 20:08, Robert T. Johnson wrote: > > Both of these bugs look exploitable. The vt.c patch is > > self-explanatory. > > > > In gamma_dma.c, argument "d" to gamma_dma_priority() points to a > > structure copied from userspace (see

Re: [Dri-devel] 2.4.23: user/kernel pointer bugs (drivers/char/vt.c, drivers/char/drm/gamma_dma.c)

2004-01-08 Thread Alan Cox
On Iau, 2004-01-08 at 20:08, Robert T. Johnson wrote: > Both of these bugs look exploitable. The vt.c patch is > self-explanatory. > > In gamma_dma.c, argument "d" to gamma_dma_priority() points to a > structure copied from userspace (see gamma_dma()). That means that > d->send_indices is a po

Re: [Dri-devel] 2.6.1-rc2-mm1: drm/sis_mm.c compile error

2004-01-08 Thread Alan Cox
On Iau, 2004-01-08 at 15:36, Adrian Bunk wrote: > On Wed, Jan 07, 2004 at 11:28:31PM -0800, Andrew Morton wrote: > >... > > - Added the latest code drop from DRM CVS. People who use DRM, please test > > it. > >... > > I got the following compile error: I got it to crash the kernel. Build with

[Dri-devel] savage and 2d corruption fixed

2004-01-08 Thread Alex Deucher
well, I managed to fix the 2D corruption in tile mode on savage4. the problem is that the bits of the GBD (MM816C) have different meaning on savage4 vs. twister/prosavage. The fix is to use the SavageEnableMode_M7() function for savage4 rather than SavageEnableMode_Twister(). This also negates t

[Dri-devel] 2.4.23: user/kernel pointer bugs (drivers/char/vt.c, drivers/char/drm/gamma_dma.c)

2004-01-08 Thread Robert T. Johnson
Both of these bugs look exploitable. The vt.c patch is self-explanatory. In gamma_dma.c, argument "d" to gamma_dma_priority() points to a structure copied from userspace (see gamma_dma()). That means that d->send_indices is a pointer under user control, so it shouldn't be dereferenced. The pa

[Dri-devel] Re: [Bugme-new] [Bug 1811] New: Error during compile 2.6.1-rc2-mm1

2004-01-08 Thread Andrew Morton
Leandro Piccilli <[EMAIL PROTECTED]> wrote: > > CC drivers/video/sis/sis_main.o > drivers/video/sis/sis_main.c: In function `sisfb_do_set_var': > drivers/video/sis/sis_main.c:622: warning: unused variable `reg' >CC drivers/video/sis/sis_accel.o > . > finishing with this errors:

[Dri-devel] 2.6.1-rc2-mm1: drm/sis_mm.c compile error

2004-01-08 Thread Adrian Bunk
On Wed, Jan 07, 2004 at 11:28:31PM -0800, Andrew Morton wrote: >... > - Added the latest code drop from DRM CVS. People who use DRM, please test > it. >... I got the following compile error: <-- snip --> ... CC drivers/char/drm/sis_mm.o drivers/char/drm/sis_mm.c:37:25: linux/sisfb.h:

[Dri-devel] Re: 2.6.1-rc2-mm1: drm/sis_mm.c compile error

2004-01-08 Thread Andrew Morton
Adrian Bunk <[EMAIL PROTECTED]> wrote: > > drivers/char/drm/sis_mm.c:37:25: linux/sisfb.h: No such file or directory > drivers/char/drm/sis_mm.c: In function `sis_fb_alloc': > drivers/char/drm/sis_mm.c:92: error: storage size of `req' isn't known > drivers/char/drm/sis_mm.c:98: warning: implicit

[Dri-devel] Re: [Bugme-new] [Bug 1811] New: Error during compile 2.6.1-rc2-mm1

2004-01-08 Thread Andrew Morton
Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > > On Thu, 8 Jan 2004, Andrew Morton wrote: > > > > Well sisfb_do_set_var() is using floating point. I guess it has been > > changed in the recent update so the compiler now has to actually emit FP > > library function calls. > > > > It would be be

Re: [Dri-devel] Re: [Bugme-new] [Bug 1811] New: Error during compile 2.6.1-rc2-mm1

2004-01-08 Thread Alan Cox
On Iau, 2004-01-08 at 19:20, Linus Torvalds wrote: > It really looks like all the math should be quite doable with just regular > integer code. You'd need to use 64-bit integer division (some of the > values involved are large), but it doesn't look fundamentally hard. > > Somebody that knows the

[Dri-devel] Re: [Bugme-new] [Bug 1811] New: Error during compile 2.6.1-rc2-mm1

2004-01-08 Thread Linus Torvalds
On Thu, 8 Jan 2004, Andrew Morton wrote: > > Well sisfb_do_set_var() is using floating point. I guess it has been > changed in the recent update so the compiler now has to actually emit FP > library function calls. > > It would be best if that code could be reworked to use integer math. It rea

[Dri-devel] Re: S3 Savage DRM

2004-01-08 Thread Alex Deucher
--- Felix Kühling <[EMAIL PROTECTED]> wrote: > On Wed, 7 Jan 2004 14:56:24 -0800 (PST) > Alex Deucher <[EMAIL PROTECTED]> wrote: > > > just as a follow up, I got the DRM to build under 2.4.24, (redhat > uses > > 2.6 MM in rh9). Unfortunately, I can't get pcmcia to work for me > in > > 2.4.24, so

[Dri-devel] Re: S3 Savage DRM

2004-01-08 Thread Felix Kühling
On Wed, 7 Jan 2004 14:56:24 -0800 (PST) Alex Deucher <[EMAIL PROTECTED]> wrote: > just as a follow up, I got the DRM to build under 2.4.24, (redhat uses > 2.6 MM in rh9). Unfortunately, I can't get pcmcia to work for me in > 2.4.24, so I can either hack on the savage driver or have network > acce

[Dri-devel] Re: [Mesa3d-dev] Mesa 6.0 release plans

2004-01-08 Thread Brian Paul
Eric Anholt wrote: On Wed, 2004-01-07 at 11:13, Felix Kühling wrote: On Wed, 07 Jan 2004 08:01:54 -0700 Brian Paul <[EMAIL PROTECTED]> wrote: The Mesa 5.1 release seems to have been fairly solid so I'm planning on releasing Mesa 6.0 (stabilized release advertising OpenGL 1.5 support) pretty soo

Re: [Dri-devel] Re: S3 Savage DRM

2004-01-08 Thread Rafael Maximo
At 07:56 PM 7/1/2004, Alex Deucher wrote: I tested the driver on my savage4 and I see the 2D corruption maximo was talking about with tile mode enabled. everything is fine with tilemode disabled. However, 3D doesn't seem to work in either mode. With or without tilemode disabled I get random bla