Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-11-14 Thread Keith Zhao
On 2023/11/13 21:31, Dmitry Baryshkov wrote: > On Mon, 13 Nov 2023 at 14:11, Keith Zhao wrote: >> >> >> >> On 2023/10/26 6:23, Dmitry Baryshkov wrote: >> > On 25/10/2023 13:39, Keith Zhao wrote: >> >> add hdmi driver as encoder and connect >> >> >> >> Signed-off-by: Keith Zhao >> >> --- >> >>

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-11-13 Thread Dmitry Baryshkov
On Mon, 13 Nov 2023 at 14:11, Keith Zhao wrote: > > > > On 2023/10/26 6:23, Dmitry Baryshkov wrote: > > On 25/10/2023 13:39, Keith Zhao wrote: > >> add hdmi driver as encoder and connect > >> > >> Signed-off-by: Keith Zhao > >> --- > >> drivers/gpu/drm/verisilicon/Kconfig | 8 +- > >>

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-11-13 Thread Keith Zhao
On 2023/10/26 6:23, Dmitry Baryshkov wrote: > On 25/10/2023 13:39, Keith Zhao wrote: >> add hdmi driver as encoder and connect >> >> Signed-off-by: Keith Zhao >> --- >>   drivers/gpu/drm/verisilicon/Kconfig |   8 +- >>   drivers/gpu/drm/verisilicon/Makefile    |   1 + >>   drivers/g

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-11-07 Thread Maxime Ripard
Hi, On Sun, Oct 29, 2023 at 06:52:24PM +0200, Dmitry Baryshkov wrote: > On Thu, 26 Oct 2023 at 14:53, Maxime Ripard wrote: > > > > On Thu, Oct 26, 2023 at 11:57:22AM +0300, Dmitry Baryshkov wrote: > > > On Thu, 26 Oct 2023 at 11:07, Maxime Ripard wrote: > > > > > > > > On Thu, Oct 26, 2023 at 01

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-10-29 Thread Dmitry Baryshkov
On Thu, 26 Oct 2023 at 14:53, Maxime Ripard wrote: > > On Thu, Oct 26, 2023 at 11:57:22AM +0300, Dmitry Baryshkov wrote: > > On Thu, 26 Oct 2023 at 11:07, Maxime Ripard wrote: > > > > > > On Thu, Oct 26, 2023 at 01:23:53AM +0300, Dmitry Baryshkov wrote: > > > > > +static int starfive_hdmi_registe

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-10-26 Thread Maxime Ripard
On Thu, Oct 26, 2023 at 11:57:22AM +0300, Dmitry Baryshkov wrote: > On Thu, 26 Oct 2023 at 11:07, Maxime Ripard wrote: > > > > On Thu, Oct 26, 2023 at 01:23:53AM +0300, Dmitry Baryshkov wrote: > > > > +static int starfive_hdmi_register(struct drm_device *drm, struct > > > > starfive_hdmi *hdmi) >

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-10-26 Thread Dmitry Baryshkov
On Thu, 26 Oct 2023 at 11:07, Maxime Ripard wrote: > > On Thu, Oct 26, 2023 at 01:23:53AM +0300, Dmitry Baryshkov wrote: > > > +static int starfive_hdmi_register(struct drm_device *drm, struct > > > starfive_hdmi *hdmi) > > > +{ > > > + struct drm_encoder *encoder = &hdmi->encoder; > > > + st

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-10-26 Thread Maxime Ripard
On Thu, Oct 26, 2023 at 01:23:53AM +0300, Dmitry Baryshkov wrote: > > +static int starfive_hdmi_register(struct drm_device *drm, struct > > starfive_hdmi *hdmi) > > +{ > > + struct drm_encoder *encoder = &hdmi->encoder; > > + struct device *dev = hdmi->dev; > > + > > + encoder->possible_crtc

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-10-25 Thread Dmitry Baryshkov
On 25/10/2023 13:39, Keith Zhao wrote: add hdmi driver as encoder and connect Signed-off-by: Keith Zhao --- drivers/gpu/drm/verisilicon/Kconfig | 8 +- drivers/gpu/drm/verisilicon/Makefile| 1 + drivers/gpu/drm/verisilicon/starfive_hdmi.c | 949 dri

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-10-25 Thread Maxime Ripard
On Wed, Oct 25, 2023 at 06:39:57PM +0800, Keith Zhao wrote: > +static int starfive_hdmi_setup(struct starfive_hdmi *hdmi, > +struct drm_display_mode *mode) > +{ > + hdmi_modb(hdmi, STARFIVE_BIAS_CONTROL, STARFIVE_BIAS_ENABLE, > STARFIVE_BIAS_ENABLE); > + hdmi_wr

[PATCH v2 6/6] drm/vs: Add hdmi driver

2023-10-25 Thread Keith Zhao
add hdmi driver as encoder and connect Signed-off-by: Keith Zhao --- drivers/gpu/drm/verisilicon/Kconfig | 8 +- drivers/gpu/drm/verisilicon/Makefile| 1 + drivers/gpu/drm/verisilicon/starfive_hdmi.c | 949 drivers/gpu/drm/verisilicon/starfive_hdmi.h | 29