Re: [PATCH v2 4/4] drm/fb-helper: improve documentation and print warnings

2018-09-09 Thread Gerd Hoffmann
> > * This function sets up generic fbdev emulation for drivers that supports > > - * dumb buffers with a virtual address and that can be mmap'ed. > > + * dumb buffers with a virtual address and that can be mmap'ed. If the > > driver > > + * does not support these functions, it could use > > dr

Re: [PATCH v2 4/4] drm/fb-helper: improve documentation and print warnings

2018-09-07 Thread Daniel Vetter
On Fri, Sep 07, 2018 at 12:18:10AM +0200, Peter Wu wrote: > Clarify the relation between drm_fb_helper_fbdev_setup/teardown. Clarify > requirements for the new generic fbdev emulation API and log some more > details in case the driver does something wrong. Fix related typos. > > Cc: Noralf Trønnes

[PATCH v2 4/4] drm/fb-helper: improve documentation and print warnings

2018-09-06 Thread Peter Wu
Clarify the relation between drm_fb_helper_fbdev_setup/teardown. Clarify requirements for the new generic fbdev emulation API and log some more details in case the driver does something wrong. Fix related typos. Cc: Noralf Trønnes Signed-off-by: Peter Wu --- drivers/gpu/drm/drm_fb_helper.c | 25