Re: [PATCH v2 2/4] drm: lcdif: Don't use BIT() for multi-bit register fields

On Wed, 2022-09-28 at 03:58 +0300, Laurent Pinchart wrote: > The BIT() macro is meant to represent a single bit. Don't use it for > values of register fields that span multiple bits. > > Signed-off-by: Laurent Pinchart > --- > Changes since v1: > > - Use hex for field values > --- > drivers/gpu

Re: [PATCH v2 2/4] drm: lcdif: Don't use BIT() for multi-bit register fields

Quoting Laurent Pinchart (2022-09-28 01:58:10) > The BIT() macro is meant to represent a single bit. Don't use it for > values of register fields that span multiple bits. > > Signed-off-by: Laurent Pinchart > --- > Changes since v1: > > - Use hex for field values > --- > drivers/gpu/drm/mxsfb/l

Re: [PATCH v2 2/4] drm: lcdif: Don't use BIT() for multi-bit register fields

On 9/28/22 02:58, Laurent Pinchart wrote: The BIT() macro is meant to represent a single bit. Don't use it for values of register fields that span multiple bits. Signed-off-by: Laurent Pinchart Reviewed-by: Marek Vasut

[PATCH v2 2/4] drm: lcdif: Don't use BIT() for multi-bit register fields

The BIT() macro is meant to represent a single bit. Don't use it for values of register fields that span multiple bits. Signed-off-by: Laurent Pinchart --- Changes since v1: - Use hex for field values --- drivers/gpu/drm/mxsfb/lcdif_regs.h | 28 ++-- 1 file changed, 14 i