Re: [PATCH net-next v17 01/14] netdev: add netdev_rx_queue_restart()

2024-07-31 Thread Mina Almasry
On Tue, Jul 30, 2024 at 4:17 AM Xuan Zhuo wrote: > > On Tue, 30 Jul 2024 02:26:05 +, Mina Almasry > wrote: > > Add netdev_rx_queue_restart() function to netdev_rx_queue.h > > > Can you say more? As far as I understand, we just release the buffer > submitted to the rx ring and get a new page

Re: [PATCH net-next v17 01/14] netdev: add netdev_rx_queue_restart()

2024-07-30 Thread Xuan Zhuo
On Tue, 30 Jul 2024 02:26:05 +, Mina Almasry wrote: > Add netdev_rx_queue_restart() function to netdev_rx_queue.h Can you say more? As far as I understand, we just release the buffer submitted to the rx ring and get a new page pool. But I personally feel that the interface here is a bit too

[PATCH net-next v17 01/14] netdev: add netdev_rx_queue_restart()

2024-07-29 Thread Mina Almasry
Add netdev_rx_queue_restart() function to netdev_rx_queue.h Signed-off-by: David Wei Signed-off-by: Mina Almasry Reviewed-by: Pavel Begunkov Reviewed-by: Jakub Kicinski --- v17: - Use ASSERT_RTNL() (Jakub). v13: - Add reviewed-by from Pavel (thanks!) - Fixed comment (Pavel) v11: - Fix not