Re: [PATCH 1/2] drm/vmwgfx: Refactor cursor handling

2025-03-03 Thread Zack Rusin
Sorry, I didn't see this before because the email formatting got really butchered, I only found the underneath comment in it. Please let me know if there were more. On Tue, Feb 11, 2025 at 9:33 AM Martin Krastev wrote: > On Wed, Jan 15, 2025 at 6:50 AM Zack Rusin wrote: ... > > diff --git a/driv

Re: [PATCH 1/2] drm/vmwgfx: Refactor cursor handling

2025-02-11 Thread Martin Krastev
On Wed, Jan 15, 2025 at 6:50 AM Zack Rusin wrote: > > Refactor cursor handling to make the code maintainable again. Over the > last 12 years the svga device improved support for virtualized cursors > and at the same time the drm interfaces evolved quite a bit from > pre-atomic to current atomic on

Re: [PATCH 1/2] drm/vmwgfx: Refactor cursor handling

2025-01-24 Thread Zack Rusin
On Fri, Jan 24, 2025 at 11:48 AM Ian Forbes wrote: > > On Tue, Jan 14, 2025 at 10:50 PM Zack Rusin wrote: > > > > +int vmw_cursor_plane_prepare_fb(struct drm_plane *plane, > > + struct drm_plane_state *new_state) > > +{ > > + struct drm_framebuffer *fb = new_st

Re: [PATCH 1/2] drm/vmwgfx: Refactor cursor handling

2025-01-24 Thread Ian Forbes
On Tue, Jan 14, 2025 at 10:50 PM Zack Rusin wrote: > > +int vmw_cursor_plane_prepare_fb(struct drm_plane *plane, > + struct drm_plane_state *new_state) > +{ > + struct drm_framebuffer *fb = new_state->fb; > + struct vmw_cursor_plane *vcp = vmw_plane_to_vcp

[PATCH 1/2] drm/vmwgfx: Refactor cursor handling

2025-01-14 Thread Zack Rusin
Refactor cursor handling to make the code maintainable again. Over the last 12 years the svga device improved support for virtualized cursors and at the same time the drm interfaces evolved quite a bit from pre-atomic to current atomic ones. vmwgfx only added new code over the years, instead of adj