Re: [PATCH] drm/gem: Fix a leak in drm_gem_objects_lookup()

2020-05-17 Thread Emil Velikov
On Mon, 23 Mar 2020 at 12:13, Dan Carpenter wrote: > > On Mon, Mar 23, 2020 at 11:13:22AM +, Emil Velikov wrote: > > Hi Dan, > > > > On Fri, 20 Mar 2020 at 13:23, Dan Carpenter > > wrote: > > > > > > If the "handles" allocation or the copy_from_user() fails then we leak > > > "objs". It's s

Re: [PATCH] drm/gem: Fix a leak in drm_gem_objects_lookup()

2020-03-23 Thread Dan Carpenter
On Mon, Mar 23, 2020 at 11:13:22AM +, Emil Velikov wrote: > Hi Dan, > > On Fri, 20 Mar 2020 at 13:23, Dan Carpenter wrote: > > > > If the "handles" allocation or the copy_from_user() fails then we leak > > "objs". It's supposed to be freed in panfrost_job_cleanup(). > > > > Fixes: c117aa4d87

Re: [PATCH] drm/gem: Fix a leak in drm_gem_objects_lookup()

2020-03-23 Thread Emil Velikov
Hi Dan, On Fri, 20 Mar 2020 at 13:23, Dan Carpenter wrote: > > If the "handles" allocation or the copy_from_user() fails then we leak > "objs". It's supposed to be freed in panfrost_job_cleanup(). > > Fixes: c117aa4d8701 ("drm: Add a drm_gem_objects_lookup helper") > Signed-off-by: Dan Carpenter

[PATCH] drm/gem: Fix a leak in drm_gem_objects_lookup()

2020-03-20 Thread Dan Carpenter
If the "handles" allocation or the copy_from_user() fails then we leak "objs". It's supposed to be freed in panfrost_job_cleanup(). Fixes: c117aa4d8701 ("drm: Add a drm_gem_objects_lookup helper") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/drm_gem.c | 4 ++-- 1 file changed, 2 insertions(