Re: [PATCH v5 11/11] drm: xlnx: zynqmp: Add support for XVUY2101010

2025-09-03 Thread Sagar, Vishal
Hi Tomi, On 4/25/2025 1:01 PM, Tomi Valkeinen wrote: Add support for XVUY2101010 format. Reviewed-by: Laurent Pinchart Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers

Re: [PATCH v5 10/11] drm: xlnx: zynqmp: Add support for X403

2025-09-03 Thread Sagar, Vishal
Hi Tomi, On 4/25/2025 1:01 PM, Tomi Valkeinen wrote: Add support for X403 format. Reviewed-by: Laurent Pinchart Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/dr

Re: [PATCH v5 09/11] drm: xlnx: zynqmp: Add support for Y8 and Y10_P32

2025-09-03 Thread Sagar, Vishal
Hi Tomi, Thanks for the patch. On 4/25/2025 1:01 PM, Tomi Valkeinen wrote: Add support for Y8 and Y10_P32 formats. We also need to add new csc matrices for the y-only formats. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 26 +- 1 file chang

Re: [PATCH v5 08/11] drm: xlnx: zynqmp: Add support for XV15 & XV20

2025-09-03 Thread Sagar, Vishal
Hi Tomi, Thanks for the patch. On 4/25/2025 1:01 PM, Tomi Valkeinen wrote: Add support for XV15 & XV20 formats. Reviewed-by: Laurent Pinchart Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/dr

Re: [PATCH v5 06/11] drm/fourcc: Add DRM_FORMAT_XVUY2101010

2025-09-03 Thread Sagar, Vishal
Hi Tomi, Thanks for the patch. On 4/25/2025 1:01 PM, Tomi Valkeinen wrote: Add XVUY2101010, a 10 bits per component YCbCr format in a 32 bit container. Reviewed-by: Laurent Pinchart Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/drm_fourcc.c | 1 + include/uapi/drm/drm_fourcc.h | 1 +

Re: [PATCH v5 05/11] drm/fourcc: Add DRM_FORMAT_X403

2025-09-03 Thread Sagar, Vishal
Hi Tomi, Thanks for the patch. On 4/25/2025 1:01 PM, Tomi Valkeinen wrote: Add X403, a 3 plane 10 bits per component non-subsampled YCbCr format. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/drm_fourcc.c | 3 +++ include/uapi/drm/drm_fourcc.h | 9 + 2 files changed, 12 inser

Re: [PATCH v5 04/11] drm/fourcc: Add DRM_FORMAT_Y10_P32

2025-09-03 Thread Sagar, Vishal
Hi Tomi, On 4/25/2025 1:01 PM, Tomi Valkeinen wrote: Add Y10_P32, a 10 bit greyscale format, with 3 pixels packed into 32-bit container. The fourcc for the format is 'YPA4', which comes from Y - Y only, P - packed, A - 10 (as in 0xA), 4 - 4 bytes. Signed-off-by: Tomi Valkeinen --- drivers/g

Re: [PATCH v5 03/11] drm/fourcc: Add DRM_FORMAT_Y8

2025-09-03 Thread Sagar, Vishal
Hi Tomi, Thanks for the patch. On 4/25/2025 1:01 PM, Tomi Valkeinen wrote: Add greyscale Y8 format. Acked-by: Dmitry Baryshkov Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/drm_fourcc.c | 1 + include/uapi/drm/drm_fourcc.h | 10 ++ 2 files changed, 11 insertions(+) diff --

Re: [PATCH v5 02/11] drm/fourcc: Add DRM_FORMAT_XV15/XV20

2025-09-03 Thread Sagar, Vishal
Hi Tomi, Thanks for the patch. On 4/25/2025 1:01 PM, Tomi Valkeinen wrote: Add two new pixel formats: DRM_FORMAT_XV15 ("XV15") DRM_FORMAT_XV20 ("XV20") The formats are 2 plane 10 bit per component YCbCr, with the XV15 2x2 subsampled whereas XV20 is 2x1 subsampled. Reviewed-by: Dmitry Baryshk

RE: [PATCH] drm: xlnx: zynqmp_dpsub: Fix kernel doc

2024-12-20 Thread Sagar, Vishal
Airlie > ; Simona Vetter ; Jonathan Corbet > ; Simek, Michal ; Sagar, Vishal > > Cc: dri-devel@lists.freedesktop.org; linux-...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; linux-ker...@vger.kernel.org; Tomi Valkeinen > > Subject: [PATCH] drm: xlnx: zynqmp_dpsub

Re: [PATCH v4 3/3] drm: xlnx: zynqmp_dpsub: Add DP audio support

2024-12-18 Thread Sagar, Vishal
Hi Tomi, Thanks for the patch. On 10/23/2024 1:52 PM, Tomi Valkeinen wrote: Add basic DisplayPort audio support. Support non-live audio playback from two PCMs (DMA channels), and the volume control in the audio mixer. As older dtb files may not have the audio DMA channels defined, the driver

RE: [PATCH 01/10] drm/fourcc: Add warning for bad bpp

2024-12-18 Thread Sagar, Vishal
[AMD Official Use Only - AMD Internal Distribution Only] Hi Tomi > -Original Message- > From: Tomi Valkeinen > Sent: Wednesday, December 18, 2024 12:49 PM > To: Sagar, Vishal > Cc: dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org; linux-arm- > ker...@l

RE: [PATCH 01/10] drm/fourcc: Add warning for bad bpp

2024-12-04 Thread Sagar, Vishal
[AMD Official Use Only - AMD Internal Distribution Only] Hi Tomi, Thanks for the patch. > -Original Message- > From: Tomi Valkeinen > Sent: Wednesday, December 4, 2024 10:31 AM > To: Sagar, Vishal ; Klymenko, Anatoliy > ; Maarten Lankhorst > ; Maxime Ripard ; &

RE: [PATCH] drm: xlnx: dp: Reset DisplayPort IP

2024-02-16 Thread Sagar, Vishal
[AMD Official Use Only - General] Hi Rohit, Thanks for the patch. > -Original Message- > From: dri-devel On Behalf Of > Rohit Visavalia > Sent: Friday, February 16, 2024 1:41 PM > To: gre...@linuxfoundation.org; laurent.pinch...@ideasonboard.com; > maarten.lankho...@linux.intel.com; mri