Re: [RFC v5 1/5] drm/netlink: Add netlink infrastructure

2025-10-02 Thread Rodrigo Vivi
On Mon, Aug 25, 2025 at 11:31:49AM -0600, Zack McKevitt wrote: > > > On 8/21/2025 3:45 AM, Aravind Iddamsetty wrote: > > Glad to know the interest,  at present the code does create drm netlink > > family for accel device as well, but it is tries to register with the > > drm primary node name whic

[PATCH 0/2] Introduce DRM_RAS using generic netlink for RAS

2025-10-02 Thread Rodrigo Vivi
--do query-error-counter --json '{"node-id": 0, "error-id": 12}' {'error-id': 12, 'error-name': 'SG Unit Error', 'error-value': 0} $ sudo ./tools/net/ynl/pyynl/cli.py \ --spec Documentation/netlink/specs/drm_ras.yaml \ --d

[PATCH 2/2] drm/xe: Introduce the usage of drm_ras with supported HW errors

2025-09-29 Thread Rodrigo Vivi
tself and start using the drm_ras generic netlink to report them. Keep the CSC_work only for discrete devices. Cc: Riana Tauro Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/regs/xe_hw_error_regs.h | 22 +++ drivers/gpu/drm/xe/xe_hw_error.c | 155 - 2 files ch

[PULL] drm-xe-fixes

2025-09-25 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our drm-xe-fixes PR for this week. Nothing extraordinary. A quiet week in fixes. Thanks, Rodrigo. drm-xe-fixes-2025-09-25: - Don't expose sysfs attributes not applicable for VFs (Michal) - Fix build with CONFIG_MODULES=n (Lucas) - Don't copy pinned kernel bos twice on

[PULL] drm-xe-fixes

2025-09-20 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes the xe fixes for this week. Thanks, Rodrigo. drm-xe-fixes-2025-09-11: - Don't touch survivability_mode on fini (Michal) - Fixes around eviction and suspend (Thomas) - Extend Wa_13011645652 to PTL-H, WCL (Julia) The following changes since commit 76eeb9b8de9880ca38696b

[PULL] drm-intel-next v2 of drm-intel-next-2025-09-12

2025-09-18 Thread Rodrigo Vivi
sed struct_mutex from drm_i915_private drm/i915: Remove todo and comments about struct_mutex Rodrigo Vivi (1): Merge drm/drm-next into drm-intel-next Suraj Kandpal (1): drm/i915/backlight: Disable backlight when using luminance control Uma Shankar (1): drm/i915/display

Re: [PATCH v9 2/9] mei: late_bind: add late binding component driver

2025-09-18 Thread Rodrigo Vivi
On Fri, Sep 12, 2025 at 12:19:21AM -0500, Lucas De Marchi wrote: > On Tue, Sep 09, 2025 at 09:43:02AM -0500, Lucas De Marchi wrote: > > On Tue, Sep 09, 2025 at 04:50:41AM +, Usyskin, Alexander wrote: > > > > > +static int mei_lb_component_match(struct device *dev, int > > > > > subcomponent, >

[PULL] drm-xe-fixes

2025-09-18 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our drm-xe-fixes. It has more fixes than normal for this time of the cycle, but nothing very critical. Perhaps the most critical one is the RCS/CCS yield policy which prevents starvation in the CCS engine on BMG. A patch that was slightly modified to add a missing incl

Re: [PATCH v2 06/11] drm/i915/gt: Use pci_rebar_size_supported()

2025-09-16 Thread Rodrigo Vivi
On Tue, Sep 16, 2025 at 10:57:24AM +0200, Christian König wrote: > On 16.09.25 10:12, Jani Nikula wrote: > > On Mon, 15 Sep 2025, Rodrigo Vivi wrote: > >> On Mon, Sep 15, 2025 at 07:24:10PM +0200, Andi Shyti wrote: > >>> Hi, > >>> > >>> On Mo

Re: [PATCH v2 09/11] drm/xe/vram: Use pci_rebar_get_max_size()

2025-09-15 Thread Rodrigo Vivi
On Mon, Sep 15, 2025 at 12:13:56PM +0300, Ilpo Järvinen wrote: > Use pci_rebar_get_max_size() from PCI core in resize_vram_bar() to > simplify code. > > Signed-off-by: Ilpo Järvinen > Acked-by: Christian König > --- > drivers/gpu/drm/xe/xe_vram.c | 15 +++---- A

Re: [PATCH v2 07/11] drm/xe/vram: Use PCI rebar helpers in resize_vram_bar()

2025-09-15 Thread Rodrigo Vivi
ers/gpu/drm/xe/xe_vram.c | 19 +++---- Acked-by: Rodrigo Vivi > 1 file changed, 7 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_vram.c b/drivers/gpu/drm/xe/xe_vram.c > index 0b7417bb0a47..d4fbd7f74255 100644 > --- a/drivers/gpu/drm/xe/xe_vram

Re: [PATCH v2 06/11] drm/i915/gt: Use pci_rebar_size_supported()

2025-09-15 Thread Rodrigo Vivi
On Mon, Sep 15, 2025 at 07:24:10PM +0200, Andi Shyti wrote: > Hi, > > On Mon, Sep 15, 2025 at 03:42:23PM +0300, Jani Nikula wrote: > > On Mon, 15 Sep 2025, Ilpo Järvinen wrote: > > > PCI core provides pci_rebar_size_supported() that helps in checking if > > > a BAR Size is supported for the BAR o

Re: [PATCH -next 2/2] drm/xe: Remove duplicated include in xe_tlb_inval.c

2025-09-15 Thread Rodrigo Vivi
On Mon, Sep 15, 2025 at 04:06:47PM +0800, Yang Li wrote: > The header files xe_tlb_inval.h is included twice in xe_tlb_inval.c, > so one inclusion of each can be removed. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=24706 > Signed-off-by: Yang Li > --- >

Re: [PATCH] drm/xe: Fix a NULL vs IS_ERR() in xe_vm_add_compute_exec_queue()

2025-09-15 Thread Rodrigo Vivi
On Mon, Sep 15, 2025 at 02:12:00PM +0300, Dan Carpenter wrote: > Ping? Sorry for the delay and thank you for the patch. pushed to drm-xe-next > > regards, > dan carpenter > > On Thu, Aug 07, 2025 at 06:53:41PM +0300, Dan Carpenter wrote: > > The xe_preempt_fence_create() function returns error

Re: [PATCH 1/9 v4] drm/i915: Move struct_mutex to drm_i915_private

2025-09-13 Thread Rodrigo Vivi
On Mon, Sep 08, 2025 at 02:32:28PM +0100, Tvrtko Ursulin wrote: > > On 08/09/2025 14:15, Luiz Otavio Mello wrote: > > Move legacy BKL struct_mutex from drm_device to drm_i915_private, which > > is the last remaining user. > > > > Signed-off-by: Luiz Otavio Mello

[PULL] drm-intel-next

2025-09-05 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our first drm-intel-next pull request towards 6.18. I'm planning to send another pull request in the end of next week. It is important to highlight the iopoll.h work that is pushed here without any ack since it lacks MAINTAINERS and previous changes apparently gets thr

[PULL] drm-xe-fixes

2025-09-03 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our drm-xe-fixes targeting -rc5, with only one fix. Thanks, Rodrigo. drm-xe-fixes-2025-09-03: - Fix incorrect migration of backed-up object to VRAM (Thomas) The following changes since commit b320789d6883cc00ac78ce83bccbfe7ed58afcf0: Linux 6.17-rc4 (2025-08-31 15:3

[PULL] drm-xe-fixes

2025-08-27 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our drm-xe-fixes targeting v6.17-rc4. Thanks, Rodrigo. drm-xe-fixes-2025-08-27: - Fix user-fence race issue (Zbigniew) - Couple xe_vm fixes (Thomas) - Don't trigger rebind on initial dma-buf validation (Brost) - Fix a build issue related to basename() posix vs gnu dis

Re: [PATCH v9 02/10] drm: Add a vendor-specific recovery method to drm device wedged uevent

2025-08-26 Thread Rodrigo Vivi
; > Cc: André Almeida > Cc: Christian König > Cc: David Airlie > Cc: Simona Vetter > Cc: Maxime Ripard > Signed-off-by: Riana Tauro > Reviewed-by: Rodrigo Vivi > Acked-by: Maxime Ripard pushed to drm-xe-next. Thank you all for the patches, ideas, reviews, etc

Re: [PATCH] drm/xe: Skip creation of pcode sysfs files when pcode is disabled

2025-08-25 Thread Rodrigo Vivi
On Mon, Aug 25, 2025 at 04:48:28PM +0200, Raag Jadav wrote: > On Mon, Aug 25, 2025 at 04:31:23PM +0200, Andi Shyti wrote: > > Hi Rodrigo, > > > > On Fri, Aug 22, 2025 at 12:30:02PM -0400, Rodrigo Vivi wrote: > > > On Tue, Aug 19, 2025 at 04:55:29PM -0100, Andi S

Re: [RFC 9/9] {fwctl,drm}/xe/pcode: Introduce xe_pcode_fwctl

2025-08-22 Thread Rodrigo Vivi
On Wed, May 07, 2025 at 07:04:44PM -0300, Jason Gunthorpe wrote: > On Wed, May 07, 2025 at 03:49:15PM -0400, Rodrigo Vivi wrote: > > > One last thing since I have your attention here. Was any time in the > > previous > > fwctl discussions talked about the possibility

Re: [PATCH] drm/xe: Skip creation of pcode sysfs files when pcode is disabled

2025-08-22 Thread Rodrigo Vivi
On Tue, Aug 19, 2025 at 04:55:29PM -0100, Andi Shyti wrote: > From: Andi Shyti > > Coverity warns that 'cap' may be used uninitialised. If pcode > is disabled there is no need to go through the hassle of a > pcode read or taking a PM reference. Please mark it as false positive! We will only get

[PULL] drm-xe-fixes

2025-08-21 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our xe-fixes targeting -rc3. The xe_vm_create fixes should actually had been squashed together, to avoid null-deref in the vm_create. But this would mess up the original hash of a fix propagated last week that already landed in -rc2. :/ I should had checked this last

Re: [PATCH v8 02/10] drm: Add a vendor-specific recovery method to drm device wedged uevent

2025-08-21 Thread Rodrigo Vivi
; Riana > > On 8/17/2025 9:55 PM, Rodrigo Vivi wrote: > > On Thu, Aug 14, 2025 at 05:44:32PM +0530, Riana Tauro wrote: > > > Address the need for a recovery method (firmware flash on Firmware errors) > > > introduced in the later patches of Xe KMD. > > > When

Re: [PATCH 8/9 v3] drm/i915: Drop unused struct_mutex from drm_i915_private

2025-08-21 Thread Rodrigo Vivi
On Wed, Aug 13, 2025 at 10:50:32AM -0300, Luiz Otavio Mello wrote: > The struct_mutex field in drm_i915_private is no longer used anywhere in > the driver. This patch removes it completely to clean up unused code and > avoid confusion. > > Signed-off-by: Luiz Otavio Mello > Re

Re: [PATCH v7 00/24] MADVISE FOR XE

2025-08-18 Thread Rodrigo Vivi
On Thu, Aug 14, 2025 at 04:29:26PM +0530, Himal Prasad Ghimiray wrote: > -v8 > Define new function in gpuvm for madvise > Fix tile check in ops_create Please re-send this series again. But this time, ensure that dri-devel is in the --to= of the series! In 8 revisions, it looks like not a single t

Re: [PATCH v8 01/10] drm/xe: Add documentation for Xe Device Wedging

2025-08-17 Thread Rodrigo Vivi
On Thu, Aug 14, 2025 at 05:44:31PM +0530, Riana Tauro wrote: > Add documentation for Xe Device Wedging so that > file can be referenced in following patches. > > Signed-off-by: Riana Tauro Reviewed-by: Rodrigo Vivi > --- > Documentation/gpu/xe/index.rst | 1 + >

Re: [PATCH v8 02/10] drm: Add a vendor-specific recovery method to drm device wedged uevent

2025-08-17 Thread Rodrigo Vivi
t; > Cc: André Almeida > Cc: Christian König > Cc: David Airlie > Cc: Simona Vetter Cc: Maxime Ripard Folks, is it clear now? can we move ahead and get this through drm-xe-next? > Signed-off-by: Raag Jadav > Signed-off-by: Riana Tauro > Reviewed-by: Rodrigo Vivi &g

Re: [PATCH v2] drm/xe/hwmon: Return early on power limit read failure

2025-08-17 Thread Rodrigo Vivi
On Fri, Aug 15, 2025 at 02:36:23PM +0800, zhaoguo...@kylinos.cn wrote: > From: GuoHan Zhao > > In xe_hwmon_pcode_rmw_power_limit(), when xe_pcode_read() fails, > the function logs the error but continues to execute the subsequent > logic. This can result in undefined behavior as the values val0 a

Re: [PATCH 1/9 v3] drm/i915: Move struct_mutex to drm_i915_private

2025-08-15 Thread Rodrigo Vivi
On Fri, Aug 15, 2025 at 09:04:34AM -0400, Rodrigo Vivi wrote: > On Wed, Aug 13, 2025 at 10:50:25AM -0300, Luiz Otavio Mello wrote: > > Move legacy BKL struct_mutex from drm_device to drm_i915_private, which > > is the last remaining user. > > > > Signed-off-by: Luiz Ot

Re: [RFC v5 5/5] drm/xe/RAS: send multicast event on occurrence of an error

2025-08-15 Thread Rodrigo Vivi
On Wed, Jul 30, 2025 at 12:19:56PM +0530, Aravind Iddamsetty wrote: > Whenever a correctable or an uncorrectable error happens an event is sent > to the corresponding listeners of these groups. > > v2: Rebase > v3: protect with CONFIG_NET define. > > Reviewed-by: Michael J. Ruhl #v2 > Signed-off

Re: [RFC v5 4/5] drm/netlink: Define multicast groups

2025-08-15 Thread Rodrigo Vivi
On Wed, Jul 30, 2025 at 12:19:55PM +0530, Aravind Iddamsetty wrote: > Netlink subsystem supports event notifications to userspace. we define > two multicast groups for correctable and uncorrectable errors to which > userspace can subscribe and be notified when any of those errors happen. > The grou

Re: [RFC v5 3/5] drm/xe/RAS: Expose the error counters

2025-08-15 Thread Rodrigo Vivi
On Wed, Jul 30, 2025 at 12:19:54PM +0530, Aravind Iddamsetty wrote: > We expose the various error counters supported on a hardware via genl > subsytem through the registered commands to userspace. The > DRM_RAS_CMD_QUERY lists the error names with config id, > DRM_RAD_CMD_READ_ONE returns the count

Re: [RFC v5 2/5] drm/xe/RAS: Register netlink capability

2025-08-15 Thread Rodrigo Vivi
On Wed, Jul 30, 2025 at 12:19:53PM +0530, Aravind Iddamsetty wrote: > Register netlink capability with the DRM and register the driver > callbacks to DRM RAS netlink commands. > > v2: > Move the netlink registration parts to DRM susbsytem (Tomer Tayar) > > v3: compile only if CONFIG_NET is enable

Re: [RFC v5 1/5] drm/netlink: Add netlink infrastructure

2025-08-15 Thread Rodrigo Vivi
On Wed, Jul 30, 2025 at 12:19:52PM +0530, Aravind Iddamsetty wrote: > Define the netlink registration interface and commands, attributes that > can be commonly used across by drm drivers. This patch intends to use > the generic netlink family to expose various stats of device. At present > it defin

Re: [RFC v5 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2025-08-15 Thread Rodrigo Vivi
On Wed, Aug 13, 2025 at 04:21:03PM -0400, Rodrigo Vivi wrote: > On Wed, Jul 30, 2025 at 12:19:51PM +0530, Aravind Iddamsetty wrote: > > Revisiting this patch series to address pending feedback and help move > > the discussion towards a conclusion. This revision includes updat

Re: [PATCH 1/9 v3] drm/i915: Move struct_mutex to drm_i915_private

2025-08-15 Thread Rodrigo Vivi
On Wed, Aug 13, 2025 at 10:50:25AM -0300, Luiz Otavio Mello wrote: > Move legacy BKL struct_mutex from drm_device to drm_i915_private, which > is the last remaining user. > > Signed-off-by: Luiz Otavio Mello > Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/drm_drv.c

Re: [PATCH 9/9 v3] drm/i915: Remove todo and comments about struct_mutex

2025-08-15 Thread Rodrigo Vivi
i915.rst to avoid outdated > documentation. > > Signed-off-by: Luiz Otavio Mello > Reviewed-by: Rodrigo Vivi > --- > Documentation/gpu/i915.rst | 7 --- > Documentation/gpu/todo.rst | 25 - drm,drm-misc maintainers, ack to merge this through

[PULL] drm-xe-fixes

2025-08-14 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our first round for 6.17 fixes. The SRIOV setting for VF LMEM BAR size is critical and will cause trouble for people using SRIOV if not there. But we couldn't send it earlier because the dependency on PCI patches that just landed in the last merge-window: https://lore

Re: [RFC v5 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2025-08-13 Thread Rodrigo Vivi
0030 > error-gt1-soc-fatal-hbm-ss1-4 0x1031 > error-gt1-soc-fatal-hbm-ss1-5 0x10000032 > error-gt1-soc-fatal-hbm-ss1-6 0x1033 > error-gt1-soc-fatal-hbm-ss1-7

Re: [PATCH v2 3/7] kunit: Pass parameterized test context to generate_params()

2025-08-12 Thread Rodrigo Vivi
r > * or NULL if there are no more Xe devices on the system. > */ > -const void *xe_pci_live_device_gen_param(const void *prev, char *desc) > +const void *xe_pci_live_device_gen_param(struct kunit *test, const void > *prev, char *desc) > { > const struct xe_device *xe =

Re: [RESEND][PATCH] drm/xe/hwmon: Return early on power limit read failure

2025-08-12 Thread Rodrigo Vivi
On Tue, Aug 12, 2025 at 02:59:30PM +0800, zhaoguo...@kylinos.cn wrote: > From: GuoHan Zhao > > In xe_hwmon_pcode_rmw_power_limit(), when xe_pcode_read() fails, > the function logs the error but continues to execute the subsequent > logic. This can result in undefined behavior as the values val0 a

Re: [PATCH 9/9 v2] drm/i915: Remove todo and comments about struct_mutex

2025-08-08 Thread Rodrigo Vivi
I wondered if it would be better to have a split patch to clean up the i915 doc separate of the drm one, but I believe this single all in one patch for the doc part is okay... Reviewed-by: Rodrigo Vivi > 2 files changed, 32 deletions(-) > > diff --git a/Documentation/gpu/i915.rst b/Do

Re: [PATCH 8/9 v2] drm/i915: Remove unused struct_mutex from drm_i915_private

2025-08-08 Thread Rodrigo Vivi
gt; - * for BKL. > - * > - * For this reason, it is no longer part of struct drm_device. > - */ This will need to be rebased like I did in my resubmission for CI once the other patch removes this trailing spaces and fix the alignement. But with that change, this patch is: Reviewed-by: Rodrigo Vivi > - struct mutex struct_mutex; > - > /* LPT/WPT IOSF sideband protection */ > struct mutex sbi_lock; > > -- > 2.50.1 >

Re: [PATCH 7/9 v2] drm/i915: Clean-up outdated struct_mutex comments

2025-08-08 Thread Rodrigo Vivi
longer used > in the driver. > * i915_gem.c: Removed parentheses suggesting usage of struct_mutex, which > which is no longer used. > > Signed-off-by: Luiz Otavio Mello Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_drv.h | 3 +-- > drivers/gpu/drm/i915/i91

Re: [PATCH 4/9 v2] drm/i915: Replace struct_mutex in intel_guc_log.c

2025-08-08 Thread Rodrigo Vivi
ck. The lock is initialized using drmm_mutex_init(), > which also ensures it is properly destroyed when the driver is unloaded. > > Signed-off-by: Luiz Otavio Mello > Suggested-by: Rodrigo Vivi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 +++-

Re: [PATCH 6/9 v2] drm/i915/display: Remove outdated struct_mutex comments

2025-08-08 Thread Rodrigo Vivi
> Signed-off-by: Luiz Otavio Mello Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_fbc.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c > b/drivers/gpu/drm/i915/display/inte

Re: [PATCH 5/9 v2] drm/i915/gem: Clean-up outdated struct_mutex comments

2025-08-08 Thread Rodrigo Vivi
text. Updated to refer to > a generic global lock instead. > > Signed-off-by: Luiz Otavio Mello Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- > drivers/gpu/drm/i915/gem/i915_gem_object.c | 4 ++-- > drivers/gpu/drm/

Re: [PATCH 3/9 v2] drm/i915: Change mutex initialization in intel_guc_log

2025-08-08 Thread Rodrigo Vivi
mutex_init() with drmm_mutex_init(), > which ensures the lock is properly destroyed when the driver is > unloaded. > > Signed-off-by: Luiz Otavio Mello Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 7 ++- > 1 file changed, 6 insertions(+), 1 de

Re: [PATCH 2/9 v2] drm/i915: Remove struct_mutex in i915_irq.c

2025-08-08 Thread Rodrigo Vivi
> struct_mutex. > > Signed-off-by: Luiz Otavio Mello > Suggested-by: Rodrigo Vivi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_irq.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c

Re: [PATCH 1/9 v2] drm/i915: Move struct_mutex to drm_i915_private

2025-08-08 Thread Rodrigo Vivi
urious space and alignment and ensure that it is passing the checkpatch. Right after rebasing into tip/drm-tip you can do this to check all your patches: $ git show --no-use-mailmap --pretty=email tip/drm-tip..HEAD | ./scripts/checkpatch.pl -q --emacs --strict --show-types --max-line-length=100 -

[PULL] drm-xe-next-fixes

2025-08-06 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our last xe-next-fixes pr towards 6.17-rc1. It marks Xe driver as BROKEN if kernel page is not 4K, while we don't fix this ARM support, but work is in progress there. Also, mostly SRIOV fixes, but one patch that is more of a convenience, removing the need of a kernel

Re: [PATCH v7 1/9] drm: Add a vendor-specific recovery method to drm device wedged uevent

2025-08-05 Thread Rodrigo Vivi
ommit message > > Cc: André Almeida > Cc: Christian König > Cc: David Airlie > Cc: Simona Vetter Cc: Maxime Ripard > Co-developed-by: Raag Jadav > Signed-off-by: Raag Jadav > Signed-off-by: Riana Tauro > Reviewed-by: Rodrigo Vivi > --- > Documenta

Re: [PATCH v7 1/9] drm: Add a vendor-specific recovery method to drm device wedged uevent

2025-08-05 Thread Rodrigo Vivi
pu/xe/'. > > > > > > > > > > Recovery script contributed by Raag. > > > > > > > > > > v2: fix documentation (Raag) > > > > > v3: add more details to commit message (Sima, Rodrigo, Raag) > > > > >

Re: [PATCH][next] drm/i915: remove redundant repeated checks on err

2025-08-01 Thread Rodrigo Vivi
On Fri, Aug 01, 2025 at 06:26:47PM +, Cavitt, Jonathan wrote: > -Original Message- > From: Intel-gfx On Behalf Of Colin > Ian King > Sent: Friday, August 1, 2025 8:17 AM > To: Jani Nikula ; Vivi, Rodrigo > ; Tvrtko Ursulin ; David Airlie > ; Simona Vetter ; > intel-...@lists.freede

Re: [PATCH][next] drm/i915/bw: Remove space before newline

2025-08-01 Thread Rodrigo Vivi
On Fri, Aug 01, 2025 at 06:27:25PM +, Cavitt, Jonathan wrote: > -Original Message- > From: Intel-xe On Behalf Of Colin > Ian King > Sent: Friday, August 1, 2025 9:47 AM > To: Jani Nikula ; Vivi, Rodrigo > ; Joonas Lahtinen ; > Tvrtko Ursulin ; David Airlie ; > Simona Vetter ; intel

Re: [PATCH 8/9] drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late binding

2025-08-01 Thread Rodrigo Vivi
On Thu, Jul 31, 2025 at 08:03:36PM +, Summers, Stuart wrote: > On Thu, 2025-07-10 at 11:08 -0400, Rodrigo Vivi wrote: > > From: Badal Nilawar > > > > Introduce a debug filesystem node to disable late binding fw reload > > during the system or runtime resume. This

[PULL] drm-xe-next-fixes

2025-07-31 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our xe-next-fixes. Thanks, Rodrigo. drm-xe-next-fixes-2025-07-31: - Fix BMG probe on unsupported mailbox command (Raag) - Fix OA static checker warning about null gt (Ashutosh) - Fix a NULL vs IS_ERR() bug in xe_i2c_register_adapter (Dan) - Fix missing unwind goto in

Re: [PATCH v6 6/9] drm/xe/doc: Document device wedged and runtime survivability

2025-07-24 Thread Rodrigo Vivi
ocumentation (Raag) > > Signed-off-by: Riana Tauro Reviewed-by: Rodrigo Vivi > --- > Documentation/gpu/xe/index.rst | 1 + > Documentation/gpu/xe/xe_device.rst | 10 +++ > Documentation/gpu/xe/xe_pcode.rst | 6 ++-- > drivers/

Re: [PATCH v6 1/9] drm: Add a vendor-specific recovery method to drm device wedged uevent

2025-07-24 Thread Rodrigo Vivi
> v4: use consistent naming (Raag) > > Cc: André Almeida > Cc: Christian König > Cc: David Airlie Cc: Simona Vetter Reviewed-by: Rodrigo Vivi > Co-developed-by: Raag Jadav > Signed-off-by: Raag Jadav > Signed-off-by: Riana Tauro > --- > Documentation/gpu/

[PULL] drm-intel-fixes

2025-07-24 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes i915 fixes for this round, with only a couple of display fixes. Thanks, Rodrigo. drm-intel-fixes-2025-07-24: - Fix DP 2.7 Gbps DP_LINK_BW value on g4x (Ville) - Fix return value on intel_atomic_commit_fence_wait (Aakash) The following changes since commit 89be9a83ccf1

Re: [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST

2025-07-21 Thread Rodrigo Vivi
On Fri, Jul 18, 2025 at 12:19:41PM -0400, Rodrigo Vivi wrote: > On Fri, Jul 18, 2025 at 02:59:10PM +0100, Ruben Wauters wrote: > > On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote: > > > DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest: > > >

Re: [PATCH next] drm/xe: Fix an IS_ERR() vs NULL bug in xe_tile_alloc_vram()

2025-07-21 Thread Rodrigo Vivi
PTR_ERR(vram); > + if (!vram) > + return -ENOMEM; Indeed correct, from the drmm_kmalloc to the probe where it is consumed. Reviewed-by: Rodrigo Vivi and pushed to drm-xe-next > tile->mem.vram = vram; > > return 0; > -- > 2.47.2 >

Re: [PATCH] [PATCH v2] drm/i915: move struct_mutex from drm_device to drm_i915_private

2025-07-18 Thread Rodrigo Vivi
On Fri, Jul 18, 2025 at 01:34:13PM -0300, Luiz Otavio Mello wrote: Oi Luiz! :) First of all thank you so much for the patch. A few comments below: > Includes the missing file drm_device.h, which was unintentionally > omitted in v1. This version comment should be below, not in the beginning of t

Re: [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST

2025-07-18 Thread Rodrigo Vivi
On Fri, Jul 18, 2025 at 02:59:10PM +0100, Ruben Wauters wrote: > On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote: > > DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest: > > convert drm_mm selftest to KUnit) and all functions under it were > > converted to KUnit, under the

Re: [PULL] drm-intel-fixes

2025-07-17 Thread Rodrigo Vivi
On Thu, Jul 17, 2025 at 11:02:49AM -0400, Rodrigo Vivi wrote: > Hi Dave and Sima, > > Here goes the drm-intel-fixes of this week > with a single display fix. > > This might conflict when getting merged, but the > solution is trivial to go what is already in the -next trees.

[PULL] drm-intel-fixes

2025-07-17 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes the drm-intel-fixes of this week with a single display fix. This might conflict when getting merged, but the solution is trivial to go what is already in the -next trees. Thanks, Rodrigo. drm-intel-fixes-2025-07-17: - DP AUX DPCD address fix (Imre) The following chan

Re: [PATCH next] drm/xe: Fix a NULL vs IS_ERR() bug in xe_i2c_register_adapter()

2025-07-16 Thread Rodrigo Vivi
On Tue, Jul 15, 2025 at 05:59:44PM -0500, Dan Carpenter wrote: > The fwnode_create_software_node() function returns error pointers. It > never returns NULL. Update the checks to match. > > Fixes: f0e53aadd702 ("drm/xe: Support for I2C attached MCUs") Reviewed-by: Rodr

Re: [PATCH v2 13/19] drm/i915: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct()

2025-07-15 Thread Rodrigo Vivi
() lookup > is needed. > > Reviewed-by: Thomas Zimmermann > Signed-off-by: Ville Syrjälä Acked-by: Rodrigo Vivi to get this through drm-misc > --- > drivers/gpu/drm/i915/display/intel_fb.c| 8 +--- > drivers/gpu/drm/i915/display/intel_fb.h| 2 ++ >

[PULL] drm-xe-next

2025-07-15 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our last drm-xe-next PR towards 6.17. It brings a lot of workarounds infra and additions and the enabling of SRIOV capability in BMG, as long as underneath hardware SKU and Firmware supports it as well. Thanks, Rodrigo. drm-xe-next-2025-07-15: Driver Changes: - Crea

Re: [PATCH] drm/dp: Change AUX DPCD probe address from LANE0_1_STATUS to TRAINING_PATTERN_SET

2025-07-15 Thread Rodrigo Vivi
On Mon, Jul 14, 2025 at 11:06:52PM +0300, Imre Deak wrote: > On Mon, Jul 14, 2025 at 11:00:08AM +0200, Thomas Zimmermann wrote: > > > > Am 14.07.25 um 10:57 schrieb Imre Deak: > > > Hi, > > > > > > On Thu, Jul 10, 2025 at 02:28:28PM +0300, Imre Deak wrote: > > > > Hi Thomas, Maxime, Maarten, > >

[PULL] drm-intel-fixes

2025-07-10 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes the drm-intel-fixes of this week as I'm covering for Joonas here. Also, only the single DSI fix from Hans. Thanks, Rodrigo. drm-intel-fixes-2025-07-10: Short summary of fixes: - DSI panel's version 2 mipi-sequences fix (Hans) The following changes since commit d7b8f8

[PULL] drm-intel-next

2025-07-10 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes the last drm-intel-next towards 6.17. I'm covering for Jani here, but in the end we got just one patch that is a fix, but let's push that soon anyway and minimize the -next-fixes round. Thanks, Rodrigo. drm-intel-next-2025-07-10: Driver Changes: - DSI panel's version

[PULL] drm-xe-next

2025-07-10 Thread Rodrigo Vivi
oing H2G requests when stopping CT Raag Jadav (2): drm/xe: Expose fan control and voltage regulator version drm/xe/pm: Wire up suspend/resume for I2C controller Reuven Abliyev (1): drm/xe/nvm: add support for non-posted erase Riana Tauro (2): drm/xe/xe_pmu: Validate gt in

Re: [PATCH v4 1/9] drm: Add a vendor-specific recovery method to device wedged uevent

2025-07-10 Thread Rodrigo Vivi
On Thu, Jul 10, 2025 at 01:24:52PM +0300, Raag Jadav wrote: > On Thu, Jul 10, 2025 at 11:37:14AM +0200, Christian König wrote: > > On 10.07.25 11:01, Simona Vetter wrote: > > > On Wed, Jul 09, 2025 at 12:52:05PM -0400, Rodrigo Vivi wrote: > > >> On Wed, Jul 09, 2025 a

Re: [PATCH resend] drm/i915/bios: Apply vlv_fixup_mipi_sequences() to v2 mipi-sequences too

2025-07-10 Thread Rodrigo Vivi
On Mon, Jul 07, 2025 at 11:10:59PM +0200, Hans de Goede wrote: > Hi Ville, > > On 4-Jul-25 12:31 PM, Ville Syrjälä wrote: > > On Thu, Jul 03, 2025 at 04:38:24PM +0200, Hans de Goede wrote: > >> From: Hans de Goede > >> > >> It turns out that the fixup from vlv_fixup_mipi_sequences() is necessary

[PATCH 2/9] mei: late_bind: add late binding component driver

2025-07-10 Thread Rodrigo Vivi
: Anshuman Gupta Signed-off-by: Rodrigo Vivi --- Changes in this revision: - Proper commit message - Proper explanation of 'Late Binding' on Kconfig help and doc - Consistency in naming: + mei_ prefix where it makes sense + use 'lb' for short of 'Late Binding' instead

[PATCH 8/9] drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late binding

2025-07-10 Thread Rodrigo Vivi
te in late binding flow from user space. Binary loaded from the userspace will be lost upon entering to D3 cold hence user space app need to handle this situation. v2: - s/(uval == 1) ? true : false/!!uval/ (Daniele) v3: - Refine the commit message (Daniele) Acked-by: Rodrigo Vivi Signed-o

[PATCH 0/9] Introducing firmware late binding

2025-07-10 Thread Rodrigo Vivi
Introducing firmware late binding feature to enable firmware loading for the devices, such as the fan controller and voltage regulator, during the driver probe. Typically, firmware for these devices are part of IFWI flash image but can be replaced at probe after OEM tuning. This version (v8?): I'm

[PATCH 1/9] mei: bus: add mei_cldev_mtu interface

2025-07-10 Thread Rodrigo Vivi
that can be safely sent before starting transmission and size of the buffer to allocate when receiving data. Signed-off-by: Alexander Usyskin Signed-off-by: Badal Nilawar Reviewed-by: Umesh Nerlige Ramappa Signed-off-by: Rodrigo Vivi --- Change in this revision: Proper commit message

[PATCH 9/9] drm/xe/xe_late_bind_fw: Extract and print version info

2025-07-10 Thread Rodrigo Vivi
From: Badal Nilawar Extract and print version info of the late binding binary. v2: Some refinements (Daniele) Signed-off-by: Badal Nilawar Reviewed-by: Daniele Ceraolo Spurio Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_late_bind_fw.c | 124 + drivers/gpu

[PATCH 3/9] drm/xe/xe_late_bind_fw: Introducing xe_late_bind_fw

2025-07-10 Thread Rodrigo Vivi
/INTEL_COMPONENT_LATE_BIND/ v6: - rebased Signed-off-by: Badal Nilawar Reviewed-by: Daniele Ceraolo Spurio Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/Makefile| 1 + drivers/gpu/drm/xe/xe_device.c | 5 ++ drivers/gpu/drm/xe/xe_device_types.h | 6

[PATCH 6/9] drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume

2025-07-10 Thread Rodrigo Vivi
From: Badal Nilawar Reload late binding fw during runtime resume. Signed-off-by: Badal Nilawar Reviewed-by: Rodrigo Vivi Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_late_bind_fw.c | 2 +- drivers/gpu/drm/xe/xe_late_bind_fw.h | 1 + drivers/gpu/drm/xe/xe_pm.c | 4 3

[PATCH 4/9] drm/xe/xe_late_bind_fw: Initialize late binding firmware

2025-07-10 Thread Rodrigo Vivi
: Daniele Ceraolo Spurio Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_late_bind_fw.c | 100 - drivers/gpu/drm/xe/xe_late_bind_fw_types.h | 30 +++ 2 files changed, 129 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers

[PATCH 5/9] drm/xe/xe_late_bind_fw: Load late binding firmware

2025-07-10 Thread Rodrigo Vivi
(Daniele) v7 (Rodrigo): - Rename of mei structs and callback. Signed-off-by: Badal Nilawar Reviewed-by: Daniele Ceraolo Spurio Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/xe/xe_late_bind_fw.c | 157 - drivers/gpu/drm/xe/xe_late_bind_fw.h | 1 + drivers/gpu

[PATCH 7/9] drm/xe/xe_late_bind_fw: Reload late binding fw during system resume

2025-07-10 Thread Rodrigo Vivi
From: Badal Nilawar Reload late binding fw during resume from system suspend v2: - Unconditionally reload late binding fw (Rodrigo) - Flush worker during system suspend Cc: Rodrigo Vivi Signed-off-by: Badal Nilawar Reviewed-by: Rodrigo Vivi Signed-off-by: Rodrigo Vivi --- drivers/gpu

Re: [PATCH v4 1/9] drm: Add a vendor-specific recovery method to device wedged uevent

2025-07-09 Thread Rodrigo Vivi
On Wed, Jul 09, 2025 at 05:18:54PM +0300, Raag Jadav wrote: > On Wed, Jul 09, 2025 at 04:09:20PM +0200, Christian König wrote: > > On 09.07.25 15:41, Simona Vetter wrote: > > > On Wed, Jul 09, 2025 at 04:50:13PM +0530, Riana Tauro wrote: > > >> Certain errors can cause the device to be wedged and m

Re: [RFC PATCH 0/1] drm/i915/display: Avoid unsupported 300Hz output mode on a TUXEDO device

2025-07-08 Thread Rodrigo Vivi
On Fri, Jul 04, 2025 at 09:03:45PM +0200, Werner Sembach wrote: > RFC because I'm not sure if this is the right approach. Could you please file a gitlab issue for us so we can get someone from our display team to take a look and see if there's anything else that could be done before we take the qu

Re: [PATCH v5 10/10] drm/xe/xe_late_bind_fw: Select INTEL_MEI_LATE_BIND for CI

2025-07-02 Thread Rodrigo Vivi
On Wed, Jul 02, 2025 at 10:22:16PM +0530, Badal Nilawar wrote: > Do not review Why? Why don't we add this dependency here? > > Signed-off-by: Badal Nilawar > --- > drivers/gpu/drm/xe/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm

Re: [PATCH v5 06/10] drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume

2025-07-02 Thread Rodrigo Vivi
er > to ensure worker completes lb fw loading. Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/xe/xe_late_bind_fw.c | 2 +- > drivers/gpu/drm/xe/xe_late_bind_fw.h | 1 + > drivers/gpu/drm/xe/xe_pm.c | 4 > 3 files changed, 6 insertions(+), 1 deletion(-)

Re: [PATCH v5 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw during system resume

2025-07-02 Thread Rodrigo Vivi
On Wed, Jul 02, 2025 at 10:22:13PM +0530, Badal Nilawar wrote: > Reload late binding fw during resume from system suspend > > v2: > - Unconditionally reload late binding fw (Rodrigo) > - Flush worker during system suspend > > Cc: Rodrigo Vivi > Signed-off-by: Bad

Re: [PATCH v4 02/10] mei: late_bind: add late binding component driver

2025-07-01 Thread Rodrigo Vivi
On Tue, Jul 01, 2025 at 10:11:54PM +0530, Nilawar, Badal wrote: > > On 01-07-2025 18:04, Nilawar, Badal wrote: > > > > On 01-07-2025 15:15, Greg KH wrote: > > > On Tue, Jul 01, 2025 at 02:02:15PM +0530, Nilawar, Badal wrote: > > > > On 28-06-2025 17:48, Greg KH wrote: > > > > > > + * @payload_siz

Re: [RFC 9/9] {fwctl,drm}/xe/pcode: Introduce xe_pcode_fwctl

2025-06-30 Thread Rodrigo Vivi
On Tue, May 06, 2025 at 03:13:53PM -0300, Jason Gunthorpe wrote: > On Tue, Apr 29, 2025 at 09:39:56PM +0530, Badal Nilawar wrote: > > > diff --git a/drivers/gpu/drm/xe/xe_pcode_fwctl.c > > b/drivers/gpu/drm/xe/xe_pcode_fwctl.c > > new file mode 100644 > > I really do prefer it if you can find a

Re: [PATCH] drm/i915/gsc: mei interrupt top half should be in irq disabled context

2025-06-30 Thread Rodrigo Vivi
r(struct intel_gt *gt, unsigned > int intf_id) > if (gt->gsc.intf[intf_id].irq < 0) > return; > > - ret = generic_handle_irq(gt->gsc.intf[intf_id].irq); > + ret = generic_handle_irq_safe(gt->gsc.intf[intf_id].irq); Reviewed-by: Rodrigo

Re: [PATCH v2 1/5] drm: Add a firmware flash method to device wedged uevent

2025-06-30 Thread Rodrigo Vivi
On Mon, Jun 30, 2025 at 10:29:10AM +0200, Christian König wrote: > On 27.06.25 23:38, Rodrigo Vivi wrote: > >>> Or at least print a big warning into the system log? > >>> > >>> I mean a firmware update is usually something which the system > >>>

Re: [PATCH v2 1/5] drm: Add a firmware flash method to device wedged uevent

2025-06-27 Thread Rodrigo Vivi
On Tue, Jun 24, 2025 at 05:36:29PM -0400, Rodrigo Vivi wrote: > On Tue, Jun 24, 2025 at 04:23:31PM +0200, Christian König wrote: > > On 24.06.25 16:03, Riana Tauro wrote: > > > Hi Christian > > > > > > On 6/24/2025 5:56 PM, Christian König wrote: > &g

Re: [PATCH v4 03/10] drm/xe/xe_late_bind_fw: Introducing xe_late_bind_fw

2025-06-27 Thread Rodrigo Vivi
On Wed, Jun 25, 2025 at 10:30:08PM +0530, Badal Nilawar wrote: > Introducing xe_late_bind_fw to enable firmware loading for the devices, > such as the fan controller, during the driver probe. Typically, > firmware for such devices are part of IFWI flash image but can be > replaced at probe after OE

Re: [PATCH v4 05/10] drm/xe/xe_late_bind_fw: Load late binding firmware

2025-06-26 Thread Rodrigo Vivi
On Thu, Jun 26, 2025 at 03:38:18PM -0700, Daniele Ceraolo Spurio wrote: > > > On 6/26/2025 2:49 PM, Rodrigo Vivi wrote: > > On Thu, Jun 26, 2025 at 02:27:50PM -0700, Daniele Ceraolo Spurio wrote: > > > > > > On 6/26/2025 10:24 AM, Rodrigo Vivi wrote: > >

Re: [PATCH v4 05/10] drm/xe/xe_late_bind_fw: Load late binding firmware

2025-06-26 Thread Rodrigo Vivi
On Thu, Jun 26, 2025 at 02:27:50PM -0700, Daniele Ceraolo Spurio wrote: > > > On 6/26/2025 10:24 AM, Rodrigo Vivi wrote: > > On Wed, Jun 25, 2025 at 10:30:10PM +0530, Badal Nilawar wrote: > > > Load late binding firmware > > > > > > v2: > >

Re: [PATCH v4 05/10] drm/xe/xe_late_bind_fw: Load late binding firmware

2025-06-26 Thread Rodrigo Vivi
On Wed, Jun 25, 2025 at 10:30:10PM +0530, Badal Nilawar wrote: > Load late binding firmware > > v2: > - s/EAGAIN/EBUSY/ > - Flush worker in suspend and driver unload (Daniele) > v3: > - Use retry interval of 6s, in steps of 200ms, to allow >other OS components release MEI CL handle (Sasha)

  1   2   3   4   5   6   7   8   9   10   >