omas.
We are still not enabling these DRM drivers in Fedora though, but maybe it
is time to do that and just disable CONFIG_SYSFB_SIMPLEFB. I can propose a
change request for Fedora 44 to do this.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Marcus Folkesson writes:
Hello Marcus,
> Hello Javier,
>
> On Thu, Sep 18, 2025 at 01:07:18PM +0200, Javier Martinez Canillas wrote:
>> Marcus Folkesson writes:
>>
>> Hello Marcus,
>>
>> > Hello Javier,
>> >
>> > On Wed, Sep
an individual element. So the arguments should be swapped.
> Same for the other changes.
>
> I know it's nitpicking, but who knows what it'll be good for. Fun fact
> is that even kmalloc_array mixes up both parameters internally.
>
You are right. I didn't notice this subtlety when reviewing mentioned
patch that pushed to drm-misc-next.
> Best regards
> Thomas
>
>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
t; - Use a goto label to ensure drm_dev_exit() is called in the error path
> of drm_gem_fb_begin_cpu_access().
> - Link to v1:
> https://lore.kernel.org/r/20250912-improve-ssd130x-v1-0-bc9389ed2...@gmail.com
>
Pushed to drm-misc (drm-misc-next). Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Marcus Folkesson writes:
Hello Marcus,
> Hello Javier,
>
> On Wed, Sep 17, 2025 at 11:32:05AM +0200, Javier Martinez Canillas wrote:
>> Marcus Folkesson writes:
>>
>> > We cannot know where the write pointer is, always reset position to
>> > (0,0) before
per_mode_valid_fixed() helper for this exact
> use case.
>
> Signed-off-by: Iker Pedrosa
> ---
Indeed.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ith this
> patch (6.1.y, 6.6.y, 6.12,y, 6.15.y, 6.16.y) and mainline are unaffected.
But are you proposing to revert the mentioned commit in mainline too
or just in the 5.15.y LTS tree ?
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
e blit lookup in begin_fb_access then
> always uses the correct CRTC format on all drivers.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
-by: James Flowers
> ---
Pushed to drm-misc (drm-misc-next). Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Brett A C Sheffield writes:
> On 2025-09-10 12:46, Javier Martinez Canillas wrote:
>> Brett A C Sheffield writes:
>>
>> Hello Brett,
>>
>> > This reverts commit 13d28e0c79cbf69fc6f145767af66905586c1249.
>> >
>> > Commit ee7a69
; ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
>
> Signed-off-by: Iker Pedrosa
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
cs subsystem.
>
> Signed-off-by: Iker Pedrosa
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
avoids this issue.
>
> Signed-off-by: James Flowers
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Marcus Folkesson writes:
> We cannot know where the write pointer is, always reset position to
> (0,0) before clearing display.
>
> Signed-off-by: Marcus Folkesson
> ---
Reviewed-by: Javier Martinez Canillas
Marcus, do you already have commit rights in drm-misc or do you w
and then here before the call you could have the label.
out_drm_dev_exit:
> drm_dev_exit(idx);
Same comments for the other places where you are adding the
drm_gem_fb_end_cpu*() calls next to the drm_dev*() ones.
After the mentioned changes:
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
> The function is unused; remove it.
>
> Instead of relying on a general blit helper, drivers should pick a blit
> function by themselves from their list of supported color formats.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Jav
drm_gem_duplicate_shadow_plane_state(plane, new_shadow_plane_state);
return &new_shadow_plane_state->base;
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Michael Kelley writes:
Hello Michael,
> From: Javier Martinez Canillas Sent: Tuesday, September
> 2, 2025 8:41 AM
>>
>> Thomas Zimmermann writes:
>>
>> [...]
>>
>> >>
>> >> I'm not familiar with hyperv to know whether i
o not rate-limit their output.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
[...]
>
> @@ -111,11 +113,15 @@ static void hyperv_crtc_helper_atomic_enable(struct
> drm_crtc *crtc,
> crtc_state->mode.hdispl
*src, const struct
drm_framebuffer *fb,
CHECK: Alignment should match open parenthesis
#153: FILE: include/drm/drm_format_helper.h:140:
+void drm_fb_xrgb_to_gray2(struct iosys_map *dst, const unsigned int
*dst_pitch,
+const struct iosys_map *src, const struct
drm_f
Thomas Zimmermann writes:
Hello Thomas,
> Hi
>
> Am 11.08.25 um 14:06 schrieb Marcus Folkesson:
>> On Mon, Jul 21, 2025 at 01:24:19PM +0200, Javier Martinez Canillas wrote:
>>> Marcus Folkesson writes:
>>>
>>>> Convert XRGB to 2bit grayscale.
&g
tc_vblank_atomic_disable,
+ .atomic_disable = hyperv_crtc_helper_atomic_disable,
};
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
that touches the struct vkms_output).
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
uct vkms_output. The
> vblank timer calls vkms' custom timeout code via handle_vblank_timeout
> in struct drm_crtc_helper_funcs.
>
> Signed-off-by: Thomas Zimmermann
> Tested-by: Louis Chauvet
> Reviewed-by: Louis Chauvet
> ---
Reviewed-by: Javier Martinez Canillas
--
al processing, such as vkms, can init
> handle_vblank_timeout in struct drm_crtc_helper_funcs to refer to
> their timeout handler.
>
> v2:
> - implement vblank timer entirely in vblank helpers
> - downgrade overrun warning to debug
> - fix docs
>
> Signed-off-by: Thomas Zimm
v_err_probe(dev, -ENOMEM,
> - "Failed to allocate SPI transport data\n");
> + return -ENOMEM;
>
> t->spi = spi;
> t->dc = dc;
> --
> 2.34.1
>
Reviewed-by: Javier Martinez Canillas
Pushed to drm-misc (drm-misc-next). Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
n't have a folder to put
> these drivers under.
>
> It was pretty confusing to differentiate a driver maintained through its
> own tree, and one maintained through drm-misc, so at least explicitly
> having the git tree set to drm-misc is how we show that's where the
> patches are going to land.
>
Thanks a lot for the clarification.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Dmitry Baryshkov writes:
> On Fri, Jul 18, 2025 at 05:25:25PM +0200, Javier Martinez Canillas wrote:
>> The kernel test robot reported that sparse gives the following warnings:
>>
>> make C=2 M=drivers/gpu/drm/sitronix/
>> CC [M] st7571-i2c.o
>> CHECK st7
r me the change looks good.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
> If this is not what the display map against, the controller has support
> to invert these values.
>
> Signed-off-by: Marcus Folkesson
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ng: symbol 'st7571_config' was not declared. Should
it be static?
MODPOST Module.symvers
LD [M] st7571-i2c.ko
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202507180503.nfyd9urv-...@intel.com
Signed-off-by: Javier Martinez Canillas
---
Changes in
ng: symbol 'st7571_config' was not declared. Should
it be static?
MODPOST Module.symvers
LD [M] st7571-i2c.ko
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202507180503.nfyd9urv-...@intel.com
Signed-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/sitro
Javier Martinez Canillas writes:
> This patch-series adds support for the Sitronix ST7567 Controller, which is a
> monochrome Dot Matrix LCD Controller that has SPI, I2C and parallel
> interfaces.
>
> The st7571-i2c driver only has support for I2C so displays using oth
Other Sitronix display controllers might need a different parsing DT
logic, so lets add a .parse_dt callback to struct st7571_panel_data.
Suggested-by: Thomas Zimmermann
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Marcus Folkesson
---
(no changes since v1)
drivers/gpu/drm/sitronix
is used by the ST7571 controller, so only is needed a different callback
that implements the expected initialization sequence for the ST7567 chip.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Marcus Folkesson
Reviewed-by: Thomas Zimmermann
---
Changes in v3:
- Explicitly set
Sitronix ST7567 is a monochrome Dot Matrix LCD Controller.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Rob Herring (Arm)
Reviewed-by: Marcus Folkesson
---
(no changes since v1)
.../bindings/display/sitronix,st7567.yaml | 63 +++
MAINTAINERS
The driver already uses the dev_err_probe() helper (that only prints error
messages for the -EPROBE_DEFER case) when fails to get any other resource.
Also do the same when it fails to obtain the reset GPIO.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Marcus Folkesson
---
Changes in
It seems the driver took some inspiration from ssd130x and some of the
functions (encoder callbacks) were not renamed to use a st7571_ prefix.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Marcus Folkesson
---
(no changes since v1)
drivers/gpu/drm/sitronix/st7571-i2c.c | 12
.
Changes in v3:
- Fix reset typo in commit message (Marcus Folkesson).
- Explicitly set ST7571_SET_REVERSE(0) instead of relying on defaults.
Changes in v2:
- Use a different parse DT function (Thomas Zimmermann).
Javier Martinez Canillas (5):
drm/sitronix/st7571-i2c: Fix encoder callbacks
Marcus Folkesson writes:
> On Mon, Jul 14, 2025 at 12:44:01PM +0200, Javier Martinez Canillas wrote:
>> The driver already uses the dev_err_probe() helper (that only prints error
>> messages for the -EPROBE_DEFER case) when fails to get any other resource.
>>
>> Als
Marcus Folkesson writes:
Hello Marcus,
> On Mon, Jul 14, 2025 at 12:44:00PM +0200, Javier Martinez Canillas wrote:
>> It seems the driver took some inspiration from ssd130x and some of the
>> functions (encoder callbacks) were not renamed to use a st7571_ prefix.
>
> Outch,
Marcus Folkesson writes:
> Add support for 2bit grayscale and use it for XRGB when grayscale is
> supported.
>
> Signed-off-by: Marcus Folkesson
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
It seems the driver took some inspiration from ssd130x and some of the
functions (encoder callbacks) were not renamed to use a st7571_ prefix.
Signed-off-by: Javier Martinez Canillas
---
(no changes since v1)
drivers/gpu/drm/sitronix/st7571-i2c.c | 12 ++--
1 file changed, 6
> Dark Gray
> 10 => Light Gray
> 11 => White
>
> If this is not what the display map against, make it possible to invert
> the pixels.
>
> Signed-off-by: Marcus Folkesson
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
controller also have a "Inverse Display" command, so this
property will also apply.
Or do you prefer for this to land before and then I could post a v3 on top?
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
.
Changes in v2:
- Use a different parse DT function (Thomas Zimmermann).
Javier Martinez Canillas (5):
drm/sitronix/st7571-i2c: Fix encoder callbacks function names
drm/sitronix/st7571-i2c: Log probe deferral cause for GPIO get failure
drm/sitronix/st7571-i2c: Add an indirection level to parse
off-by: Marcus Folkesson
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
The driver already uses the dev_err_probe() helper (that only prints error
messages for the -EPROBE_DEFER case) when fails to get any other resource.
Also do the same when it fails to obtain the rest GPIO.
Signed-off-by: Javier Martinez Canillas
---
(no changes since v1)
drivers/gpu/drm
Other Sitronix display controllers might need a different parsing DT
logic, so lets add a .parse_dt callback to struct st7571_panel_data.
Suggested-by: Thomas Zimmermann
Signed-off-by: Javier Martinez Canillas
---
(no changes since v1)
drivers/gpu/drm/sitronix/st7571-i2c.c | 4 +++-
1 file
is used by the ST7571 controller, so only is needed a different callback
that implements the expected initialization sequence for the ST7567 chip.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Marcus Folkesson
---
Changes in v2:
- Use a different parse DT function (Thomas Zimmermann
Sitronix ST7567 is a monochrome Dot Matrix LCD Controller.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Rob Herring (Arm)
Reviewed-by: Marcus Folkesson
---
(no changes since v1)
.../bindings/display/sitronix,st7567.yaml | 63 +++
MAINTAINERS
Thomas Zimmermann writes:
> Hi
>
> Am 10.07.25 um 12:24 schrieb Javier Martinez Canillas:
>> Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin,
>> so lets relax this in the driver and make the reset GPIO to be optional.
>>
>> T
Thomas Zimmermann writes:
Hello Thomas,
> Hi
>
> Am 10.07.25 um 12:24 schrieb Javier Martinez Canillas:
>> Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin,
>> so lets relax this in the driver and make the reset GPIO to be optional.
>>
Marcus Folkesson writes:
Hello Marcus,
> Hello Javier,
>
>
> On Thu, Jul 10, 2025 at 12:24:32PM +0200, Javier Martinez Canillas wrote:
>> This patch-series adds support for the Sitronix ST7567 Controller, which is
>> is a
>> monochrome Dot Matrix LCD Controller
Marcus Folkesson writes:
Hello Marcus,
> Hello Javier,
>
> On Thu, Jul 10, 2025 at 01:00:41PM +0200, Javier Martinez Canillas wrote:
>> >
>> > devm_gpiod_get_optional() returns -ENOENT when the GPIO is not found,
>> > and that is no error we want to propagag
onversion state.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
onversion state.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ut allows
> common userspace, such as Wayland compositors, to operate on the
> display.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
;
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
> List the conversion from XRGB-to-RGB332 in drm_fb_blit(), so that
> drivers based on sysfb-helpers can use it.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
<< 13) | (g << 10) | (g << 7) | (g << 4) | (g << 1) | (g >> 2);
b = (b << 14) | (b << 12) | (b << 10) | (b << 8) | (b << 6) | (b <<
4) | (b << 2) | b;
/* Call the drivers' specific callback to program the hardware LUT */
set_palette(crtc, i, r, g, b);
It might be evident to you, but I don't think it will be for others looking
at the code later.
The code itself looks good to me, if I understood it correctly :)
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
t; 1 file changed, 9 insertions(+), 12 deletions(-)
>
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
to use the pixel format.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
gt;
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
"Luca Weiss" writes:
Hello Luca,
> Hi Javier,
>
> On Fri Jun 27, 2025 at 9:51 AM CEST, Javier Martinez Canillas wrote:
[...]
>>> +static int simpledrm_device_attach_icc(struct simpledrm_device *sdev)
>>> +{
>>> + struct device *dev =
xpect them to be broken.
>
> Signed-off-by: Maxime Ripard
> ---
This seems to be much more robust indeed.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Maxime Ripard writes:
> For some reason, the HDMI VSDBs in our kunit EDIDs had a length longer
> than expected.
>
> While this was harmless, we should get rid of it to make it somewhat
> predictable.
>
> Signed-off-by: Maxime Ripard
> ---
Reviewed-by: Javier Mart
, 30-70 kHz H, max dotclock 150 MHz
>
> They were actually:
> Display Range Limits:
> Monitor ranges (GTF): 50-70 Hz V, 0-0 kHz H, max dotclock 1960 MHz
>
> Fix that section of the EDIDs to match the expected edid-decode output.
>
> Signed-off-by: Maxime Ripard
&g
Tomi Valkeinen writes:
Hello Tomi,
> Add a call to drm_aperture_remove_framebuffers() to drop the possible
> early fb (simplefb).
>
> Signed-off-by: Tomi Valkeinen
> ---
This patch can be picked and is independant of how the other one.
Reviewed-by: Javier Martinez Canillas
-
Marcus Folkesson writes:
Hello Marcus,
Thanks for your feedback.
> On Thu, Jul 10, 2025 at 12:24:34PM +0200, Javier Martinez Canillas wrote:
>> Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin,
>> so lets relax this in the driver and make the reset
is used by the ST7571 controller, so only is needed a different callback
that implements the expected initialization sequence for the ST7567 chip.
Signed-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/sitronix/st7571-i2c.c | 47 +++
1 file changed, 47 insertions
a DT node.
The DT binding schema for "sitronix,st7571" that require a reset GPIO will
enforce the "reset-gpios" to be present, due being a required DT property.
But in the driver itself the property can be made optional if not defined.
Signed-off-by: Javier Martinez Canillas
"reset-gpios" property in the driver to be optional since
that
isn't needed for the ST7567.
Patch #3 finally extends the st7571-i2c driver to also support the ST7567
device.
Javier Martinez Canillas (3):
dt-bindings: display: Add Sitronix ST7567 LCD Controller
drm/sitronix/st757
Sitronix ST7567 is a monochrome Dot Matrix LCD Controller.
Signed-off-by: Javier Martinez Canillas
---
.../bindings/display/sitronix,st7567.yaml | 63 +++
MAINTAINERS | 1 +
2 files changed, 64 insertions(+)
create mode 100644
"Rob Herring (Arm)" writes:
Hello Rob,
> Use the newly added of_reserved_mem_region_to_resource() function to
> handle "memory-region" properties.
>
> Signed-off-by: Rob Herring (Arm)
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier M
Javier Martinez Canillas writes:
> The commit d391c5827107 ("drivers/firmware: move x86 Generic System
> Framebuffers support") moved the sysfb*.c source files from arch/x86
> to drivers/firmware, because the logic wasn't x86 specific and could
> be used by other
Rob Clark writes:
> On Fri, Jun 27, 2025 at 12:10 PM Javier Martinez Canillas
> wrote:
>>
>> Laurent Pinchart writes:
>>
>> > On Fri, Jun 27, 2025 at 09:39:37AM -0700, Rob Clark wrote:
>> >> On Mon, Feb 26, 2024 at 5:43 AM Jacopo Mondi wrote:
>
say that you could just push it through drm-misc
since there are already a few review-by tags collected.
[0]:
https://drm.pages.freedesktop.org/maintainer-tools/committer/committer-drm-misc.html#merge-criteria
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
her be directed towards deleting
> simplefb entirely.
>
That is a good point. You are correct that having some duplication to
make easier to get rid of the fbdev driver is a much better approach.
> Best regards
> Thomas
>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
7 ("drivers/firmware: move x86 Generic System Framebuffers
support")
Reported-by: Andy Shevchenko
Closes: https://lore.kernel.org/lkml/af53djlieunf_...@smile.fi.intel.com/
Signed-off-by: Javier Martinez Canillas
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/M
ht need a set
of clocks, power domains, regulators, etc left enabled in order to work.
It's true that the "simple" is a misnomer, probably these drivers should
had been named sysfb and sysfbdrm, or something along those lines.
> The driver code also has that support added in this series.
>
> Regards
> Luca
>
>>
>> Best regards,
>> Krzysztof
>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
"Luca Weiss" writes:
> On Fri Jun 27, 2025 at 9:56 AM CEST, Javier Martinez Canillas wrote:
[...]
>> These two functions contain the same logic that you are using in the
>> simpledrm driver. I wonder if could be made helpers so that the code
>> isn't dupli
Maxime Ripard writes:
> On Fri, Jun 27, 2025 at 11:04:16AM +0200, Javier Martinez Canillas wrote:
>> Maxime Ripard writes:
>>
[...]
>>
>> Usually I prefer to have static inline functions instead of macros to have
>> type checking. I see that this header has
mann
> Fixes: 814d270b31d2 ("drm/sysfb: vesadrm: Add gamma correction")
> Link:
> https://elixir.bootlin.com/linux/v6.15/source/drivers/video/fbdev/vesafb.c#L375
> # 1
> Cc: Thomas Zimmermann
> Cc: Javier Martinez Canillas
> Cc: dri-devel@lists.freedesktop.org
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
e one if
> relevant.
>
> Reported-by: Francesco Dolcini
> Closes: https://lore.kernel.org/all/20250612081834.GA248237@francesco-nb/
> Fixes: de04bb0089a9 ("drm/panel/panel-simple: Use the new allocation in place
> of devm_kzalloc()")
> Signed-off-by: Maxime Ripard
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
0);
> if (ddc) {
> panel->ddc = of_find_i2c_adapter_by_node(ddc);
> of_node_put(ddc);
>
> if (!panel->ddc)
> - return -EPROBE_DEFER;
> + return ERR_PTR(-EPROBE_DEFER);
Not r
o
> the caller.
>
> This will not fix the breaking commit entirely, but will move us towards
> the right direction.
>
> Fixes: de04bb0089a9 ("drm/panel/panel-simple: Use the new allocation in place
> of devm_kzalloc()")
> Signed-off-by: Maxime Ripard
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
functions instead of macros to have
type checking. I see that this header has a mix of both, so I don't have a
strong opinion on what to use in this case.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Luca Weiss writes:
> Make sure the headers are sorted alphabetically to ensure consistent
> code.
>
> Signed-off-by: Luca Weiss
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
detach_icc, par);
> +
> +err:
> + while (i) {
> + --i;
> + if (!IS_ERR_OR_NULL(par->icc_paths[i]))
> + icc_put(par->icc_paths[i]);
> + }
> + return ret;
> +}
> +#else
These two functions contain the same logic that you are using in the
simpledrm driver. I wonder if could be made helpers so that the code
isn't duplicated in both drivers.
But in any case it could be a follow-up of your series I think.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
goto err;
> + drm_err(&sdev->sysfb.dev, "failed to get interconnect
> path %u: %d\n",
> + i, ret);
You could use dev_err_probe() instead that already handles the -EPROBE_DEFER
case and also will get this message in the /sys/kernel/debug/devices_deferred
debugfs entry, as the reason why the probe deferral happened.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Luca Weiss writes:
> Make sure the headers are sorted alphabetically to ensure consistent
> code.
>
> Signed-off-by: Luca Weiss
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
s
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ed-off-by: Thomas Zimmermann
> Fixes: a979a54165c2 ("drm/format-helper: Normalize BT.601 factors to 256")
> Cc: Thomas Zimmermann
> Cc: Javier Martinez Canillas
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> ---
> drivers/gpu/drm/tests/drm_format_helper_tes
his patch.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
John Keeping writes:
Hello John,
> The number of columns relates to the width, not the height. Use the
> correct variable.
>
> Signed-off-by: John Keeping
> ---
Pushed to drm-misc (drm-misc-fixes). Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
1 - 100 of 2183 matches
Mail list logo