Re: [PATCH v1 6/6] drm/mediatek: Add support for MT8195 Digital Parallel Interface

2024-11-21 Thread 胡俊光

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-21 Thread Raag Jadav
On Mon, Nov 18, 2024 at 08:26:37PM +0530, Aravind Iddamsetty wrote: > On 15/11/24 10:37, Raag Jadav wrote: > > Introduce device wedged event, which notifies userspace of 'wedged' > > (hanged/unusable) state of the DRM device through a uevent. This is > > useful especially in cases where the device

Re: [PATCH v1 3/6] drm/mediatek: mtk_dpi: Use an array for pixclk factor calculation

2024-11-21 Thread 胡俊光

Re: [PATCH 0/5] clk: Fix simple video pipelines on i.MX8

2024-11-21 Thread Liu Ying
> Miquel Raynal (4): > clk: Add a helper to determine a clock rate > clk: Split clk_calc_subtree() > clk: Add flag to prevent frequency changes when walking subtrees > clk: imx: imx8mp: Prevent media clocks to be incompatibly changed > > drivers/clk/clk.c| 39

Re: [PATCH v1 2/6] drm/mediatek: mtk_dpi: Add support for Pattern Generator in debugfs

2024-11-21 Thread 胡俊光

RE: [PATCHv6 5/8] drm/i915/histogram: Add crtc properties for global histogram

2024-11-21 Thread Murthy, Arun R
> On Thu, Nov 21, 2024 at 05:56:00PM +0530, Arun R Murthy wrote: > > CRTC properties have been added for enable/disable histogram, reading > > the histogram data and writing the IET data. > > "HISTOGRAM_EN" is the crtc property to enable/disable the global > > histogram and takes a value 0/1 accord

Re: Phase out ttm_exec

2024-11-21 Thread Zack Rusin
On Thu, Nov 21, 2024 at 5:27 AM Christian König wrote: > > Hey Zack, > > vmwgfx is the only driver left using this component. > > So I though I go ahead and complete switching over to drm_exec. > The patches are only compile tested, but relatively staright forward. Hi, Christian. Thank you so mu

Re: [PATCHv2 3/3] drm/i915/display: Populate list of async supported formats/modifiers

2024-11-21 Thread kernel test robot
Hi Arun, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-intel/for-linux-next-fixes] [also build test WARNING on v6.12 next-20241121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v1 3/6] drm/mediatek: mtk_dpi: Use an array for pixclk factor calculation

2024-11-21 Thread 胡俊光

RE: [PATCH v7 2/7] Revert "clk: imx: clk-imx8mp: Allow media_disp pixel clock reconfigure parent rate"

2024-11-21 Thread Ying Liu
On 11/22/24, Marek Vasut wrote: > On 11/20/24 7:38 AM, Ying Liu wrote: > > [...] > > >>> If the DP monitors support typical video modes like 1080p60 with > >>> 148.5MHz pixel clock rate, I assume these typical video modes work > >>> still ok with this patch at least. Please help confirm this, s

Re: [PATCH v5 4/9] drm/vs: Add Hardware Functions for VS DC8200

2024-11-21 Thread kernel test robot
Hi keith, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.12 next-20241121] [cannot apply to drm-misc/drm-misc-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

[PATCH v4 1/7] ASoC: hdmi-codec: pass data to get_dai_id too

2024-11-21 Thread Dmitry Baryshkov
The upcoming DRM connector HDMI codec implementation is going to use codec-specific data in the .get_dai_id to get drm_connector. Pass data to the callback, as it is done with other hdmi_codec_ops callbacks. Acked-by: Mark Brown Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/adv7511

Re: [RFC PATCH 02/29] dma-fence: Add dma_fence_user_fence

2024-11-21 Thread Matthew Brost
On Thu, Nov 21, 2024 at 10:31:16AM +0100, Christian König wrote: > Am 20.11.24 um 23:50 schrieb Matthew Brost: > > On Wed, Nov 20, 2024 at 02:38:49PM +0100, Christian König wrote: > > > Am 19.11.24 um 00:37 schrieb Matthew Brost: > > > > Normalize user fence attachment to a DMA fence. A user fence

Re: [PATCH v5 drm-dp 5/5] drm/hisilicon/hibmc: add dp module in hibmc

2024-11-21 Thread Dmitry Baryshkov
On Mon, Nov 18, 2024 at 10:28:05PM +0800, Yongbang Shi wrote: > From: baihan li > > To support DP interface displaying in hibmc driver. Add > a encoder and connector for DP modual. > > Signed-off-by: Baihan Li > Signed-off-by: Yongbang Shi > --- > ChangeLog: > v3 -> v4: > - static inline hib

Re: [PATCH v5 drm-dp 4/5] drm/hisilicon/hibmc: separate struct of vdac

2024-11-21 Thread Dmitry Baryshkov
On Mon, Nov 18, 2024 at 10:28:04PM +0800, Yongbang Shi wrote: > From: baihan li > > Refactored struct hibmc_drm_private to separate VGA module from > generic struct. > > Signed-off-by: Baihan Li > Signed-off-by: Yongbang Shi > --- > ChangeLog: > v3 -> v4: > - separating hibmc_vdac and hibmc_

Re: [PATCH v5 drm-dp 3/5] drm/hisilicon/hibmc: add dp hw moduel in hibmc

2024-11-21 Thread Dmitry Baryshkov
On Mon, Nov 18, 2024 at 10:28:03PM +0800, Yongbang Shi wrote: > From: baihan li > > Build a dp level that hibmc driver can enable dp by > calling their functions. > > Signed-off-by: Baihan Li > Signed-off-by: Yongbang Shi > --- > ChangeLog: > v3 -> v4: > - changed the type of train_set to ar

Re: [PATCH v5 drm-dp 2/5] drm/hisilicon/hibmc: add dp link moduel in hibmc

2024-11-21 Thread Dmitry Baryshkov
On Mon, Nov 18, 2024 at 10:28:02PM +0800, Yongbang Shi wrote: > From: baihan li > > Add link training process functions in this moduel. > > Signed-off-by: Baihan Li > Signed-off-by: Yongbang Shi > --- > Changelog: > v3 -> v4: > - optimizing hibmc_dp_link_get_adjust_train() to delete for loop

Re: [PATCH] nouveau: Remove unused functions

2024-11-21 Thread Dr. David Alan Gilbert
* li...@treblig.org (li...@treblig.org) wrote: > From: "Dr. David Alan Gilbert" > > dcb_outp_match() last use was removed in 2017 in > commit 99a845a30f62 ("drm/nouveau/disp/nv50-gt21x: remove workaround for > dp->tmds hotplug issues") > > dcb_xpio_parse was added in 2012 in > commit 112a12aab8a

Re: [PATCH v1 1/6] dt-bindings: display: mediatek: dpi: Add MT8195 and MT8188 compat

2024-11-21 Thread 胡俊光

Re: [PATCH v5 drm-dp 1/5] drm/hisilicon/hibmc: add dp aux in hibmc

2024-11-21 Thread Dmitry Baryshkov
On Mon, Nov 18, 2024 at 10:28:01PM +0800, Yongbang Shi wrote: > From: baihan li > > Add dp aux read/write functions. They are basic functions > and will be used later. > > Signed-off-by: Baihan Li > Signed-off-by: Yongbang Shi > --- > ChangeLog: > v4 -> v5: > - fixing build errors reported b

[PATCH v4 4/7] drm/bridge: connector: add support for HDMI codec framework

2024-11-21 Thread Dmitry Baryshkov
Add necessary glue code to be able to use new HDMI codec framework from the DRM bridge drivers. The drm_bridge implements a limited set of the hdmi_codec_ops interface, with the functions accepting both drm_connector and drm_bridge instead of just a generic void pointer. This framework is integrat

[PATCH v4 7/7] drm/bridge_connector: hook drm_atomic_helper_connector_hdmi_update_edid()

2024-11-21 Thread Dmitry Baryshkov
Extend drm_bridge_connector code to read the EDID and use it to update connector status if the bridge chain implements HDMI bridge. Performing it from the generic location minimizes individual bridge's code and enforces standard behaviour from all corresponding drivers. Signed-off-by: Dmitry Barys

[PATCH v4 2/7] ASoC: hdmi-codec: move no_capture_mute to struct hdmi_codec_pdata

2024-11-21 Thread Dmitry Baryshkov
The no_capture_mute flag might differ from platform to platform, especially in the case of the wrapping implementations, like the upcoming DRM HDMI Codec framework. Move the flag next to all other flags in struct hdmi_codec_pdata. Acked-by: Mark Brown Signed-off-by: Dmitry Baryshkov --- drivers

[PATCH v4 0/7] drm: add DRM HDMI Codec framework

2024-11-21 Thread Dmitry Baryshkov
While porting lt9611 DSI-to-HDMI bridge driver to use HDMI Connector framework, I stumbled upon an issue while handling the Audio InfoFrames. The HDMI codec callbacks weren't receiving the drm_atomic_state, so there was no simple way to get the drm_connector that stayed at the end of the bridge cha

[PATCH v4 5/7] drm/bridge: lt9611: switch to using the DRM HDMI codec framework

2024-11-21 Thread Dmitry Baryshkov
Make the Lontium LT9611 DSI-to-HDMI bridge driver use the DRM HDMI Codec framework. This enables programming of Audio InfoFrames using the HDMI Connector interface and also enables support for the missing features, including the ELD retrieval and better hotplug support. Signed-off-by: Dmitry Barys

[PATCH v4 6/7] drm/display/hdmi: implement connector update functions

2024-11-21 Thread Dmitry Baryshkov
The HDMI Connectors need to perform a variety of tasks when the HDMI connector state changes. Such tasks include setting or invalidating CEC address, notifying HDMI codec driver, updating scrambler data, etc. Implementing such tasks in a driver-specific callbacks is error prone. Start implementing

[PATCH v4 3/7] drm/connector: implement generic HDMI codec helpers

2024-11-21 Thread Dmitry Baryshkov
Several DRM drivers implement HDMI codec support (despite its name it applies to both HDMI and DisplayPort drivers). Implement generic framework to be used by these drivers. This removes a requirement to implement get_eld() callback and provides default implementation for codec's plug handling. Th

Re: [PATCH v5 9/9] drm/vs: Add VS DRM Master Driver for JH7110 SoC

2024-11-21 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 02:18:48PM +0800, keith zhao wrote: > The VS DRM master driver for the JH7110 System on Chip (SoC), > along with the addition of a DMA GEM (Graphics Execution Manager) driver > > Signed-off-by: keith zhao > --- > drivers/gpu/drm/verisilicon/Makefile | 3 +- > drivers/gp

Re: [PATCH v5 7/9] drm/vs: Add VS Plane API

2024-11-21 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 02:18:46PM +0800, keith zhao wrote: > This commit introduces plane functions and helper functions > for the VS DRM subsystem, enhancing support for managing > display planes and their configurations. > > Signed-off-by: keith zhao > --- > drivers/gpu/drm/verisilicon/Makefi

Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

2024-11-21 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 02:18:42PM +0800, keith zhao wrote: > move rochchip inno hdmi connector to a newly created directory named > inno-hdmi.c, and rename rockchip/inno_hdmi.c to > rockchip/inno_hdmi-rockchip.c > > This patch refines the Innosilicon HDMI architecture by abstracting > the existin

Re: [PATCH v5 6/9] drm/vs: Add CRTC Functions

2024-11-21 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 02:18:45PM +0800, keith zhao wrote: > This commit adds CRTC functions and helper functions > to the VS DRM subsystem, > enhancing support for display management and configurations. > > Signed-off-by: keith zhao > --- > drivers/gpu/drm/verisilicon/Makefile | 3 +- > dri

Re: [PATCH v5 8/9] drm/vs: Add Innosilicon HDMI Support

2024-11-21 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 02:18:47PM +0800, keith zhao wrote: > This commit adds the Innosilicon HDMI driver, Documentation/process/submitting-patches.rst, look for "This patch..." > designed to interface with the VS display controller. > > The driver leverages the APIs provided by the Innosilicon

Re: [PATCH v5 5/9] drm/vs: Add Base API for VS Mode Configuration

2024-11-21 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 02:18:44PM +0800, keith zhao wrote: > This commit adds a base API for configuring VS modes, > which will streamline the setup and management of display modes > in the VS DRM subsystem. > > In this implementation, we are using drm_atomic_helper_commit_tail_rpm() > instead of

Re: [PATCH v5 4/9] drm/vs: Add Hardware Functions for VS DC8200

2024-11-21 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 02:18:43PM +0800, keith zhao wrote: > This commit introduces hardware-based APIs for > the VS DRM related to the DC8200 This doesn't describe anything. I've asked to describe the hardware. Also please don't use phrases as "This commit does this and this". See Documentation/

Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

2024-11-21 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 02:18:42PM +0800, keith zhao wrote: > move rochchip inno hdmi connector to a newly created directory named > inno-hdmi.c, and rename rockchip/inno_hdmi.c to > rockchip/inno_hdmi-rockchip.c > > This patch refines the Innosilicon HDMI architecture by abstracting > the existin

Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

2024-11-21 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 02:18:42PM +0800, keith zhao wrote: > move rochchip inno hdmi connector to a newly created directory named > inno-hdmi.c, and rename rockchip/inno_hdmi.c to > rockchip/inno_hdmi-rockchip.c > > This patch refines the Innosilicon HDMI architecture by abstracting > the existin

Re: [PATCH 2/2] drm/sched: Fix docu of drm_sched_entity_flush()

2024-11-21 Thread kernel test robot
Hi Philipp, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on v6.12 next-20241121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

Re: [git pull] drm for 6.13-rc1

2024-11-21 Thread pr-tracker-bot
The pull request you sent on Thu, 21 Nov 2024 10:25:45 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-next-2024-11-21 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/28eb75e178d389d325f1666e422bc139804c Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCHv6 5/8] drm/i915/histogram: Add crtc properties for global histogram

2024-11-21 Thread Dmitry Baryshkov
On Thu, Nov 21, 2024 at 05:56:00PM +0530, Arun R Murthy wrote: > CRTC properties have been added for enable/disable histogram, reading > the histogram data and writing the IET data. > "HISTOGRAM_EN" is the crtc property to enable/disable the global > histogram and takes a value 0/1 accordingly. > "

RE: [PATCH v4 0/2] Refactor MST DSC Determination Policy

2024-11-21 Thread Zuo, Jerry
[AMD Official Use Only - AMD Internal Distribution Only] Hi Lyude, Jani, Imre, Simona: Please kindly review the patch series at your convenient time. Thanks. Regards, Jerry > -Original Message- > From: Fangzhi Zuo > Sent: Friday, November 8, 2024 12:42 PM > To: dri-devel@lists.fre

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-11-21 Thread Dmitry Baryshkov
On Tue, Nov 19, 2024 at 08:09:31PM -0500, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2024-11-15 09:17:15) > > On Mon, Nov 11, 2024 at 06:16:27PM -0800, Stephen Boyd wrote: > > > Quoting Dmitry Baryshkov (2024-11-08 23:05:18) > > > > On Thu, Nov 07, 2024 at 04:28:24PM -0800, Stephen Boyd wrote:

Re: [PATCH v2 6/9] drm/msm/dsi: Add support for QCS615

2024-11-21 Thread fange zhang
On 2024/11/14 21:32, Konrad Dybcio wrote: On 13.11.2024 12:51 PM, Fange Zhang wrote: From: Li Liu Add support for DSI 2.3.1 (block used on QCS615). Add phy configuration for QCS615 Signed-off-by: Li Liu Signed-off-by: Fange Zhang --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 17

[RFC 05/13] acpi/x86: s2idle: add modern standby transition function

2024-11-21 Thread Antheas Kapenekakis
Add a new function to transition modern standby states and call it as part of the suspend sequence to make sure it begins under the Modern Standby "Sleep" state. Signed-off-by: Antheas Kapenekakis --- include/linux/suspend.h | 11 kernel/power/power.h| 1 + kernel/power/suspend.c |

[RFC 01/13] Documentation: PM: Add documentation for S0ix Standby States

2024-11-21 Thread Antheas Kapenekakis
Add documentation about the S0ix Standby States that will be exposed to userspace as part of this series. Signed-off-by: Antheas Kapenekakis --- .../admin-guide/pm/standby-states.rst | 133 ++ Documentation/admin-guide/pm/system-wide.rst | 1 + 2 files changed, 134 ins

Re: [PATCH 30/37] clk: bcm: rpi: Add ISP to exported clocks

2024-11-21 Thread Stephen Boyd
Quoting Dave Stevenson (2024-10-23 09:50:27) > From: Dom Cobley > > The ISP clock can be controlled by the driver, so register it > with the clock subsystem. > > Signed-off-by: Dom Cobley > Signed-off-by: Dave Stevenson > --- Acked-by: Stephen Boyd

[RFC 13/13] PM: standby: Add sysfs attribute for modern standby transitions

2024-11-21 Thread Antheas Kapenekakis
Add a sysfs attribute to allow informing the kernel about the current standby state, those being: "active", "screen_off", "sleep", and "resume" (to prepare turning the display on). The final modern standby state DRIPS is omitted, as that is entered during the kernel suspend process and userspace wi

Re: [PATCH 31/37] clk: bcm: rpi: Allow cpufreq driver to also adjust gpu clocks

2024-11-21 Thread Stephen Boyd
Quoting Dave Stevenson (2024-10-23 09:50:28) > From: Dom Cobley > > For performance/power it is beneficial to adjust gpu clocks with arm clock. > This is how the downstream cpufreq driver works > > Signed-off-by: Dom Cobley > Signed-off-by: Dave Stevenson > --- With Maxime's suggestion: Acke

[RFC 09/13] acpi/x86: s2idle: call Sleep Entry/Exit as part of callbacks

2024-11-21 Thread Antheas Kapenekakis
Move the Sleep Entry/Exit notifications outside the suspend sequence, with their own ACPI lock, as was done for Display On/Off. Suggested-by: Mario Limonciello Signed-off-by: Antheas Kapenekakis --- drivers/acpi/x86/s2idle.c | 57 --- 1 file changed, 47 inser

Re: [PATCH 34/37] clk: bcm: rpi: Add disp clock

2024-11-21 Thread Stephen Boyd
Quoting Dave Stevenson (2024-10-23 09:50:31) > From: Maxime Ripard > > BCM2712 has an extra clock exposed by the firmware called DISP, and used > by (at least) the HVS. Let's add it to the list of clocks to register in > Linux. > > Signed-off-by: Maxime Ripard > Signed-off-by: Dave Stevenson >

Re: [PATCH 33/37] clk: bcm: rpi: Create helper to retrieve private data

2024-11-21 Thread Stephen Boyd
Quoting Dave Stevenson (2024-10-23 09:50:30) > From: Maxime Ripard > > The RaspberryPi firmware clocks driver uses in several instances a > container_of to retrieve the struct raspberrypi_clk_data from a pointer > to struct clk_hw. Let's create a small function to avoid duplicating it > all over

Re: [PATCH 32/37] clk: bcm: rpi: Enable minimize for all firmware clocks

2024-11-21 Thread Stephen Boyd
Quoting Dave Stevenson (2024-10-23 09:50:29) > From: Dom Cobley > > There isn't a reason not to minimise the clocks, and it saves > some power. > > Signed-off-by: Dom Cobley > Signed-off-by: Dave Stevenson > --- Acked-by: Stephen Boyd

[RFC 11/13] acpi/x86: s2idle: add quirk table for modern standby delays

2024-11-21 Thread Antheas Kapenekakis
Unfortunately, some modern standby systems, including the ROG Ally, rely on a delay between modern standby transitions. Add a quirk table for introducing delays between modern standby transitions, and quirk the ROG Ally on "Display Off", which needs a bit of time to turn off its controllers prior t

Re: [RFC 11/13] acpi/x86: s2idle: add quirk table for modern standby delays

2024-11-21 Thread Antheas Kapenekakis
On Thu, 21 Nov 2024 at 19:04, Mario Limonciello wrote: > > On 11/21/2024 11:22, Antheas Kapenekakis wrote: > > Unfortunately, some modern standby systems, including the ROG Ally, rely > > on a delay between modern standby transitions. Add a quirk table for > > introducing delays between modern sta

Re: [RFC 05/13] acpi/x86: s2idle: add modern standby transition function

2024-11-21 Thread Antheas Kapenekakis
On Thu, 21 Nov 2024 at 19:16, Mario Limonciello wrote: > > On 11/21/2024 11:22, Antheas Kapenekakis wrote: > > Add a new function to transition modern standby states and call it > > as part of the suspend sequence to make sure it begins under the > > Modern Standby "Sleep" state. > > > Signed-off

Re: [RFC 01/13] Documentation: PM: Add documentation for S0ix Standby States

2024-11-21 Thread Antheas Kapenekakis
On Thu, 21 Nov 2024 at 22:08, Mario Limonciello wrote: > > On 11/21/2024 14:33, Antheas Kapenekakis wrote: > > On Thu, 21 Nov 2024 at 20:40, Mario Limonciello > > wrote: > >> > >> On 11/21/2024 13:11, Antheas Kapenekakis wrote: > >>> On Thu, 21 Nov 2024 at 19:58, Mario Limonciello > >>> wrote: >

[RFC 02/13] acpi/x86: s2idle: add support for Display Off and Display On callbacks

2024-11-21 Thread Antheas Kapenekakis
The Display Off and Display On firmware notifications are meant to signify the system entering a state where the user is not actively interacting with it (i.e., in Windows this state is called "Screen Off" and the system enters it once it turns the screen off e.g., due to inactivity). Currently, t

[RFC 04/13] acpi/x86: s2idle: add support for Turn On Display callback

2024-11-21 Thread Antheas Kapenekakis
The Turn On Display callback was introduced in Windows 22H2, to allow devices to resume faster from sleep. Essentially, if the device lowers its power limit (PLx) while it is in the Sleep state, this might lengthen the suspend sequence in an undesirable manner. Therefore, this callback can be used

[RFC 00/13] acpi/x86: s2idle: implement Modern Standby transition states and expose to userspace

2024-11-21 Thread Antheas Kapenekakis
The following series moves the _DSM 3,4,7,8 firmware notifications outside the suspend sequence, and makes them part of a transition function, where the system can transition freely between them when it is not suspended. This transition function is exposed to userspace, which now gains the ability

[RFC 08/13] acpi/x86: s2idle: rename MS Exit/Entry to Sleep Exit/Entry

2024-11-21 Thread Antheas Kapenekakis
Microsoft refers to the _DSMs 7,8 as "Sleep Entry" and "Sleep Exit". Currently, the code uses "MS Entry/Exit" to name the variables, which is confusing as it could either mean "Modern Standby" or "Microsoft" and is not representative of the state. Rename as part of converting it into a transition.

[RFC 12/13] platform/x86: asus-wmi: remove Ally (1st gen) and Ally X suspend quirk

2024-11-21 Thread Antheas Kapenekakis
By moving the Display On/Off calls outside of the suspend sequence and introducing a slight delay after Display Off, the ROG Ally controller functions exactly as it does in Windows. Therefore, remove the quirk that fixed the controller only when the mcu_powersave attribute was disabled, while addi

[RFC 06/13] acpi/x86: s2idle: rename Screen On/Off to Display On/Off

2024-11-21 Thread Antheas Kapenekakis
Microsoft and Intel use the term "Display" to refer to the _DSM 3,4 calls and the term "Screen" for the state ("Screen Off"). Currently, the code uses "Screen On/Off" to name the variables, which is about to become confusing as they become callbacks. To prepare for that, rename the variables to "Di

[RFC 07/13] acpi/x86: s2idle: call Display On/Off as part of callbacks

2024-11-21 Thread Antheas Kapenekakis
Move the Display On/Off notifications into dedicated callbacks that gate the ACPI mutex, so they can be called outside of the suspend path. Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello Signed-off-by: Antheas Kapenekakis --- drivers/acpi/x86/s2idle.c | 67

Re: [PATCH v2 8/9] arm64: dts: qcom: Add display support for QCS615 RIDE board

2024-11-21 Thread fange zhang
On 2024/11/13 20:27, Dmitry Baryshkov wrote: On Wed, 13 Nov 2024 at 13:53, Fange Zhang wrote: From: Li Liu Add display MDSS and DSI configuration for QCS615. QCS615 has a DP port, and DP support will be added in a later patch. Signed-off-by: Li Liu Signed-off-by: Fange Zhang --- arch

Re: [RFC 01/13] Documentation: PM: Add documentation for S0ix Standby States

2024-11-21 Thread Antheas Kapenekakis
On Thu, 21 Nov 2024 at 19:58, Mario Limonciello wrote: > > On 11/21/2024 11:22, Antheas Kapenekakis wrote: > > Add documentation about the S0ix Standby States that will be exposed > > to userspace as part of this series. > > > > Signed-off-by: Antheas Kapenekakis > > --- > > .../admin-guide/pm/

[RFC 10/13] acpi/x86: s2idle: add Turn On Display and call as part of callback

2024-11-21 Thread Antheas Kapenekakis
The Turn On Display callback was introduced in Windows 22H2, to allow devices to resume faster from sleep. Essentially, if the device lowers its power limit (PLx) while it is in the Sleep state, this might lengthen the suspend sequence in an undesirable manner. Implement this callback, which corres

Re: [PATCH v2 6/9] drm/msm/dsi: Add support for QCS615

2024-11-21 Thread fange zhang
On 2024/11/14 21:41, Dmitry Baryshkov wrote: On Thu, 14 Nov 2024 at 15:32, Konrad Dybcio wrote: On 13.11.2024 12:51 PM, Fange Zhang wrote: From: Li Liu Add support for DSI 2.3.1 (block used on QCS615). Add phy configuration for QCS615 Signed-off-by: Li Liu Signed-off-by: Fange Zhang -

[RFC 03/13] acpi/x86: s2idle: add support for Sleep Entry and Sleep Exit callbacks

2024-11-21 Thread Antheas Kapenekakis
The Sleep Entry and Sleep Exit firmware notifications allow the platform to enter Modern Standby. In this state, if supported, the platform turns off auxiliary USB devices (e.g., the controllers of the Legion Go), makes the power light of the device flash, and lowers the power envelope to a minimum

Re: [RFC 01/13] Documentation: PM: Add documentation for S0ix Standby States

2024-11-21 Thread Antheas Kapenekakis
On Thu, 21 Nov 2024 at 20:40, Mario Limonciello wrote: > > On 11/21/2024 13:11, Antheas Kapenekakis wrote: > > On Thu, 21 Nov 2024 at 19:58, Mario Limonciello > > wrote: > >> > >> On 11/21/2024 11:22, Antheas Kapenekakis wrote: > >>> Add documentation about the S0ix Standby States that will be ex

Re: [PATCH v4 1/2] init/Kconfig: add python3 availability config

2024-11-21 Thread Masahiro Yamada
On Thu, Nov 21, 2024 at 10:49 AM Rob Clark wrote: > > On Wed, Nov 20, 2024 at 5:17 PM Petr Vorel wrote: > > > > > On Thu, Nov 21, 2024 at 5:41 AM Petr Vorel wrote: > > > > > > It will be used in the next commit for DRM_MSM. > > > > > > Suggested-by: Rob Clark > > > > Signed-off-by: Petr Vorel

Re: [PATCH v2 03/11] drm/msm: adreno: move features bits in a separate variable

2024-11-21 Thread Dmitry Baryshkov
On Thu, Nov 21, 2024 at 11:48:28AM -0800, Rob Clark wrote: > On Thu, Nov 21, 2024 at 10:44 AM Dmitry Baryshkov > wrote: > > > > On Wed, Nov 20, 2024 at 10:54:24AM -0800, Rob Clark wrote: > > > On Wed, Nov 20, 2024 at 3:18 AM Dmitry Baryshkov > > > wrote: > > > > > > > > On Tue, Nov 19, 2024 at 06

Re: [PATCH v4 2/2] misc: fastrpc: Rename tgid and pid to client_id

2024-11-21 Thread Dmitry Baryshkov
On Thu, Nov 21, 2024 at 02:17:13PM +0530, Ekansh Gupta wrote: > The information passed as request tgid and pid is actually the > client id of the process. This client id is used as an > identifier by DSP to identify the DSP PD corresponding to the > process. Currently process tgid is getting passed

Re: [PATCH v4 1/2] misc: fastrpc: Add support for multiple PD from one process

2024-11-21 Thread Dmitry Baryshkov
On Thu, Nov 21, 2024 at 02:17:12PM +0530, Ekansh Gupta wrote: > Memory intensive applications(which requires more tha 4GB) that wants > to offload tasks to DSP might have to split the tasks to multiple > user PD to make the resources available. > > For every call to DSP, fastrpc driver passes the

Re: [PATCH v3 3/3] i2c: i2c-qcom-geni: Update compile dependenices for I2C GENI driver

2024-11-21 Thread Dmitry Baryshkov
On Thu, Nov 21, 2024 at 06:31:34PM +0530, Jyothi Kumar Seerapu wrote: > I2C functionality has dependencies on the GPI driver. > Ensure that the GPI driver is enabled when using the I2C > driver functionality. > Therefore, update the I2C GENI driver to depend on the GPI driver. > > Signed-off-by: J

Re: [PATCH v4 1/2] init/Kconfig: add python3 availability config

2024-11-21 Thread Masahiro Yamada
On Thu, Nov 21, 2024 at 10:17 AM Petr Vorel wrote: > > > On Thu, Nov 21, 2024 at 5:41 AM Petr Vorel wrote: > > > > It will be used in the next commit for DRM_MSM. > > > > Suggested-by: Rob Clark > > > Signed-off-by: Petr Vorel > > > --- > > > Changes v3->v4: > > > * Move definition to the end o

[PATCH v1 1/1] drm/xe: fix the ERR_PTR() returned on failure to allocate tiny pt

2024-11-21 Thread Mirsad Todorovac
Running coccinelle spatch gave the following warning: ./drivers/gpu/drm/xe/tests/xe_migrate.c:226:5-11: inconsistent IS_ERR and PTR_ERR on line 228. The code reports PTR_ERR(pt) when IS_ERR(tiny) is checked: → 211 pt = xe_bo_create_pin_map(xe, tile, m->q->vm, XE_PAGE_SIZE, 212

Re: [RFC 01/13] Documentation: PM: Add documentation for S0ix Standby States

2024-11-21 Thread Mario Limonciello
On 11/21/2024 14:33, Antheas Kapenekakis wrote: On Thu, 21 Nov 2024 at 20:40, Mario Limonciello wrote: On 11/21/2024 13:11, Antheas Kapenekakis wrote: On Thu, 21 Nov 2024 at 19:58, Mario Limonciello wrote: On 11/21/2024 11:22, Antheas Kapenekakis wrote: Add documentation about the S0ix St

Re: [PATCH v1 1/7] dt-bindings: display: mediatek: Add binding for HDMIv2 DDC

2024-11-21 Thread Rob Herring
On Wed, Nov 20, 2024 at 01:45:06PM +0100, AngeloGioacchino Del Regno wrote: > Add a binding for the Display Data Channel (DDC) IP in MediaTek > SoCs with version 2 HDMI TX IP. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > .../mediatek/mediatek,mt8195-hdmi-ddc.yaml| 41

Re: [PATCH 1/2 v2] bcachefs: do not use PF_MEMALLOC_NORECLAIM

2024-11-21 Thread Simona Vetter
On Wed, Nov 20, 2024 at 05:39:09PM -0500, Kent Overstreet wrote: > There were concerns raised in the recent CoC enforcement thread, by > someone with experience in such matters, that your aproach seemed > extremeely heavy handed and I find myself in 100% agreement. Ehrm ... Yes, I did quite stron

Re: [RFC 01/13] Documentation: PM: Add documentation for S0ix Standby States

2024-11-21 Thread Mario Limonciello
On 11/21/2024 13:11, Antheas Kapenekakis wrote: On Thu, 21 Nov 2024 at 19:58, Mario Limonciello wrote: On 11/21/2024 11:22, Antheas Kapenekakis wrote: Add documentation about the S0ix Standby States that will be exposed to userspace as part of this series. Signed-off-by: Antheas Kapenekakis

Re: [PATCH v2 04/11] drm/msm: adreno: add GMU_BW_VOTE feature flag

2024-11-21 Thread Rob Clark
On Thu, Nov 21, 2024 at 11:50 AM Rob Clark wrote: > > On Tue, Nov 19, 2024 at 9:56 AM Neil Armstrong > wrote: > > > > The Adreno GMU Management Unit (GNU) can also scale the DDR Bandwidth > > nit, s/GNU/GMU/ And I guess you meant "GPU Management Unit" (presumably this isn't yet another recursive

Re: [PATCH v2 04/11] drm/msm: adreno: add GMU_BW_VOTE feature flag

2024-11-21 Thread Rob Clark
On Tue, Nov 19, 2024 at 9:56 AM Neil Armstrong wrote: > > The Adreno GMU Management Unit (GNU) can also scale the DDR Bandwidth nit, s/GNU/GMU/ > along the Frequency and Power Domain level, but by default we leave the > OPP core vote for the interconnect ddr path. > > While scaling via the inter

[PATCH] ammdgpu fix for gfx1103 queue evict/restore crash

2024-11-21 Thread Mika Laitio
AMD gfx1103/M780 iGPU will crash eventually while performing pytorch ML/AI operations on rocm sdk stack. Crash causes linux desktop randomly either to recover after killing the app, freeze the desktop or reset back to login screen. Easy way to trigger the problem is to build the the ML/AI support

Re: [PATCH v2 03/11] drm/msm: adreno: move features bits in a separate variable

2024-11-21 Thread Rob Clark
On Thu, Nov 21, 2024 at 10:44 AM Dmitry Baryshkov wrote: > > On Wed, Nov 20, 2024 at 10:54:24AM -0800, Rob Clark wrote: > > On Wed, Nov 20, 2024 at 3:18 AM Dmitry Baryshkov > > wrote: > > > > > > On Tue, Nov 19, 2024 at 06:56:38PM +0100, Neil Armstrong wrote: > > > > Now the features defines have

[PULL] drm-xe-next-fixes

2024-11-21 Thread Thomas Hellstrom
Hi Dave, Simona A couple of fixes to drm-xe-next. I'm currently looking into as to why they are not CC'd stable and will ensure they get backported if needed. Thanks, Thomas drm-xe-next-fixes-2024-11-21: Driver Changes: - Wake up waiters after wait condition set to true (Nirmoy Das) - Mark the p

Re: [PATCH v2 04/11] drm/msm: adreno: add GMU_BW_VOTE feature flag

2024-11-21 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 01:37:48PM +0100, Neil Armstrong wrote: > On 20/11/2024 12:19, Dmitry Baryshkov wrote: > > On Tue, Nov 19, 2024 at 06:56:39PM +0100, Neil Armstrong wrote: > > > The Adreno GMU Management Unit (GNU) can also scale the DDR Bandwidth > > > along the Frequency and Power Domain l

[PATCH 3/5] clk: Split clk_calc_subtree()

2024-11-21 Thread Miquel Raynal
This helper does two different things: - it calculates the new clock frequency - as part of this task, it also handles a possible parent change - it walks the clock subtree to further update frequencies as well (but the parent changes are no longer relevant there). In order to ease the under

Re: [RFC 01/13] Documentation: PM: Add documentation for S0ix Standby States

2024-11-21 Thread Mario Limonciello
On 11/21/2024 11:22, Antheas Kapenekakis wrote: Add documentation about the S0ix Standby States that will be exposed to userspace as part of this series. Signed-off-by: Antheas Kapenekakis --- .../admin-guide/pm/standby-states.rst | 133 ++ Documentation/admin-guide/p

Re: [PATCH v2 05/11] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

2024-11-21 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 01:37:16PM +0100, Neil Armstrong wrote: > On 20/11/2024 12:42, Dmitry Baryshkov wrote: > > On Tue, Nov 19, 2024 at 06:56:40PM +0100, Neil Armstrong wrote: > > > The Adreno GMU Management Unit (GMU) can also scale DDR Bandwidth along > > > the Frequency and Power Domain level

Re: [PATCH v1 4/4] misc: fastrpc: Add debugfs support for fastrpc

2024-11-21 Thread Dmitry Baryshkov
On Thu, Nov 21, 2024 at 12:12:17PM +0530, Ekansh Gupta wrote: > > > On 11/18/2024 7:32 PM, Greg KH wrote: > > On Mon, Nov 18, 2024 at 02:10:46PM +0530, Ekansh Gupta wrote: > >> Add changes to support debugfs. The fastrpc directory will be > >> created which will carry debugfs files for all fastrp

Re: [PATCH v2 03/11] drm/msm: adreno: move features bits in a separate variable

2024-11-21 Thread Dmitry Baryshkov
On Wed, Nov 20, 2024 at 10:54:24AM -0800, Rob Clark wrote: > On Wed, Nov 20, 2024 at 3:18 AM Dmitry Baryshkov > wrote: > > > > On Tue, Nov 19, 2024 at 06:56:38PM +0100, Neil Armstrong wrote: > > > Now the features defines have the right name, introduce a features > > > bitfield and move the featur

Re: [RFC PATCH 01/29] dma-fence: Add dma_fence_preempt base class

2024-11-21 Thread Matthew Brost
On Thu, Nov 21, 2024 at 11:04:47AM +0100, Christian König wrote: > Am 20.11.24 um 18:36 schrieb Matthew Brost: > > On Wed, Nov 20, 2024 at 02:31:50PM +0100, Christian König wrote: > > > Am 19.11.24 um 00:37 schrieb Matthew Brost: > > > > Add a dma_fence_preempt base class with driver ops to impleme

Re: [RFC 05/13] acpi/x86: s2idle: add modern standby transition function

2024-11-21 Thread Mario Limonciello
On 11/21/2024 11:22, Antheas Kapenekakis wrote: Add a new function to transition modern standby states and call it as part of the suspend sequence to make sure it begins under the Modern Standby "Sleep" state. > > Signed-off-by: Antheas Kapenekakis --- include/linux/suspend.h | 11 ke

Re: [PATCH 1/2] drm/sched: add WARN_ON and BUG_ON to drm_sched_fini

2024-11-21 Thread Matthew Brost
On Thu, Nov 21, 2024 at 10:06:54AM +0100, Philipp Stanner wrote: > +CC Thomas Hellström > > > On Mon, 2024-11-18 at 12:48 +0100, Christian König wrote: > >  Am 15.11.24 um 17:07 schrieb Philipp Stanner: > >   > > >   > > > On Fri, 2024-11-15 at 15:39 +0100, Christian König wrote: > > >   > > > >

Re: [PATCH 1/2] drm/sched: add WARN_ON and BUG_ON to drm_sched_fini

2024-11-21 Thread Matthew Brost
On Tue, Oct 29, 2024 at 08:22:22AM +0100, Philipp Stanner wrote: > Christian, Sima? > > Matthew? (+CC) > Sorry catching up here. Internally in Xe we ref count the scheduler as the scheduler is embedded into our user queue structure (xe_exec_queue). Jobs ref the queue once they are armed. Upon qu

Re: [RFC 11/13] acpi/x86: s2idle: add quirk table for modern standby delays

2024-11-21 Thread Mario Limonciello
On 11/21/2024 11:22, Antheas Kapenekakis wrote: Unfortunately, some modern standby systems, including the ROG Ally, rely on a delay between modern standby transitions. Add a quirk table for introducing delays between modern standby transitions, and quirk the ROG Ally on "Display Off", which needs

[PATCH 2/5] clk: Add a helper to determine a clock rate

2024-11-21 Thread Miquel Raynal
In the context of the clock core, "determine" means we calculate a possible clock rate based on its hardware capabilities and its current upstream parent frequency. This is opposed to "round" which tries to find the best parent and best rate and "recalc" which is about finding the next output clock

[PATCH 1/5] clk: imx: clk-imx8mp: Allow LDB serializer clock reconfigure parent rate

2024-11-21 Thread Miquel Raynal
From: Marek Vasut The media_ldb_root_clk supply LDB serializer. These clock are usually shared with the LCDIFv3 pixel clock and supplied by the Video PLL on i.MX8MP, but the LDB clock run at either x7 or x14 rate of the LCDIFv3 pixel clock. Allow the LDB to reconfigure Video PLL as needed, as tha

[PATCH 0/5] clk: Fix simple video pipelines on i.MX8

2024-11-21 Thread Miquel Raynal
+++--- drivers/clk/imx/clk-imx8mp.c | 6 +++--- include/linux/clk-provider.h | 2 ++ 3 files changed, 37 insertions(+), 10 deletions(-) --- base-commit: 62facaf164585923d081eedcb6871f4ff3c2e953 change-id: 20241121-ge-ian-debug-imx8-clk-tree-bd325aa866f1 Best regards, -- Miquel Raynal

[PATCH 5/5] clk: imx: imx8mp: Prevent media clocks to be incompatibly changed

2024-11-21 Thread Miquel Raynal
Having set the CLK_SET_RATE_PARENT flag to gain accuracy to the i.MX8 media related clocks (media_ldb, media_disp1_pix, media_disp2_pix) broke most simple setups using the LDB and one LCDIF. Indeed, pixel frequencies being set first, the top level PLL (video_pll1) was tuned to achieve the perfect f

Re: [RFC 00/13] acpi/x86: s2idle: implement Modern Standby transition states and expose to userspace

2024-11-21 Thread Rafael J. Wysocki
On Thu, Nov 21, 2024 at 6:28 PM Antheas Kapenekakis wrote: > > The following series moves the _DSM 3,4,7,8 firmware notifications outside > the suspend sequence, and makes them part of a transition function, where > the system can transition freely between them when it is not suspended. > This tra

  1   2   >