Re: [PATCH -next] drm/amd/display: use swap() in sort()

2024-07-24 Thread Christian König
Am 24.07.24 um 09:37 schrieb Jiapeng Chong: Use existing swap() function rather than duplicating its implementation. ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn3.c:17:29-30: WARNING opportunity for swap(). Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.

Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-24 Thread Krzysztof Kozlowski
On 25/07/2024 02:47, Alex Lanzano wrote: > Add device tree bindings for the monochrome Sharp Memory LCD > > Signed-off-by: Alex Lanzano > --- > .../bindings/display/sharp,sharp-memory.yaml | 97 +++ > include/dt-bindings/display/sharp-memory.h| 9 ++ > 2 files changed, 106

Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-24 Thread Krzysztof Kozlowski
On 25/07/2024 02:47, Alex Lanzano wrote: > Add device tree bindings for the monochrome Sharp Memory LCD > > Signed-off-by: Alex Lanzano > --- > .../bindings/display/sharp,sharp-memory.yaml | 97 +++ > include/dt-bindings/display/sharp-memory.h| 9 ++ > 2 files changed, 106

Re: [PATCH 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-07-24 Thread Krzysztof Kozlowski
On 25/07/2024 02:47, Alex Lanzano wrote: > Add support for the monochrome Sharp Memory LCDs. > > Signed-off-by: Alex Lanzano > --- > MAINTAINERS | 8 + > drivers/gpu/drm/tiny/Kconfig| 20 + > drivers/gpu/drm/tiny/Makefile | 1 + > drivers/gpu/drm/tiny/s

Re: [PATCH 0/2] Add driver for Sharp Memory LCD

2024-07-24 Thread Thomas Petazzoni
Hello Alex, On Wed, 24 Jul 2024 20:47:01 -0400 Alex Lanzano wrote: > This patch series add support for the monochrome Sharp Memory LCD > panels. This series is based off of the work done by Mehdi Djait. Thanks for resuming the effort on this patch series! Since this patch series is clearly heav

Re: [PATCH 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-07-24 Thread Christophe JAILLET
Le 25/07/2024 à 02:47, Alex Lanzano a écrit : Add support for the monochrome Sharp Memory LCDs. Signed-off-by: Alex Lanzano --- MAINTAINERS | 8 + drivers/gpu/drm/tiny/Kconfig| 20 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/sharp

Re: [PATCH RFC 1/3] firmware: qcom: implement object invoke support

2024-07-24 Thread Dmitry Baryshkov
On Thu, 25 Jul 2024 at 07:15, Amirreza Zarrabi wrote: > > > > On 7/25/2024 2:09 PM, Dmitry Baryshkov wrote: > > On Thu, Jul 25, 2024 at 01:19:07PM GMT, Amirreza Zarrabi wrote: > >> > >> > >> On 7/4/2024 5:34 PM, Dmitry Baryshkov wrote: > >>> On Thu, 4 Jul 2024 at 00:40, Amirreza Zarrabi > >>> wr

Re: [PATCH RFC 1/3] firmware: qcom: implement object invoke support

2024-07-24 Thread Amirreza Zarrabi
On 7/25/2024 2:09 PM, Dmitry Baryshkov wrote: > On Thu, Jul 25, 2024 at 01:19:07PM GMT, Amirreza Zarrabi wrote: >> >> >> On 7/4/2024 5:34 PM, Dmitry Baryshkov wrote: >>> On Thu, 4 Jul 2024 at 00:40, Amirreza Zarrabi >>> wrote: On 7/3/2024 10:13 PM, Dmitry Baryshkov wrote: >

Re: [PATCH RFC 1/3] firmware: qcom: implement object invoke support

2024-07-24 Thread Dmitry Baryshkov
On Thu, Jul 25, 2024 at 01:19:07PM GMT, Amirreza Zarrabi wrote: > > > On 7/4/2024 5:34 PM, Dmitry Baryshkov wrote: > > On Thu, 4 Jul 2024 at 00:40, Amirreza Zarrabi > > wrote: > >> > >> > >> > >> On 7/3/2024 10:13 PM, Dmitry Baryshkov wrote: > >>> On Tue, Jul 02, 2024 at 10:57:36PM GMT, Amirrez

[PATCH 1/2] drm/sched: Add error code parameter to drm_sched_start

2024-07-24 Thread vitaly.prosyak
From: Vitaly Prosyak The current implementation of drm_sched_start uses a hardcoded -ECANCELED to dispose of a job when the parent/hw fence is NULL. This results in drm_sched_job_done being called with -ECANCELED for each job with a NULL parent in the pending list, making it difficult to disti

Re: [PATCH RFC 1/3] firmware: qcom: implement object invoke support

2024-07-24 Thread Amirreza Zarrabi
On 7/4/2024 5:34 PM, Dmitry Baryshkov wrote: > On Thu, 4 Jul 2024 at 00:40, Amirreza Zarrabi > wrote: >> >> >> >> On 7/3/2024 10:13 PM, Dmitry Baryshkov wrote: >>> On Tue, Jul 02, 2024 at 10:57:36PM GMT, Amirreza Zarrabi wrote: Qualcomm TEE hosts Trusted Applications and Services that run

Re: [PATCH] drm/vmwgfx: Fix overlay when using Screen Targets

2024-07-24 Thread Zack Rusin
On Fri, Jul 19, 2024 at 12:37 PM Ian Forbes wrote: > > This code was never updated to support Screen Targets. > Fixes a bug where Xv playback displays a green screen instead of actual > video contents when 3D acceleration is disabled in the guest. > > Fixes: c8261a961ece ("vmwgfx: Major KMS refact

Re: [PATCH RFC 0/3] Implement Qualcomm TEE IPC and ioctl calls

2024-07-24 Thread Amirreza Zarrabi
On 7/17/2024 10:31 PM, Dmitry Baryshkov wrote: > Adding TEE mailing list and maintainers to the CC list. > > Amirreza, please include them in future even if you are not going to use > the framework. > Sure, Thanks Dmitry. > > On Wed, Jul 10, 2024 at 09:16:48AM GMT, Amirreza Zarrabi wrote: >

[PATCH v2] udmabuf: array alloc use kvmalloc

2024-07-24 Thread Huan Yang
When PAGE_SIZE 4096, MAX_PAGE_ORDER 10, 64bit machine, page_alloc only support 4MB. If above this, trigger this warn and return NULL. udmabuf can change size limit, if change it to 3072(3GB), and then alloc 3GB udmabuf, will fail create. [ 4080.876581] [ cut here ] [ 4080.

[PATCH v4] drm/client: fix null pointer dereference in drm_client_modeset_probe

2024-07-24 Thread Ma Ke
In drm_client_modeset_probe(), the return value of drm_mode_duplicate() is assigned to modeset->mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Cc: sta...@vger.kernel.org Fixes: cf13909aee05 ("drm/fb-helper: Move out modese

[PATCH -next] drm/amd/display: remove unneeded semicolon

2024-07-24 Thread Jiapeng Chong
No functional modification involved. ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c:481:2-3: Unneeded semicolon. ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c:3783:168-169: Unneeded semicolon. ./drivers/gpu/drm/amd/display/dc/d

Re: [PATCH RFC 0/3] Implement Qualcomm TEE IPC and ioctl calls

2024-07-24 Thread Amirreza Zarrabi
On 7/18/2024 12:52 AM, Jens Wiklander wrote: > Hi, > > On Wed, Jul 10, 2024 at 1:17 AM Amirreza Zarrabi > wrote: >> >> >> >> On 7/3/2024 9:36 PM, Dmitry Baryshkov wrote: >>> On Tue, Jul 02, 2024 at 10:57:35PM GMT, Amirreza Zarrabi wrote: Qualcomm TEE hosts Trusted Applications (TAs) and s

Re: [PATCH v3] drm/client: fix null pointer dereference in drm_client_modeset_probe

2024-07-24 Thread Ma Ke
On Wed, 24 Jul 2024, Jani Nikula wrote: > On Wed, 24 Jul 2024, Ma Ke wrote: > > On Wed, 24 Jul 2024, Jani Nikula wrote: > >> On Wed, 24 Jul 2024, Ma Ke wrote: > >> > In drm_client_modeset_probe(), the return value of drm_mode_duplicate() > >> > is > >> > assigned to modeset->mode, which will l

[PATCH 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-07-24 Thread Alex Lanzano
Add support for the monochrome Sharp Memory LCDs. Signed-off-by: Alex Lanzano --- MAINTAINERS | 8 + drivers/gpu/drm/tiny/Kconfig| 20 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/sharp-memory.c | 742 4 files

[PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-24 Thread Alex Lanzano
Add device tree bindings for the monochrome Sharp Memory LCD Signed-off-by: Alex Lanzano --- .../bindings/display/sharp,sharp-memory.yaml | 97 +++ include/dt-bindings/display/sharp-memory.h| 9 ++ 2 files changed, 106 insertions(+) create mode 100644 Documentation/device

[PATCH 0/2] Add driver for Sharp Memory LCD

2024-07-24 Thread Alex Lanzano
This patch series add support for the monochrome Sharp Memory LCD panels. This series is based off of the work done by Mehdi Djait. References: https://lore.kernel.org/dri-devel/71a9dbf4609dbba46026a31f60261830163a0b99.1701267411.git.mehdi.dj...@bootlin.com/ https://www.sharpsde.com/fileadmin/prod

[PATCH] drm/sched: Only start TDR in drm_sched_job_begin on first job

2024-07-24 Thread Matthew Brost
Only start in drm_sched_job_begin on first job being added to the pending list as if pending list non-empty the TDR has already been started. It is problematic to restart the TDR as it will extend TDR period for an already running job, potentially leading to dma-fence signaling for a very long peri

Re: [PATCH] drm/scheduler: remove full_recover from drm_sched_start

2024-07-24 Thread Matthew Brost
On Mon, Jul 22, 2024 at 10:38:16AM +0200, Christian König wrote: > This was basically just another one of amdgpus hacks. The parameter > allowed to restart the scheduler without turning fence signaling on > again. > > That this is absolutely not a good idea should be obvious by now since > the fen

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-07-24 Thread Werner Sembach
Hi Am 24.07.24 um 19:36 schrieb Pavel Machek: Hi! IMO working with the HID LampArray is the way forward. So I would suggest to convert any non-HID RGB "LED display" that we are talking about as a HID LampArray device through `hid_allocate_device()` in the kernel. Basically what you are suggest

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-07-24 Thread Werner Sembach
Hi Am 24.07.24 um 19:36 schrieb Pavel Machek: Hi! IMO working with the HID LampArray is the way forward. So I would suggest to convert any non-HID RGB "LED display" that we are talking about as a HID LampArray device through `hid_allocate_device()` in the kernel. Basically what you are suggest

[PATCH v2] rockchip/drm: vop2: add support for gamma LUT

2024-07-24 Thread Piotr Zalewski
Add support for gamma LUT in VOP2 driver. The implementation is based on the one found in VOP driver and modified to be compatible with VOP2. Blue and red channels in gamma LUT register write were swapped with respect to how gamma LUT values are written in VOP. Write of the current video port id to

Re: CVE-2024-39471: drm/amdgpu: add error handle to avoid out-of-bounds

2024-07-24 Thread Siddh Raman Pant
(Mail V2: Send to correct mailing list and CCing relevant people.) On Tue, 25 Jun 2024 16:29:04 +0200, Greg Kroah-Hartman wrote: > In the Linux kernel, the following vulnerability has been resolved: > > drm/amdgpu: add error handle to avoid out-of-bounds > > if the sdma_v4_0_irq_id_to_seq return

Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

2024-07-24 Thread Riyan Dhiman
Hi, Thank you for your feedback on my patch submission. I understand that the fix provided by my patch is not needed. As this is my first contribution to the Linux kernel, I am eager to learn and make valuable contributions. To ensure my future submissions are more aligned with the needs, I would

Re: [PATCH v4] drm/loongson: Introduce component framework support

2024-07-24 Thread Sui Jingfeng
Hi, On 7/24/24 15:30, Markus Elfring wrote: In some display subsystems, the functionality of a PCIe device may too might be? … of the dirver is loaded, … driver? … its dependencies ready before it can register

Re: [PATCH] drm/amd/display: Fix documentation warning for mpc.h

2024-07-24 Thread Ricardo B. Marliere
On 24 Jul 24 23:24, Abhishek Tamboli wrote: > Fix documentation compile warning by adding description > for program_3dlut_size function. > > Remove the following warning: > ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:1043: warning: Function > parameter or struct member 'program_3dlut_size' not

Re: [PATCH 0/2] drm/virtio: introduce the HOST_PAGE_SIZE feature

2024-07-24 Thread Dmitry Osipenko
On 7/23/24 14:49, Sergio Lopez wrote: > There's an incresing number of machines supporting multiple page sizes > and on these machines the host and a guest can be running, each one, > with a different page size. > > For what pertains to virtio-gpu, this is not a problem if the page size > of the g

Re: [PATCH] drm/sched: Add error code parameter to drm_sched_start

2024-07-24 Thread Alex Deucher
On Wed, Jul 24, 2024 at 2:43 PM wrote: > > From: Vitaly Prosyak > > The current implementation of drm_sched_start uses a hardcoded -ECANCELED to > dispose of a job when > the parent/hw fence is NULL. This results in drm_sched_job_done being called > with -ECANCELED for > each job with a NULL pa

[PATCH] drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()

2024-07-24 Thread Nikita Zhandarovich
On the off chance that clock value ends up being too high (by means of skl_ddi_calculate_wrpll() having benn called with big enough value of crtc_state->port_clock * 1000), one possible consequence may be that the result will not be able to fit into signed int. Fix this, albeit unlikely, issue by

Re: [PATCH] drm/xe/oa: Use vma_pages() helper function in xe_oa_mmap()

2024-07-24 Thread Dixit, Ashutosh
On Wed, 24 Jul 2024 11:18:27 -0700, Thorsten Blum wrote: > > Use the vma_pages() helper function and remove the following > Coccinelle/coccicheck warning reported by vma_pages.cocci: > > WARNING: Consider using vma_pages helper on vma Reviewed-by: Ashutosh Dixit > > Signed-off-by: Thorsten Blu

[PATCH] drm/sched: Add error code parameter to drm_sched_start

2024-07-24 Thread vitaly.prosyak
From: Vitaly Prosyak The current implementation of drm_sched_start uses a hardcoded -ECANCELED to dispose of a job when the parent/hw fence is NULL. This results in drm_sched_job_done being called with -ECANCELED for each job with a NULL parent in the pending list, making it difficult to disti

[PATCH] drm/xe/oa: Use vma_pages() helper function in xe_oa_mmap()

2024-07-24 Thread Thorsten Blum
Use the vma_pages() helper function and remove the following Coccinelle/coccicheck warning reported by vma_pages.cocci: WARNING: Consider using vma_pages helper on vma Signed-off-by: Thorsten Blum --- drivers/gpu/drm/xe/xe_oa.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --g

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-24 Thread Marc Gonzalez
On 15/07/2024 16:40, Maxime Ripard wrote: > On Thu, Jul 04, 2024 at 07:04:41PM GMT, Marc Gonzalez wrote: >> On 01/07/2024 15:50, Maxime Ripard wrote: >> >>> The i2c register access (and the whole behaviour of the device) is >>> constrained on the I2C_EN pin status, and you can't read it from the >>

Re: [PATCH v1] drm/virtio: Add DRM capset definition

2024-07-24 Thread Dmitry Osipenko
On 7/14/24 23:55, Dmitry Osipenko wrote: > Define DRM native context capset in the VirtIO-GPU protocol header. > > Signed-off-by: Dmitry Osipenko > --- > include/uapi/linux/virtio_gpu.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux

[PATCH] drm/amd/display: Fix documentation warning for mpc.h

2024-07-24 Thread Abhishek Tamboli
Fix documentation compile warning by adding description for program_3dlut_size function. Remove the following warning: ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:1043: warning: Function parameter or struct member 'program_3dlut_size' not described in 'mpc_funcs' Signed-off-by: Abhishek Tambol

Re: [PATCH v1] drm/virtio: Fix type of dma-fence context variable

2024-07-24 Thread Dmitry Osipenko
On 7/14/24 23:50, Dmitry Osipenko wrote: > Type of DMA fence context is u64. Fence-waiting code uses u32 for the > context variable, fix it. > > Fixes: e4812ab8e6b1 ("drm/virtio: Refactor and optimize job submission code > path") > Cc: # v6.4+ > Signed-off-by: Dmitry Osipenko > --- > drivers/g

Re: In kernel virtual HID devices (was Future handling of complex RGB devices on Linux v3)

2024-07-24 Thread Pavel Machek
Hi! > > IMO working with the HID LampArray is the way forward. So I would > > suggest to convert any non-HID RGB "LED display" that we are talking > > about as a HID LampArray device through `hid_allocate_device()` in the > > kernel. Basically what you are suggesting Hans. It's just that you don't

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-24 Thread Marc Gonzalez
On 15/07/2024 18:38, Dmitry Baryshkov wrote: > Please correct me if I'm wrong. We have following usecases. > > 1. I2C_EN pulled low. TI158 is in the pin strap mode, it is not > connected to the I2C bus. A0, A1, SDA and SCL pins are used for > strapping the settings. > board DT file should des

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-24 Thread Marc Gonzalez
On 24/07/2024 19:25, Dmitry Baryshkov wrote: > On Wed, Jul 24, 2024 at 07:18:39PM GMT, Marc Gonzalez wrote: >> On 15/07/2024 16:42, Maxime Ripard wrote: >>> On Mon, Jul 08, 2024 at 11:29:46PM GMT, Dmitry Baryshkov wrote: On Mon, Jul 08, 2024 at 04:59:23PM GMT, Maxime Ripard wrote: > On Mon

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-24 Thread Dmitry Baryshkov
On Wed, Jul 24, 2024 at 07:18:39PM GMT, Marc Gonzalez wrote: > On 15/07/2024 16:42, Maxime Ripard wrote: > > On Mon, Jul 08, 2024 at 11:29:46PM GMT, Dmitry Baryshkov wrote: > >> On Mon, Jul 08, 2024 at 04:59:23PM GMT, Maxime Ripard wrote: > >>> On Mon, Jul 01, 2024 at 05:36:18PM GMT, Marc Gonzalez

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-24 Thread Marc Gonzalez
On 16/07/2024 11:24, Maxime Ripard wrote: > On Mon, Jul 15, 2024 at 07:38:34PM GMT, Dmitry Baryshkov wrote: >> On Mon, 15 Jul 2024 at 17:42, Maxime Ripard wrote: >>> On Mon, Jul 08, 2024 at 11:29:46PM GMT, Dmitry Baryshkov wrote: On Mon, Jul 08, 2024 at 04:59:23PM GMT, Maxime Ripard wrote: >>

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-24 Thread Marc Gonzalez
On 15/07/2024 16:42, Maxime Ripard wrote: > On Mon, Jul 08, 2024 at 11:29:46PM GMT, Dmitry Baryshkov wrote: >> On Mon, Jul 08, 2024 at 04:59:23PM GMT, Maxime Ripard wrote: >>> On Mon, Jul 01, 2024 at 05:36:18PM GMT, Marc Gonzalez wrote: On 01/07/2024 15:50, Maxime Ripard wrote: > On T

Re: 6.10/bisected/regression - Since commit e356d321d024 in the kernel log appears the message "MES failed to respond to msg=MISC (WAIT_REG_MEM)" which were never seen before

2024-07-24 Thread Mikhail Gavrilov
On Tue, Jul 23, 2024 at 2:34 AM Alex Deucher wrote: > Do either of these patches help? > https://patchwork.freedesktop.org/patch/605437/ Unfortunately, this patch didn't help. Please see the attached kernel log. > https://patchwork.freedesktop.org/patch/605201/ For which kernel is this patch int

[Bug 219092] New: Problem with fill_dc_mst_payload_table_from_drm [amdgpu]

2024-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219092 Bug ID: 219092 Summary: Problem with fill_dc_mst_payload_table_from_drm [amdgpu] Product: Drivers Version: 2.5 Kernel Version: Ubuntu 6.8.0-40.40-generic 6.8.12 Hardwar

Re: [PATCH -next] drm/amd/display: use swap() in sort()

2024-07-24 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jul 24, 2024 at 3:38 AM Jiapeng Chong wrote: > > Use existing swap() function rather than duplicating its implementation. > > ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn3.c:17:29-30: > WARNING opportunity for swap(). > > Reported-by: Abac

Re: [PATCH] drm/amd/display: Reapply 2fde4fdddc1f

2024-07-24 Thread Alex Deucher
*= 1.0 + margin; > > - divider = (unsigned int)(DFS_DIVIDER_RANGE_SCALE_FACTOR * > (vco_freq_khz / clock_khz)); > + divider = (unsigned int)((int)DFS_DIVIDER_RANGE_SCALE_FACTOR * > (vco_freq_khz / clock_khz)); > > /* we want to floor here to get higher clock than

Re: [PATCH][next] drm/amd/display: Fix spelling mistake "tolarance" -> "tolerance"

2024-07-24 Thread Alex Deucher
Applied. Thanks! On Wed, Jul 24, 2024 at 9:50 AM Colin Ian King wrote: > > There is a spelling mistake in a dml2_printf message. Fix it. > > Signed-off-by: Colin Ian King > --- > .../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-07-24 Thread Dan Carpenter
On Wed, Jul 24, 2024 at 02:19:38AM +0200, Marek Vasut wrote: > diff --git a/drivers/staging/media/imx/imx-media-dev.c > b/drivers/staging/media/imx/imx-media-dev.c > index be54dca11465d..a841fdb4c2394 100644 > --- a/drivers/staging/media/imx/imx-media-dev.c > +++ b/drivers/staging/media/imx/imx-me

Re: [PATCH 2/2] drm/panel: add BOE tv101wum-ll2 panel driver

2024-07-24 Thread Doug Anderson
Hi, On Wed, Jul 24, 2024 at 12:51 AM Neil Armstrong wrote: > > >> @@ -0,0 +1,240 @@ > >> +// SPDX-License-Identifier: GPL-2.0-only > >> +// Generated with linux-mdss-dsi-panel-driver-generator from vendor > >> device tree: > >> +// Copyright (c) 2013, The Linux Foundation. All rights reserved.

[PATCH] drm/client: Fix error code in drm_client_buffer_vmap_local()

2024-07-24 Thread Dan Carpenter
This function accidentally returns zero/success on the failure path. It leads to locking issues and an uninitialized *map_copy in the caller. Fixes: b4b0193e83cb ("drm/fbdev-generic: Fix locking with drm_client_buffer_vmap_local()") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/drm_client.c

[bug report] accel/habanalabs: enforce release order of compute device and dma-buf

2024-07-24 Thread Dan Carpenter
Hello Tomer Tayar, Commit 09524eb8824e ("accel/habanalabs: enforce release order of compute device and dma-buf") from Jan 22, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/accel/habanalabs/common/memory.c:1844 hl_release_dmabuf() error: dereferen

Re: [PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-07-24 Thread Nicolas Dufresne
Hi Marek, Le mercredi 24 juillet 2024 à 02:19 +0200, Marek Vasut a écrit : > Introduce dedicated memory-to-memory IPUv3 VDI deinterlacer driver. > Currently the IPUv3 can operate VDI in DIRECT mode, from sensor to > memory. This only works for single stream, that is, one input from > one camera is

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-07-24 Thread Alex Deucher
On Wed, Jul 24, 2024 at 4:58 AM Jani Nikula wrote: > > On Thu, 18 Jul 2024, Hans de Goede wrote: > > Hi Thomas, > > > > On 6/24/24 6:15 PM, Thomas Weißschuh wrote: > >> Hi Hans! > >> > >> thanks for your feedback! > >> > >> On 2024-06-24 11:11:40+, Hans de Goede wrote: > >>> On 6/23/24 10:51

[PATCH] drm/amd/display: Reapply 2fde4fdddc1f

2024-07-24 Thread Nathan Chancellor
get higher clock than required rather than lower */ if (divider < DFS_DIVIDER_RANGE_2_START) { --- base-commit: bd4bea5ab2bda37ddb092a978218c4d9b46927e6 change-id: 20240724-amdgpu-dml2-fix-float-enum-warning-again-647a33789138 Best regards, -- Nathan Chancellor

[regression] opening and closing /dev/dri/card0 in a QEMU KVM instance will shutdown system

2024-07-24 Thread Linux regression tracking (Thorsten Leemhuis)
Hi, Thorsten here, the Linux kernel's regression tracker. I noticed a report about a regression in bugzilla.kernel.org that appears to be related to the simpledrm driver. As many (most?) kernel developers don't keep an eye on the bug tracker, I decided to write this mail. To quote from https://bug

Re: [PATCH 6/7] drm/i915/pmu: Lazy unregister

2024-07-24 Thread Lucas De Marchi
On Wed, Jul 24, 2024 at 02:41:05PM GMT, Peter Zijlstra wrote: On Tue, Jul 23, 2024 at 10:30:08AM -0500, Lucas De Marchi wrote: On Tue, Jul 23, 2024 at 09:03:25AM GMT, Tvrtko Ursulin wrote: > > On 22/07/2024 22:06, Lucas De Marchi wrote: > > Instead of calling perf_pmu_unregister() when unbinding

Re: [PATCH 2/2] drm/mipi-dsi: Change multi functions to use quiet member of mipi_dsi_multi_context

2024-07-24 Thread Jani Nikula
On Wed, 24 Jul 2024, Tejas Vipin wrote: > Changes all the multi functions to check if the current context requires > errors to be printed or not using the quiet member. > > Signed-off-by: Tejas Vipin > --- > drivers/gpu/drm/drm_mipi_dsi.c | 20 > 1 file changed, 20 insertion

Re: [PATCH 1/2] drm/mipi-dsi: Add quiet member to mipi_dsi_multi_context struct

2024-07-24 Thread Jani Nikula
On Wed, 24 Jul 2024, Tejas Vipin wrote: > A "quiet" member is added to mipi_dsi_multi_context which allows > silencing all the errors printed by the multi functions. > > Signed-off-by: Tejas Vipin > --- > include/drm/drm_mipi_dsi.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --

Re: [PATCH v7 1/2] drm/buddy: Add start address support to trim function

2024-07-24 Thread Jani Nikula
On Tue, 23 Jul 2024, Arunpravin Paneer Selvam wrote: > - Add a new start parameter in trim function to specify exact > address from where to start the trimming. This would help us > in situations like if drivers would like to do address alignment > for specific requirements. > > - Add a new

[PATCH v7 1/6] dt-bindings: phy: add qcom,hdmi-phy-8998

2024-07-24 Thread Marc Gonzalez
HDMI PHY block embedded in the APQ8098. Acked-by: Rob Herring (Arm) Acked-by: Vinod Koul Signed-off-by: Marc Gonzalez --- Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yam

[PATCH v7 6/6] arm64: dts: qcom: add HDMI nodes for msm8998

2024-07-24 Thread Marc Gonzalez
From: Arnaud Vrac Port device nodes from vendor code. Signed-off-by: Arnaud Vrac Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Signed-off-by: Marc Gonzalez --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 100 +- 1 file changed, 99 insertions(+), 1 dele

[PATCH v7 0/6] HDMI TX support in msm8998

2024-07-24 Thread Marc Gonzalez
DT bits required for HDMI TX support in qcom APQ8098 (MSM8998 cousin) --- Changes in v7: - prefix the labels hdmi: and hdmi_phy: with mdss_ (Konrad) - DID NOT MODIFY patch 3, based on conversation between Conor & Dmitry - tested 40+40 boots with/without maxcpus=1 => no iommu panic witnessed - Coll

[PATCH v7 5/6] arm64: dts: qcom: msm8998: add HDMI GPIOs

2024-07-24 Thread Marc Gonzalez
MSM8998 GPIO pin controller reference design defines: - CEC: pin 31 - DDC: pin 32,33 - HPD: pin 34 Downstream vendor code for reference: https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/arch/arm/boot/dts/qcom/msm8998-pinctrl.dtsi#L2324-2400 mdss_hdmi_

[PATCH v7 4/6] drm/msm: add msm8998 hdmi phy/pll support

2024-07-24 Thread Marc Gonzalez
From: Arnaud Vrac Add support for the HDMI PHY as present on the Qualcomm MSM8998 SoC. This code is mostly copy & paste of the vendor code from msm-4.4 kernel.lnx.4.4.r38-rel. Signed-off-by: Arnaud Vrac Reviewed-by: Dmitry Baryshkov Signed-off-by: Marc Gonzalez --- drivers/gpu/drm/msm/Makefi

[PATCH v7 2/6] dt-bindings: display/msm: hdmi: add qcom,hdmi-tx-8998

2024-07-24 Thread Marc Gonzalez
HDMI TX block embedded in the APQ8098. Reviewed-by: Rob Herring (Arm) Reviewed-by: Conor Dooley Signed-off-by: Marc Gonzalez --- .../devicetree/bindings/display/msm/hdmi.yaml | 28 -- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetr

[PATCH v7 3/6] drm/msm/hdmi: add "qcom,hdmi-tx-8998" compatible

2024-07-24 Thread Marc Gonzalez
Current driver already supports the msm8998 HDMI TX. We just need to add the compatible string. Reviewed-by: Dmitry Baryshkov Signed-off-by: Marc Gonzalez --- drivers/gpu/drm/msm/hdmi/hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/ms

Re: [PATCH v3] drm/client: fix null pointer dereference in drm_client_modeset_probe

2024-07-24 Thread Jani Nikula
On Wed, 24 Jul 2024, Ma Ke wrote: > On Wed, 24 Jul 2024, Jani Nikula wrote: >> On Wed, 24 Jul 2024, Ma Ke wrote: >> > In drm_client_modeset_probe(), the return value of drm_mode_duplicate() is >> > assigned to modeset->mode, which will lead to a possible NULL pointer >> > dereference on failure

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-24 Thread Miguel Ojeda
On Wed, Jul 24, 2024 at 3:54 PM Steven Price wrote: > > I'd be quite keen for the "fork" to live in the upstream kernel. My > preference is for the two drivers to sit side-by-side. I'm not sure > whether that's a common view though. It is supposed to be against the usual rules/guidelines, but we

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-24 Thread Steven Price
On 24/07/2024 15:27, Daniel Almeida wrote: > Hi Steven! > >> On 24 Jul 2024, at 10:54, Steven Price wrote: >> >> [1] Although I have to admit for a debugging feature like devcoredump >> there might well be pressure to implement this in C as well purely so >> that customer issues can be debugged…

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-24 Thread Daniel Almeida
Hi Steven! > On 24 Jul 2024, at 10:54, Steven Price wrote: > > [1] Although I have to admit for a debugging feature like devcoredump > there might well be pressure to implement this in C as well purely so > that customer issues can be debugged… FYI: I picked devcoredump because it was self-cont

[PATCH] drm/i915/gt: Stop poisoning the idle kernel context alone when waking up

2024-07-24 Thread Krzysztof Niemiec
From: Chris Wilson The kernel context was poisoned on wakeup to simulate how the driver would cope with bad HW that caused corruption of any context that was still resident during power loss, see commit 1d0e2c9359fe ("drm/i915/gt: Always poison the kernel_context image before unparking"). However

Re: [PATCH net-next v15 03/14] netdev: support binding dma-buf to netdevice

2024-07-24 Thread Taehee Yoo
On Wed, Jul 24, 2024 at 6:49 AM Mina Almasry wrote: > > On Tue, Jul 9, 2024 at 8:37 AM Taehee Yoo wrote: > ... > > Reproducer: > > ./ncdevmem -f -l -p 5201 -v 7 -t 0 -q 2 & > > sleep 10 > > modprobe -rv bnxt_en > > killall ncdevmem > > > > I think it's a devmemTCP core bug so this issue would be

[PATCH v2 08/12] drm/i915/spi: add spi device for discrete graphics

2024-07-24 Thread Alexander Usyskin
From: Tomas Winkler Enable access to internal spi on DGFX devices via a child device. The spi child device is exposed via auxiliary bus. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/Makefile| 4 ++ drive

[PATCH v2 12/12] drm/xe/spi: add support for access mode

2024-07-24 Thread Alexander Usyskin
Check SPI access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/regs/xe_gsc_regs.h | 5 drivers/gpu/drm/xe/xe_heci_gsc.c | 5 +--- drivers/gpu/drm/xe/xe_spi.c | 33 ++

[PATCH v2 10/12] drm/i915/spi: add support for access mode

2024-07-24 Thread Alexander Usyskin
Check SPI access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/spi/intel_spi.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/i915/spi/in

[PATCH v2 09/12] drm/i915/spi: add intel_spi_region map

2024-07-24 Thread Alexander Usyskin
From: Tomas Winkler Add the dGFX spi region map and convey it via auxiliary device to the spi child device. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/spi/intel_spi.c | 8 1 file changed, 8 insertions(

[PATCH v2 11/12] drm/xe/spi: add on-die spi device

2024-07-24 Thread Alexander Usyskin
Enable access to internal spi on DGFX with GSC/CSC devices via a child device. The spi child device is exposed via auxiliary bus. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_device.c | 3 ++ drivers/gpu/drm/xe/xe_device_types.h |

[PATCH v2 07/12] spi: intel-dg: wake card on operations

2024-07-24 Thread Alexander Usyskin
Enable runtime PM in spi driver to notify graphics driver that whole card should be kept awake while spi operations are performed through this driver. CC: Lucas De Marchi Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 44 ++ 1 file changed,

[PATCH v2 06/12] spi: intel-dg: align 64bit read and write

2024-07-24 Thread Alexander Usyskin
GSC SPI HW errors on quad access overlapping 1K border. Align 64bit read and write to avoid readq/writeq over 1K border. Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/spi/spi-intel-

[PATCH v2 05/12] spi: intel-dg: implement mtd access handlers

2024-07-24 Thread Alexander Usyskin
From: Tomas Winkler Implement mtd read, erase, and write handlers. For erase operation address and size should be 4K aligned. For write operation address and size has to be 4bytes aligned. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Vitaly Lubart Signed-o

[PATCH v2 04/12] spi: intel-dg: spi register with mtd

2024-07-24 Thread Alexander Usyskin
From: Tomas Winkler Register the on-die spi device with the mtd subsystem. Refcount spi object on _get and _put mtd callbacks. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 111

[PATCH v2 03/12] spi: intel-dg: implement spi access functions

2024-07-24 Thread Alexander Usyskin
From: Tomas Winkler Implement spi_read(), spi_erase() and spi_write() functions. CC: Lucas De Marchi CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Vitaly Lubart Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 199 + 1 fil

[PATCH v2 02/12] spi: intel-dg: implement region enumeration

2024-07-24 Thread Alexander Usyskin
From: Tomas Winkler In intel-dg spi, there is no access to the spi controller, the information is extracted from the descriptor region. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 190 +++

[PATCH v2 01/12] spi: add driver for intel graphics on-die spi device

2024-07-24 Thread Alexander Usyskin
Add auxiliary driver for intel discrete graphics on-die spi device. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- MAINTAINERS | 7 ++ drivers/spi/Kconfig | 11 +++ drivers/spi/Makefile |

[PATCH v2 00/12] spi: add driver for Intel discrete graphics

2024-07-24 Thread Alexander Usyskin
Add driver for access to Intel discrete graphics card internal SPI device. Expose device on auxiliary bus by i915 and Xe drivers and provide spi driver to register this device with MTD framework. This is a rewrite of "drm/i915/spi: spi access for discrete graphics" series with connection to the Xe

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-24 Thread Maxime Ripard
On Tue, Jul 23, 2024 at 08:57:03PM GMT, Conor Dooley wrote: > On Tue, Jul 23, 2024 at 05:17:12PM +0200, Marc Gonzalez wrote: > > On 27/06/2024 18:25, Conor Dooley wrote: > > > > > On Thu, Jun 27, 2024 at 01:13:03PM +0200, Marc Gonzalez wrote: > > > > > >> TDP158 is an AC-coupled DVI / HDMI to TMDS

Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

2024-07-24 Thread Greg KH
On Wed, Jul 24, 2024 at 06:22:55PM +0530, Riyan Dhiman wrote: > Hi, > > Thank you for your feedback on my patch submission. > I understand that the fix provided by my patch is not needed. As this is my > first contribution to the Linux kernel, I am eager to learn and make > valuable contributions.

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-24 Thread Steven Price
On 24/07/2024 14:15, Rob Herring wrote: > On Wed, Jul 24, 2024 at 3:59 AM Steven Price wrote: >> >> Hi Boris, >> >> On 23/07/2024 17:06, Boris Brezillon wrote: >>> Hi Steve, >>> >>> On Mon, 15 Jul 2024 10:12:16 +0100 >>> Steven Price wrote: >>> I note it also shows that the "panthor_regs.rs"

[PATCH v2] drm/panel-edp: Add 6 panels used by MT8186 Chromebooks

2024-07-24 Thread Terry Hsiao
The raw EDIDs for each panel: AUO - B116XTN02.3 00 ff ff ff ff ff ff 00 06 af aa 73 00 00 00 00 00 21 01 04 95 1a 0e 78 02 6b f5 91 55 54 91 27 22 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 ce 1d 56 e2 50 00 1e 30 26 16 36 00 00 90 10 00 00 18 df 13 56 e2 50 00 1e 30 26 16 36 0

[PATCH] drm/i915: Allow evicting to use the requested placement

2024-07-24 Thread David Gow
In a78a8da5 ("drm/ttm: replace busy placement with flags v6"), the old system of having a separate placement list (for placements which should be used without eviction) and a 'busy' placement list (for placements which should be attempted if eviction is required) was replaced with a new one where p

Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

2024-07-24 Thread Riyan Dhiman
Hi, Thank you for your feedback on my patch submission. I have reviewed the mailing list traffic and noted that the last patch addressing the same coding style issue was submitted in April. Given this timeframe, I believed it was appropriate to submit my patch to contribute to the resolution of th

Re: [PATCH] mtd: mtdoops: Fix kmsgdump parameter renaming.

2024-07-24 Thread Richard Weinberger
- Ursprüngliche Mail - > Betreff: [PATCH] mtd: mtdoops: Fix kmsgdump parameter renaming. > When the kmsg_dumper callback parameter changed, the reason variable > in mtdoops_do_dump() was not updated accordingly. > This breaks the build with mtdoops. > > Fixes: e1a261ba599e ("printk: Add a

Re: [PATCH v4 4/4] drm/panic: Add a QR code panic screen

2024-07-24 Thread Mitchell Levy
On 7/17/2024 7:24 AM, Jocelyn Falempe wrote: This patch adds a new panic screen, with a QR code and the kmsg data embedded. If DRM_PANIC_SCREEN_QR_CODE_URL is set, then the kmsg data will be compressed with zlib and encoded as a numerical segment, and appended to the URL as a URL parameter. This

[PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

2024-07-24 Thread Riyan Dhiman
Adhere to Linux kernel coding style. Reported by checkpatch: CHECK: Unnecessary parentheses around 'devcode != 0x' CHECK: Unnecessary parentheses around 'devcode != 0x9320' CHECK: Unnecessary parentheses around 'par->info->var.xres == 320' CHECK: Unnecessary parentheses around 'par->info->var

Re: [PATCH v1] drm/panel-edp: Add panels with conservative timings

2024-07-24 Thread Terry Hsiao
Hi Doug, Thank you for your reply. The patch has been modified and will be sent to you shortly. The timings are set based on the panel datasheets in IssueTracker (https://partnerissuetracker.corp.google.com/issues/348109270) B116XTN02.3: B116XTN02.3(HW 9A)_HP_ Functional Spec_0617Y24.pdf B116XAN0

Re: [Linux-stm32] [PATCH RESEND v3 0/3] Update STM DSI PHY driver

2024-07-24 Thread Yanjun Yang
On Fri, Jun 28, 2024 at 8:47 PM Philippe CORNU wrote: > > > > On 1/29/24 11:41, Raphael Gallais-Pou wrote: > > > > This patch series aims to add several features of the dw-mipi-dsi phy > > driver that are missing or need to be updated. > > > > First patch update a PM macro. > > > > Second patch ad

  1   2   >