[PATCH v2 RESEND] drm/client: fix null pointer dereference in drm_client_modeset_probe

2024-07-23 Thread Ma Ke
In drm_client_modeset_probe(), the return value of drm_mode_duplicate() is assigned to modeset->mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Cc: sta...@vger.kernel.org Fixes: cf13909aee05 ("drm/fb-helper: Move out modese

Re: [PATCH 1/2] dt-bindings: display: panel: Document Densitron DMT028VGHMCMI-1D TFT on ILI9806E DSI TCON

2024-07-23 Thread Krzysztof Kozlowski
On 24/07/2024 02:55, Marek Vasut wrote: > Document Densitron DMT028VGHMCMI-1D 480x640 TFT matrix 2.83 inch panel > attached to Ilitek ILI9806E DSI TCON in the ILI9806E bindings. > > Signed-off-by: Marek Vasut Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

[Bug 219091] New: amdgpu: after updating to linux 6.10, screen flickering occurs

2024-07-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219091 Bug ID: 219091 Summary: amdgpu: after updating to linux 6.10, screen flickering occurs Product: Drivers Version: 2.5 Hardware: AMD OS: Linux Sta

Re: [PATCH RESEND] rockchip/drm: vop2: add support for gamma LUT

2024-07-23 Thread Dragan Simic
Hello Piotr, On 2024-07-22 20:26, Piotr Zalewski wrote: Thank you for the comment/review. Your code styling suggestions are naturally justified. Also, thanks to your comment, I noticed one extra thing. Namely, in my patch, gamma LUT write happens outside of the vop2 lock - which should happen in

Re: [PATCH v7 5/5] drm/ci: rockchip: add tests for rockchip display driver

2024-07-23 Thread Helen Koike
On 12/07/2024 06:15, Vignesh Raman wrote: For rockchip rk3288 and rk3399, the display driver is rockchip and gpu driver is panfrost. Currently, in drm-ci for rockchip rk3288 and rk3399, only the gpu driver is tested. Refactor the existing rockchip jobs to test both display and gpu driver and u

Re: [PATCH v7 4/5] drm/ci: meson: add tests for meson display driver

2024-07-23 Thread Helen Koike
On 12/07/2024 06:15, Vignesh Raman wrote: For Amlogic Meson G12B (A311D) SOC the display driver is meson and gpu driver is panfrost. Currently, in drm-ci for Meson G12B (A311D), only the gpu driver is tested. Refactor the existing meson jobs and add support in drm-ci to test both display and g

Re: [PATCH v7 3/5] drm/ci: mediatek: add tests for powervr gpu driver

2024-07-23 Thread Helen Koike
On 12/07/2024 06:15, Vignesh Raman wrote: For mediatek mt8173, the display driver is mediatek, while the gpu driver is powervr. Currently, in drm-ci for mt8173, only the display driver is tested. Add support in drm-ci to test powervr driver for mt8173. Powervr driver was merged in linux kernel

Re: [PATCH v7 2/5] drm/ci: mediatek: add tests for mediatek display driver

2024-07-23 Thread Helen Koike
On 12/07/2024 06:15, Vignesh Raman wrote: For mediatek mt8183, the display driver is mediatek, while the gpu driver is panfrost. Currently, in drm-ci for mt8183, only the gpu driver is tested. Refactor the existing mediatek jobs and add support in drm-ci to test both display and gpu driver for

Re: [PATCH v7 1/2] drm/buddy: Add start address support to trim function

2024-07-23 Thread Marek Olšák
The reason is that our DCC requires 768K alignment in some cases. I haven't read this patch series, but one way to do that is to align to 256K, overallocate by 512K, and then not use either 0, 256K, or 512K at the beginning to get to 768K alignment. Marek On Tue, Jul 23, 2024, 11:04 Matthew Auld

[PATCH 2/2] drm/panel/panel-ilitek-ili9806e: Add Densitron DMT028VGHMCMI-1D TFT to ILI9806E DSI TCON driver

2024-07-23 Thread Marek Vasut
Add Densitron DMT028VGHMCMI-1D 480x640 TFT matrix 2.83 inch panel attached to Ilitek ILI9806E DSI TCON into the ILI9806E driver. Note that the Densitron panels use different TCONs, this driver is for the later panel, use panel-ilitek-st7701.c for the former panel: DMT028VGHMCMI-1A - ST7701 DMT028V

[PATCH 1/2] dt-bindings: display: panel: Document Densitron DMT028VGHMCMI-1D TFT on ILI9806E DSI TCON

2024-07-23 Thread Marek Vasut
Document Densitron DMT028VGHMCMI-1D 480x640 TFT matrix 2.83 inch panel attached to Ilitek ILI9806E DSI TCON in the ILI9806E bindings. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Daniel Vetter Cc: David Airlie Cc: Jessica Zhang Cc: Krzysztof Kozlowski Cc: Maarten Lankhorst Cc: Maxime

[PATCH v2 2/2] media: imx: vdic: Introduce mem2mem VDI deinterlacer driver

2024-07-23 Thread Marek Vasut
Introduce dedicated memory-to-memory IPUv3 VDI deinterlacer driver. Currently the IPUv3 can operate VDI in DIRECT mode, from sensor to memory. This only works for single stream, that is, one input from one camera is deinterlaced on the fly with a helper buffer in DRAM and the result is written into

[PATCH v2 1/2] gpu: ipu-v3: vdic: Simplify ipu_vdi_setup()

2024-07-23 Thread Marek Vasut
The 'code' parameter only ever selects between YUV 4:2:0 and 4:2:2 subsampling, turn it into boolean to select exactly that and update related code accordingly. Signed-off-by: Marek Vasut --- Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Greg Kroah-Hartman Cc: Helge Deller Cc: Mau

Re: [PATCH 1/7] perf/core: Add pmu get/put

2024-07-23 Thread Ian Rogers
On Mon, Jul 22, 2024 at 2:07 PM Lucas De Marchi wrote: > > If a pmu is unregistered while there's an active event, perf will still > access the pmu via event->pmu, even after the event is destroyed. This > makes it difficult for drivers like i915 that take a reference on the > device when the even

Re: [PATCH net-next v15 03/14] netdev: support binding dma-buf to netdevice

2024-07-23 Thread Mina Almasry
On Tue, Jul 9, 2024 at 8:37 AM Taehee Yoo wrote: ... > Reproducer: > ./ncdevmem -f -l -p 5201 -v 7 -t 0 -q 2 & > sleep 10 > modprobe -rv bnxt_en > killall ncdevmem > > I think it's a devmemTCP core bug so this issue would be reproduced > with other drivers. Sorry for the late reply. I was out at

[bug report] drm/v3d: Create a CPU job extension for the reset timestamp job

2024-07-23 Thread Dan Carpenter
[ The Smatch integer overflow are too garbage to publish. We're going to have a BoF about integer overflows at plumbers. - dan ] Hello Maíra Canal, Commit 34a101e64296 ("drm/v3d: Create a CPU job extension for the reset timestamp job") from Nov 30, 2023 (linux-next), leads to the following Sma

Keybaords with arrays of RGB LEDs was Re: Future handling of complex RGB devices on Linux v2

2024-07-23 Thread Pavel Machek
Hi! So... I got two gaming keyboards. One is totally unusable (and it looks LEDs are not controllable from the host), and the second one is .. HyperX Elite RGB. Needs 2 USB connections, very buggy, probably needs repair, and I'd not recomend it to anyone. But that one seems to be usable for RGB ke

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-23 Thread Conor Dooley
On Tue, Jul 23, 2024 at 05:17:12PM +0200, Marc Gonzalez wrote: > On 27/06/2024 18:25, Conor Dooley wrote: > > > On Thu, Jun 27, 2024 at 01:13:03PM +0200, Marc Gonzalez wrote: > > > >> TDP158 is an AC-coupled DVI / HDMI to TMDS level shifting Redriver. > >> It supports DVI 1.0, HDMI 1.4b and 2.0b.

Re: [PATCH v4 2/2] drm/panel: boe-th101mb31ig002 : using drm_connector_helper_get_modes_fixed()

2024-07-23 Thread Doug Anderson
Hi, On Mon, Jul 22, 2024 at 11:26 PM Zhaoxiong Lv wrote: > > Use public functions( drm_connector_helper_get_modes_fixed()) to > get porch parameters. > > Signed-off-by: Zhaoxiong Lv > --- > Changes between V4 and V3: > - 1.Modify the return value, return > drm_connector_helper_get_modes_fixed(

bisected/regression: choopy youtube video on Ryzen IGP - 0ddd2ae586d2 drm/ttm: increase ttm pre-fault value to PMD size

2024-07-23 Thread Yanko Kaneti
Hello, Noticed and bisected a rawhide (with the new 6.11-rc0 snapshots) regression to this commit: 0ddd2ae586d2 drm/ttm: increase ttm pre-fault value to PMD size The regression manifests in choppy youtube video playback in google-chrome-stable. https://www.youtube.com/watch?v=uOpl2XNOgMA g

Re: [PATCH v4 0/1] drm/loongson: Introduce component framework support

2024-07-23 Thread Markus Elfring
… > v3 -> v4: > * Tiny refinement and clean up. I suggest to reconsider the need for a cover letter according to a single patch. Regards, Markus

Re: [PATCH 2/2] drm/panel: add BOE tv101wum-ll2 panel driver

2024-07-23 Thread Doug Anderson
Hi, On Tue, Jul 9, 2024 at 6:06 AM Neil Armstrong wrote: > > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > index 5581387707c6..79c90894b6a4 100644 > --- a/drivers/gpu/drm/panel/Makefile > +++ b/drivers/gpu/drm/panel/Makefile > @@ -7,6 +7,7 @@ obj-$(CONFIG_DRM_PANE

[PATCH] drm/test: use kunit action wrapper macro in the gem shmem test suite

2024-07-23 Thread Marco Pagani
Replace deferred action function wrappers with equivalent ones defined using the macro introduced by commit 56778b49c9a2 ("kunit: Add a macro to wrap a deferred action function") Signed-off-by: Marco Pagani --- drivers/gpu/drm/tests/drm_gem_shmem_test.c | 27 ++ 1 file change

[PATCH v4 1/1] drm/loongson: Introduce component framework support

2024-07-23 Thread Sui Jingfeng
In some display subsystems, the functionality of a PCIe device may too complex to be managed by a single driver. A split of the functionality into child devices can help to achieve better modularity. For example, KMS drivers who have dependencies on external modules will suffer from the deferral pr

[PATCH v4 0/1] drm/loongson: Introduce component framework support

2024-07-23 Thread Sui Jingfeng
Introduce component framework to avoid potential cyclic dependency problem. The whole driver won't finish bound before all submodules are ready, respective modules just do fundimental works in their probe() function, such as allocating storage for themselves, mapping mmio, and handling the externa

Re: [PATCH] drm/dp_mst: Simplify character output in drm_dp_mst_dump_topology()

2024-07-23 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to the kernel in just a moment On Mon, 2024-07-15 at 13:26 +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 15 Jul 2024 13:12:10 +0200 > > Single characters should be put into a sequence. > Thus use the corresponding function “seq_putc” for one

Re: [PATCH 06/11] drm/vc4: hdmi: Handle error case of pm_runtime_resume_and_get

2024-07-23 Thread Stefan Wahren
Hello, Am 30.06.24 um 17:36 schrieb Stefan Wahren: The commit 0f5251339eda ("drm/vc4: hdmi: Make sure the controller is powered in detect") introduced the necessary power management handling to avoid register access while controller is powered down. Unfortunately it just print a warning if pm_ru

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-23 Thread Daniel Almeida
The script (and the panthor_regs.rs file it generates) is at https://gitlab.collabora.com/dwlsalmeida/for-upstream/-/commit/783be55acf8d3352901798efb0118cce43e7f60b As you can see, it’s all regexes. It works, but I agree that it’s simpler to generate something more idiomatic by hand. — Daniel

Re: [PATCH] drm/amdgpu: convert bios_hardcoded_edid to drm_edid

2024-07-23 Thread Alex Deucher
On Tue, Jul 23, 2024 at 12:49 PM Alex Deucher wrote: > > On Sun, Jun 16, 2024 at 2:32 PM Thomas Weißschuh wrote: > > > > On 2024-06-16 11:12:03+, Thomas Weißschuh wrote: > > > Instead of manually passing around 'struct edid *' and its size, > > > use 'struct drm_edid', which encapsulates a va

Re: [PATCH] drm/nouveau/debugfs: Simplify character output in nouveau_debugfs_vbios_image()

2024-07-23 Thread Ilia Mirkin
On Tue, Jul 23, 2024 at 12:58 PM Christophe JAILLET wrote: > > Le 15/07/2024 à 15:15, Ilia Mirkin a écrit : > > On Mon, Jul 15, 2024 at 7:49 AM Markus Elfring > > wrote: > >> > >> From: Markus Elfring > >> Date: Mon, 15 Jul 2024 13:36:54 +0200 > >> > >> Single characters should be put into a se

Re: [PATCH] drm/nouveau/debugfs: Simplify character output in nouveau_debugfs_vbios_image()

2024-07-23 Thread Christophe JAILLET
Le 15/07/2024 à 15:15, Ilia Mirkin a écrit : On Mon, Jul 15, 2024 at 7:49 AM Markus Elfring wrote: From: Markus Elfring Date: Mon, 15 Jul 2024 13:36:54 +0200 Single characters should be put into a sequence. Thus use the corresponding function “seq_putc” for one selected call. This issue was

Re: [PATCH] drm/amdgpu: convert bios_hardcoded_edid to drm_edid

2024-07-23 Thread Alex Deucher
On Sun, Jun 16, 2024 at 2:32 PM Thomas Weißschuh wrote: > > On 2024-06-16 11:12:03+, Thomas Weißschuh wrote: > > Instead of manually passing around 'struct edid *' and its size, > > use 'struct drm_edid', which encapsulates a validated combination of > > both. > > > > As the drm_edid_ can hand

[PATCH v2] drm/nouveau/debugfs: Optimise data output in nouveau_debugfs_vbios_image()

2024-07-23 Thread Markus Elfring
From: Markus Elfring Date: Tue, 23 Jul 2024 18:08:15 +0200 Some characters should be put into a sequence. * Thus print all data by the corresponding function “seq_write” at once. * Return also the value from this function call. * Omit a local variable which became redundant with this refactori

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-23 Thread Boris Brezillon
Hi Steve, On Mon, 15 Jul 2024 10:12:16 +0100 Steven Price wrote: > I note it also shows that the "panthor_regs.rs" would ideally be shared. > For arm64 we have been moving to generating system register descriptions > from a text source (see arch/arm64/tools/sysreg) - I'm wondering whether > some

Re: [PATCH] [PATCH RESEND] drm/virtio: fix memory leak of vbuf

2024-07-23 Thread Dmitry Osipenko
On 5/9/24 04:52, Weishi Li wrote: > @@ -356,12 +356,14 @@ static int virtio_gpu_queue_ctrl_sgs(struct > virtio_gpu_device *vgdev, > > ret = virtqueue_add_sgs(vq, sgs, outcnt, incnt, vbuf, GFP_ATOMIC); > WARN_ON(ret); > + if (ret < 0 && ret != -ENOSPC) { > + free_vbuf(

Re: [PATCH 6/7] drm/i915/pmu: Lazy unregister

2024-07-23 Thread Lucas De Marchi
On Tue, Jul 23, 2024 at 09:03:25AM GMT, Tvrtko Ursulin wrote: On 22/07/2024 22:06, Lucas De Marchi wrote: Instead of calling perf_pmu_unregister() when unbinding, defer that to the destruction of i915 object. Since perf itself holds a reference in the event, this only happens when all events ar

Re: [PATCH v3 1/2] dt-bindings: display: bridge: add TI TDP158

2024-07-23 Thread Marc Gonzalez
On 27/06/2024 18:25, Conor Dooley wrote: > On Thu, Jun 27, 2024 at 01:13:03PM +0200, Marc Gonzalez wrote: > >> TDP158 is an AC-coupled DVI / HDMI to TMDS level shifting Redriver. >> It supports DVI 1.0, HDMI 1.4b and 2.0b. >> It supports 4 TMDS channels, HPD, and a DDC interface. >> It supports du

[Bug 219007] opening and closing /dev/dri/card0 in a QEMU KVM instance will shutdown system, 6.10.0-rc6+

2024-07-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=219007 Colin Ian King (colin.i.k...@gmail.com) changed: What|Removed |Added CC||colin.i.k...@gma

Re: [PATCH v7 1/2] drm/buddy: Add start address support to trim function

2024-07-23 Thread Matthew Auld
On 23/07/2024 14:43, Paneer Selvam, Arunpravin wrote: Hi Matthew, Can we push this version for now as we need to mainline the DCC changes ASAP, while we continue our discussion and proceed to implement the permanent solution for address alignment? Yeah, we can always merge now and circle ba

Re: [PATCH] drm/buddy: Add start address support to trim function

2024-07-23 Thread Matthew Auld
Hi, On 22/07/2024 12:41, Paneer Selvam, Arunpravin wrote: Hi Matthew, On 7/19/2024 4:01 PM, Matthew Auld wrote: On 17/07/2024 16:02, Paneer Selvam, Arunpravin wrote: On 7/16/2024 3:34 PM, Matthew Auld wrote: On 16/07/2024 10:50, Paneer Selvam, Arunpravin wrote: Hi Matthew, On 7/10/2024 6

Re: [PATCH v5 4/4] arm64: dts: qcom: add HDMI nodes for msm8998

2024-07-23 Thread Marc Gonzalez
On 23/07/2024 15:43, Konrad Dybcio wrote: > On 23.07.2024 3:38 PM, Marc Gonzalez wrote: > >> On 23/07/2024 15:08, Konrad Dybcio wrote: >> >>> On 23.07.2024 2:57 PM, Marc Gonzalez wrote: >>> On 23/07/2024 13:45, Konrad Dybcio wrote: > On 23.07.2024 11:59 AM, Dmitry Baryshkov wrote: >>

Re: [PATCH v1] drm/i915/hwmon: expose fan speed

2024-07-23 Thread Riana Tauro
On 7/23/2024 3:53 PM, Raag Jadav wrote: On Mon, Jul 22, 2024 at 04:20:51PM +0530, Riana Tauro wrote: Hi Raag On 7/12/2024 5:53 PM, Raag Jadav wrote: Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors t

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-23 Thread Alice Ryhl
On Tue, Jul 23, 2024 at 3:41 PM Daniel Almeida wrote: > > Hi Alice, thanks for the review! > > > >> +fn alloc_mem(&mut self, size: usize) -> Option<*mut u8> { > >> +assert!(size % 8 == 0, "Allocation size must be 8-byte > >> aligned"); > >> +if isize::try_from(size

Re: [PATCH v7 1/2] drm/buddy: Add start address support to trim function

2024-07-23 Thread Paneer Selvam, Arunpravin
Hi Matthew, Can we push this version for now as we need to mainline the DCC changes ASAP, while we continue our discussion and proceed to implement the permanent solution for address alignment? Thanks, Arun. On 7/23/2024 6:55 PM, Arunpravin Paneer Selvam wrote: - Add a new start parameter i

Re: [PATCH v5 4/4] arm64: dts: qcom: add HDMI nodes for msm8998

2024-07-23 Thread Konrad Dybcio
On 23.07.2024 3:38 PM, Marc Gonzalez wrote: > On 23/07/2024 15:08, Konrad Dybcio wrote: > >> On 23.07.2024 2:57 PM, Marc Gonzalez wrote: >> >>> On 23/07/2024 13:45, Konrad Dybcio wrote: >>> On 23.07.2024 11:59 AM, Dmitry Baryshkov wrote: > On Tue, 23 Jul 2024 at 12:48, Marc Gonzalez

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-23 Thread Daniel Almeida
Hi Alice, thanks for the review! >> +fn alloc_mem(&mut self, size: usize) -> Option<*mut u8> { >> +assert!(size % 8 == 0, "Allocation size must be 8-byte >> aligned"); >> +if isize::try_from(size).unwrap() == isize::MAX { >> +return None; >> +

Re: [PATCH v5 4/4] arm64: dts: qcom: add HDMI nodes for msm8998

2024-07-23 Thread Marc Gonzalez
On 23/07/2024 15:08, Konrad Dybcio wrote: > On 23.07.2024 2:57 PM, Marc Gonzalez wrote: > >> On 23/07/2024 13:45, Konrad Dybcio wrote: >> >>> On 23.07.2024 11:59 AM, Dmitry Baryshkov wrote: >>> On Tue, 23 Jul 2024 at 12:48, Marc Gonzalez wrote: > On 16/07/2024 18:37, Dmitry Baryshkov

[PATCH v7 1/2] drm/buddy: Add start address support to trim function

2024-07-23 Thread Arunpravin Paneer Selvam
- Add a new start parameter in trim function to specify exact address from where to start the trimming. This would help us in situations like if drivers would like to do address alignment for specific requirements. - Add a new flag DRM_BUDDY_TRIM_DISABLE. Drivers can use this flag to disab

[PATCH v7 2/2] drm/amdgpu: Add address alignment support to DCC buffers

2024-07-23 Thread Arunpravin Paneer Selvam
Add address alignment support to the DCC VRAM buffers. v2: - adjust size based on the max_texture_channel_caches values only for GFX12 DCC buffers. - used AMDGPU_GEM_CREATE_GFX12_DCC flag to apply change only for DCC buffers. - roundup non power of two DCC buffer adjusted size to nea

Re: [PATCH v5 4/4] arm64: dts: qcom: add HDMI nodes for msm8998

2024-07-23 Thread Dmitry Baryshkov
On Tue, 23 Jul 2024 at 15:57, Marc Gonzalez wrote: > > On 23/07/2024 13:45, Konrad Dybcio wrote: > > > On 23.07.2024 11:59 AM, Dmitry Baryshkov wrote: > > > >> On Tue, 23 Jul 2024 at 12:48, Marc Gonzalez wrote: > >> > >>> On 16/07/2024 18:37, Dmitry Baryshkov wrote: > >>> > No, that's fine. I

Re: [PATCH v5 4/4] arm64: dts: qcom: add HDMI nodes for msm8998

2024-07-23 Thread Konrad Dybcio
On 23.07.2024 2:57 PM, Marc Gonzalez wrote: > On 23/07/2024 13:45, Konrad Dybcio wrote: > >> On 23.07.2024 11:59 AM, Dmitry Baryshkov wrote: >> >>> On Tue, 23 Jul 2024 at 12:48, Marc Gonzalez wrote: >>> On 16/07/2024 18:37, Dmitry Baryshkov wrote: > No, that's fine. It is the SMMU is

Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

2024-07-23 Thread Greg KH
On Tue, Jul 23, 2024 at 06:28:19PM +0530, Riyan Dhiman wrote: > Hi, > > Thank you for your feedback on my patch submission. > I have reviewed the mailing list traffic and noted that the last patch > addressing the same coding style issue was submitted in April. Given this > timeframe, I believed i

Re: [PATCH v5 4/4] arm64: dts: qcom: add HDMI nodes for msm8998

2024-07-23 Thread Marc Gonzalez
On 23/07/2024 13:45, Konrad Dybcio wrote: > On 23.07.2024 11:59 AM, Dmitry Baryshkov wrote: > >> On Tue, 23 Jul 2024 at 12:48, Marc Gonzalez wrote: >> >>> On 16/07/2024 18:37, Dmitry Baryshkov wrote: >>> No, that's fine. It is the SMMU issue that Konrad has been asking you to take a loo

[PATCH 6/8] drm/ttm: revert "Export ttm_bo_get_unless_zero()"

2024-07-23 Thread Christian König
This reverts commit 24dc64c1ba5c3ef0463d59fef6df09336754188d. Shouldn't be needed by drivers any more. Signed-off-by: Christian König Reviewed-by: Matthew Brost --- drivers/gpu/drm/ttm/ttm_bo.c | 1 + drivers/gpu/drm/ttm/ttm_bo_internal.h | 48 +++ drivers/gpu

[PATCH 8/8] drm/ttm: make ttm_bo_get internal

2024-07-23 Thread Christian König
Prevent drivers from using this directly. Signed-off-by: Christian König Reviewed-by: Matthew Brost --- drivers/gpu/drm/ttm/ttm_bo_internal.h | 10 ++ include/drm/ttm/ttm_bo.h | 10 -- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH 7/8] drm/ttm: use GEM references for VM mappings

2024-07-23 Thread Christian König
Instead of a TTM reference grab a GEM reference whenever necessary for a VM mapping. Signed-off-by: Christian König Reviewed-by: Matthew Brost --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b

[PATCH 4/8] drm/vmwgfx: use GEM references instead of TTMs

2024-07-23 Thread Christian König
Instead of a TTM reference grab a GEM reference whenever necessary. Signed-off-by: Christian König Cc: Zack Rusin Cc: Broadcom internal kernel review list --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_bo.h | 19 ++- drivers/gpu/drm/

[PATCH 3/8] drm/loongson: use GEM references instead of TTMs

2024-07-23 Thread Christian König
Instead of a TTM reference grab a GEM reference whenever necessary. Signed-off-by: Christian König Cc: Sui Jingfeng --- drivers/gpu/drm/loongson/lsdc_ttm.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c b/drivers/gpu/drm/loongson

[PATCH 5/8] drm/vmwgfx: partially revert "Adapt validation code for reference-free lookups"

2024-07-23 Thread Christian König
This reverts commit 64ad2abfe9a628ce79859d072704bd1ef7682044. To me it looks like this functionality was never actually used. At least I can't find any protection in vmw_bo_free(). Signed-off-by: Christian König Cc: Zack Rusin Cc: Broadcom internal kernel review list --- drivers/gpu/drm/vmwgf

[PATCH 1/8] drm/amdgpu: use GEM references instead of TTMs

2024-07-23 Thread Christian König
Instead of a TTM reference grab a GEM reference whenever necessary. Signed-off-by: Christian König Cc: Alex Deucher Cc: Felix Kuehling Cc: amd-...@lists.freedesktop.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c| 8 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 7 ++- 2 files

[PATCH 2/8] drm/radeon: use GEM references instead of TTMs

2024-07-23 Thread Christian König
Instead of a TTM reference grab a GEM reference whenever necessary. Signed-off-by: Christian König Cc: Alex Deucher Cc: amd-...@lists.freedesktop.org --- drivers/gpu/drm/radeon/radeon_gem.c| 2 +- drivers/gpu/drm/radeon/radeon_object.c | 7 ++- 2 files changed, 3 insertions(+), 6 deleti

[PATCH 2/2] drm/virtio: add VIRTGPU_PARAM_HOST_PAGE_SIZE to params

2024-07-23 Thread Sergio Lopez
Add VIRTGPU_PARAM_HOST_PAGE_SIZE as a param that can be read with VIRTGPU_GETPARAM by userspace applications running in the guest to obtain the host's page size and find out the right alignment to be used in shared memory allocations. Signed-off-by: Sergio Lopez --- drivers/gpu/drm/virtio/virtgp

[PATCH 1/2] drm/virtio: introduce the HOST_PAGE_SIZE feature

2024-07-23 Thread Sergio Lopez
Introduce a new feature, HOST_PAGE_SIZE, that indicates the host provides its page size as a value in virtio_gpu_config. Signed-off-by: Sergio Lopez --- drivers/gpu/drm/virtio/virtgpu_drv.c | 1 + drivers/gpu/drm/virtio/virtgpu_drv.h | 2 ++ drivers/gpu/drm/virtio/virtgpu_kms.c | 13 ++

[PATCH 0/2] drm/virtio: introduce the HOST_PAGE_SIZE feature

2024-07-23 Thread Sergio Lopez
There's an incresing number of machines supporting multiple page sizes and on these machines the host and a guest can be running, each one, with a different page size. For what pertains to virtio-gpu, this is not a problem if the page size of the guest happens to be bigger or equal than the host,

Re: [PATCH v5 4/4] arm64: dts: qcom: add HDMI nodes for msm8998

2024-07-23 Thread Konrad Dybcio
On 23.07.2024 11:59 AM, Dmitry Baryshkov wrote: > On Tue, 23 Jul 2024 at 12:48, Marc Gonzalez wrote: >> >> On 16/07/2024 18:37, Dmitry Baryshkov wrote: >> >>> No, that's fine. It is the SMMU issue that Konrad has been asking you >>> to take a look at. >> >> Context: >> >> [4.911422] arm-smmu c

Re: [PATCH 2/2] arm64: dts: qcom: sc7280: Add 0x81 Adreno speed bin

2024-07-23 Thread Konrad Dybcio
On 22.07.2024 8:43 PM, Danila Tikhonov wrote: > From: Eugene Lepshy > > A642L (speedbin 0x81) uses index 4, so this commit > sets the fourth bit for A642L supported opps. > > Signed-off-by: Eugene Lepshy > Signed-off-by: Danila Tikhonov > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 1/2] drivers: drm/msm/a6xx_catalog: Add A642L speedbin (0x81)

2024-07-23 Thread Konrad Dybcio
On 22.07.2024 8:43 PM, Danila Tikhonov wrote: > From: Eugene Lepshy > > According to downstream, A642L's speedbin is 129 and uses 4 as index > > Signed-off-by: Eugene Lepshy > Signed-off-by: Danila Tikhonov > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v1] drm/i915/hwmon: expose fan speed

2024-07-23 Thread Raag Jadav
On Mon, Jul 22, 2024 at 04:20:51PM +0530, Riana Tauro wrote: > Hi Raag > > On 7/12/2024 5:53 PM, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > > > > $ sensors > > i915-

Re: [DO NOT MERGE PATCH v2 11/16] dt-bindings: phy: mixel,mipi-dsi-phy: Allow assigned-clock* properties

2024-07-23 Thread Liu Ying
On 07/23/2024, Rob Herring wrote: > On Fri, Jul 12, 2024 at 05:32:38PM +0800, Liu Ying wrote: >> assigned-clock* properties can be used by default now, so allow them. >> >> Signed-off-by: Liu Ying >> --- >> v2: >> * New patch as needed by MIPI/LVDS subsystems device tree. > > Seems like this coul

Re: [PATCH v5 4/4] arm64: dts: qcom: add HDMI nodes for msm8998

2024-07-23 Thread Dmitry Baryshkov
On Tue, 23 Jul 2024 at 12:48, Marc Gonzalez wrote: > > On 16/07/2024 18:37, Dmitry Baryshkov wrote: > > > No, that's fine. It is the SMMU issue that Konrad has been asking you > > to take a look at. > > Context: > > [4.911422] arm-smmu cd0.iommu: FSR= 0402 [Format=2 TF], > SID=0x0

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-23 Thread Alice Ryhl
On Thu, Jul 11, 2024 at 12:52 AM Daniel Almeida wrote: > > Dump the state of the GPU. This feature is useful for debugging purposes. > --- > Hi everybody! > > For those looking for a branch instead, see [0]. > > I know this patch has (possibly many) issues. It is meant as a > discussion around the

Re: [PATCH v2 02/16] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine

2024-07-23 Thread Liu Ying
On 07/23/2024, Rob Herring wrote: > On Fri, Jul 12, 2024 at 05:32:29PM +0800, Liu Ying wrote: >> i.MX8qxp Display Controller display engine consists of all processing units >> that operate in a display clock domain. >> >> Signed-off-by: Liu Ying >> --- >> v2: >> * Drop fsl,dc-*-id DT properties. (

Re: [PATCH v2 01/16] dt-bindings: display: imx: Add some i.MX8qxp Display Controller processing units

2024-07-23 Thread Liu Ying
On 07/23/2024, Rob Herring wrote: > On Fri, Jul 12, 2024 at 05:32:28PM +0800, Liu Ying wrote: >> Freescale i.MX8qxp Display Controller is implemented as construction set of >> building blocks with unified concept and standardized interfaces. >> >> Document some processing units to support two displ

Re: [PATCH v5 4/4] arm64: dts: qcom: add HDMI nodes for msm8998

2024-07-23 Thread Marc Gonzalez
On 16/07/2024 18:37, Dmitry Baryshkov wrote: > No, that's fine. It is the SMMU issue that Konrad has been asking you > to take a look at. Context: [4.911422] arm-smmu cd0.iommu: FSR= 0402 [Format=2 TF], SID=0x0 [4.923353] arm-smmu cd0.iommu: FSYNR0 = 0021 [S1CBNDX=0 P

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-23 Thread Alice Ryhl
On Mon, Jul 15, 2024 at 11:12 AM Steven Price wrote: > >>> + > >>> +pub(crate) const GPU_ID: GpuRegister = GpuRegister(0x0); > >>> +pub(crate) const fn gpu_arch_major(x: u64) -> GpuRegister { > >>> +GpuRegister((x) >> 28) > >>> +} > >>> +pub(crate) const fn gpu_arch_minor(x: u64) -> GpuRegiste

[PATCH 4/5] drm/panic: Move copyright notice to the top

2024-07-23 Thread Jocelyn Falempe
Move the copyright notice to the top of drm_panic.h, and add the missing Red Hat copyright notice. Suggested-by: Thomas Zimmermann Signed-off-by: Jocelyn Falempe --- include/drm/drm_panic.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/include/drm/drm_panic.h b/in

[PATCH 5/5] drm/panic: Add panic description

2024-07-23 Thread Jocelyn Falempe
Now that kmsg dump callback has the description parameter, use it in the user panic screen. This is the string passed to panic(), like "VFS: Unable to mount root fs on xxx" or "Attempted to kill init! exitcode=0". It gives a hint on why the panic occurred, without being too cryptic. Signed-off

[PATCH 3/5] drm/panic: Move drm_panic_register prototype to drm_crtc_internal.h

2024-07-23 Thread Jocelyn Falempe
drm_panic_[un]register() are only used by the core drm, and are not intended to be called by other drm drivers, so move their prototypes to drm_crtc_internal.h. Suggested-by: Daniel Vetter Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_crtc_internal.h | 4 include/drm/drm_panic.h

[PATCH 1/5] drm/panic: Remove space before "!" in panic message

2024-07-23 Thread Jocelyn Falempe
There is no space between the last word, and the punctuation mark in English. Suggested-by: Diego Viola Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c in

[PATCH 2/5] drm/panic: Remove useless export symbols

2024-07-23 Thread Jocelyn Falempe
drm_panic_[un]register() are called only from the core drm, so there is no need to export them. Suggested-by: Daniel Vetter Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic

[PATCH 0/5] drm/panic: Cleanup and add panic description

2024-07-23 Thread Jocelyn Falempe
This small series removes unused export symbols, moves internal include to drm_crtc_internal.h, and adds the panic description, now that kmsg_dump provides this information. Jocelyn Falempe (5): drm/panic: Remove space before "!" in panic message drm/panic: Remove useless export symbols dr

Re: [PATCH v6 2/2] misc: fastrpc: Increase unsigned PD initmem size

2024-07-23 Thread Dmitry Baryshkov
On Tue, 23 Jul 2024 at 07:36, Ekansh Gupta wrote: > > > > On 7/22/2024 2:04 PM, Dmitry Baryshkov wrote: > > On Mon, Jul 22, 2024 at 01:32:00PM GMT, Ekansh Gupta wrote: > >> For unsigned PD offloading requirement, additional memory is required > >> because of additional static heap initialization.

Re: [PATCH v6 1/2] misc: fastrpc: Define a new initmem size for user PD

2024-07-23 Thread Dmitry Baryshkov
On Tue, 23 Jul 2024 at 07:35, Ekansh Gupta wrote: > > > > On 7/22/2024 2:02 PM, Dmitry Baryshkov wrote: > > On Mon, Jul 22, 2024 at 01:31:59PM GMT, Ekansh Gupta wrote: > >> For user PD initialization, initmem is allocated and sent to DSP for > >> initial memory requirements like shell loading. The

Re: [PATCH 9/9] drm/ttm: make ttm_bo_get internal

2024-07-23 Thread Christian König
Am 16.07.24 um 23:37 schrieb Matthew Brost: On Tue, Jul 16, 2024 at 02:35:19PM +0200, Christian König wrote: Prevent drivers from using this directly. This is a good change. Early on in Xe, our reference counting for BOs was flawed (and incorrect) due to confusion between GEM ref count and TTM

Re: [PATCH v4 4/4] drm/panic: Add a QR code panic screen

2024-07-23 Thread Jocelyn Falempe
On 23/07/2024 01:20, Mitchell Levy wrote: On 7/17/2024 7:24 AM, Jocelyn Falempe wrote: This patch adds a new panic screen, with a QR code and the kmsg data embedded. If DRM_PANIC_SCREEN_QR_CODE_URL is set, then the kmsg data will be compressed with zlib and encoded as a numerical segment, and

Re: [PATCH 6/7] drm/i915/pmu: Lazy unregister

2024-07-23 Thread Tvrtko Ursulin
On 22/07/2024 22:06, Lucas De Marchi wrote: Instead of calling perf_pmu_unregister() when unbinding, defer that to the destruction of i915 object. Since perf itself holds a reference in the event, this only happens when all events are gone, which guarantees i915 is not unregistering the pmu wit

Re: [PATCH 5/7] drm/i915/pmu: Let resource survive unbind

2024-07-23 Thread Tvrtko Ursulin
On 22/07/2024 22:06, Lucas De Marchi wrote: There's no need to free the resources during unbind. Since perf events may still access them due to open events, it's safer to free them when dropping the last i915 reference. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_pmu.c | 21

Re: [PATCH 4/7] drm/i915/pmu: Drop is_igp()

2024-07-23 Thread Tvrtko Ursulin
On 22/07/2024 22:06, Lucas De Marchi wrote: There's no reason to hardcode checking for integrated graphics on a specific pci slot. That information is already available per platform an can be checked with IS_DGFX(). Hmm probably reason was this, added is_igp: commit 05488673a4d41383f9dd537f2

Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

2024-07-23 Thread Greg KH
On Tue, Jul 23, 2024 at 11:33:11AM +0530, Riyan Dhiman wrote: > Adhere to Linux kernel coding style. > > Reported by checkpatch: > > CHECK: Unnecessary parentheses around 'devcode != 0x' > CHECK: Unnecessary parentheses around 'devcode != 0x9320' > CHECK: Unnecessary parentheses around 'par->

Re: [PATCH 2/2] drm/panel: add BOE tv101wum-ll2 panel driver

2024-07-23 Thread Neil Armstrong
Hi Jessica, Doug, On 09/07/2024 15:05, Neil Armstrong wrote: Add support for the 1200x1920 BOE TV101WUM-LL2 DSI Display Panel found in the Lenovo Smart Tab M10 tablet. The controller is unknown. Could you review this patch ? Thanks ! Neil Signed-off-by: Neil Armstrong --- drivers/gpu/dr

Re: [PATCH v3 2/3] Subject: [PATCH] drm/mediatek/dp: Add HDCP2.x feature for DisplayPort

2024-07-23 Thread 胡俊光