[linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

2022-07-06 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 088b9c375534d905a4d337c78db3b3bfbb52c4a0 Add linux-next specific files for 20220706 Error/Warning reports: https://lore.kernel.org/linux-doc/202207070644.x48xoovs-...@intel.com Error/Warning

Re: [PATCH v3 00/71] drm/vc4: Fix hotplug for vc4

2022-07-06 Thread Thomas Zimmermann
Hi Am 29.06.22 um 14:33 schrieb Maxime Ripard: Hi, Here is a series that address multiple issues when trying to unbind/rebind vc4-related devices to their drivers. Most of these issues involve either use-after-free, improper resource liberation or similar. It has been tested on the Pi3 and Pi

Re: [RFT][PATCH v2 0/9] Update vfio_pin/unpin_pages API

2022-07-06 Thread Nicolin Chen
On Thu, Jul 07, 2022 at 06:08:45AM +, Tian, Kevin wrote: > > Request for testing: I only did build for s390 and i915 code, so it'd > > be nice to have people who have environment to run sanity accordingly. > > > > +Terrence who is testing it for i915 now... Hi Terrence, would it be possible

RE: [RFT][PATCH v2 0/9] Update vfio_pin/unpin_pages API

2022-07-06 Thread Tian, Kevin
> From: Nicolin Chen > Sent: Wednesday, July 6, 2022 2:28 PM > > This is a preparatory series for IOMMUFD v2 patches. It prepares for > replacing vfio_iommu_type1 implementations of vfio_pin/unpin_pages() > with IOMMUFD version. > > There's a gap between these two versions: the vfio_iommu_type1 v

Re: [Intel-gfx] [RFC 05/10] drm/i915/vm_bind: Handle persistent vmas

2022-07-06 Thread Niranjana Vishwanathapura
On Tue, Jul 05, 2022 at 06:50:19AM -0700, Zeng, Oak wrote: Thanks, Oak -Original Message- From: C, Ramalingam Sent: July 5, 2022 5:20 AM To: Zeng, Oak Cc: Vishwanathapura, Niranjana ; intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vetter, Daniel ; christian.koe...

Re: [RFC 10/10] drm/i915/vm_bind: Fix vm->vm_bind_mutex and vm->mutex nesting

2022-07-06 Thread Niranjana Vishwanathapura
On Tue, Jul 05, 2022 at 10:40:56AM +0200, Thomas Hellström wrote: On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: VM_BIND functionality maintain that vm->vm_bind_mutex will never be taken while holding vm->mutex. However, while closing 'vm', vma is destroyed while holding vm-

Re: [RFC 02/10] drm/i915/vm_bind: Bind and unbind mappings

2022-07-06 Thread Niranjana Vishwanathapura
On Wed, Jul 06, 2022 at 06:21:03PM +0200, Thomas Hellström wrote: On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: Bind and unbind the mappings upon VM_BIND and VM_UNBIND calls. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Prathap Kumar Valsan ---  drivers/gpu/dr

Re: [Intel-gfx] [RFC 02/10] drm/i915/vm_bind: Bind and unbind mappings

2022-07-06 Thread Niranjana Vishwanathapura
On Thu, Jul 07, 2022 at 03:41:26AM +0200, Andi Shyti wrote: Hi, [...] > @@ -28,7 +28,6 @@ static u32 object_max_page_size(struct > intel_memory_region **placements, > max_page_size = max_t(u32, max_page_size, mr- > >min_page_size); > } >   > -   GEM_BUG_ON(!max_page

Re: [PATCH v2 3/4] drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr}

2022-07-06 Thread kernel test robot
Hi Danilo, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.19-rc5] [also build test ERROR on linus/master] [cannot apply to drm-misc/drm-misc-next anholt/for-next pinchartl-media/drm/du/next next-20220706] [If your patch is applied to the wrong git tree, kindly

Re: [PATCH v2 3/4] drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr}

2022-07-06 Thread kernel test robot
Hi Danilo, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.19-rc5] [also build test ERROR on linus/master] [cannot apply to drm-misc/drm-misc-next anholt/for-next pinchartl-media/drm/du/next next-20220706] [If your patch is applied to the wrong git tree, kindly

Re: [Intel-gfx] [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

2022-07-06 Thread Niranjana Vishwanathapura
On Thu, Jul 07, 2022 at 03:18:15AM +0200, Andi Shyti wrote: Hi, [...] > +/* > + * VM_BIND feature version supported. > + * > + * The following versions of VM_BIND have been defined: > + * > + * 0: No VM_BIND support. > + * > + * 1: In VM_UNBIND calls, the UMD must specify the exact mappings >

Re: [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

2022-07-06 Thread Niranjana Vishwanathapura
On Tue, Jul 05, 2022 at 02:59:24AM -0700, Hellstrom, Thomas wrote: Hi, On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: Add VM_BIND and VM_UNBIND ioctls to bind/unbind a section of an object at the specified GPU virtual addresses. Add I915_PARAM_VM_BIND_VERSION to indicate

[PATCH v1] drm/syncobj: Fix sync syncobj issue

2022-07-06 Thread jie1zhan
enable signaling after flatten dma_fence_chains on transfer Signed-off-by: jie1zhan Reviewed-by: Christian König Reviewed-by: Nirmoy Das --- drivers/gpu/drm/drm_syncobj.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 7

[PULL] drm-intel-next

2022-07-06 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-2022-07-06 that shall be our last one towards 5.20, containing only a few things: - Suspend fixes for Display (Jose) - Properly block D3Cold for now (Anshuman) - Eliminate PIPECONF RMWs from .color_commit()(Ville) - Display info clean-up (Ville) - Fix

[PATCH] drm/sprd: Remove of_node_put() in sprd_crtc_init()

2022-07-06 Thread Liang He
As the new reference created in 'dpu->base.port' will be escaped out, we need not to call of_node_put() again. Fixes: b07bcf34b6c9 ("drm/sprd: add Unisoc's drm display controller driver") Signed-off-by: Liang He --- drivers/gpu/drm/sprd/sprd_dpu.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] drm/bridge:tc358767: Add of_node_put() when breaking out of loop

2022-07-06 Thread Liang He
In tc_probe_bridge_endpoint(), we should call of_node_put() when breaking out of the for_each_endpoint_of_node() which will automatically increase and decrease the refcount. Fixes: 71f7d9c03118 ("drm/bridge: tc358767: Detect bridge mode from connected endpoints in DT") Signed-off-by: Liang He --

[pull] amdgpu drm-fixes-5.19

2022-07-06 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.19. The following changes since commit b8f0009bc9edf9186b20ae2a9e442ef0af93040e: Merge tag 'drm-misc-fixes-2022-06-30' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2022-07-01 09:27:55 +1000) are available in the Git repository at: https://git

[PATCH] drm/imx/dcss: Add missing of_node_put() in fail path

2022-07-06 Thread Liang He
In dcss_dev_create(), we should call of_node_put() in fail path for of_graph_get_port_by_id() which will increase the refcount. Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ") Signed-off-by: Liang He --- drivers/gpu/drm/imx/dcss/dcss-dev.c | 1 + 1 file changed, 1 inserti

[PATCH -next] drm: Remove unnecessary print function dev_err()

2022-07-06 Thread Yang Li
The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:817:2-9: line 817 is redundant because platform_get_irq() already prints an error Signed-off-by: Yang Li --- drivers

Re: [Intel-gfx] [RFC 02/10] drm/i915/vm_bind: Bind and unbind mappings

2022-07-06 Thread Andi Shyti
Hi, [...] > > @@ -28,7 +28,6 @@ static u32 object_max_page_size(struct > > intel_memory_region **placements, > > max_page_size = max_t(u32, max_page_size, mr- > > >min_page_size); > > } > >   > > -   GEM_BUG_ON(!max_page_size); > > return max_page_size; > >  }

[PATCH -next] drm/amd/display: clean up some inconsistent indenting

2022-07-06 Thread Yang Li
Eliminate the follow smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:405 get_bios_object_from_path_v3() warn: inconsistent indenting drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:611 bios_parser_get_hpd_info() warn: inconsistent indenting drivers/gpu/d

[PATCH] drm:bridge:analogix: Fix refcount bugs in anx7625_parse_dt()

2022-07-06 Thread Liang He
There are two refcount bugs in this funcion: BUG-1: 'pdata->mipi_host_node' will be assigned a new reference with of_graph_get_remote_node() which will increase the refcount of the object, correspondingly, we should call of_node_put() for the old reference stored in the 'pdata->mipi_host_node'. B

Re: [Intel-gfx] [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

2022-07-06 Thread Andi Shyti
Hi, [...] > > +/* > > + * VM_BIND feature version supported. > > + * > > + * The following versions of VM_BIND have been defined: > > + * > > + * 0: No VM_BIND support. > > + * > > + * 1: In VM_UNBIND calls, the UMD must specify the exact mappings > > created > > + *    previously with VM_BIND, t

Re: [PATCH] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-07-06 Thread kernel test robot
Hi Dmitry, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v5.19-rc5 next-20220706] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

Re: [PATCH v5 5/9] drm/bridge: anx7625: Add typec_mux_set callback function

2022-07-06 Thread Stephen Boyd
Quoting Prashant Malani (2022-07-06 11:26:19) > > Stephen, any pending concerns? No more pending concerns. > If not,I will post a v6 series with the suggested changes: > - Drop typec-switch binding; instead add a new top-level port with > end-points for each Type-C connector's switch. > - Drop it

Re: [PATCH v4] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Doug Anderson
Hi, On Wed, Jul 6, 2022 at 12:32 PM Kuogee Hsieh wrote: > > Some userspace presumes that the first connected connector is the main > display, where it's supposed to display e.g. the login screen. For > laptops, this should be the main panel. > > This patch call drm_helper_move_panel_connectors_to

Re: [PATCH] drm/i915/gem: Really move i915_gem_context.link under ref protection

2022-07-06 Thread Andi Shyti
Hi, [...] > @@ -1265,10 +1264,15 @@ static void i915_gem_context_release_work(struct > work_struct *work) > struct i915_gem_context *ctx = container_of(work, typeof(*ctx), > release_work); > struct i915_address_space *vm; > + unsi

Re: [PATCH] drm/radeon: avoid bogus "vram limit (0) must be a power of 2" warning

2022-07-06 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jul 6, 2022 at 5:40 PM Mateusz Jończyk wrote: > > I was getting the following message on boot on Linux 5.19-rc5: > radeon :01:05.0: vram limit (0) must be a power of 2 > (I didn't use any radeon.vramlimit commandline parameter). > > This is caused by >

Re: [PATCH v3 1/3] drm/msm/dpu: index dpu_kms->hw_vbif using vbif_idx

2022-07-06 Thread Abhinav Kumar
On 6/15/2022 5:57 AM, Dmitry Baryshkov wrote: Remove loops over hw_vbif. Instead always VBIF's idx as an index in the array. This fixes an error in dpu_kms_hw_init(), where we fill dpu_kms->hw_vbif[i], but check for an error pointer at dpu_kms->hw_vbif[vbif_idx]. Fixes: 25fdd5933e4c ("drm/msm

[PATCH] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-07-06 Thread Dmitry Baryshkov
Currently the DSI driver has two separate paths: one if the next device in a chain is a bridge and another one if the panel is connected directly to the DSI host. Simplify the code path by using panel-bridge driver (already selected in Kconfig) and dropping support for handling the panel directly.

Re: [PATCH] drm: xlnx: add for readl/writel\

2022-07-06 Thread Ville Syrjälä
gt; > allmodconfig caught a few other drivers needing io.h but somehow > > this one built for me without that header on both arm and x86. > > Was this on some other architecture, or maybe there's some weird > > config dependency that pulls in io.h for allmodconfig? &

Re: [PATCH v4] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Abhinav Kumar
On 7/6/2022 12:32 PM, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the main panel. This patch call drm_helper_move_panel_connectors_to_head() after drm_brid

[PATCH v4] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Kuogee Hsieh
Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the main panel. This patch call drm_helper_move_panel_connectors_to_head() after drm_bridge_connector_init() to make sure eDP stay at he

Re: [RFT][PATCH v2 4/9] vfio: Pass in starting IOVA to vfio_pin/unpin_pages API

2022-07-06 Thread Nicolin Chen
On Wed, Jul 06, 2022 at 02:49:23PM -0300, Jason Gunthorpe wrote: > On Tue, Jul 05, 2022 at 11:27:54PM -0700, Nicolin Chen wrote: > > > These functions call back into the back-end IOMMU module by using the > > pin_pages > > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c > > b/drivers/gpu/drm/i915

Re: [PATCH] drm: xlnx: add for readl/writel

2022-07-06 Thread Randy Dunlap
t; Should be > Fixes: a204f9743b68 ("drm: Remove linux/i2c.h from drm_crtc.h") > probably? Ack, thanks. > > allmodconfig caught a few other drivers needing io.h but somehow > this one built for me without that header on both arm and x86. > Was this on some other architecture, or

[PATCH] drm/msm/dsi: Set panel orientation when directly connected

2022-07-06 Thread Stephen Boyd
Set the panel orientation in drm when the panel is directly connected, i.e. we're not using an external bridge. The external bridge case is already handled by the panel bridge code, so we only update the path we take when the panel is directly connected/internal. This silences a warning splat comin

Re: [PATCH] drm: xlnx: add for readl/writel

2022-07-06 Thread Ville Syrjälä
On Wed, Jul 06, 2022 at 11:42:24AM -0700, Randy Dunlap wrote: > Add a header file to prevent build errors: > > ../drivers/gpu/drm/xlnx/zynqmp_dp.c: In function ‘zynqmp_dp_write’: > ../drivers/gpu/drm/xlnx/zynqmp_dp.c:335:9: error: implicit declaration of > function ‘writel’ [-Werror=implicit-func

[PATCH] drm: xlnx: add for readl/writel

2022-07-06 Thread Randy Dunlap
Add a header file to prevent build errors: ../drivers/gpu/drm/xlnx/zynqmp_dp.c: In function ‘zynqmp_dp_write’: ../drivers/gpu/drm/xlnx/zynqmp_dp.c:335:9: error: implicit declaration of function ‘writel’ [-Werror=implicit-function-declaration] 335 | writel(val, dp->iomem + offset); ../dr

[PATCH] drm/etnaviv: Remove duplicate call to drm_gem_free_mmap_offset

2022-07-06 Thread T.J. Mercier
The docs explicitly say the drm_gem_object_release function already calls this, and this does not appear to be a prerequisite for the call to etnaviv_gem_ops.release. Signed-off-by: T.J. Mercier --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/

Re: [PATCH v5 5/9] drm/bridge: anx7625: Add typec_mux_set callback function

2022-07-06 Thread Prashant Malani
On Thu, Jun 30, 2022 at 4:38 PM Prashant Malani wrote: > > On Thu, Jun 30, 2022 at 4:21 PM Stephen Boyd wrote: > > > > Quoting Prashant Malani (2022-06-28 13:56:22) > > > On Tue, Jun 28, 2022 at 1:40 PM Stephen Boyd wrote: > > > > > > > > I suppose none of those things matter though as long as t

Re: [RFT][PATCH v2 9/9] vfio: Replace phys_pfn with pages for vfio_pin_pages()

2022-07-06 Thread Jason Gunthorpe
On Tue, Jul 05, 2022 at 11:27:59PM -0700, Nicolin Chen wrote: > Most of the callers of vfio_pin_pages() want "struct page *" and the > low-level mm code to pin pages returns a list of "struct page *" too. > So there's no gain in converting "struct page *" to PFN in between. > > Replace the output

Re: [RFT][PATCH v2 8/9] vfio/ccw: Add kmap_local_page() for memcpy

2022-07-06 Thread Jason Gunthorpe
On Tue, Jul 05, 2022 at 11:27:58PM -0700, Nicolin Chen wrote: > A PFN is not secure enough to promise that the memory is not IO. And > direct access via memcpy() that only handles CPU memory will crash on > S390 if the PFN is an IO PFN, as we have to use the memcpy_to/fromio() > that uses the speci

Re: [RFT][PATCH v2 7/9] vfio: Rename user_iova of vfio_dma_rw()

2022-07-06 Thread Jason Gunthorpe
On Tue, Jul 05, 2022 at 11:27:57PM -0700, Nicolin Chen wrote: > Following the updated vfio_pin/unpin_pages(), use the simpler "iova". > > Signed-off-by: Nicolin Chen > --- > drivers/vfio/vfio.c | 6 +++--- > include/linux/vfio.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) Review

Re: [RFT][PATCH v2 6/9] vfio/ccw: Change pa_pfn list to pa_iova list

2022-07-06 Thread Jason Gunthorpe
On Tue, Jul 05, 2022 at 11:27:56PM -0700, Nicolin Chen wrote: > The vfio_ccw_cp code maintains both iova and its PFN list because the > vfio_pin/unpin_pages API wanted pfn list. Since vfio_pin/unpin_pages() > now accept "iova", change to maintain only pa_iova list and rename all > "pfn_array" strin

Re: [RFT][PATCH v2 4/9] vfio: Pass in starting IOVA to vfio_pin/unpin_pages API

2022-07-06 Thread Nicolin Chen
On Wed, Jul 06, 2022 at 02:49:23PM -0300, Jason Gunthorpe wrote: > On Tue, Jul 05, 2022 at 11:27:54PM -0700, Nicolin Chen wrote: > > > These functions call back into the back-end IOMMU module by using the > > pin_pages > > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c > > b/drivers/gpu/drm/i915

Re: [PATCH v3] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Dmitry Baryshkov
On 06/07/2022 20:54, Kuogee Hsieh wrote: On 7/6/2022 10:41 AM, Dmitry Baryshkov wrote: On 06/07/2022 20:38, Kuogee Hsieh wrote: On 7/6/2022 10:25 AM, Dmitry Baryshkov wrote: On 06/07/2022 20:24, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main displ

Re: [RFT][PATCH v2 5/9] vfio/ap: Remove redundant pfn

2022-07-06 Thread Jason Gunthorpe
On Tue, Jul 05, 2022 at 11:27:55PM -0700, Nicolin Chen wrote: > The vfio_ap_ops code maintains both nib address and its PFN, which > is redundant, merely because vfio_pin/unpin_pages API wanted pfn. > Since vfio_pin/unpin_pages() now accept "iova", remove duplicated > pfn code in their callers too.

Re: [PATCH v3] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Kuogee Hsieh
On 7/6/2022 10:41 AM, Dmitry Baryshkov wrote: On 06/07/2022 20:38, Kuogee Hsieh wrote: On 7/6/2022 10:25 AM, Dmitry Baryshkov wrote: On 06/07/2022 20:24, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. t

Re: [RFT][PATCH v2 4/9] vfio: Pass in starting IOVA to vfio_pin/unpin_pages API

2022-07-06 Thread Jason Gunthorpe
On Tue, Jul 05, 2022 at 11:27:54PM -0700, Nicolin Chen wrote: > These functions call back into the back-end IOMMU module by using the > pin_pages > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c > b/drivers/gpu/drm/i915/gvt/kvmgt.c > index 8c67c9aba82d..ea6041fa48ac 100644 > --- a/drivers/gpu/dr

Re: [PATCH v3] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Dmitry Baryshkov
On 06/07/2022 20:38, Kuogee Hsieh wrote: On 7/6/2022 10:25 AM, Dmitry Baryshkov wrote: On 06/07/2022 20:24, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the

Re: [RFT][PATCH v2 9/9] vfio: Replace phys_pfn with pages for vfio_pin_pages()

2022-07-06 Thread Kirti Wankhede
Reviewed-by: Kirti Wankhede On 7/6/2022 11:57 AM, Nicolin Chen wrote: Most of the callers of vfio_pin_pages() want "struct page *" and the low-level mm code to pin pages returns a list of "struct page *" too. So there's no gain in converting "struct page *" to PFN in between. Replace the out

Re: [RFT][PATCH v2 4/9] vfio: Pass in starting IOVA to vfio_pin/unpin_pages API

2022-07-06 Thread Kirti Wankhede
Reviewed by: Kirti Wankhede On 7/6/2022 11:57 AM, Nicolin Chen wrote: The vfio_pin/unpin_pages() so far accepted arrays of PFNs of user IOVA. Among all three callers, there was only one caller possibly passing in a non-contiguous PFN list, which is now ensured to have contiguous PFN inputs t

Re: [RFT][PATCH v2 1/9] vfio: Make vfio_unpin_pages() return void

2022-07-06 Thread Kirti Wankhede
Reviewed-by: Kirti Wankhede On 7/6/2022 11:57 AM, Nicolin Chen wrote: There's only one caller that checks its return value with a WARN_ON_ONCE, while all other callers do not check return value at all. So simplify the API to return void by embedding similar WARN_ON_ONCEs. Suggested-by: Chris

Re: [PATCH v3] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Kuogee Hsieh
On 7/6/2022 10:25 AM, Dmitry Baryshkov wrote: On 06/07/2022 20:24, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the main panel. This patch call drm_helper_m

Re: [PATCH v2 3/4] drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr}

2022-07-06 Thread Laurent Pinchart
Hi Danilo, Thank you for the patch. On Wed, Jul 06, 2022 at 02:43:51PM +0200, Danilo Krummrich wrote: > The field paddr of struct drm_gem_dma_object holds a DMA address, which > might actually be a physical address. However, depending on the platform, > it can also be a bus address or a virtual a

Re: [PATCH v3] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Dmitry Baryshkov
On 06/07/2022 20:24, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the main panel. This patch call drm_helper_move_panel_connectors_to_head() after drm_bridge_c

[PATCH v3] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Kuogee Hsieh
Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the main panel. This patch call drm_helper_move_panel_connectors_to_head() after drm_bridge_connector_init() to make sure eDP stay at he

Re: [PATCH v2] drm/msm/adreno: Do not propagate void return values

2022-07-06 Thread Dmitry Baryshkov
On Wed, 6 Jul 2022 at 16:18, Geert Uytterhoeven wrote: > > With sparse ("make C=2"), lots of > > error: return expression in void function > > messages are seen. > > Fix this by removing the return statements to propagate void return > values. > > Signed-off-by: Geert Uytterhoeven > Reviewed-by

Re: [PATCH v2] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Dmitry Baryshkov
On Wed, 6 Jul 2022 at 19:12, Kuogee Hsieh wrote: > > Some userspace presumes that the first connected connector is the main > display, where it's supposed to display e.g. the login screen. For > laptops, this should be the main panel. > > This patch call drm_helper_move_panel_connectors_to_head()

Re: [PATCH v2 2/7] drm/i915/gem: Typecheck page lookups

2022-07-06 Thread Mauro Carvalho Chehab
On Wed, 6 Jul 2022 19:33:22 +0300 Gwan-gyeong Mun wrote: > On 7/5/22 5:35 PM, Mauro Carvalho Chehab wrote: > > On Tue, 5 Jul 2022 15:24:50 +0300 > > Gwan-gyeong Mun wrote: > > > >> From: Chris Wilson > >> > >> We need to check that we avoid integer overflows when looking up a page, > >> and

Re: [RFT][PATCH v2 3/9] vfio/ccw: Only pass in contiguous pages

2022-07-06 Thread Jason Gunthorpe
On Tue, Jul 05, 2022 at 11:27:53PM -0700, Nicolin Chen wrote: > This driver is the only caller of vfio_pin/unpin_pages that might pass > in a non-contiguous PFN list, but in many cases it has a contiguous PFN > list to process. So letting VFIO API handle a non-contiguous PFN list > is actually coun

Re: [PATCH v2 1/7] drm: Move and add a few utility macros into drm util header

2022-07-06 Thread Mauro Carvalho Chehab
On Wed, 6 Jul 2022 18:04:20 +0300 Gwan-gyeong Mun wrote: > On 7/5/22 5:23 PM, Mauro Carvalho Chehab wrote: > > On Tue, 5 Jul 2022 15:24:49 +0300 > > Gwan-gyeong Mun wrote: > > > >> It moves overflows_type utility macro into drm util header from i915_utils > >> header. The overflows_type can

[PATCH] drm: Fix EDID firmware load on resume

2022-07-06 Thread Matthieu CHARETTE
Loading an EDID using drm.edid_firmware parameter makes resume to fail after firmware cache is being cleaned. This is because edid_load() use a temporary device to request the firmware. This cause the EDID firmware not to be cached from suspend. And, requesting the EDID firmware return an error du

Re: [PATCH 2/4] dt-bindings: display/msm/gpu: document using the amd,imageon adreno too

2022-07-06 Thread Dmitry Baryshkov
On 06/07/2022 19:19, Krzysztof Kozlowski wrote: On 06/07/2022 18:00, Dmitry Baryshkov wrote: On 06/07/2022 18:50, Krzysztof Kozlowski wrote: On 06/07/2022 16:52, Dmitry Baryshkov wrote: The DT binding desribes using amd,imageon only for Imageon 2xx GPUs. We have been using amd,imageon with new

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-06 Thread Vinod Koul
On 05-07-22, 09:29, Kuogee Hsieh wrote: > 0) rebase on > https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree > 1) add regulator_set_load() to eDP phy > 2) add regulator_set_load() to DP phy > 3) remove vdda related function out of eDP/DP controller Applied, thanks -- ~Vinod

Re: [PATCH 1/2] iommu: arm-smmu-impl: Add 8250 display compatible to the client list.

2022-07-06 Thread Will Deacon
On Tue, 14 Jun 2022 16:01:35 -0700, Emma Anholt wrote: > Required for turning on per-process page tables for the GPU. > > Applied to will (for-joerg/arm-smmu/updates), thanks! [1/2] iommu: arm-smmu-impl: Add 8250 display compatible to the client list. https://git.kernel.org/will/c/3482c0b

Re: [RFT][PATCH v2 2/9] vfio/ap: Pass in physical address of ind to ap_aqic()

2022-07-06 Thread Jason Gunthorpe
On Tue, Jul 05, 2022 at 11:27:52PM -0700, Nicolin Chen wrote: > The ap_aqic() is called by vfio_ap_irq_enable() where it passes in a > virt value that's casted from a physical address "h_nib". Inside the > ap_aqic(), it does virt_to_phys() again. > > Since ap_aqic() needs a physical address, let's

Re: [RFT][PATCH v2 1/9] vfio: Make vfio_unpin_pages() return void

2022-07-06 Thread Jason Gunthorpe
On Tue, Jul 05, 2022 at 11:27:51PM -0700, Nicolin Chen wrote: > There's only one caller that checks its return value with a WARN_ON_ONCE, > while all other callers do not check return value at all. So simplify the > API to return void by embedding similar WARN_ON_ONCEs. > > Suggested-by: Christoph

Re: [PATCH v2 2/7] drm/i915/gem: Typecheck page lookups

2022-07-06 Thread Gwan-gyeong Mun
On 7/5/22 5:35 PM, Mauro Carvalho Chehab wrote: On Tue, 5 Jul 2022 15:24:50 +0300 Gwan-gyeong Mun wrote: From: Chris Wilson We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a mor

Re: [RFC 10/10] drm/i915/vm_bind: Fix vm->vm_bind_mutex and vm->mutex nesting

2022-07-06 Thread Ramalingam C
On 2022-07-05 at 10:40:56 +0200, Thomas Hellström wrote: > On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: > > VM_BIND functionality maintain that vm->vm_bind_mutex will never be > > taken > > while holding vm->mutex. > > However, while closing 'vm', vma is destroyed while holdi

Re: [RFC 02/10] drm/i915/vm_bind: Bind and unbind mappings

2022-07-06 Thread Thomas Hellström
On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: > Bind and unbind the mappings upon VM_BIND and VM_UNBIND calls. > > Signed-off-by: Niranjana Vishwanathapura > > Signed-off-by: Prathap Kumar Valsan > --- >  drivers/gpu/drm/i915/Makefile |   1 + >  drivers/gpu/

Re: [PATCH 2/4] dt-bindings: display/msm/gpu: document using the amd,imageon adreno too

2022-07-06 Thread Krzysztof Kozlowski
On 06/07/2022 18:00, Dmitry Baryshkov wrote: > On 06/07/2022 18:50, Krzysztof Kozlowski wrote: >> On 06/07/2022 16:52, Dmitry Baryshkov wrote: >>> The DT binding desribes using amd,imageon only for Imageon 2xx GPUs. We >>> have been using amd,imageon with newer (Adreno) GPUs to describe the >>> hea

[PATCH v2] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Kuogee Hsieh
Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the main panel. This patch call drm_helper_move_panel_connectors_to_head() after drm_bridge_connector_init() to make sure eDP stay at he

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Grab the runtime pm in shrink_thp

2022-07-06 Thread Andi Shyti
Hi, On Wed, Jul 06, 2022 at 04:47:38PM +0100, Matthew Auld wrote: > From: Chris Wilson > > Since we are not holding a wakeref, shrinking a bound object is not > guaranteed. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6370 > Signed-off-by: Chris Wilson > Signed-off-by: Matthew

Re: [PATCH 2/4] dt-bindings: display/msm/gpu: document using the amd,imageon adreno too

2022-07-06 Thread Dmitry Baryshkov
On 06/07/2022 18:50, Krzysztof Kozlowski wrote: On 06/07/2022 16:52, Dmitry Baryshkov wrote: The DT binding desribes using amd,imageon only for Imageon 2xx GPUs. We have been using amd,imageon with newer (Adreno) GPUs to describe the headless setup, when the platform does not (yet) have the disp

Re: [RFT][PATCH v2 4/9] vfio: Pass in starting IOVA to vfio_pin/unpin_pages API

2022-07-06 Thread Nicolin Chen
On Tue, Jul 05, 2022 at 11:56:25PM -0700, Christoph Hellwig wrote: > > - vfio_unpin_pages(&q->matrix_mdev->vdev, &q->saved_pfn, 1); > > + vfio_unpin_pages(&q->matrix_mdev->vdev, q->saved_pfn << > > PAGE_SHIFT, 1); > > Overly long line here. The following PATCH-5 drops the "<<

Re: [PATCH] drm/amd/display: remove repeated includes

2022-07-06 Thread Alex Deucher
Applied. Thanks! On Wed, Jul 6, 2022 at 9:49 AM Harry Wentland wrote: > > On 2022-07-06 05:13, Guo Zhengkui wrote: > > Remove a repeated "#include " > > > > Signed-off-by: Guo Zhengkui > > Reviewed-by: Harry Wentland > > Harry > > > --- > > drivers/gpu/drm/amd/display/dc/os_types.h | 2 -- > >

Re: [PATCH 4/4] dt-bindings: display/msm/mdp4: require 4 IOMMUs

2022-07-06 Thread Krzysztof Kozlowski
On 06/07/2022 16:52, Dmitry Baryshkov wrote: > APQ8064, the only supported mdp4 platform, uses 4 IOMMUs for the MDP4 > device. Update schema accordingly. When we have other MDP4 platforms, > this spec can be updated accordingly. > > Signed-off-by: Dmitry Baryshkov Acked-by: Krzysztof Kozlowski

Re: [PATCH 3/4] dt-bindings: display/msm/gmu: account for different GMU variants

2022-07-06 Thread Krzysztof Kozlowski
On 06/07/2022 16:52, Dmitry Baryshkov wrote: > Make display/msm/gmu.yaml describe all existing GMU variants rather than > just the 630.2 (SDM845) version of it. > > Signed-off-by: Dmitry Baryshkov > --- > .../devicetree/bindings/display/msm/gmu.yaml | 166 +++--- > 1 file changed, 1

Re: [RFT][PATCH v2 1/9] vfio: Make vfio_unpin_pages() return void

2022-07-06 Thread Nicolin Chen
On Tue, Jul 05, 2022 at 11:54:50PM -0700, Christoph Hellwig wrote: > > +void vfio_unpin_pages(struct vfio_device *device, unsigned long *user_pfn, > > + int npage) > > { > > struct vfio_container *container; > > struct vfio_iommu_driver *driver; > > - int ret; > > > > -

Re: [PATCH] drm/i915/selftests: Grab the runtime pm in shrink_thp

2022-07-06 Thread Matthew Auld
On Wed, 6 Jul 2022 at 16:48, Matthew Auld wrote: > > From: Chris Wilson > > Since we are not holding a wakeref, shrinking a bound object is not > guaranteed. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6370 > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld

Re: [PATCH 2/4] dt-bindings: display/msm/gpu: document using the amd,imageon adreno too

2022-07-06 Thread Krzysztof Kozlowski
On 06/07/2022 16:52, Dmitry Baryshkov wrote: > The DT binding desribes using amd,imageon only for Imageon 2xx GPUs. We > have been using amd,imageon with newer (Adreno) GPUs to describe the > headless setup, when the platform does not (yet) have the display DT Does not have "yet"? So later it will

[PATCH] drm/i915/selftests: Grab the runtime pm in shrink_thp

2022-07-06 Thread Matthew Auld
From: Chris Wilson Since we are not holding a wakeref, shrinking a bound object is not guaranteed. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6370 Signed-off-by: Chris Wilson Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 7 ++- 1 file cha

Re: [PATCH] drm/amdgpu/display: Remove duplicated argument to ||

2022-07-06 Thread Alex Deucher
Applied. Thanks! On Wed, Jul 6, 2022 at 3:41 AM Zhongjun Tan wrote: > > From: Zhongjun Tan > > Remove duplicated argument to || > > Signed-off-by: Zhongjun Tan > --- > .../gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

Re: [PATCH 1/4] dt-bindings: display/msm/gpu: allow specifying several IOMMU nodes

2022-07-06 Thread Krzysztof Kozlowski
On 06/07/2022 16:52, Dmitry Baryshkov wrote: > Different platforms require different amounts of IOMMUs. The APQ8064 > uses 64 IOMMU instances for GPU, adjust the schema accordingly. > > Signed-off-by: Dmitry Baryshkov > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-07-06 Thread Alex Deucher
On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky wrote: > > On 2022-07-06 03:07, Dmitry Osipenko wrote: > > > Hello Andrey, > > > > On 5/17/22 17:48, Dmitry Osipenko wrote: > >> On 5/17/22 17:13, Andrey Grodzovsky wrote: > >>> Done. > >>> > >>> Andrey > >> Awesome, thank you! > >> > > Given that t

[PATCH AUTOSEL 5.15 13/18] fbdev: Disable sysfb device registration when removing conflicting FBs

2022-07-06 Thread Sasha Levin
From: Javier Martinez Canillas [ Upstream commit ee7a69aa38d87a3bbced7b8245c732c05ed0c6ec ] The platform devices registered by sysfb match with firmware-based DRM or fbdev drivers, that are used to have early graphics using a framebuffer provided by the system firmware. DRM or fbdev drivers lat

[PATCH AUTOSEL 5.18 17/22] fbdev: Disable sysfb device registration when removing conflicting FBs

2022-07-06 Thread Sasha Levin
From: Javier Martinez Canillas [ Upstream commit ee7a69aa38d87a3bbced7b8245c732c05ed0c6ec ] The platform devices registered by sysfb match with firmware-based DRM or fbdev drivers, that are used to have early graphics using a framebuffer provided by the system firmware. DRM or fbdev drivers lat

[PATCH] drm/i915/gem: Really move i915_gem_context.link under ref protection

2022-07-06 Thread Andi Shyti
From: Chris Wilson i915_perf assumes that it can use the i915_gem_context reference to protect its i915->gem.contexts.list iteration. However, this requires that we do not remove the context from the list until after we drop the final reference and release the struct. If, as currently, we remove

Re: [PATCH v2 1/1] drm/bridge: ti-sn65dsi86: Use atomic variants of drm_bridge_funcs

2022-07-06 Thread Dave Stevenson
Hi Sam On Mon, 4 Jul 2022 at 17:18, Sam Ravnborg wrote: > > Move away from the deprecated enable/disable operations in > drm_bridge_funcs and enable atomic use. If you're moving to the atomic API, shouldn't you also be getting the mode from the provided state, rather than ti_sn_bridge_set_video_

Re: [PATCH] video: of_display_timing.h: include errno.h

2022-07-06 Thread Helge Deller
On 7/1/22 01:27, Stephen Boyd wrote: > Quoting Hsin-Yi Wang (2022-06-30 10:33:29) >> If CONFIG_OF is not enabled, default of_get_display_timing() returns an >> errno, so include the header. >> >> Fixes: 422b67e0b31a ("videomode: provide dummy inline functions for >> !CONFIG_OF") >> Suggested-by: S

Re: [PATCH v2 1/1] drm/bridge: ti-sn65dsi86: Use atomic variants of drm_bridge_funcs

2022-07-06 Thread Robert Foss
On Sun, 3 Jul 2022 at 20:40, Sam Ravnborg wrote: > > Move away from the deprecated enable/disable operations in > drm_bridge_funcs and enable atomic use. > > v3: > - Drop use of DRM_BRIDGE_STATE_OPS > > v2: > - fix build (kernel test robot ) > > Signed-off-by: Sam Ravnborg > Cc: Kieran Bingham

Re: [PATCH v2 1/7] drm: Move and add a few utility macros into drm util header

2022-07-06 Thread Gwan-gyeong Mun
On 7/5/22 5:23 PM, Mauro Carvalho Chehab wrote: On Tue, 5 Jul 2022 15:24:49 +0300 Gwan-gyeong Mun wrote: It moves overflows_type utility macro into drm util header from i915_utils header. The overflows_type can be used to catch the truncation between data types. And it adds safe_conversion

[PATCH v3 1/4] fbcon: Disallow setting font bigger than screen size

2022-07-06 Thread Helge Deller
Prevent that users set a font size which is bigger than the physical screen. It's unlikely this may happen (because screens are usually much larger than the fonts and each font char is limited to 32x32 pixels), but it may happen on smaller screens/LCD displays. Signed-off-by: Helge Deller Reviewe

[PATCH v3 4/4] fbcon: Use fbcon_info_from_console() in fbcon_modechange_possible()

2022-07-06 Thread Helge Deller
Use the fbcon_info_from_console() wrapper which was added to kernel v5.19 with commit 409d6c95f9c6 ("fbcon: Introduce wrapper for console->fb_info lookup"). Signed-off-by: Helge Deller Reviewed-by: Geert Uytterhoeven --- drivers/video/fbdev/core/fbcon.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v3 3/4] fbmem: Check virtual screen sizes in fb_set_var()

2022-07-06 Thread Helge Deller
Verify that the fbdev or drm driver correctly adjusted the virtual screen sizes. On failure report the failing driver and reject the screen size change. Signed-off-by: Helge Deller Cc: sta...@vger.kernel.org # v5.4+ --- drivers/video/fbdev/core/fbmem.c | 11 +++ 1 file changed, 11 insert

[PATCH v3 0/4] fbcon: Fixes for screen resolution changes

2022-07-06 Thread Helge Deller
This series fixes possible out-of-bound memory accesses when users trigger screen resolutions changes with invalid input parameters, e.g. reconfigures screen which is smaller than the current font size, or if the virtual screen size is smaller than the physical screen size. Changes in v3 (all feed

[PATCH v3 2/4] fbcon: Prevent that screen size is smaller than font size

2022-07-06 Thread Helge Deller
We need to prevent that users configure a screen size which is smaller than the currently selected font size. Otherwise rendering chars on the screen will access memory outside the graphics memory region. This patch adds a new function fbcon_modechange_possible() which implements this check and wh

Re: [PATCH v5 2/5] dt-bindings: display: bridge: cdns,dsi: Add compatible for dsi on j721e

2022-07-06 Thread Rob Herring
On Wed, 06 Jul 2022 17:10:50 +0530, Rahul T R wrote: > Add compatible to support dsi bridge on j721e > > Signed-off-by: Rahul T R > --- > .../bindings/display/bridge/cdns,dsi.yaml | 21 +++ > 1 file changed, 21 insertions(+) > Reviewed-by: Rob Herring

Re: [PATCH v5 1/5] dt-bindings: display: bridge: Convert cdns,dsi.txt to yaml

2022-07-06 Thread Rob Herring
On Wed, Jul 06, 2022 at 05:10:49PM +0530, Rahul T R wrote: > Convert cdns,dsi.txt binding to yaml format > > Signed-off-by: Rahul T R > --- > .../bindings/display/bridge/cdns,dsi.txt | 112 -- > .../bindings/display/bridge/cdns,dsi.yaml | 195 ++ > 2 files change

  1   2   >