Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-04 Thread Geert Uytterhoeven
Hi Helge, On Tue, Apr 5, 2022 at 8:34 AM Helge Deller wrote: > On 4/4/22 13:46, Geert Uytterhoeven wrote: > > On Sun, Apr 3, 2022 at 5:41 PM Helge Deller wrote: > >> On 4/3/22 13:26, Zheyu Ma wrote: > >>> I found a bug in the function i740fb_set_par(). > >> > >> Nice catch! > >> > >>> When the u

Re: Build regressions/improvements in v5.18-rc1

2022-04-04 Thread Kalle Valo
Geert Uytterhoeven writes: > On Mon, Apr 4, 2022 at 8:39 PM Kalle Valo wrote: >> Geert Uytterhoeven writes: >> >> /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: >> >> error: case label does not reduce to an integer constant: => 3798:2, >> >> 3809:2 >> > >> > arm64-gcc5.4/a

Re: Build regressions/improvements in v5.18-rc1

2022-04-04 Thread Geert Uytterhoeven
Hi Kalle, On Mon, Apr 4, 2022 at 8:39 PM Kalle Valo wrote: > Geert Uytterhoeven writes: > >> /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: > >> error: case label does not reduce to an integer constant: => 3798:2, > >> 3809:2 > > > > arm64-gcc5.4/arm64-allmodconfig > > powe

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-04 Thread Helge Deller
Hello Geert, On 4/4/22 13:46, Geert Uytterhoeven wrote: > Hi Helge, > > On Sun, Apr 3, 2022 at 5:41 PM Helge Deller wrote: >> On 4/3/22 13:26, Zheyu Ma wrote: >>> I found a bug in the function i740fb_set_par(). >> >> Nice catch! >> >>> When the user calls the ioctl system call without setting the

Re: [PATCH] drm/format_helper: fix a kernel-doc typo

2022-04-04 Thread Javier Martinez Canillas
On 4/5/22 08:12, Simon Ser wrote: > On Monday, April 4th, 2022 at 23:35, Randy Dunlap > wrote: > >> On 4/4/22 09:04, Simon Ser wrote: >> >>> Both doc patches pushed, thanks. I had to manually edit them because they >>> wouldn't apply cleanly. Next time, please use git-send-email (see >>> https:/

Re: [PATCH] drm/format_helper: fix a kernel-doc typo

2022-04-04 Thread Simon Ser
On Monday, April 4th, 2022 at 23:35, Randy Dunlap wrote: > On 4/4/22 09:04, Simon Ser wrote: > > > Both doc patches pushed, thanks. I had to manually edit them because they > > wouldn't apply cleanly. Next time, please use git-send-email (see > > https://git-send-email.io/ for setup instructions)

Re: [PATCH v2] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Christian König
Am 05.04.22 um 00:57 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state' was not declared. Should it be static? si_blit_shaders.c:253:11: warning: symbol 'si_default_size' was not declared. Should it be static? Both symbols are only used

linux-next: manual merge of the drm-intel tree with Linus' tree

2022-04-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/intel_device_info.h between commit: 5e3094cfd9fb ("drm/i915/xehpsdv: Add has_flat_ccs to device info") from Linus' tree and commit: 072ce4164f97 ("drm/i915/dg2: Tile 4 plane format support")

linux-next: manual merge of the drm-intel tree with Linus' tree

2022-04-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/i915_pci.c between commit: 132aaaf01788 ("drm/i915: add needs_compact_pt flag") from Linus' tree and commits: 072ce4164f97 ("drm/i915/dg2: Tile 4 plane format support") 412c942bdfae ("drm/i9

[PATCH v2] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Tom Rix
Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state' was not declared. Should it be static? si_blit_shaders.c:253:11: warning: symbol 'si_default_size' was not declared. Should it be static? Both symbols are only used in si.c. Single file symbols should be s

Re: [PATCH v2] drm/scheduler: quieten kernel-doc warnings

2022-04-04 Thread Andrey Grodzovsky
--- 2 files changed, 7 insertions(+), 5 deletions(-) --- linux-next-20220404.orig/drivers/gpu/drm/scheduler/sched_main.c +++ linux-next-20220404/drivers/gpu/drm/scheduler/sched_main.c @@ -198,7 +198,7 @@ static void drm_sched_job_done_cb(struct } /** - * drm_sched_dependency_optimized + * dr

Re: [Intel-gfx] [PATCH 15/15] drm/i915/xehp: Eliminate shared/implicit steering

2022-04-04 Thread Matt Roper
On Fri, Apr 01, 2022 at 09:34:04AM +0100, Tvrtko Ursulin wrote: > > On 31/03/2022 00:28, Matt Roper wrote: > > Historically we've selected and programmed a single MCR group/instance > > ID at driver startup that will steer register accesses for GSLICE/DSS > > ranges to a non-terminated instance.

Re: [PATCH] drm/format_helper: fix a kernel-doc typo

2022-04-04 Thread Randy Dunlap
Hi Simon, On 4/4/22 09:04, Simon Ser wrote: > Both doc patches pushed, thanks. I had to manually edit them because they > wouldn't apply cleanly. Next time, please use git-send-email (see > https://git-send-email.io/ for setup instructions). That's odd. I did use 'git send-email' and I don't usua

Re: [Intel-gfx] [PATCH 15/15] drm/i915/xehp: Eliminate shared/implicit steering

2022-04-04 Thread Matt Roper
On Thu, Mar 31, 2022 at 06:35:52PM +0100, Tvrtko Ursulin wrote: > > On 31/03/2022 00:28, Matt Roper wrote: > > Historically we've selected and programmed a single MCR group/instance > > ID at driver startup that will steer register accesses for GSLICE/DSS > > ranges to a non-terminated instance.

[PATCH v2] drm/scheduler: quieten kernel-doc warnings

2022-04-04 Thread Randy Dunlap
g --- Feel free to make changes or suggest changes... v2: drop @work description (already done by Andrey) drivers/gpu/drm/scheduler/sched_main.c |3 ++- include/drm/gpu_scheduler.h|9 +---- 2 files changed, 7 insertions(+), 5 deletions(-) --- linux-next-20220404.orig/drivers/

Re: [PATCH v6 8/8] drm/msm/dp: Handle eDP mode_valid differently from dp

2022-04-04 Thread Dmitry Baryshkov
On Mon, 4 Apr 2022 at 21:21, Sankeerth Billakanti (QUIC) wrote: > > Hi Doug, > > > On Wed, Mar 30, 2022 at 11:02 PM Sankeerth Billakanti (QUIC) > > wrote: > > > > > > Hi Dmitry, > > > > > > > On Wed, 30 Mar 2022 at 19:04, Sankeerth Billakanti > > > > wrote: > > > > > > > > > > The panel-edp driv

Re: [PATCH] clk: base: fix an incorrect NULL check on list iterator

2022-04-04 Thread Lyude Paul
This should probably be prefixed with the title "drm/nouveau/clk:", but I can fix that before pushing it. Reviewed-by: Lyude Paul Will push it to the appropriate repository shortly On Sun, 2022-03-27 at 15:58 +0800, Xiaomeng Tong wrote: > The bug is here: > if (nvkm_cstate_valid(clk, c

Re: [PATCH v6 7/8] drm/msm/dp: Support edp/dp without hpd

2022-04-04 Thread Dmitry Baryshkov
On Mon, 4 Apr 2022 at 21:32, Sankeerth Billakanti (QUIC) wrote: > > Hi Doug, > > > On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti > > wrote: > > > > > > Some eDP sinks or platform boards will not support hpd. > > > This patch adds support for those cases. > > > > You could say more, like: >

Re: [PATCH v6 6/8] drm/msm/dp: remove unnecessary delay during boot

2022-04-04 Thread Dmitry Baryshkov
On Mon, 4 Apr 2022 at 16:53, Sankeerth Billakanti (QUIC) wrote: > > Hi Doug, > > > On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti > > wrote: > > > > > > Remove the unnecessary delay in executing the EV_HPD_INIT_SETUP > > event. > > > > Tell me more and put it in the commit message! Why did

Re: [Intel-gfx] [PATCH 14/15] drm/i915: Define multicast registers as a new type

2022-04-04 Thread Matt Roper
On Fri, Apr 01, 2022 at 08:55:19AM +0100, Tvrtko Ursulin wrote: > > On 31/03/2022 00:28, Matt Roper wrote: > > Rather than treating multicast registers as 'i915_reg_t' let's define > > them as a completely new type. This will allow the compiler to help us > > make sure we're using multicast-aware

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-04 Thread Doug Anderson
Hi, On Sat, Apr 2, 2022 at 1:26 PM Dmitry Baryshkov wrote: > > On Sat, 2 Apr 2022 at 20:06, Doug Anderson wrote: > > > > Hi, > > > > On Sat, Apr 2, 2022 at 3:37 AM Dmitry Baryshkov > > wrote: > > > > > > On 01/04/2022 02:22, Doug Anderson wrote: > > > > Hi, > > > > > > > > On Wed, Mar 30, 2022

[PATCH v5 9/9] drm: vkms: Add support to the RGB565 format

2022-04-04 Thread Igor Torrente
Adds this common format to vkms. This commit also adds new helper macros to deal with fixed-point arithmetic. It was done to improve the precision of the conversion to ARGB16161616 since the "conversion ratio" is not an integer. V3: Adapt the handlers to the new format introduced in patch 7 V3.

[PATCH v5 8/9] drm: vkms: Adds XRGB_16161616 and ARGB_1616161616 formats

2022-04-04 Thread Igor Torrente
This will be useful to write tests that depends on these formats. ARGB and XRGB follows the a similar implementation of the former formats. Just adjusting for 16 bits per channel. V3: Adapt the handlers to the new format introduced in patch 7 V3. V5: Minor improvements Added le16_to_cpu/cpu_t

[PATCH v5 7/9] drm: vkms: Supports to the case where primary plane doesn't match the CRTC

2022-04-04 Thread Igor Torrente
We will break the current assumption that the primary plane has the same size and position as CRTC. For that we will add CRTC dimension information to `vkms_crtc_state` and add a opaque black backgound color. Because now we need to fill the background, we had a loss in performance with this chang

[PATCH v5 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-04-04 Thread Igor Torrente
Currently the blend function only accepts XRGB_ and ARGB_ as a color input. This patch refactors all the functions related to the plane composition to overcome this limitation. A new internal format(`struct pixel`) is introduced to deal with all possible inputs. It consists of 16 bits fie

[PATCH v5 5/9] drm: vkms: Add fb information to `vkms_writeback_job`

2022-04-04 Thread Igor Torrente
This commit is the groundwork to introduce new formats to the planes and writeback buffer. As part of it, a new buffer metadata field is added to `vkms_writeback_job`, this metadata is represented by the `vkms_composer` struct. Also adds two new function pointers (`{wb,plane}_format_transform_func

[PATCH v5 4/9] drm: drm_atomic_helper: Add a new helper to deal with the writeback connector validation

2022-04-04 Thread Igor Torrente
Add a helper function to validate the connector configuration receive in the encoder atomic_check by the drivers. So the drivers don't need do these common validations themselves. V2: Move the format verification to a new helper at the drm_atomic_helper.c (Thomas Zimmermann). V3: Format check

[PATCH v5 3/9] drm: vkms: Rename `vkms_composer` to `vkms_frame_info`

2022-04-04 Thread Igor Torrente
Changes the name of this struct to a more meaningful name. A name that represents better what this struct is about. Composer is the code that do the compositing of the planes. This struct contains information on the frame used in the output composition. Thus, vkms_frame_info is a better name to re

[PATCH v5 2/9] drm: vkms: Replace hardcoded value of `vkms_composer.map` to DRM_FORMAT_MAX_PLANES

2022-04-04 Thread Igor Torrente
The `map` vector at `vkms_composer` uses a hardcoded value to define its size. If someday the maximum number of planes increases, this hardcoded value can be a problem. This value is being replaced with the DRM_FORMAT_MAX_PLANES macro. Acked-by: Thomas Zimmermann Reviewed-by: Melissa Wen Signe

[PATCH v5 1/9] drm: vkms: Alloc the compose frame using vzalloc

2022-04-04 Thread Igor Torrente
Currently, the memory to the composition frame is being allocated using the kzmalloc. This comes with the limitation of maximum size of one page size(which in the x86_64 is 4Kb and 4MB for default and hugepage respectively). Somes test of igt (e.g. kms_plane@pixel-format) uses more than 4MB when t

[PATCH v5 0/9] Add new formats support to vkms

2022-04-04 Thread Igor Torrente
Summary === This series of patches refactor some vkms components in order to introduce new formats to the planes and writeback connector. Now in the blend function, the plane's pixels are converted to ARGB16161616 and then blended together. The CRC is calculated based on the ARGB1616161616 bu

[PATCH] fbdev: Fix unregistering of framebuffers without device

2022-04-04 Thread Thomas Zimmermann
OF framebuffers do not have an underlying device in the Linux device hierarchy. Do a regular unregister call instead of hot unplugging such a non-existing device. Fixes a NULL dereference. An example error message on ppc64le is shown below. BUG: Kernel NULL pointer dereference on read at 0x0

Re: [pull] amdgpu, amdkfd drm-next-5.18

2022-04-04 Thread Alex Deucher
On Fri, Mar 25, 2022 at 2:36 PM Alex Deucher wrote: > > Hi Dave, Daniel, > > Fixes for 5.18. Just wanted to make sure this didn't get missed. This fixes some warning splat reported by Linus, et al. Alex > > The following changes since commit c6e90a1c660874736bd09c1fec6312b4b4c2ff7b: > > Merg

Re: AMDGPU: regression on 5.17.1

2022-04-04 Thread Michele Ballabio
On Mon, 4 Apr 2022 13:03:41 -0400 Alex Deucher wrote: > On Sun, Apr 3, 2022 at 10:19 AM Michele Ballabio > wrote: > > > > Hi, > > I've hit a regression on 5.17.1 (haven't tested 5.17.0, but > > 5.16-stable didn't have this problem). > > > > The machine is a Ryzen 5 1600 with AMD graphics

Re: [PATCH 1/2] dt-bindings: display: bridge: lt9211: Add Lontium LT9211 bridge driver

2022-04-04 Thread Rob Herring
On Wed, Mar 30, 2022 at 11:22:30PM +0200, Marek Vasut wrote: > Add bindings for Lontium LT9211 Single/Dual-Link DSI/LVDS or Single DPI to > Single-link/Dual-Link DSI/LVDS or Single DPI bridge. This chip is highly > capable at converting formats, but sadly it is also highly undocumented. > > Signed

Re: [RFC][PATCH 2/3] drm/modes: Make width-mm/height-mm mandatory in of_get_drm_panel_display_mode()

2022-04-04 Thread Marek Vasut
On 4/4/22 18:01, Rob Herring wrote: On Sat, Apr 02, 2022 at 07:55:59PM +0200, Marek Vasut wrote: On 4/2/22 19:08, Noralf Trønnes wrote: Den 02.04.2022 18.39, skrev Marek Vasut: On 4/2/22 09:45, Noralf Trønnes wrote: Den 02.04.2022 06.28, skrev Marek Vasut: On 4/2/22 05:19, Laurent Pincha

Re: [PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages only

2022-04-04 Thread Sierra Guiza, Alejandro (Alex)
On 4/4/2022 12:38 PM, Jason Gunthorpe wrote: On Fri, Apr 01, 2022 at 04:08:35PM -0400, Felix Kuehling wrote: In general I find the vm_normal_lru_page vs vm_normal_page API highly confusing. An explicit check for zone device pages in the dozen or so spots that care has a much better documenta

[PATCH] dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory

2022-04-04 Thread Marek Vasut
Make the width-mm/height-mm panel properties mandatory to correctly report the panel dimensions to the OS. Fixes: 2f3468b82db97 ("dt-bindings: display: add bindings for MIPI DBI compatible SPI panels") Signed-off-by: Marek Vasut Cc: Christoph Niedermaier Cc: Daniel Vetter Cc: Dmitry Osipenko

Re: [PATCH v6 4/4] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-04 Thread Rob Clark
On Fri, Apr 1, 2022 at 8:38 AM Laurent Pinchart wrote: > > Hi Abhinav, > > Thank you for the patch. > > On Thu, Mar 31, 2022 at 05:12:13PM -0700, Abhinav Kumar wrote: > > For some vendor driver implementations, display hardware can > > be shared between the encoder used for writeback and the physi

Re: Build regressions/improvements in v5.18-rc1

2022-04-04 Thread Kalle Valo
Geert Uytterhoeven writes: >> /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: >> error: case label does not reduce to an integer constant: => 3798:2, >> 3809:2 > > arm64-gcc5.4/arm64-allmodconfig > powerpc-gcc5/powerpc-allmodconfig > powerpc-gcc5/ppc64_book3e_allmodconfig Af

RE: [PATCH v6 7/8] drm/msm/dp: Support edp/dp without hpd

2022-04-04 Thread Sankeerth Billakanti (QUIC)
Hi Doug, > On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti > wrote: > > > > Some eDP sinks or platform boards will not support hpd. > > This patch adds support for those cases. > > You could say more, like: > > If we're not using HPD then _both_ the panel node and the eDP controller > node

[PATCH] drm/atomic: Convert a warning to dbg atomic printk

2022-04-04 Thread Zack Rusin
From: Zack Rusin By default each flip times out after 0.1 sec and a warning about the time out is added to the kernel log. The warning is harmless because there's another flip coming right after but it can quickly fill up the log, e.g. missing 2 flips every second over a 24 hour span will add abo

RE: [PATCH v6 8/8] drm/msm/dp: Handle eDP mode_valid differently from dp

2022-04-04 Thread Sankeerth Billakanti (QUIC)
Hi Doug, > On Wed, Mar 30, 2022 at 11:02 PM Sankeerth Billakanti (QUIC) > wrote: > > > > Hi Dmitry, > > > > > On Wed, 30 Mar 2022 at 19:04, Sankeerth Billakanti > > > wrote: > > > > > > > > The panel-edp driver modes needs to be validated differently from > > > > DP because the link capabilities

RE: [PATCH v6 4/8] drm/msm/dp: avoid handling masked interrupts

2022-04-04 Thread Sankeerth Billakanti (QUIC)
> On Thu, 31 Mar 2022 at 14:05, Sankeerth Billakanti > wrote: > > > > Hi Dmitry, > > > > > On 31/03/2022 08:53, Sankeerth Billakanti (QUIC) wrote: > > > > Hi Dmitry, > > > > > > > >> On Wed, 30 Mar 2022 at 19:03, Sankeerth Billakanti > > > >> wrote: > > > >>> > > > >>> The interrupt register will

Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI)

2022-04-04 Thread Rob Herring
On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote: > Change bus-type define for DPI. > > Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define") > > Signed-off-by: Xin Ji > --- > .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 4 ++-- > 1 file changed, 2 in

Re: [RFC v4 2/8] cgroup: gpu: Add a cgroup controller for allocator attribution of GPU memory

2022-04-04 Thread Tejun Heo
Hello, On Wed, Mar 30, 2022 at 01:56:09PM -0700, T.J. Mercier wrote: > The use case we have for accounting the total (separate from the > individual devices) is to include the value as part of bugreports, for > understanding the system-wide amount of dmabuf allocations. I'm not > aware of an exist

Re: [PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages only

2022-04-04 Thread Jason Gunthorpe
On Fri, Apr 01, 2022 at 04:08:35PM -0400, Felix Kuehling wrote: > > In general I find the vm_normal_lru_page vs vm_normal_page > > API highly confusing. An explicit check for zone device pages > > in the dozen or so spots that care has a much better documentation > > value, especially if accompan

Re: AMDGPU: regression on 5.17.1

2022-04-04 Thread Alex Deucher
On Sun, Apr 3, 2022 at 10:19 AM Michele Ballabio wrote: > > Hi, > I've hit a regression on 5.17.1 (haven't tested 5.17.0, but > 5.16-stable didn't have this problem). > > The machine is a Ryzen 5 1600 with AMD graphics (RX 560). > > The regression I hit seems to trigger when the machine is

Re: [PATCH v2 4/4] drm/msm/dp: make dp_connector_mode_valid() more precise

2022-04-04 Thread Kuogee Hsieh
On 3/30/2022 3:30 PM, Dmitry Baryshkov wrote: Make dp_connector_mode_valid() return precise MODE_CLOCK_HIGH rather than generic MODE_BAD in case the mode clock is higher than DP_MAX_PIXEL_CLK_KHZ (675 MHz). Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Kuogee Hsieh drivers/gpu/drm/ms

Re: [PATCH 2/4] dt-bindings: display: ssd1307fb: Add entry for SINO WEALTH SH1106

2022-04-04 Thread Javier Martinez Canillas
On 4/4/22 18:11, Chen-Yu Tsai wrote: [snip] >>> >> >> tl; dr: unfortunately we can't do it due how SPI and I2C report module >> aliases. Otherwise module auto loading will not work. I wrote a much >> longer explanation with some details not so long ago: >> >> https://patchwork.kernel.org/project/

Re: [PATCH 4/4] drm: ssd130x: Add support for SINO WEALTH SH1106

2022-04-04 Thread Javier Martinez Canillas
On 4/4/22 18:35, Chen-Yu Tsai wrote: > On Fri, Apr 1, 2022 at 6:10 PM Javier Martinez Canillas > wrote: [snip] >> >> I wonder if we should also list SH1106 in the >> drivers/gpu/drm/solomon/Kconfig file so people can find it ? > > I can add it to the help text if that helps? > No strong opinio

[linux-next:master] BUILD REGRESSION 696206280c5e5c028caf9fd259999cb72b1f6127

2022-04-04 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 696206280c5e5c028caf9fd25cb72b1f6127 Add linux-next specific files for 20220404 Error/Warning reports: https://lore.kernel.org/linux-media/202203170501.ahquekof-...@intel.com https

Re: [PATCH 4/4] drm: ssd130x: Add support for SINO WEALTH SH1106

2022-04-04 Thread Chen-Yu Tsai
On Fri, Apr 1, 2022 at 6:10 PM Javier Martinez Canillas wrote: > > On Wed, Mar 30, 2022 at 9:09 PM Chen-Yu Tsai wrote: > > > > From: Chen-Yu Tsai > > > > The SINO WEALTH SH1106 is an OLED display driver that is somewhat > > compatible with the SSD1306. It supports a slightly wider display, > > a

[PATCH v6 14/14] drm/msm/dsi: Add support for DSC configuration

2022-04-04 Thread Vinod Koul
When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-off-by: Dmitry Baryshkov Signed-off-by: Vi

[PATCH v6 13/14] drm/msm: Update generated headers

2022-04-04 Thread Vinod Koul
Update headers from mesa commit: commit 28ae397be111c37c6ced397e12d453a7695701bd Author: Vinod Koul Date: Fri Apr 1 16:53:04 2022 +0530 freedreno/registers: update dsi registers to support dsc Display Stream compression (DSC) compresses the display stream in host which

[PATCH v6 12/14] drm/msm/dsi: add mode valid callback for dsi_mgr

2022-04-04 Thread Vinod Koul
Add a mode valid callback for dsi_mgr for checking mode being valid in case of DSC. For DSC the height and width needs to be multiple of slice, so we check that here Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi.h |

[PATCH v6 11/14] drm/msm/disp/dpu1: Add DSC support in RM

2022-04-04 Thread Vinod Koul
This add the bits in RM to enable the DSC blocks Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 56 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h

[PATCH v6 10/14] drm/msm/disp/dpu1: Add support for DSC in topology

2022-04-04 Thread Vinod Koul
For DSC to work we typically need a 2,2,1 configuration. This should suffice for resolutions up to 4k. For more resolutions like 8k this won't work. Also, it is better to use 2 LMs and DSC instances as half width results in lesser power consumption as compared to single LM, DSC at full width. The

[PATCH v6 09/14] drm/msm: Add missing num_dspp field documentation

2022-04-04 Thread Vinod Koul
Somehow documentation for num_dspp was missed, so add that Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/msm_drv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h inde

[PATCH v6 08/14] drm/msm/dpu: don't use merge_3d if DSC merge topology is used

2022-04-04 Thread Vinod Koul
From: Dmitry Baryshkov DPU supports different topologies for the case when multiple INTFs are being driven by the single phys_enc. The driver defaults to using 3DMux in such cases. Don't use it if DSC merge is used instead. Suggested-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov Signed-off

[PATCH v6 07/14] drm/msm/disp/dpu1: Add support for DSC in encoder

2022-04-04 Thread Vinod Koul
We need to configure the encoder for DSC configuration and calculate DSC parameters for the given timing so this patch adds that support by adding dpu_encoder_prep_dsc() which is invoked when DSC is enabled. Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul ---

[PATCH v6 06/14] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2022-04-04 Thread Vinod Koul
Later gens of hardware have DSC bits moved to hw_ctl, so configure these bits so that DSC would work there as well Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 11 ++- drivers/gpu/drm/msm/disp/dpu1/d

[PATCH v6 05/14] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2022-04-04 Thread Vinod Koul
This adds SDM845 DSC blocks into hw_catalog Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 20 +++ 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog

[PATCH v6 04/14] drm/msm/disp/dpu1: Add support for DSC in pingpong block

2022-04-04 Thread Vinod Koul
In SDM845, DSC can be enabled by writing to pingpong block registers, so add support for DSC in hw_pp Reviewed-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32 +++ .../gpu/drm/msm/disp/dpu1/dpu_hw_

[PATCH v6 03/14] drm/msm/disp/dpu1: Add support for DSC

2022-04-04 Thread Vinod Koul
Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Reviewed-by: Dmitry Baryshkov Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/Makefile | 1 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 13 ++ drivers/gpu/drm/

[PATCH v6 02/14] drm/msm/dsi: Pass DSC params to drm_panel

2022-04-04 Thread Vinod Koul
When DSC is enabled, we need to get the DSC parameters from the panel driver, so add a dsc parameter in panel to fetch and pass DSC configuration for DSI panels to DPU encoder, which will enable and then configure DSC hardware blocks accordingly. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhin

[PATCH v6 01/14] drm/msm/dsi: add support for dsc data

2022-04-04 Thread Vinod Koul
Display Stream Compression (DSC) parameters need to be calculated. Add helpers and struct msm_display_dsc_config in msm_drv for this msm_display_dsc_config uses drm_dsc_config for DSC parameters. Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- drivers/gpu

[PATCH v6 00/14] drm/msm: Add Display Stream Compression Support

2022-04-04 Thread Vinod Koul
Display Stream Compression (DSC) compresses the display stream in host which is later decoded by panel. This series enables this for Qualcomm msm driver. This was tested on Google Pixel3 phone which use LGE SW43408 panel. The changes include DSC data and hardware block enabling for DPU1 then supp

Re: [PATCH 2/4] dt-bindings: display: ssd1307fb: Add entry for SINO WEALTH SH1106

2022-04-04 Thread Chen-Yu Tsai
On Mon, Apr 4, 2022 at 11:48 PM Javier Martinez Canillas wrote: > > Hello Chen-Yu, > > On 4/4/22 17:06, Chen-Yu Tsai wrote: > > [snip] > > >>> enum: > >>> + - sinowealth,sh1106-i2c > >> > >> I like that you didn't include a "fb" suffix for this, the existing > >> ones are cargo culting f

Re: [PATCH] drm/format_helper: fix a kernel-doc typo

2022-04-04 Thread Simon Ser
Both doc patches pushed, thanks. I had to manually edit them because they wouldn't apply cleanly. Next time, please use git-send-email (see https://git-send-email.io/ for setup instructions).

Re: [RFC][PATCH 2/3] drm/modes: Make width-mm/height-mm mandatory in of_get_drm_panel_display_mode()

2022-04-04 Thread Rob Herring
On Sat, Apr 02, 2022 at 07:55:59PM +0200, Marek Vasut wrote: > On 4/2/22 19:08, Noralf Trønnes wrote: > > > > > > Den 02.04.2022 18.39, skrev Marek Vasut: > > > On 4/2/22 09:45, Noralf Trønnes wrote: > > > > > > > > > > > > Den 02.04.2022 06.28, skrev Marek Vasut: > > > > > On 4/2/22 05:19, Lau

Re: [PATCH] drm/amd/display: cleanup extern usage in function definition

2022-04-04 Thread Harry Wentland
On 2022-04-04 11:43, Tom Rix wrote: > > On 4/4/22 8:22 AM, Harry Wentland wrote: >> >> On 2022-04-03 10:21, Tom Rix wrote: >>> Smatch reports this issue >>> hdcp1_execution.c:500:29: warning: function >>>    'mod_hdcp_hdcp1_dp_execution' with external linkage >>>    has definition >>> >> Which

Re: [PATCH 7/7] video: fbdev: s3fb: Error out if 'pixclock' equals zero

2022-04-04 Thread Geert Uytterhoeven
On Mon, Apr 4, 2022 at 3:50 PM Zheyu Ma wrote: > The userspace program could pass any values to the driver through > ioctl() interface. If the driver doesn't check the value of 'pixclock', > it may cause divide error. > > Fix this by checking whether 'pixclock' is zero in s3fb_check_var(). > > The

Re: [PATCH 6/7] video: fbdev: arkfb: Error out if 'pixclock' equals zero

2022-04-04 Thread Geert Uytterhoeven
On Mon, Apr 4, 2022 at 3:10 PM Zheyu Ma wrote: > The userspace program could pass any values to the driver through > ioctl() interface. If the driver doesn't check the value of 'pixclock', > it may cause divide error. > > Fix this by checking whether 'pixclock' is zero. > > The following log revea

Re: [PATCH] drm/format_helper: fix a kernel-doc typo

2022-04-04 Thread Javier Martinez Canillas
Hello Randy, On 4/4/22 01:29, Randy Dunlap wrote: > It looks like the incorrect name of a function parameter was used > in the kernel-doc notation, so just change it to the function's > parameter name to quell the kernel-doc warning. > > drivers/gpu/drm/drm_format_helper.c:640: warning: Function

Re: [PATCH 2/4] dt-bindings: display: ssd1307fb: Add entry for SINO WEALTH SH1106

2022-04-04 Thread Javier Martinez Canillas
Hello Chen-Yu, On 4/4/22 17:06, Chen-Yu Tsai wrote: [snip] >>> enum: >>> + - sinowealth,sh1106-i2c >> >> I like that you didn't include a "fb" suffix for this, the existing >> ones are cargo culting from the previous fbdev driver to make existing >> DTBs compatible with the DRM driver.

Re: [PATCH] drm/amd/display: cleanup extern usage in function definition

2022-04-04 Thread Tom Rix
On 4/4/22 8:22 AM, Harry Wentland wrote: On 2022-04-03 10:21, Tom Rix wrote: Smatch reports this issue hdcp1_execution.c:500:29: warning: function 'mod_hdcp_hdcp1_dp_execution' with external linkage has definition Which branch are you using? linux-next from 4/1 Tom I don't see t

Re: [Intel-gfx] [PATCH] drm/i915/display/debugfs: Add connector debugfs for "output_bpc"

2022-04-04 Thread Daniel Vetter
On Mon, Apr 04, 2022 at 01:46:23PM +0300, Jani Nikula wrote: > On Mon, 04 Apr 2022, "Modem, Bhanuprakash" > wrote: > > On Fri-01-04-2022 06:10 pm, Jani Nikula wrote: > >> On Tue, 29 Mar 2022, Bhanuprakash Modem > >> wrote: > >>> This new debugfs will expose the connector's max supported bpc > >

Re: [PATCH] drm/scheduler: quieten kernel-doc warnings

2022-04-04 Thread Andrey Grodzovsky
Seems to me better this way to avoid merge conflicts ? Andrey On 2022-04-04 11:33, Randy Dunlap wrote: On 4/4/22 07:34, Andrey Grodzovsky wrote: On 2022-04-04 00:25, Randy Dunlap wrote: Fix kernel-doc warnings in gpu_scheduler.h and sched_main.c. Quashes these warnings: include/drm/gpu_sc

Re: [PATCH 1/3] drm/vmwgfx: Add debugfs entries for ttm placements

2022-04-04 Thread Daniel Vetter
On Fri, Apr 01, 2022 at 04:56:00PM -0400, Zack Rusin wrote: > From: Zack Rusin > > Add a few debugfs entries for every used TTM placement that vmwgfx is > using. This allows basic tracking of memory usage inside vmwgfx, e.g. > 'cat /sys/kernel/debug/dri/0/mob_ttm' will display mob memory usage. >

Re: [Intel-gfx] [CI 8/8] drm/i915: Expose client engine utilisation via fdinfo

2022-04-04 Thread Daniel Vetter
On Mon, Apr 04, 2022 at 10:23:53AM +0100, Tvrtko Ursulin wrote: > > + Dave and Daniel > > Guys, are you okay with merging this via drm-intel-gt-next? It is one new > file at Documentation/gpu/drm-usage-stats.rst only which is outside i915. It > has acks from Christian and Rob. Acked-by: Daniel V

Re: [PATCH 2/4] drm/gem: Delete gem array fencing helpers

2022-04-04 Thread Daniel Vetter
On Mon, Apr 04, 2022 at 03:30:59PM +0200, Christian König wrote: > Am 04.04.22 um 15:15 schrieb Daniel Vetter: > > On Thu, Mar 31, 2022 at 10:46:49PM +0200, Daniel Vetter wrote: > > > Integrated into the scheduler now and all users converted over. > > > > > > v2: Rebased over changes from König. >

Re: [PATCH] drm/scheduler: quieten kernel-doc warnings

2022-04-04 Thread Randy Dunlap
On 4/4/22 07:34, Andrey Grodzovsky wrote: > On 2022-04-04 00:25, Randy Dunlap wrote: >> Fix kernel-doc warnings in gpu_scheduler.h and sched_main.c. >> >> Quashes these warnings: >> >> include/drm/gpu_scheduler.h:316: warning: Function parameter or member >> 'work' not described in 'drm_sched_j

Re: [PATCH] drm/amd/display: cleanup extern usage in function definition

2022-04-04 Thread Harry Wentland
On 2022-04-03 10:21, Tom Rix wrote: > Smatch reports this issue > hdcp1_execution.c:500:29: warning: function > 'mod_hdcp_hdcp1_dp_execution' with external linkage > has definition > Which branch are you using? I don't see the 'extern' on https://gitlab.freedesktop.org/agd5f/linux/-/blob/

Re: [PATCH 2/4] dt-bindings: display: ssd1307fb: Add entry for SINO WEALTH SH1106

2022-04-04 Thread Chen-Yu Tsai
On Fri, Apr 1, 2022 at 5:32 PM Javier Martinez Canillas wrote: > > Hello Chen-Yu, > > Thanks a lot for your patch. > > On Wed, Mar 30, 2022 at 9:09 PM Chen-Yu Tsai wrote: > > > > From: Chen-Yu Tsai > > > > The SINO WEALTH SH1106 is an OLED display driver that is somewhat > > compatible with the

Re: [PATCH] drm/scheduler: quieten kernel-doc warnings

2022-04-04 Thread Andrey Grodzovsky
On 2022-04-04 00:25, Randy Dunlap wrote: Fix kernel-doc warnings in gpu_scheduler.h and sched_main.c. Quashes these warnings: include/drm/gpu_scheduler.h:316: warning: Function parameter or member 'work' not described in 'drm_sched_job' Looks good to me except one point is that I already com

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Tom Rix
On 4/4/22 6:32 AM, Christian König wrote: Am 04.04.22 um 15:01 schrieb Tom Rix: On 4/4/22 5:34 AM, Christian König wrote: Am 04.04.22 um 14:32 schrieb Tom Rix: On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:1

RE: [PATCH v6 6/8] drm/msm/dp: remove unnecessary delay during boot

2022-04-04 Thread Sankeerth Billakanti (QUIC)
Hi Doug, > On Wed, Mar 30, 2022 at 9:04 AM Sankeerth Billakanti > wrote: > > > > Remove the unnecessary delay in executing the EV_HPD_INIT_SETUP > event. > > Tell me more and put it in the commit message! Why did it used to be > necessary and why is it no longer necessary? Inquiring minds want t

[PATCH 3/4] drm/fourcc: Introduce format modifier for DG2 clear color

2022-04-04 Thread Imre Deak
From: Mika Kahola DG2 clear color render compression uses Tile4 layout. Therefore, we need to define a new format modifier for uAPI to support clear color rendering. v2: Display version is fixed. [Imre] KDoc is enhanced for cc modifier. [Nanley & Lionel] v3: Split out the modifier addition

[PATCH 1/4] drm/fourcc: Introduce format modifiers for DG2 render and media compression

2022-04-04 Thread Imre Deak
From: Matt Roper The render/media engines on DG2 unify render compression and media compression into a single format for the first time, using the Tile 4 layout for main surfaces. The compression algorithm is different from any previous platform and the display engine must still be configured to

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Christian König
Am 04.04.22 um 15:01 schrieb Tom Rix: On 4/4/22 5:34 AM, Christian König wrote: Am 04.04.22 um 14:32 schrieb Tom Rix: On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state'    was

Re: [PATCH 4/4] drm/etnaviv: Don't break exclusive fence ordering

2022-04-04 Thread Christian König
Am 04.04.22 um 15:14 schrieb Daniel Vetter: On Thu, 31 Mar 2022 at 22:46, Daniel Vetter wrote: There's only one exclusive slot, and we must not break the ordering. Adding a new exclusive fence drops all previous fences from the dma_resv. To avoid violating the signalling order we err on the

Re: [PATCH 2/4] drm/gem: Delete gem array fencing helpers

2022-04-04 Thread Christian König
Am 04.04.22 um 15:15 schrieb Daniel Vetter: On Thu, Mar 31, 2022 at 10:46:49PM +0200, Daniel Vetter wrote: Integrated into the scheduler now and all users converted over. v2: Rebased over changes from König. Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zim

Re: [PATCH 2/4] drm/gem: Delete gem array fencing helpers

2022-04-04 Thread Daniel Vetter
On Thu, Mar 31, 2022 at 10:46:49PM +0200, Daniel Vetter wrote: > Integrated into the scheduler now and all users converted over. > > v2: Rebased over changes from König. > > Signed-off-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie >

Re: [PATCH 4/4] drm/etnaviv: Don't break exclusive fence ordering

2022-04-04 Thread Daniel Vetter
On Thu, 31 Mar 2022 at 22:46, Daniel Vetter wrote: > > There's only one exclusive slot, and we must not break the ordering. > Adding a new exclusive fence drops all previous fences from the > dma_resv. To avoid violating the signalling order we err on the side of > over-synchronizing by waiting fo

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Tom Rix
On 4/4/22 5:34 AM, Christian König wrote: Am 04.04.22 um 14:32 schrieb Tom Rix: On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state'    was not declared. Should it be static? s

RE: [PATCH v6 3/8] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-04-04 Thread Sankeerth Billakanti (QUIC)
Hi Doug, > On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti > wrote: > > > > @@ -1374,6 +1382,12 @@ static int dp_pm_resume(struct device *dev) > > dp_catalog_ctrl_hpd_config(dp->catalog); > > > > > > + if (dp->dp_display.connector_type == > DRM_MODE_CONNECTOR_DisplayPort) > > +

RE: [PATCH v6 2/8] drm/msm/dp: wait for hpd high before aux transaction

2022-04-04 Thread Sankeerth Billakanti (QUIC)
Hi Doug, > On Wed, Mar 30, 2022 at 9:03 AM Sankeerth Billakanti > wrote: > > > > The source device should ensure the sink is ready before proceeding to > > read the sink capability or performing any aux transactions. The sink > > s/performing/perform > > > will indicate its readiness by asserti

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Christian König
Am 04.04.22 um 14:32 schrieb Tom Rix: On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state'    was not declared. Should it be static? si_blit_shaders.c:253:11: warning: symbol 'si_

Re: [PATCH] gpu: host1x: Do not use mapping cache for job submissions

2022-04-04 Thread Jon Hunter
On 24/03/2022 10:30, Thierry Reding wrote: From: Thierry Reding Buffer mappings used in job submissions are usually small and not rapidly reused as opposed to framebuffers (which are usually large and rapidly reused, for example when page-flipping between double-buffered framebuffers). Avoid

  1   2   >