Re: [PATCH 32/40] drm/amd/display/amdgpu_dm/amdgpu_dm: Mark 'link_bandwidth_kbps' as __maybe_unused

2020-11-30 Thread Lee Jones
On Mon, 30 Nov 2020, Alex Deucher wrote: > On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > > > 'link_bandwidth_kbps' is always obtained, but only used if > > CONFIG_DRM_AMD_DC_DCN is defined. > > Probably better to just move this under CONFIG_DRM_AMD_DC_DCN. I'll > send a patch. I conside

[GIT PULL] exynos-drm-next

2020-11-30 Thread Inki Dae
Hi Dave, Just a new mode support for HDMI and two clenups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 22f8c80566c4a29a0d8b5ebf24aa1fd1679b39e5: Merge tag 'drm-misc-next-2020-11-18' of ssh://git.freedesktop.org/git/drm/drm-mi

Re: [PATCH v3] dt-bindings: display: mcde: Convert to YAML schema

2020-11-30 Thread Rob Herring
On Sun, 15 Nov 2020 19:51:45 +0100, Linus Walleij wrote: > This moves the MCDE bindings over to using the YAML schema > to describe the ST-Ericsson MCDE display controller, > making use of the generic DSI controller schema. > > In the process we correct an error in the old text bindings: > the clo

[PATCH v3 3/3] drm/virtio: consider dma-fence context when signaling

2020-11-30 Thread Gurchetan Singh
This an incremental refactor towards multiple dma-fence contexts in virtio-gpu. Since all fences are still allocated using &virtio_gpu_fence_driver.context, nothing should break and every processed fence will be signaled. The overall idea is every 3D context can allocate a number of dma-fence con

[PATCH v3 2/3] drm/virtio: rework virtio_fence_signaled

2020-11-30 Thread Gurchetan Singh
virtio_gpu_fence_event_process sets the last_fence_id and subsequently calls dma_fence_signal_locked(..). dma_fence_signal_locked(..) sets DMA_FENCE_FLAG_SIGNALED_BIT, which is actually checked before &dma_fence_ops.(*signaled) is called. The check for last_fence_id is therefore a bit redundant,

[PATCH v3 1/3] drm/virtio: virtio_{blah} --> virtio_gpu_{blah}

2020-11-30 Thread Gurchetan Singh
virtio_gpu typically uses the prefix virtio_gpu, but there are a few places where the virtio prefix is used. Modify this for consistency. v3: add r-b tags Signed-off-by: Gurchetan Singh Reviewed-by: Anthoine Bourgeois --- drivers/gpu/drm/virtio/virtgpu_debugfs.c | 24 ++ drive

Re: [Intel-gfx] [RFC v2 3/8] drm/i915: Keep track of pwm-related backlight hooks separately

2020-11-30 Thread Lyude Paul
On Thu, 2020-11-26 at 13:57 +0200, Jani Nikula wrote: > On Thu, 26 Nov 2020, Dave Airlie wrote: > > On Thu, 17 Sept 2020 at 03:19, Lyude Paul wrote: > > > > > > Currently, every different type of backlight hook that i915 supports is > > > pretty straight forward - you have a backlight, probably

Re: [PATCH v4 1/2] dt-bindings: dp-connector: add binding for DisplayPort connector

2020-11-30 Thread Rob Herring
On Mon, 30 Nov 2020 13:29:18 +0200, Tomi Valkeinen wrote: > Add binding for DisplayPort connector. A few notes: > > * Similar to hdmi-connector, it has hpd-gpios as an optional property, > as the HPD could also be handled by, e.g., the DP bridge. > > * dp-pwr-supply, which provides 3.3V on DP_P

Re: [PATCH v4 80/80] drm/omap: dsi: fix DCS_CMD_ENABLE

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:38PM +0200, Tomi Valkeinen wrote: > We only need to set VC_CTRL:DCS_CMD_ENABLE for command mode panels when > the HW has DSI_QUIRK_DCS_CMD_CONFIG_VC quirk. The old code did this > right by accident, but now we set DCS_CMD_ENABLE for

Re: [PATCH v4 79/80] drm/omap: dsi: remove ulps support

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:37PM +0200, Tomi Valkeinen wrote: > ULPS doesn't work, and I have been unable to get it to work. As ULPS is > a minor power-saving feature which requires substantial amount of > non-trivial code, and we have trouble just getting and

Re: [PATCH v4 78/80] drm/omap: dsi: fix and cleanup ddr_clk_always_on

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:36PM +0200, Tomi Valkeinen wrote: > The driver ignores MIPI_DSI_CLOCK_NON_CONTINUOUS, and always uses > non-continuous clock. > > Fix this by using MIPI_DSI_CLOCK_NON_CONTINUOUS and at the same time, > drop ddr_clk_always_on field w

Re: [PATCH v4 77/80] drm/omap: dsi: split video mode enable/disable into separate func

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:35PM +0200, Tomi Valkeinen wrote: > Clean up the code by separating video-mode enable/disable code into > functions of their own. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/d

Re: [PATCH v4 76/80] drm/omap: dsi: cleanup initial vc setup

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:34PM +0200, Tomi Valkeinen wrote: > As we now have a fixed setup for VCs (VC0 for video stream, VC1 for > commands), we can simplify the VC setup. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 85 ++

Re: [PATCH v4 75/80] drm/omap: dsi: rename dsi_display_* functions

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:33PM +0200, Tomi Valkeinen wrote: > The function names have evolved to be very confusing, and bunch of them > have "display" in them even if the function doesn't deal with display as > such (e.g. dsi_display_enable which just enables

Re: [PATCH v4 74/80] drm/omap: dsi: display_disable cleanup

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:32PM +0200, Tomi Valkeinen wrote: > We can drop dsi_display_disable() which just calls > _dsi_display_disable(), and rename _dsi_display_disable() to > dsi_display_disable(). Same comment as for the previous patch. I'd actually squa

Re: [PATCH v4 73/80] drm/omap: dsi: display_enable cleanup

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:31PM +0200, Tomi Valkeinen wrote: > We can drop dsi_display_enable(), which just calls > _dsi_display_enable(), and rename _dsi_display_enable() to > dsi_display_enable(). How about adding a comment here to explain why the WARN_ON()

Re: [PATCH v4 72/80] drm/omap: dsi: move enable/disable to bridge enable/disable

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:30PM +0200, Tomi Valkeinen wrote: > Clean up the code by inlining dsi_enable_video_outputs and > dsi_disable_video_outputs functions. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapd

Re: [PATCH v4 71/80] drm/omap: dsi: move structs & defines to dsi.h

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:29PM +0200, Tomi Valkeinen wrote: > Move structs and defines to a private dsi.h header file to make dsi.c a > bit easier to navigate. Also move the (now) private structs and defines > from omapdss.h to dsi.h. I usually tend to keep

Re: [PATCH v4 70/80] drm/panel: panel-dsi-cm: drop unneeded includes

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:28PM +0200, Tomi Valkeinen wrote: > Drop unneeded includes. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/panel/panel-dsi-cm.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-d

Re: [PATCH v4 69/80] drm/panel: panel-dsi-cm: add panel database to driver

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:27PM +0200, Tomi Valkeinen wrote: > Add a panel database to the driver instead of reading propertes from DT > data. This is similar to panel-simple, and I believe it's more future > safe way to handle the panels. No need to care abo

Re: [PATCH v4 68/80] drm/panel: panel-dsi-cm: remove extra 'if'

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:26PM +0200, Tomi Valkeinen wrote: > We have a useless 'if' in the dsicm_bl_update_status(), a left over from > the conversion to DRM model. Drop the if. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/panel/panel-dsi-cm.

Re: [PATCH v4 67/80] drm/omap: dsi: use separate VCs for cmd and video

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:25PM +0200, Tomi Valkeinen wrote: > For command mode panels we can use a single VC for sending command and > video data, even if we have to change the data source for that VC when > going from command to video or vice versa. > > How

Re: [PATCH v4 66/80] drm/omap: dsi: set LP/HS before update

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:24PM +0200, Tomi Valkeinen wrote: > We currently use a single VC for sending commands and pixel data. The > LP/HS mode for pixel data is correct by accident, as we have set the VC > to HS already earlier. > > However, if we use a di

Re: [PATCH v4 65/80] drm/omap: dsi: skip dsi_vc_enable_hs when already in correct mode

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:23PM +0200, Tomi Valkeinen wrote: > Simplify and optimize dsi_vc_enable_hs() so that it can be called > without checking the current HS/LP mode. Make dsi_vc_enable_hs() return > if the VC is already in the correct mode. > > Signed-o

RE: [Intel-gfx] [PATCH 1/2] drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color

2020-11-30 Thread Chery, Nanley G
> -Original Message- > From: Imre Deak > Sent: Friday, November 27, 2020 10:06 AM > To: Daniel Vetter ; Chery, Nanley G > > Cc: intel-...@lists.freedesktop.org; Nikula, Jani ; > Daniel > Vetter ; Rafael Antognolli > ; Kondapally, Kalyan > ; Pandiyan, Dhinakaran > ; dri-devel@lists.fre

Re: [PATCH v4 64/80] drm/omap: dsi: cleanup channel usages

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:22PM +0200, Tomi Valkeinen wrote: > The "channel" usage in omap dsi driver is super confusing. We have three > different "channels": > > 1) DSI virtual channel ID. This is a number from 0 to 3, included in the > packet payload. > >

Re: [PATCH v4 63/80] drm/omap: dsi: drop useless channel checks

2020-11-30 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:21PM +0200, Tomi Valkeinen wrote: > A DSI peripheral can have virtual channel ID of 0-3. This should be > always the case, and there's no need in the driver to validate the > channel. > > Signed-off-by: Tomi Valkeinen Reviewed-by:

Re: [PATCH 40/40] drm/amd/display/dc/basics/vector: Make local function 'dal_vector_presized_costruct' static

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:44 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/basics/vector.c:55:6: warning: no > previous prototype for ‘dal_vector_presized_costruct’ [-Wmissing-prototypes] > > Cc: Harry Wentland > Cc: Leo Li

Re: [PATCH 39/40] drm/amd/display/dc/basics/fixpt31_32: Remove unused variable 'dc_fixpt_pi'

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:44 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/basics/fixpt31_32.c:29:32: warning: > ‘dc_fixpt_pi’ defined but not used [-Wunused-const-variable=] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex

Re: [PATCH 38/40] drm/amd/display/dc/basics/conversion: Include header containing our prototypes

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:44 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/basics/conversion.c:34:10: warning: > no previous prototype for ‘fixed_point_to_int_frac’ [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../dis

Re: [PATCH 37/40] drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu: Remove unused function 'pp_nv_set_pme_wa_enable()'

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:44 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_pp_smu.c:664:20: > warning: no previous prototype for ‘pp_nv_set_pme_wa_enable’ > [-Wmissing-prototypes] > > Cc: Harry Wentland >

Re: [PATCH 36/40] drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu: Mark local functions invoked by reference as static

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:44 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_pp_smu.c:538:6: > warning: no previous prototype for ‘pp_rv_set_wm_ranges’ > [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/.

Re: [PATCH 35/40] drm/amd/display/amdgpu_dm/amdgpu_dm_color: Demote a misuse and fix another kernel-doc header

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:44 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_color.c:128: > warning: Function parameter or member 'lut' not described in > '__drm_lut_to_dc_gamma' > drivers/gpu/drm/amd/amdgpu

Re: [PATCH 33/40] drm/amd/display/dc/inc/hw/dpp: Mark 'dpp_input_csc_matrix' as __maybe_unused

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > 'dpp_input_csc_matrix' is used by some, but not all source files which > include dpp.h. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/inc/hw/dpp.h:50:42: warning: > ‘dpp_input_csc_matrix’ def

Re: [PATCH 32/40] drm/amd/display/amdgpu_dm/amdgpu_dm: Mark 'link_bandwidth_kbps' as __maybe_unused

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > 'link_bandwidth_kbps' is always obtained, but only used if > CONFIG_DRM_AMD_DC_DCN is defined. Probably better to just move this under CONFIG_DRM_AMD_DC_DCN. I'll send a patch. Thanks, Alex > > Fixes the following W=1 kernel build warning(

Re: [PATCH 30/40] drm/amd/pm/powerplay/hwmgr/vega12_thermal: Fix some outdated function documentation

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_thermal.c:63: > warning: Cannot understand * @fn vega12_enable_fan_control_feature > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmg

Re: [PATCH v4] dt-bindings: display: panel: one file of all simple LVDS panels with dual ports

2020-11-30 Thread Rob Herring
On Tue, Nov 17, 2020 at 09:47:25AM +0800, Liu Ying wrote: > To complement panel-simple.yaml, create panel-simple-lvds-dual-ports.yaml. > panel-simple-lvds-dual-ports.yaml is for all simple LVDS panels that > have dual LVDS ports and require only a single power-supply. > The first port receives odd

Re: [PATCH 29/40] drm/amd/pm/powerplay/hwmgr/vega20_thermal: Fix some outdated function documentation

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:217: > warning: Function parameter or member 'hwmgr' not described in > 'vega20_thermal_get_temperature' > drivers/gpu/drm

Re: [GIT PULL] mediatek drm next for 5.11

2020-11-30 Thread Chun-Kuang Hu
Hi, Dave & Daniel: I've send another pull request "mediatek drm next for 5.11-2" which include this and add more patches, so you could directly pull that request and ignore this. [1] https://lists.freedesktop.org/archives/dri-devel/2020-November/289686.html Regards, Chun-Kuang. Chun-Kuang Hu 於

Re: [PATCH 28/40] drm/amd/pm/powerplay/hwmgr/smu_helper: Demote or fix kernel-doc headers

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu_helper.c:112: warning: > Function parameter or member 'hwmgr' not described in 'phm_wait_on_register' > drivers/gpu/drm/amd/amdgpu/../pm

Re: [PATCH 27/40] drm/amd/pm/powerplay/hwmgr/hwmgr: Move 'vega20_hwmgr_init()'s prototype to shared header

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_hwmgr.c:4403:5: > warning: no previous prototype for ‘vega20_hwmgr_init’ [-Wmissing-prototypes] > 4403 | int vega20_hwmgr_init(struct

Re: [PATCH 26/40] drm/amd/pm/powerplay/hwmgr/hwmgr: Move 'vega12_hwmgr_init()'s prototype to shared header

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_hwmgr.c:2862:5: > warning: no previous prototype for ‘vega12_hwmgr_init’ [-Wmissing-prototypes] > 2862 | int vega12_hwmgr_init(struct

Re: [PATCH 24/40] drm/amd/pm/powerplay/hwmgr/vega10_thermal: Fix a bunch of dated function doc formatting

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_thermal.c:128: > warning: Function parameter or member 'hwmgr' not described in > 'vega10_fan_ctrl_set_static_mode' > drivers/gpu/dr

Re: [PATCH 23/40] drm/amd/pm/powerplay/hwmgr/smu7_thermal: Repair formatting in a bunch of function docs

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_thermal.c:112: > warning: Function parameter or member 'hwmgr' not described in > 'smu7_fan_ctrl_set_static_mode' > drivers/gpu/drm/am

[GIT PULL] mediatek drm next for 5.11-2

2020-11-30 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Add MT8167 support 2. Cleanup function 3. Convert the dpi bindings to yaml 4. Drop local dma_parms 5. Fix formatting and provide missing member description 6. Introduce GEM object functions 7. Fix aliases name 8. Move MIPI DSI phy driver to phy folder Regards

Re: [PATCH 21/40] drm/amd/pm/powerplay/hwmgr/smu7_hwmgr: Fix a whole bunch of historical function doc issues

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:202: warning: > Function parameter or member 'hwmgr' not described in > 'smu7_get_mc_microcode_version' > drivers/gpu/drm/amd/

Re: [PATCH 20/40] drm/amd/pm/powerplay/hwmgr/vega10_processpptables: Make function invoked by reference static

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_processpptables.c:1148:5: > warning: no previous prototype for ‘vega10_pp_tables_initialize’ > [-Wmissing-prototypes] > > Cc: Evan

Re: [PATCH 19/40] drm/amd/pm/powerplay/hwmgr/ppatomctrl: Fix a myriad of kernel-doc issues

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c:104: warning: > Function parameter or member 'reg_block' not described in > 'atomctrl_set_mc_reg_address_table' > drivers/gpu/

Re: [PATCH 18/40] drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0: Convert to proper kernel-doc format

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/process_pptables_v1_0.c:41: > warning: Function parameter or member 'hwmgr' not described in 'set_hw_cap' > drivers/gpu/drm/amd/amdgpu/../pm

Re: [PATCH 17/40] drm/amd/pm/powerplay/hwmgr/hardwaremanager: Fix function header related formatting issues

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:232: > warning: Function parameter or member 'hwmgr' not described in > 'phm_start_thermal_controller' > drivers/gpu/drm/

Re: [PATCH 16/40] drm/amd/pm/powerplay/smumgr/iceland_smumgr: Remove unused variable 'res'

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/iceland_smumgr.c: In > function ‘iceland_thermal_setup_fan_table’: > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/iceland_smumgr.c:209

Re: [PATCH 14/40] drm/amd/pm/powerplay/hwmgr/ppatomfwctrl: Demote kernel-doc formatting abuses

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomfwctrl.c:78: warning: > Function parameter or member 'hwmgr' not described in > 'pp_atomfwctrl_is_voltage_controlled_by_gpio_v4' > dr

Re: [PATCH 13/40] drm/amd/pm/powerplay/hwmgr/hwmgr: Move 'smu7_init_function_pointers()'s prototype to header

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:5696:5: > warning: no previous prototype for ‘smu7_init_function_pointers’ > [-Wmissing-prototypes] > 5696 | int smu7_init_fun

Re: [PATCH 12/40] drm/amd/pm/powerplay/hwmgr/ppatomctrl: Remove unused variable 'fPowerDPMx'

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c:31: > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c: In function > ‘atomctrl_calculate

Re: [PATCH 11/40] drm/amd/pm/powerplay/hwmgr/ppevvmath: Place variable declaration under same clause as its use

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppevvmath.h: In function > ‘fMultiply’: > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppevvmath.h:336:22: > warning: variable ‘Y_LessT

Re: [PATCH 10/40] drm/amd/pm/inc/pp_thermal: Mark 'SMU7Thermal{WithDelay}Policy' as __maybe_unused

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > They are used by some source files which include pp_thermal.h, but not all. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/inc/pp_thermal.h:28:41: warning: > ‘SMU7ThermalWithDelayPolicy’ defined but n

Re: [PATCH 09/40] drm/amd/pm/powerplay/hwmgr/hwmgr: Move 'smu8_init_function_pointers()' prototype to shared header

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > Cc: Evan Quan > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by:

Re: [PATCH 08/40] drm/amd/pm/powerplay/hwmgr/hardwaremanager: Remove unused 'phm_set_*()' functions

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:518:5: > warning: no previous prototype for ‘phm_set_min_deep_sleep_dcefclk’ > [-Wmissing-prototypes] > drivers/gpu/drm/a

Re: [PATCH 07/40] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Demote kernel-doc format abuse

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/fiji_smumgr.c:1107: > warning: Function parameter or member 'mem_clock' not described in > 'fiji_get_mclk_frequency_ratio' > > Cc: Evan Qua

Re: [Intel-gfx] [RFC v2 3/8] drm/i915: Keep track of pwm-related backlight hooks separately

2020-11-30 Thread Lyude Paul
On Thu, 2020-11-26 at 11:03 +1000, Dave Airlie wrote: > On Thu, 17 Sept 2020 at 03:19, Lyude Paul wrote: > > > > Currently, every different type of backlight hook that i915 supports is > > pretty straight forward - you have a backlight, probably through PWM > > (but maybe DPCD), with a single set

Re: [PATCH 06/40] drm/amd/pm/powerplay/smumgr/smu9_smumgr: Include our own header containing our prototypes

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/smu9_smumgr.c:38:6: > warning: no previous prototype for ‘smu9_is_smc_ram_running’ > [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/.

Re: [PATCH 05/40] drm/amd/pm/powerplay/smumgr/vegam_smumgr: Make function called by reference static

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/vegam_smumgr.c:2249:5: > warning: no previous prototype for ‘vegam_thermal_avfs_enable’ > [-Wmissing-prototypes] > > Cc: Evan Quan > Cc: A

Re: [PATCH 04/40] drm/amd/pm/powerplay/smumgr/iceland_smumgr: Make function called by reference static

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/iceland_smumgr.c:2085:5: > warning: no previous prototype for ‘iceland_thermal_setup_fan_table’ > [-Wmissing-prototypes] > drivers/gpu/drm

Re: [PATCH 03/40] drm/amd/pm/powerplay/smumgr/ci_smumgr: Remove set but unused variable 'res'

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:42 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/ci_smumgr.c: In function > ‘ci_thermal_setup_fan_table’: > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/ci_smumgr.c:2132:6: > warning

Re: [PATCH 02/40] drm/amd/pm/powerplay/smumgr/polaris10_smumgr: Make function called by reference static

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:42 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/polaris10_smumgr.c:2145:5: > warning: no previous prototype for ‘polaris10_thermal_avfs_enable’ > [-Wmissing-prototypes] > > Cc: Evan Quan

Re: [PATCH 01/40] drm/amd/pm/powerplay/smumgr/tonga_smumgr: Remove set but unused variable 'res'

2020-11-30 Thread Alex Deucher
On Thu, Nov 26, 2020 at 8:42 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/tonga_smumgr.c: In > function ‘tonga_thermal_setup_fan_table’: > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/tonga_smumgr.c:2469:6:

Re: [RFC v2 1/8] drm/i915/dp: Program source OUI on eDP panels

2020-11-30 Thread Lyude Paul
On Thu, 2020-11-26 at 12:51 +0200, Jani Nikula wrote: > On Wed, 16 Sep 2020, Lyude Paul wrote: > > Since we're about to start adding support for Intel's magic HDR > > backlight interface over DPCD, we need to ensure we're properly > > programming this field so that Intel specific sink services are

Re: [PATCH 40/40] drm/amd/amdgpu/amdgpu_uvd: Add description for amdgpu_uvd_cs_msg_decode()'s 'buf_sizes' param

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:555: warning: Function parameter or > member 'buf_sizes' not described in 'amdgpu_uvd_cs_msg_decode' > > Cc: Alex Deucher > Cc: "Christian König" >

Re: [PATCH 39/40] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Remove unused variable 'result'

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/fiji_smumgr.c: In function > ‘fiji_populate_smc_boot_level’: > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/fiji_smumgr.c:1603:6: > w

Re: [PATCH 38/40] drm/amd/pm/swsmu/smu11/navi10_ppt: Remove unused 'struct i2c_algorithm navi10_i2c_algo'

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Evan Quan > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by:

Re: [PATCH 37/40] drm/amd/pm/swsmu/smu12/renoir_ppt: Demote kernel-doc formatting abuse

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Appli

Re: [PATCH 36/40] drm/amd/pm/inc/smu_v11_0: Mark 'smu11_thermal_policy' as __maybe_unused

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > It's used in some, but not all source files which include 'smu_v11_0.h'. > > Fixes the following W=1 kernel build warning(s): > > In file included from > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/smu_v11_0.c:36: > drivers/gpu/drm/amd/amdgp

Re: [PATCH 35/40] drm/amd/pm/swsmu/smu11/vangogh_ppt: Make local function 'vangogh_set_default_dpm_tables()' static

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: At top level: > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:764:5: warning: > no previous prototype for ‘vangogh_s

Re: [PATCH 34/40] drm/amd/amdgpu/amdgpu_acp: Fix doc-rot issues pertaining to a couple of 'handle' params

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:183: warning: Function parameter or > member 'handle' not described in 'acp_hw_init' > drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:183: warning: Excess f

Re: [PATCH 33/40] drm/amd/amdgpu/vcn_v3_0: Remove unused variable 'direct_poll' from 'vcn_v3_0_start_sriov()'

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c: In function ‘vcn_v3_0_start_sriov’: > drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c:1242:3: warning: variable > ‘direct_poll’ set but not used [-Wunused-but-s

Re: [PATCH 23/40] drm/amd/amdgpu/sdma_v5_0: Provide some missing and repair other function params

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:403: warning: Function parameter or > member 'job' not described in 'sdma_v5_0_ring_emit_ib' > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:403: warning: Fu

Re: [PATCH 32/40] drm/amd/amdgpu/vcn_v2_0: Fix a few kernel-doc misdemeanours

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:483: warning: Excess function > parameter 'sw' description in 'vcn_v2_0_disable_clock_gating' > drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c:644: warning: Exc

Re: [PATCH 31/40] drm/amd/amdgpu/jpeg_v2_0: Add some missing kernel-doc descriptions

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c:498: warning: Function parameter or > member 'addr' not described in 'jpeg_v2_0_dec_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c:498: war

Re: [PATCH 30/40] drm/amd/amdgpu/jpeg_v1_0: Add some missing function param descriptions

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c:219: warning: Function parameter or > member 'addr' not described in 'jpeg_v1_0_decode_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c:219:

Re: [PATCH 29/40] drm/amd/amdgpu/vcn_v1_0: Fix a few kernel-doc misdemeanours

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:439: warning: Excess function > parameter 'sw' description in 'vcn_v1_0_disable_clock_gating' > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:566: warning: Exc

Re: [PATCH 28/40] drm/amd/amdgpu/gfx_v10_0: Make local function 'gfx_v10_0_rlc_stop()' static

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:5008:6: warning: no previous > prototype for ‘gfx_v10_0_rlc_stop’ [-Wmissing-prototypes] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Air

Re: [PATCH 27/40] drm/amd/amdgpu/uvd_v7_0: Fix a bunch of kernel-doc function documentation issues

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c:219: warning: Function parameter or > member 'bo' not described in 'uvd_v7_0_enc_get_create_msg' > drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c:219: warning:

Re: [PATCH 26/40] drm/amd/amdgpu/uvd_v6_0: Fix a bunch of kernel-doc function documentation issues

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c:211: warning: Function parameter or > member 'bo' not described in 'uvd_v6_0_enc_get_create_msg' > drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c:211: warning:

Re: [PATCH 25/40] drm/amd/amdgpu/amdgpu_vce: Provide some missing and repair other function params

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:97: warning: Function parameter or > member 'size' not described in 'amdgpu_vce_sw_init' > drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:441: warning: Func

Re: [PATCH 24/40] drm/amd/amdgpu/sdma_v5_2: Provide some missing and repair other function params

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:367: warning: Function parameter or > member 'job' not described in 'sdma_v5_2_ring_emit_ib' > drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:367: warning: Fu

Re: [PATCH 22/40] drm/amd/amdgpu/amdgpu_uvd: Fix some function documentation headers

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:95: warning: cannot understand > function prototype: 'struct amdgpu_uvd_cs_ctx ' > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:555: warning: Function par

Re: [PATCH 21/40] drm/amd/amdgpu/sdma_v4_0: Repair a bunch of kernel-doc problems

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:848: warning: Function parameter or > member 'job' not described in 'sdma_v4_0_ring_emit_ib' > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:848: warning: Fu

Re: [PATCH 20/40] drm/amd/amdgpu/uvd_v5_0: Fix a bunch of kernel-doc function documentation issues

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:153: warning: Function parameter or > member 'handle' not described in 'uvd_v5_0_hw_init' > drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c:153: warning: Excess

Re: [PATCH 19/40] drm/amd/amdgpu/sdma_v3_0: Fix incorrect param doc-rot issue

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1651: warning: Function parameter or > member 'ib' not described in 'sdma_v3_0_emit_copy_buffer' > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1651: warnin

Re: [PATCH 18/40] drm/amd/amdgpu/sdma_v3_0: Fix a bunch of kernel-doc function documentation issues

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:428: warning: Function parameter or > member 'job' not described in 'sdma_v3_0_ring_emit_ib' > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:428: warning: Fu

Re: [PATCH 17/40] drm/amd/amdgpu/sdma_v2_4: Fix a bunch of kernel-doc function documentation issues

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c:254: warning: Function parameter or > member 'job' not described in 'sdma_v2_4_ring_emit_ib' > drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c:254: warning: Fu

Re: [PATCH 16/40] drm/amd/amdgpu/gfx_v10_0: Remove a bunch of set but unused variables

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c: In function ‘gfx_v10_rlcg_wreg’: > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:1416:18: warning: variable ‘grbm_idx’ > set but not used [-Wunused-but-set-

RE: [PATCH] drm/kmb: fix array bounds warning

2020-11-30 Thread Chrisanthus, Anitha
Hi Arnd, Thanks for your patch. > -Original Message- > From: Arnd Bergmann > Sent: Sunday, November 29, 2020 12:09 PM > To: Chrisanthus, Anitha ; Dea, Edmund J > ; David Airlie ; Daniel Vetter > ; Sam Ravnborg > Cc: Arnd Bergmann ; lkp ; dri- > de...@lists.freedesktop.org; linux-ker...@v

Re: [PATCH 15/40] drm/amd/amdgpu/gfx_v8_0: Functions must follow directly after their headers

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:3698: warning: Excess function > parameter 'adev' description in 'DEFAULT_SH_MEM_BASES' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airli

Re: [PATCH 14/40] drm/amd/amdgpu/gfx_v9_0: Make called-by-reference only function static

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:2998:6: warning: no previous prototype > for ‘gfx_v9_0_rlc_stop’ [-Wmissing-prototypes] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airli

Re: [PATCH 13/40] drm/amd/amdgpu/dce_v11_0: Supply description for function param 'async'

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/dce_v11_0.c:255: warning: Function parameter or > member 'async' not described in 'dce_v11_0_page_flip' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David

Re: [PATCH 12/40] drm/amd/amdgpu/dce_v10_0: Supply description for function param 'async'

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/dce_v10_0.c:237: warning: Function parameter or > member 'async' not described in 'dce_v10_0_page_flip' > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David

Re: [PATCH 11/40] drm/amd/amdgpu/psp_v11_0: Make local function 'psp_v11_0_wait_for_bootloader()' static

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:45 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c:223:5: warning: no previous prototype > for ‘psp_v11_0_wait_for_bootloader’ [-Wmissing-prototypes] > > Cc: Alex Deucher > Cc: "Christian König" > Cc:

Re: [PATCH 10/40] drm/amd/amdgpu/navi10_ih: Add descriptions for 'ih' and 'entry'

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/navi10_ih.c:453: warning: Function parameter or > member 'ih' not described in 'navi10_ih_get_wptr' > drivers/gpu/drm/amd/amdgpu/navi10_ih.c:512: warning: Functio

Re: [PATCH 09/40] drm/amd/amdgpu/vega10_ih: Add descriptions for 'ih' and 'entry'

2020-11-30 Thread Alex Deucher
On Tue, Nov 24, 2020 at 2:44 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/vega10_ih.c:377: warning: Function parameter or > member 'ih' not described in 'vega10_ih_get_wptr' > drivers/gpu/drm/amd/amdgpu/vega10_ih.c:440: warning: Functio

  1   2   3   >