Re: [PATCH] drm/lima: Expose job_hang_limit module parameter

2020-06-17 Thread Qiang Yu
On Thu, Jun 18, 2020 at 1:57 AM Andrey Lebedev wrote: > > From: Andrey Lebedev > > Some pp or gp jobs can be successfully repeated even after they time outs. > Introduce lima module parameter to specify number of times a job can hang > before being dropped. > > Signed-off-by: Andrey Lebedev > --

Re: [PATCH 1/2] drm/msm: Fix address space size after refactor.

2020-06-17 Thread Rob Clark
On Wed, Jun 17, 2020 at 1:53 PM Eric Anholt wrote: > > Previously the address space went from 16M to ~0u, but with the > refactor one of the 'f's was dropped, limiting us to 256MB. > Additionally, the new interface takes a start and size, not start and > end, so we can't just copy and paste. > > F

Re: [PATCH] drm/mgag200: Don't set in MISC

2020-06-17 Thread Rong Chen
On 6/17/20 8:29 PM, Thomas Zimmermann wrote: Hi Am 17.06.20 um 11:22 schrieb Rong Chen: On Wed, Jun 17, 2020 at 08:28:02AM +0200, Thomas Zimmermann wrote: Hi Emil Am 16.06.20 um 17:14 schrieb Emil Velikov: Hi Thomas, On Tue, 16 Jun 2020 at 15:26, Thomas Zimmermann wrote: The original m

[PATCH AUTOSEL 4.9 51/80] drm/msm/mdp5: Fix mdp5_init error path for failed mdp5_kms allocation

2020-06-17 Thread Sasha Levin
From: Roy Spliet [ Upstream commit e4337877c5d578722c0716f131fb774522013cf5 ] When allocation for mdp5_kms fails, calling mdp5_destroy() leads to undefined behaviour, likely a nullptr exception or use-after-free troubles. Signed-off-by: Roy Spliet Reviewed-by: Abhinav Kumar Signed-off-by: Rob

[PATCH AUTOSEL 4.14 107/108] drm/sun4i: hdmi ddc clk: Fix size of m divider

2020-06-17 Thread Sasha Levin
From: Jernej Skrabec [ Upstream commit 54e1e06bcf1cf6e7ac3f86daa5f7454add24b494 ] m divider in DDC clock register is 4 bits wide. Fix that. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard Link: https://

[PATCH AUTOSEL 4.9 07/80] backlight: lp855x: Ensure regulators are disabled on probe failure

2020-06-17 Thread Sasha Levin
From: Jon Hunter [ Upstream commit d8207c155a7c6015eb7f43739baa7dfb1fa638af ] If probing the LP885x backlight fails after the regulators have been enabled, then the following warning is seen when releasing the regulators ... WARNING: CPU: 1 PID: 289 at drivers/regulator/core.c:2051 _regulator

[PATCH AUTOSEL 4.14 064/108] drm/msm/mdp5: Fix mdp5_init error path for failed mdp5_kms allocation

2020-06-17 Thread Sasha Levin
From: Roy Spliet [ Upstream commit e4337877c5d578722c0716f131fb774522013cf5 ] When allocation for mdp5_kms fails, calling mdp5_destroy() leads to undefined behaviour, likely a nullptr exception or use-after-free troubles. Signed-off-by: Roy Spliet Reviewed-by: Abhinav Kumar Signed-off-by: Rob

[PATCH AUTOSEL 4.14 008/108] backlight: lp855x: Ensure regulators are disabled on probe failure

2020-06-17 Thread Sasha Levin
From: Jon Hunter [ Upstream commit d8207c155a7c6015eb7f43739baa7dfb1fa638af ] If probing the LP885x backlight fails after the regulators have been enabled, then the following warning is seen when releasing the regulators ... WARNING: CPU: 1 PID: 289 at drivers/regulator/core.c:2051 _regulator

[PATCH AUTOSEL 4.19 168/172] drm/sun4i: hdmi ddc clk: Fix size of m divider

2020-06-17 Thread Sasha Levin
From: Jernej Skrabec [ Upstream commit 54e1e06bcf1cf6e7ac3f86daa5f7454add24b494 ] m divider in DDC clock register is 4 bits wide. Fix that. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard Link: https://

[PATCH AUTOSEL 4.19 097/172] drm/msm/mdp5: Fix mdp5_init error path for failed mdp5_kms allocation

2020-06-17 Thread Sasha Levin
From: Roy Spliet [ Upstream commit e4337877c5d578722c0716f131fb774522013cf5 ] When allocation for mdp5_kms fails, calling mdp5_destroy() leads to undefined behaviour, likely a nullptr exception or use-after-free troubles. Signed-off-by: Roy Spliet Reviewed-by: Abhinav Kumar Signed-off-by: Rob

[PATCH AUTOSEL 4.19 010/172] backlight: lp855x: Ensure regulators are disabled on probe failure

2020-06-17 Thread Sasha Levin
From: Jon Hunter [ Upstream commit d8207c155a7c6015eb7f43739baa7dfb1fa638af ] If probing the LP885x backlight fails after the regulators have been enabled, then the following warning is seen when releasing the regulators ... WARNING: CPU: 1 PID: 289 at drivers/regulator/core.c:2051 _regulator

[PATCH AUTOSEL 5.4 257/266] drm/sun4i: hdmi ddc clk: Fix size of m divider

2020-06-17 Thread Sasha Levin
From: Jernej Skrabec [ Upstream commit 54e1e06bcf1cf6e7ac3f86daa5f7454add24b494 ] m divider in DDC clock register is 4 bits wide. Fix that. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard Link: https://

[PATCH AUTOSEL 5.4 215/266] drm/nouveau/disp/gm200-: fix NV_PDISP_SOR_HDMI2_CTRL(n) selection

2020-06-17 Thread Sasha Levin
From: Ben Skeggs [ Upstream commit a1ef8bad506e4ffa0c57ac5f8cb99ab5cbc3b1fc ] This is a SOR register, and not indexed by the bound head. Fixes display not coming up on high-bandwidth HDMI displays under a number of configurations. Signed-off-by: Ben Skeggs Signed-off-by: Sasha Levin --- dri

[PATCH AUTOSEL 5.4 226/266] drm/amd/display: Revalidate bandwidth before commiting DC updates

2020-06-17 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit a24eaa5c51255b344d5a321f1eeb3205f2775498 ] [Why] Whenever we switch between tiled formats without also switching pixel formats or doing anything else that recreates the DC plane state we can run into underflow or hangs since we're not updating the DML

[PATCH AUTOSEL 5.4 156/266] drm/msm/mdp5: Fix mdp5_init error path for failed mdp5_kms allocation

2020-06-17 Thread Sasha Levin
From: Roy Spliet [ Upstream commit e4337877c5d578722c0716f131fb774522013cf5 ] When allocation for mdp5_kms fails, calling mdp5_destroy() leads to undefined behaviour, likely a nullptr exception or use-after-free troubles. Signed-off-by: Roy Spliet Reviewed-by: Abhinav Kumar Signed-off-by: Rob

[PATCH AUTOSEL 5.4 011/266] backlight: lp855x: Ensure regulators are disabled on probe failure

2020-06-17 Thread Sasha Levin
From: Jon Hunter [ Upstream commit d8207c155a7c6015eb7f43739baa7dfb1fa638af ] If probing the LP885x backlight fails after the regulators have been enabled, then the following warning is seen when releasing the regulators ... WARNING: CPU: 1 PID: 289 at drivers/regulator/core.c:2051 _regulator

[PATCH AUTOSEL 5.7 370/388] drm/sun4i: hdmi ddc clk: Fix size of m divider

2020-06-17 Thread Sasha Levin
From: Jernej Skrabec [ Upstream commit 54e1e06bcf1cf6e7ac3f86daa5f7454add24b494 ] m divider in DDC clock register is 4 bits wide. Fix that. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard Link: https://

[PATCH AUTOSEL 5.7 373/388] drm/ast: fix missing break in switch statement for format->cpp[0] case 4

2020-06-17 Thread Sasha Levin
From: Colin Ian King [ Upstream commit 291ddeb621e4a9f1ced8302a777fbd7fbda058c6 ] Currently the switch statement for format->cpp[0] value 4 assigns color_index which is never read again and then falls through to the default case and returns. This looks like a missing break statement bug. Fix thi

[PATCH AUTOSEL 5.7 329/388] drm/amd/display: Revalidate bandwidth before commiting DC updates

2020-06-17 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit a24eaa5c51255b344d5a321f1eeb3205f2775498 ] [Why] Whenever we switch between tiled formats without also switching pixel formats or doing anything else that recreates the DC plane state we can run into underflow or hangs since we're not updating the DML

[PATCH AUTOSEL 5.7 314/388] drm/nouveau/disp/gm200-: fix NV_PDISP_SOR_HDMI2_CTRL(n) selection

2020-06-17 Thread Sasha Levin
From: Ben Skeggs [ Upstream commit a1ef8bad506e4ffa0c57ac5f8cb99ab5cbc3b1fc ] This is a SOR register, and not indexed by the bound head. Fixes display not coming up on high-bandwidth HDMI displays under a number of configurations. Signed-off-by: Ben Skeggs Signed-off-by: Sasha Levin --- dri

[PATCH AUTOSEL 5.7 231/388] drm/msm/mdp5: Fix mdp5_init error path for failed mdp5_kms allocation

2020-06-17 Thread Sasha Levin
From: Roy Spliet [ Upstream commit e4337877c5d578722c0716f131fb774522013cf5 ] When allocation for mdp5_kms fails, calling mdp5_destroy() leads to undefined behaviour, likely a nullptr exception or use-after-free troubles. Signed-off-by: Roy Spliet Reviewed-by: Abhinav Kumar Signed-off-by: Rob

[PATCH AUTOSEL 5.7 230/388] drm/msm: Fix undefined "rd_full" link error

2020-06-17 Thread Sasha Levin
From: Bjorn Andersson [ Upstream commit 20aebe83698feb107d5a66b6cfd1d54459ccdfcf ] rd_full should be defined outside the CONFIG_DEBUG_FS region, in order to be able to link the msm driver even when CONFIG_DEBUG_FS is disabled. Fixes: e515af8d4a6f ("drm/msm: devcoredump should dump MSM_SUBMIT_BO

[PATCH AUTOSEL 5.7 090/388] drm/nouveau: gr/gk20a: Use firmware version 0

2020-06-17 Thread Sasha Levin
From: Thierry Reding [ Upstream commit 21454fe697fde188ad6fb541f94b9838fa73ab38 ] Tegra firmware doesn't actually use any version numbers and passing -1 causes the existing firmware binaries not to be found. Use version 0 to find the correct files. Fixes: ef16dc278ec2 ("drm/nouveau/gr/gf100-: s

[PATCH AUTOSEL 5.7 014/388] backlight: lp855x: Ensure regulators are disabled on probe failure

2020-06-17 Thread Sasha Levin
From: Jon Hunter [ Upstream commit d8207c155a7c6015eb7f43739baa7dfb1fa638af ] If probing the LP885x backlight fails after the regulators have been enabled, then the following warning is seen when releasing the regulators ... WARNING: CPU: 1 PID: 289 at drivers/regulator/core.c:2051 _regulator

[radeon-alex:drm-next 319/414] drivers/gpu/drm/amd/amdgpu/../powerplay/sienna_cichlid_ppt.c:1817:28: sparse: sparse: cast to restricted __le32

2020-06-17 Thread kernel test robot
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next head: f59073f6df9b07d94917221486cf5929efa6b315 commit: a5cc9a9321cb7c32ed9d8f6f82e82376bcc04f81 [319/414] drm/amd/powerplay: update powerplay table for sienna_cichlid config: i386-randconfig-s001-20200617 (attached as .config

[Bug 208205] [amdgpu] System hang / freeze

2020-06-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208205 --- Comment #4 from Automne von Einzbern (mar...@automne.me) --- Also on Kernel 5.8-rc1 -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list dri-

Re: [PATCH v3 5/5] dt-bindings: display: ti,tfp410.yaml: make the ports node optional

2020-06-17 Thread Laurent Pinchart
Hi Rob, On Wed, Jun 17, 2020 at 04:34:55PM -0600, Rob Herring wrote: > On Thu, Jun 11, 2020 at 12:23:56PM +0200, Ricardo Cañuelo wrote: > > Make the ports node optional, since there are some DTs that don't define > > any ports for ti,tfp410. > > Only arch/arm/boot/dts/dove-sbc-a510.dts AFAICT...

Re: [PATCH RESEND v2 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33

2020-06-17 Thread Rob Herring
On Fri, 12 Jun 2020 09:22:17 +0200, Matthias Schiffer wrote: > Add the Tianma Micro-electronics TM070JVHG33 7.0" WXGA display to the > panel-simple compatible list. > > Signed-off-by: Matthias Schiffer > --- > > v2: no changes > > .../devicetree/bindings/display/panel/panel-simple.yaml

Re: [PATCH RESEND v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44

2020-06-17 Thread Rob Herring
On Fri, 12 Jun 2020 09:22:16 +0200, Matthias Schiffer wrote: > Add the CDTech Electronics displays S070PWS19HP-FC21 (7.0" WSVGA) and > S070SWV29HG-DC44 (7.0" WVGA) to the panel-simple compatible list. > > Signed-off-by: Matthias Schiffer > --- > > v2: no changes > > .../devicetree/bindings/dis

[PATCH 3/3] gpu: ipu-v3: image-convert: Wait for all EOFs before completing a tile

2020-06-17 Thread Steve Longerbeam
Use a bit-mask of EOF irqs to determine when all required idmac channel EOFs have been received for a tile conversion, and only do tile completion processing after all EOFs have been received. Otherwise it was found that a conversion would stall after the completion of a tile and the start of the n

[PATCH 1/3] gpu: ipu-v3: Restore RGB32, BGR32

2020-06-17 Thread Steve Longerbeam
RGB32 and BGR32 formats were inadvertently removed from the switch statement in ipu_pixelformat_to_colorspace(). Restore them. Fixes: a59957172b0c ("gpu: ipu-v3: enable remaining 32-bit RGB V4L2 pixel formats") Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-common.c | 2 ++ 1 file c

[PATCH 2/3] gpu: ipu-v3: image-convert: Combine rotate/no-rotate irq handlers

2020-06-17 Thread Steve Longerbeam
Combine the rotate_irq() and norotate_irq() handlers into a single eof_irq() handler. Signed-off-by: Steve Longerbeam --- drivers/gpu/ipu-v3/ipu-image-convert.c | 58 +- 1 file changed, 20 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c

Re: [PATCH v3 5/5] dt-bindings: display: ti,tfp410.yaml: make the ports node optional

2020-06-17 Thread Rob Herring
On Mon, Jun 15, 2020 at 11:38:07AM +0200, Ricardo Cañuelo wrote: > Hi Laurent, > > Thanks for reviewing the patch > > On Thu, 2020-06-11 at 19:08 +0300, Laurent Pinchart wrote: > > Hi Ricardo, > > > > Thank you for the patch. > > > > On Thu, Jun 11, 2020 at 12:23:56PM +0200, Ricardo Cañuelo wro

Re: [PATCH v3 5/5] dt-bindings: display: ti,tfp410.yaml: make the ports node optional

2020-06-17 Thread Rob Herring
On Thu, Jun 11, 2020 at 12:23:56PM +0200, Ricardo Cañuelo wrote: > Make the ports node optional, since there are some DTs that don't define > any ports for ti,tfp410. Only arch/arm/boot/dts/dove-sbc-a510.dts AFAICT... It should be updated IMO. > > Signed-off-by: Ricardo Cañuelo > --- > Docume

[pull] amdgpu, amdkfd drm-fixes-5.8

2020-06-17 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.8. The following changes since commit 8d286e2ff4400d313955b4203fc640ca6fd9228b: Merge tag 'drm-intel-next-fixes-2020-06-04' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2020-06-08 11:59:57 +1000) are available in the Git repository at: git://

[PATCH][next] drm/i915/query: Use struct_size() helper

2020-06-17 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/i915/i915_query.c | 3 +-- 1 file chang

Re: [PATCH] gpu: ipu-v3: image-convert: Wait for channels before disabling

2020-06-17 Thread Steve Longerbeam
Hi Philpp, Please disregard this patch. A better solution to a busy wait with a spin lock held is to wait for all required EOF interrupts before doing tile completion processing. I will submit a new patch series. Steve On 6/9/20 5:51 PM, Steve Longerbeam wrote: Call ipu_idmac_wait_busy() o

[PATCH][next] drm/virtio: Use struct_size() helper in kmalloc()

2020-06-17 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/virtio/virtgpu_gem.c | 3 +-- 1 file ch

[PATCH][next] drm/vmwgfx: Use struct_size() helper

2020-06-17 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 2 +- 1 file

Re: [PATCH v4 22/37] dt-bindings: host1x: Document new interconnect properties

2020-06-17 Thread Rob Herring
On Tue, Jun 09, 2020 at 04:13:49PM +0300, Dmitry Osipenko wrote: > Most of Host1x devices have at least one memory client. These clients > are directly connected to the memory controller. The new interconnect > properties represent the memory client's connection to the memory > controller. > > Sig

[PATCH 1/2] drm/msm: Fix address space size after refactor.

2020-06-17 Thread Eric Anholt
Previously the address space went from 16M to ~0u, but with the refactor one of the 'f's was dropped, limiting us to 256MB. Additionally, the new interface takes a start and size, not start and end, so we can't just copy and paste. Fixes regressions in dEQP-VK.memory.allocation.random.* Fixes: cc

[PATCH 2/2] drm/msm: Fix setup of a6xx create_address_space.

2020-06-17 Thread Eric Anholt
We don't want it under CONFIG_DRM_MSM_GPU_STATE, we need it all the time (like the other GPUs do). Fixes: ccac7ce373c1 ("drm/msm: Refactor address space initialization") Signed-off-by: Eric Anholt --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH v6 4/5] drm/msm: Refactor address space initialization

2020-06-17 Thread Eric Anholt
On Wed, Jun 17, 2020 at 1:16 PM Eric Anholt wrote: > > On Thu, Apr 9, 2020 at 4:34 PM Jordan Crouse wrote: > > > > Refactor how address space initialization works. Instead of having the > > address space function create the MMU object (and thus require separate but > > equal functions for gpummu

Re: [PATCH v3 006/105] dt-bindings: display: Convert VC4 bindings to schemas

2020-06-17 Thread Rob Herring
On Wed, May 27, 2020 at 9:49 AM Maxime Ripard wrote: > > The BCM283x SoCs have a display pipeline composed of several controllers > with device tree bindings that are supported by Linux. > > Now that we have the DT validation in place, let's split into separate > files and convert the device tree

Re: [PATCH v6 4/5] drm/msm: Refactor address space initialization

2020-06-17 Thread Eric Anholt
On Thu, Apr 9, 2020 at 4:34 PM Jordan Crouse wrote: > > Refactor how address space initialization works. Instead of having the > address space function create the MMU object (and thus require separate but > equal functions for gpummu and iommu) use a single function and pass the > MMU struct in. M

[radeon-alex:drm-next 317/414] drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c:2480:28: sparse: sparse: cast to restricted __le32

2020-06-17 Thread kernel test robot
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next head: f59073f6df9b07d94917221486cf5929efa6b315 commit: 00e86cf4bb21d5904053da0c2327dbcfa21f22ca [317/414] drm/amd/powerplay: move powerplay table operation out of smu_v11_0.c config: i386-randconfig-s001-20200617 (attached as

Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe

2020-06-17 Thread Rob Herring
On Wed, Jun 17, 2020 at 8:36 AM Steven Price wrote: > > On 17/06/2020 15:15, Krzysztof Kozlowski wrote: > > On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote: > >> Reviewed-by: Alyssa Rosenzweig > >> > >> On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote: > >>> T

Re: [PATCH] drm/mgag200: Don't set in MISC

2020-06-17 Thread Emil Velikov
On Wed, 17 Jun 2020 at 07:28, Thomas Zimmermann wrote: > Maybe I can write a better commit message to highlight the change. > That would be amazing, thank you. Emil ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.or

Re: linux-next: build failure after merge of the drm-misc tree

2020-06-17 Thread Emil Velikov
Hi Stephen, On Wed, 17 Jun 2020 at 08:03, Stephen Rothwell wrote: > > Hi Thomas, > > On Wed, 17 Jun 2020 08:33:24 +0200 Thomas Zimmermann > wrote: > > > > We recently dropped the _unlock() suffix from drm_gem_object_put(). This > > patch should be ok. > > Yes, but what it shows is that the drm-

Re: [PATCH v2 2/2] drm/amdgpu/debugfs: fix memory leak when amdgpu_virt_enable_access_debugfs failed

2020-06-17 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Jun 17, 2020 at 9:10 AM Chen Tao wrote: > > Fix memory leak in amdgpu_debugfs_gpr_read not freeing data when > amdgpu_virt_enable_access_debugfs failed. > > Fixes: 95a2f917387a2 ("drm/amdgpu: restrict debugfs register accessunder > SR-IOV") > Signed-off-by: Chen T

Re: [PATCH] drm/edid: add support for min horizontal rate equal to max horizontal rate

2020-06-17 Thread Ville Syrjälä
On Thu, Jun 18, 2020 at 12:58:33AM +0800, Cyrus Lien wrote: > On Tue, Jun 9, 2020 at 10:58 PM Ville Syrjälä > wrote: > > > On Tue, Jun 09, 2020 at 03:57:04AM +0800, Cyrus Lien wrote: > > > According to EDID spec, table 3.26, byte #6 and #8, which said "Minimum > > > rate value shall be less than

[PATCH][next] fbdev/fb.h: Use struct_size() helper in kzalloc()

2020-06-17 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva --- include/linux/fb.h | 5 +++-- 1 file changed, 3 inserti

RE: [PATCH] dmabuf: use spinlock to access dmabuf->name

2020-06-17 Thread Ruhl, Michael J
>-Original Message- >From: charante=codeaurora@mg.codeaurora.org > On Behalf Of Charan Teja >Kalla >Sent: Wednesday, June 17, 2020 2:29 AM >To: Ruhl, Michael J ; Sumit Semwal >; open list:DMA BUFFER SHARING FRAMEWORK >; DRI mailing list de...@lists.freedesktop.org> >Cc: Linaro MM SIG ;

[radeon-alex:drm-next 333/414] arch/arc/include/asm/bug.h:22:2: error: implicit declaration of function 'pr_warn'; did you mean

2020-06-17 Thread kernel test robot
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next head: f59073f6df9b07d94917221486cf5929efa6b315 commit: 5872ef0b03247fe659226973998ff28e835afbe4 [333/414] drm/amd/powerplay: forbid to use pr_err/warn/info/debug config: arc-allyesconfig (attached as .config) compiler: arc-elf-gcc (G

Re: [PATCH] drm/edid: add support for min horizontal rate equal to max horizontal rate

2020-06-17 Thread Cyrus Lien
On Tue, Jun 9, 2020 at 10:58 PM Ville Syrjälä wrote: > On Tue, Jun 09, 2020 at 03:57:04AM +0800, Cyrus Lien wrote: > > According to EDID spec, table 3.26, byte #6 and #8, which said "Minimum > > rate value shall be less than or equal to maximum rate value". The > minimum > > horizontal/vertical r

[linux-next:master 953/2089] drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:446:6: sparse: sparse: symbol 'vcn_v2_5_mc_resume_dpg_mode' was not declared. Should it be

2020-06-17 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 5fcb9628fd1227a5f11d87171cb1b8b5c414d9d9 commit: c422a628925d9733b0807d803133fb78a0a0f707 [953/2089] drm/amdgpu: rename macro for VCN2.0 2.5 and 3.0 config: i386-randconfig-s001-20200617 (attached as

[RFC PATCH linux-next] drm/amdgpu: vcn_v2_5_mc_resume_dpg_mode() can be static

2020-06-17 Thread kernel test robot
Fixes: c422a628925d ("drm/amdgpu: rename macro for VCN2.0 2.5 and 3.0") Signed-off-by: kernel test robot --- vcn_v2_5.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c index 261afbb504bd0

[PATCH] drm/fbdev: fix a memory leak on the dmt_mode object

2020-06-17 Thread Colin King
From: Colin Ian King Object drm_mode is allocated by the call to drm_mode_find_dmt (via the call to drm_mode_duplicate and drm_mode_create). The object is never free'd and hence causes a small memory leak. Fix this by kfree'ing drm_mode once it is no longer required. Addresses-Coverity: ("Resour

[PATCH v3 15/22] drm: mxsfb: Remove mxsfb_devdata unused fields

2020-06-17 Thread Laurent Pinchart
The debug0 and ipversion fields of the mxsfb_devdata structure are unused. Remove them. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 drivers/gpu/drm/mxsfb/mxsfb_drv.h | 2 -- 2 files changed, 6 deletions(-)

[PATCH v3 20/22] drm: mxsfb: Merge mxsfb_set_pixel_fmt() and mxsfb_set_bus_fmt()

2020-06-17 Thread Laurent Pinchart
The mxsfb_set_pixel_fmt() and mxsfb_set_bus_fmt() functions both deal with format configuration, are always called in a row from mxsfb_crtc_mode_set_nofb(), and set fields from the LCDC_CTRL register. This requires a read-modify-update cycle in mxsfb_set_bus_fmt(). Make this more efficient by mergi

[PATCH v3 17/22] drm: mxsfb: Update internal IP version number for i.MX6SX

2020-06-17 Thread Laurent Pinchart
The LCDIF present in the i.MX6SX has extra features compared to the i.MX28. It has however lost its IP version register, so no official version number is known. Bump the version to MXSFB_V6 following the i.MX version, in preparation for support for the additional features. Signed-off-by: Laurent P

[PATCH v3 21/22] drm: mxsfb: Remove unnecessary spaces after tab

2020-06-17 Thread Laurent Pinchart
This is a cosmetic change only, no code change is included. Signed-off-by: Laurent Pinchart Reviewed-by: Emil Velikov Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_drv.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.h

[PATCH v3 16/22] drm: mxsfb: Add i.MX7 and i.MX8M to the list of supported SoCs in Kconfig

2020-06-17 Thread Laurent Pinchart
Extend the Kconfig option description by listing the i.MX7 and i.MX8M SoCs, as they are supported by the same driver. Replace the list of SoCs in the short description with just "(e)LCDIF LCD controller" to avoid expanding it further in the future as support for more SoCs is added. Signed-off-by:

[PATCH v3 22/22] drm: mxsfb: Support the alpha plane

2020-06-17 Thread Laurent Pinchart
The LCDIF in the i.MX6SX and i.MX7 have a second plane called the alpha plane. Support it. Signed-off-by: Laurent Pinchart Reviewed-by: Emil Velikov Reviewed-by: Stefan Agner --- Changes since v1: - Split whitespace cleanup to a separate patch --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 + d

[PATCH v3 09/22] drm: mxsfb: Remove unneeded includes

2020-06-17 Thread Laurent Pinchart
A fair number of includes are not needed. Drop them, and add a couple of required includes that were included indirectly. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 12 +++- drivers/gpu/drm/mxsfb/mxsfb_dr

[PATCH v3 18/22] drm: mxsfb: Drop non-OF support

2020-06-17 Thread Laurent Pinchart
The mxsfb driver is only used by OF platforms. Drop non-OF support. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/drivers/g

[PATCH v3 14/22] drm: mxsfb: Enable vblank handling

2020-06-17 Thread Laurent Pinchart
Enable vblank handling when the CRTC is turned on and disable it when it is turned off. This requires moving vblank init after the KMS pipeline initialisation, otherwise drm_vblank_init() gets called with 0 CRTCs. Signed-off-by: Laurent Pinchart Reviewed-by: Emil Velikov Reviewed-by: Stefan Agne

[PATCH v3 19/22] drm: mxsfb: Turn mxsfb_set_pixel_fmt() into a void function

2020-06-17 Thread Laurent Pinchart
The mxsfb_set_pixel_fmt() function returns an error when the selected pixel format is unsupported. This can never happen, as such errors are caught by the DRM core. Remove the error check. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers/gpu/drm/m

[PATCH v3 12/22] drm: mxsfb: Move vblank event arm to CRTC .atomic_flush()

2020-06-17 Thread Laurent Pinchart
The vblank event is armed in the plane .atomic_update(). This works fine as we have a single plane, and was the only option when the driver was using the drm_simple_kms_helper helper, but will break as soon as multiple planes are supported. Move it to CRTC .atomic_flush(). Signed-off-by: Laurent P

[PATCH v3 02/22] drm: mxsfb: Use drm_panel_bridge

2020-06-17 Thread Laurent Pinchart
Replace the manual connector implementation based on drm_panel with the drm_panel_bridge helper. This simplifies the mxsfb driver by removing connector-related code, and standardizing all pipeline control operations on bridges. A hack is needed to get hold of the connector, as that's our only sour

[PATCH v3 13/22] drm: mxsfb: Don't touch AXI clock in IRQ context

2020-06-17 Thread Laurent Pinchart
The driver attempts agressive power management by enabling and disabling the AXI clock around register accesses. This results in attempts to enable and disable the clock in the IRQ handler, which is a no-go as preparing or unpreparing the clock may sleep. On the other hand, the driver enables the

[PATCH v3 06/22] drm: mxsfb: Pass mxsfb_drm_private pointer to mxsfb_reset_block()

2020-06-17 Thread Laurent Pinchart
The mxsfb_reset_block() function isn't special, pass it the mxsfb_drm_private pointer instead of a pointer to the base address. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 12 ++-- 1 file changed, 6 insert

[PATCH v3 10/22] drm: mxsfb: Rename mxsfb_crtc.c to mxsfb_kms.c

2020-06-17 Thread Laurent Pinchart
The mxsfb_crtc.c file doesn't handle just the CRTC, but also the other KMS objects. Rename it accordingly. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers/gpu/drm/mxsfb/Makefile | 2 +- drivers/gpu/drm/mxsfb/{mxsfb_crtc.c =>

[PATCH v3 05/22] drm: mxsfb: Clarify format and bus width configuration

2020-06-17 Thread Laurent Pinchart
Replace the convoluted way to set the format and bus width through difficult to read macros with more explicit ones. Also remove the outdated comment related to the limitations on bus width setting as it doesn't apply anymore (the bus width can be specified through the display_info bus format). Si

[PATCH v3 11/22] drm: mxsfb: Stop using DRM simple display pipeline helper

2020-06-17 Thread Laurent Pinchart
The DRM simple display pipeline helper only supports a single plane. In order to prepare for support of the alpha plane on i.MX6SX and i.MX7, move away from the helper. No new feature is added. Signed-off-by: Laurent Pinchart Reviewed-by: Emil Velikov Reviewed-by: Stefan Agner --- Changes since

[PATCH v3 03/22] drm: mxsfb: Use BIT() macro to define register bitfields

2020-06-17 Thread Laurent Pinchart
Using BIT() is preferred over manual shifts as it's more readable, handles the 1 << 31 case properly, and avoids other mistakes as shown by the DEBUG0_HSYNC and DEBUG0_VSYNC bits (that are currently unused). Use it. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Veli

[PATCH v3 00/22] drm: mxsfb: Add i.MX7 support

2020-06-17 Thread Laurent Pinchart
Hello, This patch series adds i.MX7 support to the mxsfb driver. The eLCDIF instance found in the i.MX7 is backward-compatible with the already supported LCDC v4, but has extended features amongst which the most notable one is a second plane. The first 10 patches (01/22 to 10/22) contain miscella

[PATCH v3 07/22] drm: mxsfb: Use LCDC_CTRL register name explicitly

2020-06-17 Thread Laurent Pinchart
The LCDC_CTRL register is located at address 0x. Some of the accesses to the register simply use the mxsfb->base address. Reference the LCDC_CTRL register explicitly instead to clarify the code. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers

[PATCH v3 08/22] drm: mxsfb: Remove register definitions from mxsfb_crtc.c

2020-06-17 Thread Laurent Pinchart
mxsfb_crtc.c defines several macros related to register addresses and bit, which duplicates macros from mxsfb_regs.h. Use the macros from mxsfb_regs.h instead and remove them. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers/gpu/drm/mxsfb/mxsfb_cr

[PATCH v3 01/22] drm: mxsfb: Remove fbdev leftovers

2020-06-17 Thread Laurent Pinchart
Commit 8e93f1028d74 ("drm/mxsfb: Use drm_fbdev_generic_setup()") replaced fbdev handling with drm_fbdev_generic_setup() but left inclusion of the drm/drm_fb_cma_helper.h header. Remove it. Fixes: 8e93f1028d74 ("drm/mxsfb: Use drm_fbdev_generic_setup()") Signed-off-by: Laurent Pinchart Reviewed-by

[PATCH v3 04/22] drm: mxsfb: Remove unused macros from mxsfb_regs.h

2020-06-17 Thread Laurent Pinchart
mxsfb_regs.h defines macros related to register bits. Some of them are not used and don't clearly map to any particular register, so their purpose isn't known. Remove them. Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner Reviewed-by: Emil Velikov --- drivers/gpu/drm/mxsfb/mxsfb_regs.

Re: [PATCH v3] drm/tegra: Add zpos property for cursor planes

2020-06-17 Thread Thierry Reding
On Wed, Jun 17, 2020 at 05:20:14PM +0300, Dmitry Osipenko wrote: > 17.06.2020 17:10, Thierry Reding пишет: > > On Tue, Jun 16, 2020 at 09:39:19PM +0300, Dmitry Osipenko wrote: > >> 16.06.2020 21:14, Thierry Reding пишет: > >>> From: Thierry Reding > >>> > >>> As of commit 4dc55525b095 ("drm: plane

Re: [PATCH v2 22/22] drm: mxsfb: Support the alpha plane

2020-06-17 Thread Stefan Agner
On 2020-05-30 05:10, Laurent Pinchart wrote: > The LCDIF in the i.MX6SX and i.MX7 have a second plane called the alpha > plane. Support it. > > Signed-off-by: Laurent Pinchart Looks good to me. Reviewed-by: Stefan Agner -- Stefan > --- > Changes since v1: > > - Split whitespace cleanup to a

[PATCH][next] drm/mm/selftests: fix unsigned comparison with less than zero

2020-06-17 Thread Colin King
From: Colin Ian King Function get_insert_time can return error values that are cast to a u64. The checks of insert_time1 and insert_time2 check for the errors but because they are u64 variables the check for less than zero can never be true. Fix this by casting the value to s64 to allow of the ne

Re: [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-17 Thread Rob Herring
On Tue, Jun 16, 2020 at 5:15 AM Stephen Boyd wrote: > > Quoting Tanmay Shah (2020-06-11 18:50:26) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > > b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > > new file mode 100644 > > index ..5fdb9

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-06-17 Thread Ville Syrjälä
On Wed, Jun 17, 2020 at 11:58:10AM +0200, Daniel Vetter wrote: > On Wed, Jun 10, 2020 at 03:33:06PM -0700, Paulo Zanoni wrote: > > Em qui, 2020-05-28 às 11:09 +0530, Karthik B S escreveu: > > > Add enable/disable flip done functions and the flip done handler > > > function which handles the flip do

Re: [PATCH v2 6/6] drm/i915/dp_mst: Ensure the DPCD ACT sent flag is cleared before waiting for it

2020-06-17 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks for all the subtle fixes for broken MST displays, these are always my favorite to find :) On Wed, 2020-06-17 at 00:11 +0300, Imre Deak wrote: > Atm, we clear the ACT sent flag in the sink's DPCD before updating the > sink's payload table, along clearing the payload

Re: [PATCH v2 02/22] drm: mxsfb: Use drm_panel_bridge

2020-06-17 Thread Stefan Agner
On 2020-05-30 05:09, Laurent Pinchart wrote: > Replace the manual connector implementation based on drm_panel with the > drm_panel_bridge helper. This simplifies the mxsfb driver by removing > connector-related code, and standardizing all pipeline control > operations on bridges. > > A hack is nee

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: Add enable/disable flip done and flip done handler

2020-06-17 Thread Kazlauskas, Nicholas
On 2020-06-17 5:58 a.m., Daniel Vetter wrote: On Wed, Jun 10, 2020 at 03:33:06PM -0700, Paulo Zanoni wrote: Em qui, 2020-05-28 às 11:09 +0530, Karthik B S escreveu: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip

Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe

2020-06-17 Thread Steven Price
On 17/06/2020 15:15, Krzysztof Kozlowski wrote: On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote: Reviewed-by: Alyssa Rosenzweig On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote: There is no point to print deferred probe (and its failures to get resources)

Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe

2020-06-17 Thread Krzysztof Kozlowski
On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote: > Reviewed-by: Alyssa Rosenzweig > > On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote: > > There is no point to print deferred probe (and its failures to get > > resources) as an error. Also there is no need to

Re: [PATCH v3] drm/tegra: Add zpos property for cursor planes

2020-06-17 Thread Thierry Reding
On Tue, Jun 16, 2020 at 09:39:19PM +0300, Dmitry Osipenko wrote: > 16.06.2020 21:14, Thierry Reding пишет: > > From: Thierry Reding > > > > As of commit 4dc55525b095 ("drm: plane: Verify that no or all planes > > have a zpos property") a warning is emitted if there's a mix of planes > > with and

[Bug 206017] Kernel 5.4.x unusable with GUI due to crashes (some hard)

2020-06-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206017 --- Comment #19 from udo (udo...@xs4all.nl) --- Appears to work OK for me: AMD Ryzen 5 3400G with Radeon Vega Graphics on Gigabyte X570 AORUS PRO, Fedora 31, git mesa, kernel.org 5.6.x, etc amdgpu.gttsize=8192 amdgpu.lockup_timeout=1000 amdgpu.g

Re: [PATCH v5 08/12] device core: Introduce multiple dma pfn offsets

2020-06-17 Thread Robin Murphy
Hi Jim, Thanks for taking this on! On 2020-06-16 21:55, Jim Quinlan wrote: The new field in struct device 'dma_pfn_offset_map' is used to facilitate the use of single or multiple pfn offsets between cpu addrs and dma addrs. It subsumes the role of dev->dma_pfn_offset -- a uniform offset. This

Re: [PATCH] drm/mgag200: Don't set in MISC

2020-06-17 Thread Thomas Zimmermann
Hi Am 17.06.20 um 11:22 schrieb Rong Chen: > On Wed, Jun 17, 2020 at 08:28:02AM +0200, Thomas Zimmermann wrote: >> Hi Emil >> >> Am 16.06.20 um 17:14 schrieb Emil Velikov: >>> Hi Thomas, >>> >>> On Tue, 16 Jun 2020 at 15:26, Thomas Zimmermann wrote: The original modesetting code set MIS

[PATCH v5 08/12] device core: Introduce multiple dma pfn offsets

2020-06-17 Thread Jim Quinlan
The new field in struct device 'dma_pfn_offset_map' is used to facilitate the use of single or multiple pfn offsets between cpu addrs and dma addrs. It subsumes the role of dev->dma_pfn_offset -- a uniform offset. The function of_dma_get_range() has been modified to take two additional arguments:

[PATCH v5 00/12] PCI: brcmstb: enable PCIe for STB chips

2020-06-17 Thread Jim Quinlan
Patchset Summary: Enhance a PCIe host controller driver. Because of its unusual design we are foced to change dev->dma_pfn_offset into a more general role allowing multiple offsets. v5: Commit "device core: Introduce multiple dma pfn offsets" -- in of/address.c: "map_size = 0" => "*map_

Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after platform data removal

2020-06-17 Thread Grygorii Strashko
On 16/06/2020 18:30, Tony Lindgren wrote: * Tomi Valkeinen [200616 13:02]: On 11/06/2020 17:00, Grygorii Strashko wrote: I think, suspend might be fixed if all devices, which are now child of ti-sysc, will do pm_runtime_force_xxx() calls at noirq suspend stage by adding: SET_NOIRQ_SY

[PATCH v3 2/3] dt-bindings: display: bridge: Add documentation for LT9611

2020-06-17 Thread Vinod Koul
Lontium LT9611 is a DSI to HDMI bridge which supports 2 DSI ports and I2S port as input and one HDMI port as output Reviewed-by: Rob Herring Signed-off-by: Vinod Koul --- .../display/bridge/lontium,lt9611.yaml| 176 ++ 1 file changed, 176 insertions(+) create mode 10064

[PATCH v3 3/3] drm/bridge: Introduce LT9611 DSI to HDMI bridge

2020-06-17 Thread Vinod Koul
Lontium Lt9611 is a DSI to HDMI bridge which supports two DSI ports and I2S port as an input and HDMI port as output Co-developed-by: Bjorn Andersson Signed-off-by: Bjorn Andersson Co-developed-by: Srinivas Kandagatla Signed-off-by: Srinivas Kandagatla Signed-off-by: Vinod Koul --- drivers/g

  1   2   >