Re: [PATCH] MAINTAINERS: Fix pattern for Documentation path for Arm Mali Komeda

2019-03-26 Thread james qian wang (Arm Technology China)
On Tue, Mar 26, 2019 at 10:32:03AM +, Liviu Dudau wrote: > The Device Tree bindings documentation file is in a simplified path > that doesn't match the MAINTAINERS entry. > > Reported-by: Joe Perches > Signed-off-by: Liviu Dudau > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+),

[PATCH] drm/exynos: g2d: remove style error

2019-03-26 Thread Seung-Woo Kim
Remove checkpatch error, "foo* bar" should be "foo *bar". Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 24

[Bug 110143] [Regression] Doom 3: BFG Edition - Steam and GOG.com - white flickering screen

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110143 Timothy Arceri changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #4 from Timothy A

2019 Election and By-laws approval voting OPEN

2019-03-26 Thread Wentland, Harry
To all X.Org Foundation Members: The X.Org Foundation's annual election is now open and will remain open until 02:00 UTC on 11 April 2019. Four of the eight director seats are open during this election, with the four nominees receiving the highest vote totals serving as directors for two year

[Bug 110214] amdgpu: xterm scrollback buffer disappears while paging up/down

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110214 --- Comment #13 from Diego Viola --- I can also reproduce the issue with Xephyr -glamor. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@

linux-next: build failure after merge of the drm-intel tree

2019-03-26 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (i386 defconfig) failed like this: In file included from drivers/gpu/drm/i915/intel_guc.h:28:0, from drivers/gpu/drm/i915/intel_uc.h:27, from drivers/gpu/drm/i915/intel_uc.c:25: drivers/gpu/drm/i9

[Bug 106571] Stoney [Radeon R5 Graphics] [1002:98E4] hangs on hibernate

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106571 --- Comment #4 from ukbeas...@protonmail.com --- Linux 5.0-rc2 had changes to amdgpu that mentioned resume changes. "drm/amdgpu: Don't ignore rc from drm_dp_mst_topology_mgr_resume() drm/amdgpu: Don't fail resume process if resuming atomic state

Re: [PATCH v3 RESEND 00/24] drm/exynos: add support for GSCALER planes on Exynos5433

2019-03-26 Thread Inki Dae
19. 3. 26. 오후 10:51에 Andrzej Hajda 이(가) 쓴 글: > On 26.03.2019 09:45, Inki Dae wrote: >> Hi Andrzej, >> >> 19. 3. 25. 오후 4:13에 Andrzej Hajda 이(가) 쓴 글: >>> Hi Inki, >>> >>> GSCALERs in Exynos SoCs support conversion between wide range of image >>> formats, >>> plus scaling and rotation. >>> Driver

[Bug 110214] amdgpu: xterm scrollback buffer disappears while paging up/down

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110214 --- Comment #12 from Diego Viola --- I also tried recompiling xorg-server (git and 1.20.0) and the problem still persists with those, I can't compile older releases anymore due to compile time errors. -- You are receiving this mail because: Yo

[Bug 202043] amdgpu: Vega 56 SCLK drops to 700 Mhz when undervolting

2019-03-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202043 --- Comment #7 from mista...@gmail.com --- Best results performance wise had with following setup: echo 27500 >> /sys/class/drm/card0/device/hwmon/hwmon0/power1_cap echo "m 3 1100 1000" > /sys/class/drm/card0/device/pp_od_clk_voltage GPU clo

[Bug 202043] amdgpu: Vega 56 SCLK drops to 700 Mhz when undervolting

2019-03-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202043 mista...@gmail.com changed: What|Removed |Added CC||mista...@gmail.com --- Comment #6 fr

[Bug 110229] The driver is not waiting the shader have finished to update the framebuffer before displaying it.

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110229 --- Comment #7 from Laurent --- Ha! I think I've found why the shader output is not good if my guessing about how the CPU and the GPU works together is good. I'll try to change it and recompile it to see if it works. -- You are receiving this

[Bug 110214] amdgpu: xterm scrollback buffer disappears while paging up/down

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110214 --- Comment #11 from Diego Viola --- Tried mesa git (19.1.0-devel) with LLVM 9.0.0 (SVN) and the issue still persists. -- You are receiving this mail because: You are the assignee for the bug.___ dri

[PATCH] drm: headers: Add neccessary include files and guards

2019-03-26 Thread Ahmed S. Darwish
Otherwise gcc will complain about unknown types, and declarations inside parameter lists, if "drm_internal.h" is used in C files with less headers than what's now typically done under drivers/gpu/drm/. Signed-off-by: Ahmed S. Darwish --- Notes: This was triggered by the in-development drm-pa

[Bug 110251] Buffer age seems to be incorrect

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110251 Yuxuan Shui changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) -- You are receiving this

[Bug 110251] Buffer age seems incorrect

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110251 Bug ID: 110251 Summary: Buffer age seems incorrect Product: Mesa Version: 19.0 Hardware: Other OS: All Status: NEW Severity: normal Priority: m

[Bug 110251] Buffer age seems to be incorrect

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110251 Yuxuan Shui changed: What|Removed |Added Summary|Buffer age seems incorrect |Buffer age seems to be

[Bug 110229] The driver is not waiting the shader have finished to update the framebuffer before displaying it.

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110229 --- Comment #6 from Laurent --- Mmm... ok it's when I'm using a shader that the bug appears (without shaders, it works), I'll try to run gallium in Debug mode to see if the shaders outputs are correct, and if so, this is probably the attached fr

[Bug 110250] [Regression linux 5.1-rc1] Displayport 1.2 tty second monitor corruption

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110250 Bug ID: 110250 Summary: [Regression linux 5.1-rc1] Displayport 1.2 tty second monitor corruption Product: DRI Version: unspecified Hardware: x86-64 (AMD64)

Re: [PATCH 3/4] drm: Kill drm_display_info.name

2019-03-26 Thread Sam Ravnborg
Hi Ville. On Tue, Mar 26, 2019 at 07:34:00PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_display_info.name is only ever set by a few panel drveirs but drivers Nice clean-up! Sam __

Re: [Intel-gfx] [PATCH 03/16] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 06:55:33PM +0100, Noralf Trønnes wrote: > Prepare for moving drm_fb_helper modesetting code to drm_client. > drm_client will be linked to drm.ko, so move > __drm_atomic_helper_disable_plane() and __drm_atomic_helper_set_config() > out of drm_kms_helper.ko. > > While at it,

[PATCH v2 5/5] drm/rockchip: Use drm_atomic_helper_commit_tail_rpm

2019-03-26 Thread Sean Paul
From: Sean Paul Now that we use the drm psr helpers, we no longer need to hand-roll our atomic_commit_tail implementation. So use the helper Changes in v2: - None Link to v1: https://patchwork.freedesktop.org/patch/msgid/20190228210939.83386-6-s...@poorly.run Cc: Zain Wang Cc: Tomasz Figa S

[PATCH v2 2/5] drm/rockchip: Check for fast link training before enabling psr

2019-03-26 Thread Sean Paul
From: Sean Paul Once we start shutting off the link during PSR, we're going to want fast training to work. If the display doesn't support fast training, don't enable psr. Changes in v2: - None Link to v1: https://patchwork.freedesktop.org/patch/msgid/20190228210939.83386-3-s...@poorly.run Cc:

[PATCH v2 4/5] drm/rockchip: Don't fully disable vop on self refresh

2019-03-26 Thread Sean Paul
From: Sean Paul Instead of fully disabling and re-enabling the vop on self refresh transitions, only disable the active windows. This will speed up self refresh exits substantially and is still a power-savings win. This patch integrates portions of Zain's patch from here: https://patchwork.kerne

[PATCH v2 3/5] drm/rockchip: Use the helpers for PSR

2019-03-26 Thread Sean Paul
From: Sean Paul Instead of rolling our own implementation for tracking when PSR should be [in]active, use the new self refresh helpers to do the heavy lifting. Changes in v2: - updated to reflect changes made in the helpers Link to v1: https://patchwork.freedesktop.org/patch/msgid/201902282109

[PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-03-26 Thread Sean Paul
From: Sean Paul This patch adds a new drm helper library to help drivers implement self refresh. Drivers choosing to use it will register crtcs and will receive callbacks when it's time to enter or exit self refresh mode. In its current form, it has a timer which will trigger after a driver-spec

Re: [Intel-gfx] [PATCH 16/16] drm/vc4: Call drm_dev_register() after all setup is done

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 06:55:46PM +0100, Noralf Trønnes wrote: > drm_dev_register() initializes internal clients like bootsplash as the > last thing it does, so all setup needs to be done at this point. > > Fix by calling vc4_kms_load() before registering. > Also check the error code returned fro

Re: [PATCH v8] drm/lima: driver for ARM Mali4xx GPUs

2019-03-26 Thread Vasily Khoruzhick
Hi, So what's the status of it? Has it been merged? I don't see it in drm-misc-next. Regards, Vasily On Tue, Mar 12, 2019 at 1:12 AM Heiko Stuebner wrote: > > Hi, > > Am Dienstag, 12. März 2019, 02:54:57 CET schrieb Qiang Yu: > > On Mon, Mar 11, 2019 at 11:37 PM Rob Herring wrote: > > > > > >

Re: [PATCH] drm/sun4i: hdmi: add support for ddc-i2c-bus property

2019-03-26 Thread Maxime Ripard
On Thu, Mar 21, 2019 at 06:00:45PM +, Måns Rullgård wrote: > Maxime Ripard writes: > > > On Tue, Mar 19, 2019 at 12:48:19PM +, Måns Rullgård wrote: > >> Maxime Ripard writes: > >> > >> > On Mon, Mar 18, 2019 at 04:23:56PM +, Måns Rullgård wrote: > >> >> Maxime Ripard writes: > >> >>

[Bug 110143] [Regression] Doom 3: BFG Edition - Steam and GOG.com - white flickering screen

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110143 --- Comment #3 from h...@inbox.lv --- (In reply to andrew.m.mcmahon from comment #2) > Just out of interest RBDoom3-BFG works perfectly. > Consider compiling the latest master rather than running Doom 3 through > Wine/Proton. Your RX580 shouldn't

Re: FW: [PATCH] drm/dp: Add DP phy test pattern DPCD bit definitions

2019-03-26 Thread Kumar, Abhay
-Original Message- From: Taylor, Clinton A Sent: Thursday, March 21, 2019 3:42 PM To: dri-devel@lists.freedesktop.org Cc: Taylor, Clinton A Subject: [PATCH] drm/dp: Add DP phy test pattern DPCD bit definitions From: Clinton Taylor Added PHY_TEST_PATTERN_SEL bit definitions for DPCD 0

Re: [PATCH 02/16] drm/fb-helper: dpms_legacy(): Only set on connectors in use

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 06:55:32PM +0100, Noralf Trønnes wrote: > For each enabled crtc the functions sets dpms on all registered connectors. > Limit this to only doing it once and on the connectors actually in use. > > Signed-off-by: Noralf Trønnes Fixes: 023eb571a1d0 ("drm: correctly update con

Re: [Intel-gfx] [PATCH 01/16] drm/fb-helper: Remove unused gamma_size variable

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 06:55:31PM +0100, Noralf Trønnes wrote: > The gamma_size variable has not been used since > commit 4abe35204af8 ("drm/kms/fb: use slow work mechanism for normal hotplug > also.") > > While in the area move a comment back to its code block. > They got separated by > commit

Re: [PATCH 11/11] drm/fbdevdrm: Detect and validate display modes

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 06:47:41PM +0200, Ville Syrjälä wrote: > On Tue, Mar 26, 2019 at 10:17:44AM +0100, Thomas Zimmermann wrote: > > Mode detection currently reports the modes listed in fb_info::modelist. > > The list is either build from EDID information or, more often, a list of > > previously

Re: [PATCH] drm/sun4i: Eliminate pointless on stack copy of drm_display_info

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 07:38:10PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Just use a pointer to the display_info rather than make a copy > on stack. > > Cc: Maxime Ripard > Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/sun4i/sun4i_tcon.c | 8

Re: [PATCH 4/4] drm/uapi: Remove unused DRM_DISPLAY_INFO_LEN

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 07:34:01PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Remove the unused DRM_DISPLAY_INFO_LEN from the uapi headers. > I presume the original plan was to expose the display name > via getconnector, but looks like that never happened. So we have > the define for t

Re: [Intel-gfx] [PATCH 3/4] drm: Kill drm_display_info.name

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 07:34:00PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_display_info.name is only ever set by a few panel drveirs but > never actually used anywhere except in i915 debugfs code. Trash it. > > Signed-off-by: Ville Syrjälä Huh, nice find. Reviewed-by: Daniel

Re: [PATCH 2/4] drm: Fix tabs vs. spaces

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 07:33:59PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > A set of 8 spaces has snuck in. Replace with a tab, and > toss in an extra newline while at it. > > Signed-off-by: Ville Syrjälä > --- > include/drm/drm_connector.h | 3 ++- > 1 file changed, 2 insertions(

Re: [PATCH 1/4] drm: Nuke unused drm_display_info.pixel_clock

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 07:33:58PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_display_info.pixel_clock is unused. Let's get rid of it. > > Signed-off-by: Ville Syrjälä > --- > include/drm/drm_connector.h | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/include/drm/

Re: [PATCH] drm/sun4i: Eliminate pointless on stack copy of drm_display_info

2019-03-26 Thread Maxime Ripard
On Tue, Mar 26, 2019 at 07:38:10PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Just use a pointer to the display_info rather than make a copy > on stack. > > Cc: Maxime Ripard > Signed-off-by: Ville Syrjälä Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and

[PATCH 14/16] drm/client: Add display abstraction

2019-03-26 Thread Noralf Trønnes
Add display abstraction and helpers to probe for displays and commit modesets. TODO: If the bootsplash client doesn't need to subclass drm_client_display, the callbacks can be removed. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c | 415 +++ incl

[PATCH 15/16] drm/client: Hack: Add bootsplash example

2019-03-26 Thread Noralf Trønnes
An example to showcase the client API. TODO: A bootsplash client needs a way to tell drm_fb_helper to stay away, otherwise it will chime in on setup and hotplug. Most DRM drivers register fbdev before calling drm_dev_register() (the generic emulation is an exception). This have to be reversed for

[PATCH 16/16] drm/vc4: Call drm_dev_register() after all setup is done

2019-03-26 Thread Noralf Trønnes
drm_dev_register() initializes internal clients like bootsplash as the last thing it does, so all setup needs to be done at this point. Fix by calling vc4_kms_load() before registering. Also check the error code returned from that function. Cc: Eric Anholt Signed-off-by: Noralf Trønnes --- dri

[PATCH 13/16] drm/fb-helper: Avoid race with DRM userspace

2019-03-26 Thread Noralf Trønnes
drm_fb_helper_is_bound() is used to check if DRM userspace is in control. This is done by looking at the fb on the primary plane. By the time fb-helper gets around to committing, it's possible that the facts have changed. Avoid this race by holding the drm_device->master_mutex lock while committin

[PATCH 12/16] drm/fb-helper: Move out modeset config code

2019-03-26 Thread Noralf Trønnes
No functional changes, just moving code as-is and fixing includes. There is one addition and that is exporting drm_client_modesets_probe(). Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c| 698 drivers/gpu/drm/drm_fb_helper.c | 697

[PATCH 11/16] drm/fb-helper: Prepare to move out modeset config code

2019-03-26 Thread Noralf Trønnes
This prepares the modeset code so it can be moved out as-is in the next patch. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 75 + include/drm/drm_fb_helper.h | 4 -- 2 files changed, 57 insertions(+), 22 deletions(-) diff --git a/drive

[PATCH 10/16] drm/fb-helper: Remove drm_fb_helper_connector

2019-03-26 Thread Noralf Trønnes
All drivers add all their connectors so there's no need to keep around an array of available connectors. Rename functions which signature is changed since they will be moved to drm_client in a later patch. Signed-off-by: Noralf Trønnes --- checkpatch complains, but I'm unable to satisfy it: ER

[PATCH 06/16] drm/i915/fbdev: Move intel_fb_initial_config() to fbdev helper

2019-03-26 Thread Noralf Trønnes
It is generic code and having it in the helper will let other drivers benefit from it. One change was necessary assuming this to be true: INTEL_INFO(dev_priv)->num_pipes == dev->mode_config.num_crtc Suggested-by: Daniel Vetter Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: intel-...

[PATCH 09/16] drm/fb-helper: Move out commit code

2019-03-26 Thread Noralf Trønnes
Move the modeset commit code to drm_client. No changes except exporting API. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c| 236 drivers/gpu/drm/drm_fb_helper.c | 232 --- include/drm/drm_client.h| 3 + 3

[PATCH 05/16] drm/fb-helper: Remove drm_fb_helper_crtc->{x, y, desired_mode}

2019-03-26 Thread Noralf Trønnes
The values are already present in the modeset. This is done in preparation for the removal of struct drm_fb_helper_crtc. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 12 include/drm/drm_fb_helper.h | 2 -- 2 files changed, 4 insertions(+), 10 deletions(-

[PATCH 00/16] drm/fb-helper: Move modesetting code to drm_client

2019-03-26 Thread Noralf Trønnes
This moves the modesetting code from drm_fb_helper to drm_client so it can be shared by all internal clients. I have also added a client display abstraction and a bootsplash example client to show where this might be heading. Hopefully Max Staudt will be able to pick up his bootsplash work now. N

[PATCH 08/16] drm/fb-helper: Prepare to move out commit code

2019-03-26 Thread Noralf Trønnes
This makes the necessary changes so the commit code can be moved out to drm_client as-is in the next patch. It's split up to ease review. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 93 + 1 file changed, 59 insertions(+), 34 deletions(-) d

[PATCH 07/16] drm/fb-helper: Remove drm_fb_helper_crtc

2019-03-26 Thread Noralf Trønnes
It now only contains the modeset so use that directly instead. The modeset code will be moved to drm_client, so add code there. The modeset connector array size is hardcoded for the cloned case to avoid having to pass in a value from the driver. A value of 8 is chosen to err on the safe side. This

[PATCH 03/16] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-03-26 Thread Noralf Trønnes
Prepare for moving drm_fb_helper modesetting code to drm_client. drm_client will be linked to drm.ko, so move __drm_atomic_helper_disable_plane() and __drm_atomic_helper_set_config() out of drm_kms_helper.ko. While at it, fix two checkpatch complaints: - WARNING: Block comments use a trailing */ o

[PATCH 01/16] drm/fb-helper: Remove unused gamma_size variable

2019-03-26 Thread Noralf Trønnes
The gamma_size variable has not been used since commit 4abe35204af8 ("drm/kms/fb: use slow work mechanism for normal hotplug also.") While in the area move a comment back to its code block. They got separated by commit d50ba256b5f1 ("drm/kms: start adding command line interface using fb."). Sign

[PATCH 04/16] drm/fb-helper: No need to cache rotation and sw_rotations

2019-03-26 Thread Noralf Trønnes
Getting rotation info is cheap so we can do it on demand. This is done in preparation for the removal of struct drm_fb_helper_crtc. Cc: Hans de Goede Signed-off-by: Noralf Trønnes --- Hans, You had this comment inline in restore_fbdev_mode_atomic() the last time I sent this out: We want p

[PATCH 02/16] drm/fb-helper: dpms_legacy(): Only set on connectors in use

2019-03-26 Thread Noralf Trønnes
For each enabled crtc the functions sets dpms on all registered connectors. Limit this to only doing it once and on the connectors actually in use. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/dr

Re: [PATCH 3/4] drm/amd/display: In VRR mode, do DRM core vblank handling at end of vblank. (v2)

2019-03-26 Thread Kazlauskas, Nicholas
On 3/22/19 4:04 PM, Mario Kleiner wrote: > In VRR mode, proper vblank/pageflip timestamps can only be computed > after the display scanout position has left front-porch. Therefore > delay calls to drm_crtc_handle_vblank(), and thereby calls to > drm_update_vblank_count() and pageflip event delivery

[PATCH] drm/sun4i: Eliminate pointless on stack copy of drm_display_info

2019-03-26 Thread Ville Syrjala
From: Ville Syrjälä Just use a pointer to the display_info rather than make a copy on stack. Cc: Maxime Ripard Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/

[PATCH 2/4] drm: Fix tabs vs. spaces

2019-03-26 Thread Ville Syrjala
From: Ville Syrjälä A set of 8 spaces has snuck in. Replace with a tab, and toss in an extra newline while at it. Signed-off-by: Ville Syrjälä --- include/drm/drm_connector.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_connector.h b/include/drm/drm_con

[PATCH 4/4] drm/uapi: Remove unused DRM_DISPLAY_INFO_LEN

2019-03-26 Thread Ville Syrjala
From: Ville Syrjälä Remove the unused DRM_DISPLAY_INFO_LEN from the uapi headers. I presume the original plan was to expose the display name via getconnector, but looks like that never happened. So we have the define for the length of the string but no string anywhere. A quick scan didn't seem t

[PATCH 3/4] drm: Kill drm_display_info.name

2019-03-26 Thread Ville Syrjala
From: Ville Syrjälä drm_display_info.name is only ever set by a few panel drveirs but never actually used anywhere except in i915 debugfs code. Trash it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c| 1 - drivers/gpu/drm/panel/panel-arm-versatile.c

[PATCH 1/4] drm: Nuke unused drm_display_info.pixel_clock

2019-03-26 Thread Ville Syrjala
From: Ville Syrjälä drm_display_info.pixel_clock is unused. Let's get rid of it. Signed-off-by: Ville Syrjälä --- include/drm/drm_connector.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index bb3bd8e1633a..fcdca46e0c24 1006

[Bug 110229] The driver is not waiting the shader have finished to update the framebuffer before displaying it.

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110229 --- Comment #5 from Laurent --- The code is too large, there are a lot of folders and they are a lot of pointers to functions so it's very difficult to find where a specific function is called, and anyway, when I tried to compile the driver to s

[PATCH v6 6/8] mm/mmu_notifier: use correct mmu_notifier events for each invalidation

2019-03-26 Thread jglisse
From: Jérôme Glisse This update each existing invalidation to use the correct mmu notifier event that represent what is happening to the CPU page table. See the patch which introduced the events to see the rational behind this. Signed-off-by: Jérôme Glisse Cc: Andrew Morton Cc: linux...@kvack.

[PATCH v6 7/8] mm/mmu_notifier: pass down vma and reasons why mmu notifier is happening v2

2019-03-26 Thread jglisse
From: Jérôme Glisse CPU page table update can happens for many reasons, not only as a result of a syscall (munmap(), mprotect(), mremap(), madvise(), ...) but also as a result of kernel activities (memory compression, reclaim, migration, ...). Users of mmu notifier API track changes to the CPU p

[PATCH v6 8/8] mm/mmu_notifier: mmu_notifier_range_update_to_read_only() helper

2019-03-26 Thread jglisse
From: Jérôme Glisse Helper to test if a range is updated to read only (it is still valid to read from the range). This is useful for device driver or anyone who wish to optimize out update when they know that they already have the range map read only. Signed-off-by: Jérôme Glisse Cc: Andrew Mor

[PATCH v6 2/8] mm/mmu_notifier: convert user range->blockable to helper function

2019-03-26 Thread jglisse
From: Jérôme Glisse Use the mmu_notifier_range_blockable() helper function instead of directly dereferencing the range->blockable field. This is done to make it easier to change the mmu_notifier range field. This patch is the outcome of the following coccinelle patch: %<

[PATCH v6 5/8] mm/mmu_notifier: contextual information for event triggering invalidation v2

2019-03-26 Thread jglisse
From: Jérôme Glisse CPU page table update can happens for many reasons, not only as a result of a syscall (munmap(), mprotect(), mremap(), madvise(), ...) but also as a result of kernel activities (memory compression, reclaim, migration, ...). Users of mmu notifier API track changes to the CPU p

[PATCH v6 4/8] mm/mmu_notifier: contextual information for event enums

2019-03-26 Thread jglisse
From: Jérôme Glisse CPU page table update can happens for many reasons, not only as a result of a syscall (munmap(), mprotect(), mremap(), madvise(), ...) but also as a result of kernel activities (memory compression, reclaim, migration, ...). This patch introduce a set of enums that can be asso

Re: [PATCH 11/11] drm/fbdevdrm: Detect and validate display modes

2019-03-26 Thread Ville Syrjälä
On Tue, Mar 26, 2019 at 10:17:44AM +0100, Thomas Zimmermann wrote: > Mode detection currently reports the modes listed in fb_info::modelist. > The list is either build from EDID information or, more often, a list of > previously set modes. A later update to the mode detection could also > take into

[PATCH v6 3/8] mm/mmu_notifier: convert mmu_notifier_range->blockable to a flags

2019-03-26 Thread jglisse
From: Jérôme Glisse Use an unsigned field for flags other than blockable and convert the blockable field to be one of those flags. Signed-off-by: Jérôme Glisse Cc: Andrew Morton Cc: linux...@kvack.org Cc: Christian König Cc: Joonas Lahtinen Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Jan Kara Cc

[PATCH v6 0/8] mmu notifier provide context informations

2019-03-26 Thread jglisse
From: Jérôme Glisse (Andrew this apply on top of my HMM patchset as otherwise you will have conflict with changes to mm/hmm.c) Changes since v5: - drop KVM bits waiting for KVM people to express interest if they do not then i will post patchset to remove change_pte_notify as wit

[PATCH v6 1/8] mm/mmu_notifier: helper to test if a range invalidation is blockable

2019-03-26 Thread jglisse
From: Jérôme Glisse Simple helpers to test if range invalidation is blockable. Latter patches use cocinnelle to convert all direct dereference of range-> blockable to use this function instead so that we can convert the blockable field to an unsigned for more flags. Signed-off-by: Jérôme Glisse

[Bug 110199] [amdgpu] Screen flickering when using a 75Hz monitor paired with an RX 480 GPU

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110199 --- Comment #5 from Daniel Stone --- > Please don't post outside your own bug reports if you're not contributing > with anything useful. This is not Phoronix or a discussion forum. Sigh. This person constantly spams every bug report with usele

Re: [PATCH 07/11] drm/fbdevdrm: Add DRM <-> fbdev pixel-format conversion

2019-03-26 Thread Ville Syrjälä
On Tue, Mar 26, 2019 at 10:17:40AM +0100, Thomas Zimmermann wrote: > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/fbdevdrm/Makefile | 1 + > drivers/gpu/drm/fbdevdrm/fbdevdrm_format.c | 441 + > drivers/gpu/drm/fbdevdrm/fbdevdrm_format.h | 26 ++ > 3 fi

[Bug 110249] IGT command line tools load redundant GUI libraries

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110249 --- Comment #6 from Eero Tamminen --- intel_gpu_top works fine now. Large difference in ldd output, and it's still small: $ size intel_gpu_top textdata bss dec hex filename 211021204 304 226105852 /opt/instal

[Bug 110199] [amdgpu] Screen flickering when using a 75Hz monitor paired with an RX 480 GPU

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110199 --- Comment #4 from bmil...@gmail.com --- (In reply to fin4478 from comment #3) > You both have cheap low quality Sapphire cards with 2 year warranty here > when Asus has 3 years. Custom bios in those cards are famous to cause > problems with Lin

[Bug 110249] IGT command line tools load redundant GUI libraries

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110249 --- Comment #5 from Chris Wilson --- One down, the rest left to an adventurous sole. commit a350b9f9f606296b1599c3617c8530a8985709e2 (HEAD, upstream/master) Author: Chris Wilson Date: Tue Mar 26 13:26:26 2019 + tools/intel-gpu-top:

Re: [PATCH 02/11] drm/fbdevdrm: Add fbdevdrm device

2019-03-26 Thread Adam Jackson
On Tue, 2019-03-26 at 10:17 +0100, Thomas Zimmermann wrote: > +static bool is_generic_driver(const struct fb_info *fb_info) > +{ > + /* DRM porting note: We don't want to bind to vga16fb, vesafb, or any > + * other generic fbdev driver. Usually, these drivers have limited > + * capab

Re: [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check

2019-03-26 Thread Dan Carpenter
On Tue, Mar 26, 2019 at 02:53:49PM +, Chris Wilson wrote: > Quoting Mika Kuoppala (2019-03-26 09:30:57) > > Dan Carpenter writes: > > > > > The live_context() function returns error pointers. It never returns > > > NULL. > > > > > > Fixes: 9c1477e83e62 ("drm/i915/selftests: Exercise adding r

Re: [PATCH] drm/fbdev: Make skip_vt_switch the default

2019-03-26 Thread Daniel Vetter
On Wed, Nov 28, 2018 at 8:17 AM Maarten Lankhorst wrote: > > Op 27-11-18 om 18:34 schreef Daniel Vetter: > > KMS drivers really should all be able to restore their display state > > on resume without fbcon helping out. So make this the default. > > > > Since I'm not entirely foolish, make it only

Re: [PATCH 21/21] drm/fb-helper: Unexport fill_{var,info}

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > Not used by drivers anymore. > > v2: Rebase > > Signed-off-by: Daniel Vetter > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mai

Re: [PATCH 20/21] drm/vboxvideo: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > This should not result in any changes. > > v2: Rebase over vbox changes - vbox gained it's own line to fill > fix.id. > > v3: Rebase > > Reviewed-by: Greg Kroah-Hartman (v2) > Signed-off-by: Daniel Vetter > Cc: Greg Kroah-Hartman > Cc: Hans de Go

Re: [PATCH 19/21] drm/udl: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > This should not result in any changes. > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Sean Paul > Cc: Mikulas Patocka > Cc: Daniel Vetter > Cc: Greg Kroah-Hartman > Cc: Emil Lundmark > --- > drivers/gpu/drm/udl/udl_fb

Re: [PATCH 18/21] drm/tegra: Use drm_fb_helper_fill_info

2019-03-26 Thread Thierry Reding
On Tue, Mar 26, 2019 at 02:20:05PM +0100, Daniel Vetter wrote: > Another driver that didn't set fbinfo->fix.id before. > > v2: Fix subject and rebase > > Acked-by: Thierry Reding > Signed-off-by: Daniel Vetter > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-te...@vger.kernel.org > ---

Re: [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check

2019-03-26 Thread Chris Wilson
Quoting Mika Kuoppala (2019-03-26 09:30:57) > Dan Carpenter writes: > > > The live_context() function returns error pointers. It never returns > > NULL. > > > > Fixes: 9c1477e83e62 ("drm/i915/selftests: Exercise adding requests to a > > full GGTT") > > Signed-off-by: Dan Carpenter > > Reviewe

Re: [PATCH 18/21] drm/tegra: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > Another driver that didn't set fbinfo->fix.id before. > > v2: Fix subject and rebase > > Acked-by: Thierry Reding > Signed-off-by: Daniel Vetter > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-te...@vger.kernel.org > --- Reviewed-by: Nora

Re: [RFC][PATCH 00/11] DRM driver for fbdev devices

2019-03-26 Thread Daniel Vetter
On Tue, Mar 26, 2019 at 10:17:33AM +0100, Thomas Zimmermann wrote: > Hi, > > this RFC patch set implements fbdevdrm, a DRM driver on top of fbdev > drivers. I'd appreciate feedback on the code and the idea in general. > > The fbdev subsystem is considered legacy and will probably be removed at >

Re: [PATCH 17/21] drm/rockchip: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > This will set an fb name for the first time! > > v2: Rebase > > Reviewed-by: Heiko Stuebner > Signed-off-by: Daniel Vetter > Cc: Sandy Huang > Cc: "Heiko Stübner" > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-rockc...@lists.infradead.org

Re: [PATCH 16/21] drm/radeon: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > This should not result in any changes. > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou" > Cc: amd-...@lists.freedesktop.org > --- Acked-by: Noralf Trønnes _

Re: [PATCH 15/21] drm/omap: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > This changes the fb name from "omapdrm" to "omapdrmfb". > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Tomi Valkeinen > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.

Re: [PATCH 14/21] drm/nouveau: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > This changes the fb name from "nouveaufb" to "nouveaudrmfb". > > Aside: I wonder whether the in_interrupt() check is good enough for > the nouveau acceleration. Cargo-cult says drm_can_sleep() is needed, > which isn't actually working if you pick a .c

Re: [PATCH 13/21] drm/bochs: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 15.42, skrev Noralf Trønnes: > > > Den 26.03.2019 14.20, skrev Daniel Vetter: >> This will change the fb name from "msm" to "msmdrmfb". >> >> v2: Rebase >> >> Signed-off-by: Daniel Vetter >> Cc: Rob Clark >> Cc: linux-arm-...@vger.kernel.org >> Cc: freedr...@lists.freedesktop.o

[Bug 110249] IGT command line tools load redundant GUI libraries

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110249 --- Comment #4 from Eero Tamminen --- (In reply to Chris Wilson from comment #3) > The autotools build doesn't have this problem because in there intel-gpu-top > is not linked against libigt.la, as nothing outside of tests/ should be. It > looks

Re: [PATCH 13/21] drm/bochs: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.20, skrev Daniel Vetter: > This will change the fb name from "msm" to "msmdrmfb". > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Rob Clark > Cc: linux-arm-...@vger.kernel.org > Cc: freedr...@lists.freedesktop.org > --- Reviewed-by: Noralf Trønnes ___

Re: [PATCH 12/21] drm/mga200g: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.19, skrev Daniel Vetter: > Should not result in any changes. It changes the name, so: Only changes the name of the fb from "mgadrmfb" to "mga200drmfb". Acked-by: Noralf Trønnes > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Alex Deucher > Cc: "

[Bug 110249] IGT command line tools load redundant GUI libraries

2019-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110249 --- Comment #3 from Chris Wilson --- The autotools build doesn't have this problem because in there intel-gpu-top is not linked against libigt.la, as nothing outside of tests/ should be. It looks like a bit of carelessness introduced the extra d

Re: [PATCH 21/21] drm/fb-helper: Unexport fill_{var,info}

2019-03-26 Thread Alex Deucher
On Tue, Mar 26, 2019 at 9:21 AM Daniel Vetter wrote: > > Not used by drivers anymore. > > v2: Rebase > > Signed-off-by: Daniel Vetter Other than the spelling typos noted by Noralf, the series is: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_fb_helper.c | 38 +

Re: [PATCH 11/21] drm/i915: Use drm_fb_helper_fill_info

2019-03-26 Thread Noralf Trønnes
Den 26.03.2019 14.19, skrev Daniel Vetter: > This changes the fb name from "inteldrmfb" to "i915drmfb". > > v2: Rebase > > Signed-off-by: Daniel Vetter > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: intel-...@lists.freedesktop.org > --- Reviewed-by: Noralf Trønnes __

  1   2   3   >