ConnectionResetError in test_closes_connection_without_content_length

2017-09-19 Thread Zhiqiang Liu
I run the test suits for master and get the following error. Traceback (most recent call last): File "/usr/local/Cellar/python3/3.4.3/Frameworks/Python.framework/Versions/3.4/lib/python3.4/unittest/case.py", line 58, in testPartExecutor yield File "/usr/local/Cellar/python3/3.4.3/Frame

Re: ConnectionResetError in test_closes_connection_without_content_length

2017-09-20 Thread Zhiqiang Liu
> > Yeah I believe it is a new test, so I can't test if it is working for 1.11. > I did get it to pass after adding except like this try: conn.request('GET', '/example_view/', headers={'Connection': 'keep-alive'}) response = conn.getresponse().read()

New Feature: Allow password reset token to expire in under a day

2017-09-20 Thread Zhiqiang Liu
I need general consensus on how to proceed with supporting password expire time to be under a day. Currently it is not possible because we use PASSWORD_RESET_TIMEOUT_DAYS. In ticket 28622 we have two options. One is to continue to use the same set

Re: New Feature: Allow password reset token to expire in under a day

2017-09-21 Thread Zhiqiang Liu
lso, the existing 3 day timeout for password links is quite surprising >>>> from a security point of view. The consultants I work with would flag up a >>>> token that lasts longer than 12 hours as an issue during a pentest. >>>> >>>> IMO a

Re: There should be a way to make Templates substitution to raise an exception on error

2017-09-21 Thread Zhiqiang Liu
This is not 100% related to the ticket, but something to think about. In ReactJS, there a concept called propTypes, which will check all props (they are similar to context in concept I think) listed with types in UI component. So maybe we can have something similar in django template system tha

Re: There should be a way to make Templates substitution to raise an exception on error

2017-09-21 Thread Zhiqiang Liu
21, 2017 at 9:35:05 AM UTC-4, Zhiqiang Liu wrote: > > This is not 100% related to the ticket, but something to think about. > > In ReactJS, there a concept called propTypes, which will check all props > (they are similar to context in concept I think) listed with types in UI >

Re: New Feature: Allow password reset token to expire in under a day

2017-09-21 Thread Zhiqiang Liu
clue that timedelta().seconds can be used for readability > PASSWORD_RESET_TIMEOUT = datetime.timedelta(hours=6, minutes=30).seconds > > Dylan > > On Thu, Sep 21, 2017 at 6:14 AM, Zhiqiang Liu > wrote: > >> Yeah I don't think float number of days is a good choice becau

Why Django Document site always redirect to an earlier version

2017-09-21 Thread Zhiqiang Liu
Most of the times it is redirected to v1.6, sometimes 1.10, not sure why it happens? Are people aware of that? -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop rece

Re: ConnectionResetError in test_closes_connection_without_content_length

2017-09-21 Thread Zhiqiang Liu
To follow up, I set up a new macbook pro today with python3.6 and OXS10.12, and I got the same error. On Wednesday, September 20, 2017 at 8:39:23 PM UTC-4, Zhiqiang Liu wrote: > > Yeah I believe it is a new test, so I can't test if it is working for 1.11. >> > > I did get

Re: New Feature: Allow password reset token to expire in under a day

2017-09-22 Thread Zhiqiang Liu
OK, >>>>> but it seems a bit like busywork. >>>>> >>>>> It's a small thing but I don't see any practical problem with just >>>>> accepting a timedelta, they are nicer to work with in the settings file >>>>&g

Re: Why Django Document site always redirect to an earlier version

2017-09-22 Thread Zhiqiang Liu
rospace Engineering, >> IIT Madras,Chennai. >> >> On 22 September 2017 at 08:08, Dylan Reinhold wrote: >> >>> From the main site, or from other site like stack-overflow or google? >>> From the main site I get 1.11. >>> From another site you ca

Re: Why Django Document site always redirect to an earlier version

2017-09-22 Thread Zhiqiang Liu
Here it is HTTP/1.1 302 Found Server: nginx Date: Fri, 22 Sep 2017 17:26:03 GMT Content-Type: text/html; charset=utf-8 Content-Length: 0 Connection: keep-alive x-content-type-options: nosniff Content-Language: en Location: /en/1.11/ x-xss-protection: 1; mode=block X-Frame-Options: SAMEORIGIN Vary:

Re: Why Django Document site always redirect to an earlier version

2017-09-22 Thread Zhiqiang Liu
Ah it used to happen to all my browsers, now with the new laptop it only happens to Chrome, so it is browser related I think. On Friday, September 22, 2017 at 1:27:08 PM UTC-4, Zhiqiang Liu wrote: > > Here it is > HTTP/1.1 302 Found > Server: nginx > Date: Fri, 22 Sep 20

Re: Why Django Document site always redirect to an earlier version

2017-09-22 Thread Zhiqiang Liu
g ago because I didn't remember there is such a thing. Thanks for all the help:) On Friday, September 22, 2017 at 1:30:30 PM UTC-4, Zhiqiang Liu wrote: > > Ah it used to happen to all my browsers, now with the new laptop it only > happens to Chrome, so it is browser related I t

Re: New Feature: Allow password reset token to expire in under a day

2017-09-22 Thread Zhiqiang Liu
is the best unit for this >> setting. >> >> 3 minutes (even 1) is short enough for edge case and 720 (12 hours) also >> looks good. >> >> On Thursday, September 21, 2017 at 6:22:20 PM UTC+10, Tom Forbes wrote: >>> >>> I think we shouldn't

Re: ConnectionResetError in test_closes_connection_without_content_length

2017-09-22 Thread Zhiqiang Liu
Hi Chris, I did installed sqlite through brew install sqlite, the error still happens. On Friday, September 22, 2017 at 7:52:53 AM UTC-4, Chris Foresman wrote: > > The problem is the version of SQLite included in recent versions of macOS. > The easiest fix we saw was installing Homebrew and the