Re: Design Decision: GFK Reverse Lookups

2018-04-18 Thread Tim Graham
I'd lean toward a wontfix. In particular, making changes in django/db/models/sql/query.py for a contrib app doesn't look like a good separation of concerns. Is there a downside to the alternative of adding the GenericRelation? On Tuesday, April 10, 2018 at 3:38:53 AM UTC-4, Carlton Gibson wrote

Re: Fellow Reports - April 2018

2018-04-23 Thread Tim Graham
Week ending April 21, 2018 Triaged --- https://code.djangoproject.com/ticket/29331 - Model fields where the field name is shadowed by Python property aren't saved (invalid) https://code.djangoproject.com/ticket/29332 - AdminReadonlyField accepts the optional argument model_admin but tre

Re: I know this question has been asked before, but I haven't found an answer that solves my situation. I'm looking at the Django tutorial, and I've set up the first URLs exactly as the tutorial has i

2018-04-23 Thread Tim Graham
For future reference, this mailing list is for the development of Django itself, not for support. Use the django-users mailing list for that, or IRC #django on freenode, or a site like Stack Overflow. On Monday, April 23, 2018 at 9:18:11 AM UTC-4, Avitab Ayan Sarmah wrote: > > Thank you :) > > O

Fabric examples in documentation

2018-04-25 Thread Tim Graham
>From https://code.djangoproject.com/ticket/29360: "The ​Serving the site and your static files from the same server and the ​Serving static files from a dedicate

Re: ExceptionMiddleware still necessary in documentation?

2018-04-25 Thread Tim Graham
There may be portions of that documentation that could be relocated as some of the information is still relevant to new-style middleware. By the way, it's better to ask this type of question on the ticket as it doesn't require the attention of everyone reading this mailing list. On Wednesday, A

Django bugfix releases: 2.0.5 and 1.11.13

2018-05-01 Thread Tim Graham
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2018/may/01/bugfix-releases/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

Re: Fellow Reports - April 2018

2018-05-01 Thread Tim Graham
Week ending April 28, 2018 Triaged --- https://code.djangoproject.com/ticket/29354 - ordering inherited from abstract superclass does not get applied to admin inlines (invalid) https://code.djangoproject.com/ticket/29366 - startproject --template option doesn't support http authenticati

Fellow Reports - May 2018

2018-05-07 Thread Tim Graham
Week ending May 5, 2018 Triaged --- https://code.djangoproject.com/ticket/29374 - Group the 'Available format strings' in the date template tag doc by category (accepted) https://code.djangoproject.com/ticket/29378 - migration does not consistently rename field "id" to "model_id" depend

Re: Any reason to not use SHA256 (or newer) for Signer / TimeStampSigner classess?

2018-05-08 Thread Tim Graham
There's a ticket about it: https://code.djangoproject.com/ticket/27468 Backwards compatibility is the main consideration. On Tuesday, May 8, 2018 at 6:44:05 PM UTC-4, Cristiano Coelho wrote: > > Looks like the Signer class (and perhaps other parts of the code) still > use SHA1 ([1] and [2]) for

Re: Fellow Reports - May 2018

2018-05-13 Thread Tim Graham
Week ending May 12, 2018 Triaged --- https://code.djangoproject.com/ticket/29391 - Postgres array lookups need to call get_db_prep_value to adapt values to their db representation (FieldGetDbPrepValueMixin) (accepted) https://code.djangoproject.com/ticket/29395 - Assigning correctly for

status of 2.1 release blockers

2018-05-14 Thread Tim Graham
Time to kickoff the progress tracker for the next major release! The 2.1 alpha is scheduled (according to https://code.djangoproject.com/wiki/Version2.1Roadmap) for today, May 14. Typically we've released the alpha a few days later to finish up a few last minutes things. I have one patch I wa

Django 2.1 alpha 1 released

2018-05-17 Thread Tim Graham
We've made the first release on the way to Django's next major release, Django 2.1! With about two and a half months until the final release (scheduled for August 1), we'll need timely testing from the community to ensure an on time, stable release. Check out the blog post: https://www.djangoprojec

Re: Fellow Reports - May 2018

2018-05-24 Thread Tim Graham
Week ending May 19, 2018 Triaged --- https://code.djangoproject.com/ticket/29403 - Make PyLibMCCache backend handle TooBig exception from pylibmc (accepted) https://code.djangoproject.com/ticket/29402 - parse_header function in http/multipartparser.py unescapes in wrong order (needsinfo

Re: Fellow Reports - May 2018

2018-05-28 Thread Tim Graham
Week ending May 26, 2018 Triaged --- https://code.djangoproject.com/ticket/29413 - QuerySet.get_or_create()/update_or_create() shouldn't evaluate lazy defaults unless they are needed (accepted) https://code.djangoproject.com/ticket/29442 - wrong sql for cast datetime to date in sqlite

Re: Fellow Reports - May 2018

2018-06-04 Thread Tim Graham
Week ending June 2, 2018 I also spent time spinning up some new CI servers with Ubuntu 18.04. That required the GIS test fixes below. Triaged --- https://code.djangoproject.com/ticket/29455 - MySQL Backend & features detection are not taking MariaDB Aria engine into account (invalid)

Fellow Reports - June 2018

2018-06-12 Thread Tim Graham
Week ending June 9, 2018 Triaged --- https://code.djangoproject.com/ticket/29472 - Natural key not serializing for primary_key OneToOneField (duplicate) https://code.djangoproject.com/ticket/29473 - Postgres JSONField escaping to infinity on each save (needsinfo) https://code.djangopro

Re: Fellow Reports - June 2018

2018-06-18 Thread Tim Graham
Week ending June 16, 2018 Triaged --- https://code.djangoproject.com/ticket/29495 - When altering unique_together and removing a field, migrations may get wrong order (duplicate) https://code.djangoproject.com/ticket/29497 - Initializing model instance with an unsaved related object, th

Django 2.1 beta 1 released

2018-06-18 Thread Tim Graham
We've made the second release on the way to Django's next major release, Django 2.1! With a month and a half until the final release, we'll need timely testing from the community to ensure a stable release. Check out the blog post: https://www.djangoproject.com/weblog/2018/jun/18/django-21-beta-1-

Re: Fellow Reports - June 2018

2018-06-28 Thread Tim Graham
Week ending June 23, 2018 Triaged --- https://code.djangoproject.com/ticket/29505 - Impossible to set a Field's default value to a callable that takes an argument (accepted) https://code.djangoproject.com/ticket/29510 - QueryDict.copy() returns closed files when the type of file is Temp

Re: "Variables and attributes may not begin with underscores" error

2018-06-30 Thread Tim Graham
I think the reason is that underscore-prefixed attributes are generally considered to be private. Accessing them in templates doesn't seem like good practice. On Friday, June 29, 2018 at 6:44:56 PM UTC-4, Gregory Kaleka wrote: > > The docs do mention it on the more complete template api page >

Re: Fellow Reports - June 2018

2018-07-02 Thread Tim Graham
Week ending June 30, 2018 Triaged --- https://github.com/deadsnakes/issues/issues/67 - bionic: libpython3.7-stdlib: missing `distutils/__init__.py` and `distutils/version.py` (created while setting up Python 3.7 on Jenkins) https://code.djangoproject.com/ticket/29532 - Make model/app ur

Re: MariaDB, official support

2018-07-05 Thread Tim Graham
I added MariaDB 10.1.29 (as packaged by Ubuntu 18.04) to Jenkins: https://djangoci.com/job/master-mariadb/ You can trigger the builder on PRs with the comment "buildbot, test on mariadb." There are 30 failures, mainly related to windows expressions and select_for_update. On Thursday, July 5, 2

Fellow Reports - July 2018

2018-07-09 Thread Tim Graham
Week ending July 7, 2018 Triaged --- https://code.djangoproject.com/ticket/29539 - Cannot use Aggregation function in Model.Meta.ordering (accepted) https://code.djangoproject.com/ticket/29538 - Query Expression in ordering of a related object fails (accepted) Reviewed/committed -

Re: ResolverMatch and url pattern

2018-07-10 Thread Tim Graham
There's an open ticket. Perhaps you would like to finish the patch. https://code.djangoproject.com/ticket/28766 https://github.com/django/django/pull/9323 On Tuesday, July 10, 2018 at 2:16:01 PM UTC-4, Melvyn Sopacua wrote: > > Hi, > > > > I'm trying to implement a wrapper for Django's request

Re: Fellow Reports - July 2018

2018-07-16 Thread Tim Graham
Week ending July 14, 2018 Triaged --- https://code.djangoproject.com/ticket/29549 - Document that Field.choices are enforced by model validation (fixed) https://code.djangoproject.com/ticket/29553 - Test client should set Content-Length header to a string rather than integer (fixed) ht

Django 2.1 release candidate 1 released

2018-07-18 Thread Tim Graham
We've made the final (hopefully) release on the way to Django's next major release, Django 2.1! Check out the blog post: https://www.djangoproject.com/weblog/2018/jul/18/django-21-rc1/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions

Re: Fellow Reports - July 2018

2018-07-21 Thread Tim Graham
Week ending July 21, 2018 Triaged --- https://code.djangoproject.com/ticket/29575 - MySQL error code 1062 (duplicate entry for key) raises MySQLdb.IntegrityError, not django.db.IntegrityError (worksforme) https://code.djangoproject.com/ticket/29574 - Unable to create model instance aft

Re: Fellow Reports - July 2018

2018-07-28 Thread Tim Graham
Week ending July 28, 2018 Triaged --- https://code.djangoproject.com/ticket/29595 - Allow using timedelta in migrations questioner (accepted) https://code.djangoproject.com/ticket/29603 - dumpdata shouldn't use allow_migrate_model (duplicate) https://code.djangoproject.com/ticket/29605

Re: Regression? evaluation of a lazy string in Template

2018-07-30 Thread Tim Graham
It doesn't look like that force_text() was added specifically to handle lazy strings (see django/template/__init__.py in https://github.com/django/django/commit/953badbea5a04159adbfa970f5805c0232b6a401) but Django does have str() calls in various places to handle lazy strings, e.g. https://gi

Re: Installing Channels - bin\\HostX86\\x64\\cl.exe' failed with exit status

2018-07-30 Thread Tim Graham
Hi Ryan, This mailing list is for the development of Django. Please use https://groups.google.com/forum/#!forum/django-users for usage questions. I think you're more likely to get help if you maintain a positive tone and omit sentences like "This is the problem with programming...". On Sunday,

Django security releases issued: 1.11.15 and 2.0.8

2018-08-01 Thread Tim Graham
Today the Django team issued 1.11.15 and 2.0.8 as part of our security process. These releases address a security issue, and we encourage all users to upgrade as soon as possible: https://www.djangoproject.com/weblog/2018/aug/01/security-releases/ As a reminder, we ask that potential security iss

Django 2.1 released

2018-08-01 Thread Tim Graham
Django 2.1 is now available: https://www.djangoproject.com/weblog/2018/aug/01/django-21-released/ With the release of Django 2.1, Django 2.0 has reached the end of mainstream support. The final minor bug fix release (which is also a security release), 2.0.8, was issued today. Django 2.0 will recei

Fellow Reports - August 2018

2018-08-04 Thread Tim Graham
Week ending August 4, 2018 Triaged --- https://code.djangoproject.com/ticket/29611 - Reverse and built-in template tag 'url' does not work exactly the same way (needsinfo) https://code.djangoproject.com/ticket/29624 - Django 2.1 incompatible with sqlite 3.6.20 (wontfix) https://code.dja

Re: HTML5 and XHTML5 documents

2018-08-13 Thread Tim Graham
Another discussion about HTML vs XHTML is https://groups.google.com/d/topic/django-developers/EdwwxxqcKVU/discussion. I think if you want to use XHTML, Django should make is possible, but as it seems the majority of projects use HTML5, I would stick to that as the default. Have you tried creat

Re: Fellow Reports - August 2018

2018-08-13 Thread Tim Graham
Week ending August 11, 2018 Triaged --- https://code.djangoproject.com/ticket/29647 - "Please correct the error below." when saving edit model form with inline formset and space at the end of primary key value (invalid) https://code.djangoproject.com/ticket/29653 - Using GenericRelatio

Add a setting for customizing the CSRF token name?

2018-08-18 Thread Tim Graham
Do you think it's worth a new setting to allow customizing the CSRF token name ('csrfmiddlewaretoken')? It was proposed 9 years ago in https://code.djangoproject.com/ticket/12738 and closed as wontfix absent some justification. It was again proposed a few days ago in https://github.com/django/

Re: Fellow Reports - August 2018

2018-08-18 Thread Tim Graham
Week ending August 18, 2018 Triaged --- https://code.djangoproject.com/ticket/29676 - has_add_permission() returning False in TabularInline form raises exception in contrib.admin (duplicate) https://code.djangoproject.com/ticket/29678 - inspectdb fails on MySQL 8 with " 'utf8' is curre

Deprecate PickleSerializer for session serialization?

2018-08-25 Thread Tim Graham
Alex proposed: --- Pickle serializer has long been known to be dangerous. This is mitigated by requiring MAC on pickle in cookies, but nevertheless, RCEs continue to happen: ​ https://blog.scrt.ch/2018/08/24/remote-code-execution-on-a-facebook-server/ To further discourage it's use, we shou

Add autocomplete attribute to contrib.auth fields?

2018-08-25 Thread Tim Graham
Browser support looks somewhat limited, so I wanted to ask if there are any concerns or drawbacks with adding autocomplete=username/email/current-password/new-password to contrib.auth's forms? Pull request: ​https://github.com/django/django/pull/9921 >From the ticket [https://code.djangopr

Re: Fellow Reports - August 2018

2018-08-25 Thread Tim Graham
Week ending August 25, 2018 Triaged --- https://code.djangoproject.com/ticket/29697 - Complex query crashes with "missing FROM-clause entry for table" (accepted) https://code.djangoproject.com/ticket/29701 - has_add_permission in admin.TabularInline gives KeyError exception (duplicate)

Re: Django : Change Backend as mysql and create sample example using django ORM

2018-08-27 Thread Tim Graham
This list is dedicated to the discussion of developing Django itself, not answering usage questions. You might try the django-users group ( https://groups.google.com/forum/#!forum/django-users), or StackOverflow. On Monday, August 27, 2018 at 9:41:30 AM UTC-4, Raghavendrachari k wrote: > > if you

Re: Not Creating test DBs with PG backend

2018-08-28 Thread Tim Graham
Why is a new option needed? Why can't --keepdb be used for this use case? On Tuesday, August 28, 2018 at 2:23:52 AM UTC-4, Curtis Maloney wrote: > > Greetings, > > one problem that turns up more and more frequently, it seems, is that > someone is trying to run tests but can't because of the foll

Re: Django : Change Backend as mysql and create sample example using django ORM

2018-08-29 Thread Tim Graham
This list is dedicated to the discussion of developing Django itself, not answering usage questions. Please continue the discussion on the django-users thread: https://groups.google.com/d/topic/django-users/iuspogePH3k/discussion On Wednesday, August 29, 2018 at 7:15:57 AM UTC-4, Sonali Vighn

Re: Not Creating test DBs with PG backend

2018-08-29 Thread Tim Graham
On 08/28/2018 08:33 PM, Tim Graham wrote: > > Why is a new option needed? Why can't --keepdb be used for this use > case? > > Because that would be different behavior. > > If you can convince me that using --keepdb is a solution, then I will > use your argumen

Re: Fellow Reports - August 2018

2018-09-03 Thread Tim Graham
Week ending September 1, 2018 Triaged --- https://code.djangoproject.com/ticket/29718 - Document admin template collision backwards incompatibility in Django 2.1 (fixed) https://code.djangoproject.com/ticket/29717 - Provide a way for tests to run on an existing empty DB (accepted) Auth

Re: the design of django group permission should be optimized in django.contrib.auth.ModelBackend

2018-09-10 Thread Tim Graham
I'm not sure. Swappable models still have some rough edges. In particular, switching to a swappable model after beginning a project is difficult and undocumented (https://code.djangoproject.com/ticket/25313). To overcome this, the documentation recommends starting with a custom user model (http

Re: Adjusting MRO of the CBVs

2018-09-10 Thread Tim Graham
I agree that it's not worthwhile. There are alternatives like http://django-vanilla-views.org/. On Thursday, September 6, 2018 at 3:51:29 AM UTC-4, Carlton Gibson wrote: > > There's a ticket adjusting the MRO of DeleteView. > > https://code.djangoproject.com/ticket/29735 > > I'm closing this as

Fellow Reports - September 2018

2018-09-10 Thread Tim Graham
Week ending September 8, 2018 I was on vacation most of the week. Authored -- https://github.com/jazzband/sorl-thumbnail/pull/553 - Fix #554: Fix AdminImageWidget with Django 2.1 (added test) Reviewed/committed -- https://github.com/django/djangopeople/pull/88 - Fi

Re: Adding a bulk_save method to models

2018-09-14 Thread Tim Graham
I wanted to ask about naming of the new method. Currently the proposed name is "QuerySet.bulk_save()" but I think it's a bit confusing since it uses QuerySet.update(), not Model.save(). It works similarly to QuerySet.bulk_update() from https://github.com/aykut/django-bulk-update but the argu

Re: #29752 Adding a ALLOWED_HOSTS_IGNORABLE_URLS setting

2018-09-14 Thread Tim Graham
What would be the value of that setting for your use case? On Friday, September 14, 2018 at 11:52:46 AM UTC-4, Jonas H wrote: > > Hi, > > I've started a discussion on https://code.djangoproject.com/ticket/29752 > to add a new ALLOWED_HOSTS_IGNORABLE_URLS setting. > > The setting can become handy

Re: #29752 Adding a ALLOWED_HOSTS_IGNORABLE_URLS setting

2018-09-14 Thread Tim Graham
o AWS and possibly others. Here's the workaround we use in > production to support AWS health checks that may help give some more > context: http://dpaste.com/2BS0C5M > > -Matt > > On Fri, Sep 14, 2018 at 10:44 AM, Tim Graham > wrote: > >> What would be the v

Re: Fellow Reports - September 2018

2018-09-17 Thread Tim Graham
Week ending September 15, 2018 Triaged --- https://code.djangoproject.com/ticket/29747 - UUID in loaddata fixture raise ValidationError on objects having OneToOne relationship (uuid as FK) (invalid) https://code.djangoproject.com/ticket/29756 - Missing information about model field nam

Re: non-nullable field

2018-09-25 Thread Tim Graham
This mailing list is for the development of Django itself, not for support. Use the django-users mailing list for that, or IRC #django on freenode, or a site like Stack Overflow. On Tuesday, September 25, 2018 at 8:11:33 AM UTC-4, miyand...@gmail.com wrote: > > Whenever i try to makemigrations

Re: Fellow Reports - September 2018

2018-09-25 Thread Tim Graham
Week ending September 22, 2018 Triaged --- https://code.djangoproject.com/ticket/29762 - Document how database routers are used for related object access (accepted) https://code.djangoproject.com/ticket/29774 - `django-admin shell` hangs if the user starts typing before shell is ready (

Re: Model creation in autocommit mode.

2018-09-26 Thread Tim Graham
https://code.djangoproject.com/ticket/21171 looks like it should help. On Wednesday, September 26, 2018 at 2:56:34 PM UTC-4, Florian Apolloner wrote: > > Hi there, > > a fun issue came up on IRC today: Even when in autocommit mode, Django > starts a transaction when doing Model.objects.create (

Re: Fellow Reports - September 2018

2018-10-01 Thread Tim Graham
Week ending September 29, 2018 Triaged --- https://code.djangoproject.com/ticket/29801 - Allow using fixtures in data migrations (accepted) https://code.djangoproject.com/ticket/29804 - Add 'Did you mean' suggestions for unsupported lookup error (accepted) Authored -- https:/

Fellow Reports - October 2018

2018-10-10 Thread Tim Graham
Week ending October 6, 2018 Triaged --- https://code.djangoproject.com/ticket/29806 - Add parent_link to ForeignKey (duplicate) https://code.djangoproject.com/ticket/29807 - Custom user model with SlugField username causes `allow_unicode` error in admin (invalid) https://code.djangopr

Re: Requiring sqlparse for sqlite introspection

2018-10-10 Thread Tim Graham
Django creates database constraints I introduced a >> dependency on sqlparse in the sqlite introspection code. This allows Django >> to correctly read information about constraints on sqlite, particularly the >> name. >> >> When reviewing ( >> https://github.com/dja

Re: django.contrib.auth.views.PasswordResetConfirmView class properties

2018-10-13 Thread Tim Graham
There's an accepted ticket: https://code.djangoproject.com/ticket/28780 On Saturday, October 13, 2018 at 9:26:43 AM UTC-4, Frank van der Pluijm wrote: > > django.contrib.auth.views.PasswordResetConfirmView.dispatch() makes use of > two constant values outside of the class definition, > INTERNAL

Re: Fellow Reports - October 2018

2018-10-15 Thread Tim Graham
Week ending October 13, 2018 Triaged --- https://code.djangoproject.com/ticket/29790 - Migration that switches a model to a UUID primary key fails with "duplicate column name: id" (accepted) https://code.djangoproject.com/ticket/29834 - Union queryset with ordering breaks on ordering w

Re: Fellow Reports - October 2018

2018-10-20 Thread Tim Graham
Week ending October 20, 2018 Triaged --- https://code.djangoproject.com/ticket/29852 - Infinite migrations when using SimpleLazyObject in field arguments (wontfix) https://code.djangoproject.com/ticket/29858 - Clarify docs regarding CSRF token header name (fixed) https://code.djangopro

Re: Fellow Reports - October 2018

2018-10-27 Thread Tim Graham
Week ending October 27, 2018 Triaged --- https://code.djangoproject.com/ticket/29881 - Invalid SQL on MySQL with Cast to DecimalField (duplicate) https://code.djangoproject.com/ticket/29890 - FileSystemStorage._save() doesn't catch FileExistsError on concurrent os.mkdirs() (accepted) A

Re: need help to get started

2018-10-28 Thread Tim Graham
Hi Harsh, please read https://docs.djangoproject.com/en/dev/internals/contributing/new-contributors/. On Sunday, October 28, 2018 at 9:42:07 AM UTC-4, Harsh Sahu wrote: > > Hello There! > This is Harsh. I'm pursuing master's degree in Computer Science. I'm a > intermediate python person and lear

Re: Python string formatting

2018-10-31 Thread Tim Graham
Another discussion is https://groups.google.com/d/topic/django-developers/J9CfWIgrgbY/discussion - % vs {} string formatting for public APIs I haven't seen any practical benefits to prefer format() over %s. I find the latter less verbose. I'm not certain what this argument is (things like htt

Re: race condition on making directories when multiple files are uploaded to the same folder

2018-11-01 Thread Tim Graham
It's in a regression in Django 2.0 that will be fixed in today's 2.1.3 release. https://code.djangoproject.com/ticket/29890 -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group an

Re: Python string formatting

2018-11-01 Thread Tim Graham
I fail to see a problem with %. It's the primary format used throughout Django. The Django tutorial assumes some knowledge of Python, so I'd expect most newcomers would be familiar with both string formatting syntaxes. Maybe I'm just an old curmudgeon, but I find the tutorial examples more read

Re: Introspection of querysets

2018-11-02 Thread Tim Graham
Could you explain the use case for the code that needs to handle the different types of iterators? On Friday, November 2, 2018 at 11:18:34 AM UTC-4, Dan Davis wrote: > > I'm wondering two things: > >- Is there any non-internals way to know what sort of iterable a >queryset is set to do?

Re: Requiring sqlparse for sqlite introspection

2018-11-03 Thread Tim Graham
se are similar to provide a solid experience on SQLite I'd >> be +1 on requiring it from Django 2.2 to a point where the lowest version >> of SQLite we support has better introspection capabilities. >> >> Simon >> >> [0] https://github.com/django/django/pull/

Re: Using forms for bulk records

2018-11-03 Thread Tim Graham
This mailing list is for the development of Django itself, not how to solve problems with Django. Please don't cross-post from django-users. On Saturday, November 3, 2018 at 9:57:41 AM UTC-4, Elias Coutinho wrote: > > Good morning people. > > As always my problem is conceptual. I have improved a

Re: Fellow Reports - October 2018

2018-11-03 Thread Tim Graham
Week ending November 3, 2018 Triaged --- https://code.djangoproject.com/ticket/29904 - Not Null CharField Doesn't generate DB constraint on Oracle (invalid) https://code.djangoproject.com/ticket/29908 - Foreign key isn't set on object after related set access if ForeignKey uses to_field

Proposal to remove ModelAdmin's collection of actions from superclasses

2018-11-05 Thread Tim Graham
Hi, A recent bug report [1] brought up the fact that ModelAdmin collects actions from superclasses. For example: class BaseAdmin: actions = ['a'] class SubAdmin(BaseAdmin): actions = ['b'] SubAdmin will have action 'a' and 'b'. The behavior isn't tested and only mentioned in passing i

Re: Requiring sqlparse for sqlite introspection

2018-11-08 Thread Tim Graham
stall_requires even though it won't > be necessary if SQLite isn't used? > > That's my understanding and what I was advocating for. > > Simon > > Le samedi 3 novembre 2018 10:09:55 UTC-4, Tim Graham a écrit : >> >> So you want to add it to Django'

Fellow Reports - November 2018

2018-11-10 Thread Tim Graham
Week ending November 10, 2018 Triaged --- https://code.djangoproject.com/ticket/29921 - Default BooleanField.required different from Django 2.0 when using choices (invalid) https://code.djangoproject.com/ticket/29928 - TestCase doesn't check for foreign key constraints when using sqlite

Re: normalizing newlines in form fields

2018-11-12 Thread Tim Graham
Here's a ticket that was closed as wontfix. If you want it reconsidered, you should explain why you the think the arguments there aren't valid. https://code.djangoproject.com/ticket/19251 On Monday, November 12, 2018 at 9:58:39 AM UTC-5, Jakub Kleň wrote: > > I'm thinking if it wouldn't be nice i

Add Python 3.7 support for Django 1.11?

2018-11-16 Thread Tim Graham
We've received a relatively steady stream of requests to add Python 3.7 support for Django 1.11. Is there support or opposition for that? See comments of https://github.com/django/django/commit/931c60c5216bd71bc11f489e00e063331cf21f40#commitcomment-31328709 for the stream of "please backport t

Re: Add Python 3.7 support for Django 1.11?

2018-11-17 Thread Tim Graham
Okay, I've merged the PR, https://github.com/django/django/pull/10654. On Saturday, November 17, 2018 at 12:11:17 PM UTC-5, Markus Holtermann wrote: > > Agreed, let's add official 3.7 support. > > /Markus > > On Sat, Nov 17, 2018, at 1:15 PM, Adam Johnson wrote: > > Since it's about 3 lines in

Re: Fellow Reports - November 2018

2018-11-17 Thread Tim Graham
Week ending November 17, 2018 Triaged --- https://code.djangoproject.com/ticket/29946 - Weird session behavior after upgrading to Django 1.11.16 (needsinfo) https://code.djangoproject.com/ticket/29947 - Inlines containing a field with default value are considered empty and not saved (wo

Re: Question regarding a possible bug

2018-11-23 Thread Tim Graham
Generally, "is it a bug?" questions should be directed toward our support channels (linked from https://code.djangoproject.com/wiki/TicketClosingReasons/UseSupportChannels). Otherwise, Trac becomes a second level support channel which adds a lot of noise. On Thursday, November 22, 2018 at 7:10

Re: QuerySet.iterator together with prefetch_related because of chunk_size

2018-11-23 Thread Tim Graham
https://code.djangoproject.com/ticket/29984 suggests to support prefetch_related() with QuerySet.iterator(). I accepted the ticket to do something and linked back to this discussion. On Friday, October 26, 2018 at 8:12:02 PM UTC-4, charettes wrote: > > Josh, I agree that silently not working is

Re: Removing Oracle from Django core in 3.0

2018-11-25 Thread Tim Graham
I can't find a past discussion specific to Oracle, but it's not a new proposal. See https://groups.google.com/d/topic/django-developers/O-g06EM6XMM/discussion for "Moving database backends out of the core." I think removing Oracle from core would only increase the maintenance burden. Since Ora

Re: Fellow Reports - November 2018

2018-11-26 Thread Tim Graham
Week ending November 24, 2018 Triaged --- https://code.djangoproject.com/ticket/29966 - Add test coverage for BaseHandler's "The view didn't return an HttpResponse object." error (accepted) https://code.djangoproject.com/ticket/29977 - Allow customizing AccessMixin redirect (needsinfo)

Re: Removing Oracle from Django core in 3.0

2018-11-26 Thread Tim Graham
That's the query I would use. The 'oracle' keyword might not be assigned completely but you can scan through all the "Database layers" tickets fairly easily and add it to any that are missing. On Monday, November 26, 2018 at 12:25:06 PM UTC-5, Dan Davis wrote: > > Related question - how would I

Re: Fellow Reports - November 2018

2018-12-03 Thread Tim Graham
Week ending December 1, 2018 Triaged --- https://code.djangoproject.com/ticket/29992 - Error in admin checking list_display items (needsinfo) Authored -- https://github.com/django/django/pull/10697 - Switched TestCase to SimpleTestCase where possible in Django's tests. Review

Re: Allow usage of widgets in generic class-based views?

2018-12-04 Thread Tim Graham
What I meant is that modelform_factory() also has these parameters: localized_fields is a list of names of fields which should be localized. labels is a dictionary of model field names mapped to a label. help_texts is a dictionary of model field names mapped to a help text. error_messages is a

Fellow Reports - December 2018

2018-12-20 Thread Tim Graham
Week ending December 8, 2018 Authored -- https://github.com/django/django/pull/10726 - Fixed #30013 -- Fixed DatabaseOperations.last_executed_query() with mysqlclient 1.3.14+. Reviewed/committed -- https://github.com/django/django/pull/10731 - Fixed #30011 -- Fixed

Re: Fellow Reports - December 2018

2018-12-20 Thread Tim Graham
Week ending December 15, 2018 (vacation) -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@

Re: Fellow Reports - December 2018

2018-12-22 Thread Tim Graham
Week ending December 22, 2018 Authored -- https://github.com/django/django/pull/10782 - Fixed #30055 -- Dropped support for SQLite < 3.8.3. Reviewed/committed -- https://github.com/django/django/pull/10752 - Fixed #29928 -- Enabled deferred constraint checks on SQL

Re: Fellow Reports - December 2018

2018-12-29 Thread Tim Graham
Week ending December 29, 2018 Triaged --- https://code.djangoproject.com/ticket/30052 - QuerySet.only() doesn't support annotations (invalid) https://code.djangoproject.com/ticket/30049 - GIS widgets don't initialize properly after clicking "Add another" in admin inlines (accepted) htt

Django security releases issued: 2.1.5, 2.0.10, and 1.11.18

2019-01-04 Thread Tim Graham
Today the Django team issued 2.1.5, 2.0.10, and 1.11.18 as part of our security process. These releases address a security issue, and we encourage all users to upgrade as soon as possible: https://www.djangoproject.com/weblog/2019/jan/04/security-releases/ The issue was publicly reported through

Fellow Reports - January 2019

2019-01-08 Thread Tim Graham
Week ending January 5, 2019 Triaged --- https://code.djangoproject.com/ticket/30072 - SiteManager.get_current() cache uses global variable instead of cache breaking multiple instance deployments (duplicate) https://code.djangoproject.com/ticket/30082 - Document that Django 1.11.x raise

thoughts for Django fellowship applicants

2019-01-08 Thread Tim Graham
Hello, If you haven't seen the post*, I'll be stepping down as a Django fellow at the end of March. Applications are open until this Friday if you're interested in joining Carlton in the position. I wanted to give a brief retrospective on some aspects of my experience, with the hope that it'll

Re: Breaking change vs deprecation on Sitemaps `ping_google` command

2019-01-09 Thread Tim Graham
Adding temporary settings to the default project template sounds like a fair bit of cruft for a contrib app that isn't enabled by default. I don't use ping_google but I'm in favor of making the switch without a deprecation. Users of ping_google please comment, but switching to https doesn't see

Re: Fellow Reports - January 2019

2019-01-12 Thread Tim Graham
Week ending January 12, 2019 Triaged --- https://code.djangoproject.com/ticket/30075 - Better error message for "App 'bar.foo' could not be found. Is it in INSTALLED_APPS?" (fixed) https://code.djangoproject.com/ticket/30084 - Setting DATABASES['default']['TEST']['engine'] to SQLite doe

status of 2.2 release blockers

2019-01-13 Thread Tim Graham
Time to kick off the progress tracker for the next major release! The 2.2 feature freeze is scheduled (according to https://code.djangoproject.com/wiki/Version2.2Roadmap) for tomorrow, January 14. Typically we've released the alpha a few days later to finish up a few last minutes things. I hav

Google Summer of Code 2019

2019-01-16 Thread Tim Graham
Org applications for Google's Summer of Code are now open (deadline February 6). Do you think the Django Software Foundation should participate? We haven't had any high quality student applications that we could accept for the past two years. Perhaps it's partly a function of a poor ideas page

Re: status of 2.2 release blockers

2019-01-16 Thread Tim Graham
These features are in. We're planning to do the alpha release tomorrow. On Sunday, January 13, 2019 at 9:04:29 PM UTC-5, Tim Graham wrote: > > Time to kick off the progress tracker for the next major release! > > The 2.2 feature freeze is scheduled (according to > https://co

revisiting the Python version support policy

2019-01-21 Thread Tim Graham
When deciding when to drop support for Python 2 in Django, there was consensus to adopt this Python version support policy [0]: "Typically, we will support a Python version up to and including the first Django LTS release whose security support ends after security support for that version of Py

Re: Fellow Reports - January 2019

2019-01-21 Thread Tim Graham
Week ending January 19, 2019 Triaged --- https://code.djangoproject.com/ticket/17904 - Custom permissions on proxy model no longer created (fixed) https://code.djangoproject.com/ticket/30113 - Ignoring body with application/json payload causes HTTP 400 (duplicate) https://code.djangopr

Re: revisiting the Python version support policy

2019-01-24 Thread Tim Graham
It's interesting to me that no one (besides Claude -- and that's based on his ability to contribute to Django) has indicated that they care about Python 3.5 support in their deployments of Django 3.0... so I wonder if there is really a strong need for it. Who is saying, "I want to use the lates

Re: revisiting the Python version support policy

2019-01-25 Thread Tim Graham
`pip install Django` gives the latest version of Django that's compatible for the current version of Python. Yes, users will have to switch versions at docs.djangoproject.com and they'll be in the same situation at docs.python.org if they're using Python 3.5. For learning Django, I'd think the

<    5   6   7   8   9   10   11   12   13   14   >