Re: assertRaises vs. assertRaisesMessage

2017-04-07 Thread Tim Graham
Hi Shai, Without testing for a message, there's also a possibility that the exception you think you're testing isn't the one the test is actually raising. I think the readability advantages of including messages in the tests outweigh the cost of updating tests when a message changes. On Friday

Fellow Report - April 8, 2017

2017-04-08 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28011 - Correct Field.hidden docs regarding what fields are hidden (created) https://code.djangoproject.com/ticket/28027 - UTF-8 in help_text in models.ManyToManyField doesn't work anymore (invalid) https://code.djangoproject.com/ticket/

Fellow Report - April 15, 2017

2017-04-15 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28069 - Updating location of setup_test_environment() warning in tutorial 5 (fixed) https://code.djangoproject.com/ticket/28059 - ModelAdmin.radio_fields doesn't render admin.HORIZONTAL CSS classes (accepted) https://code.djangoproject.c

Fellow Report - April 22, 2017

2017-04-22 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28084 - FieldDoesNotExist when running a migration that removes a deleted field from unique_together (duplicate) https://code.djangoproject.com/ticket/28075 - USE_THOUSAND_SEPARATOR = True, causes foreignkey id to become localized (accep

Using QuerySet.iterator() with pgBouncer leads to nonexistent cursor errors (#28062)

2017-04-24 Thread Tim Graham
Django 1.11 added support for server-side cursors on PostgreSQL: https://github.com/django/django/commit/f3b7c059367a4e82bbfc7e4f0d42b10975e79f0c As reported in https://code.djangoproject.com/ticket/28062, pgBouncer doesn't support using WITH HOLD cursors in transaction pooling mode, so the chan

Organizing utilities for Django's test suite

2017-04-27 Thread Tim Graham
At present, we have a number of functions in django.test.utils which aren't documented and are meant for use in Django's test suite. Things like: * extend_sys_path() * isolate_lru_cache() * captured_stdout()/err()/in() * freeze_time() * require_jinja2() I have the need to reuse a WidgetTestCase

Re: Organizing utilities for Django's test suite

2017-04-28 Thread Tim Graham
we should include that test > case as part of Django's own test suite for now. It's IMO easier to move > code from tests/utils/something.py to django/tests/something.py than vice > versa. > > That said, I think we should make capture_stdout()/err()/in() public API.

Re: Easier way to populate test databases for parallel tests (patch in github)

2017-04-28 Thread Tim Graham
I would expect test data population to happen using migrations rather than in the test runner. Can you elaborate on your use case and say if that method would be unsuitable? On Friday, April 28, 2017 at 8:45:55 PM UTC-4, Marcos Diez wrote: > > Ticket:https://code.djangoproject.com/ti

Fellow Report - April 29, 2017

2017-04-29 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28121 - force_text incorrectly handles SafeBytes under PY3 (wontfix) https://code.djangoproject.com/ticket/28131 - Template variable "perms" single-attribute lookup does not work as documented (accepted) https://code.djangoproject.com/ti

Re: #17962 Add get_deleted_objects hook to ModelAdmin

2017-05-04 Thread Tim Graham
Lately my efforts are focused on fixing bugs and regressions in 1.11 so the patch review queue of other issues is getting quite large. If you want to help review other patches in the queue (linked from https://dashboard.djangoproject.com/), that will increase the chance I'll be able to review y

Django bugfix release: 1.11.1

2017-05-06 Thread Tim Graham
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2017/may/06/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

Fellow Report - May 6, 2017

2017-05-06 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28156 - User.has_perm always returns False for a custom permission inherited from group (invalid) https://code.djangoproject.com/ticket/28123 - django.utils.html.smart_urlquote() is incorrectly parsing the query string (accepted) https:

Re: Proposal: provide postgresql powered full-text search in djangoproject.com

2017-05-08 Thread Tim Graham
I agree that eliminating elasticsearch could be a simplification win from a maintenance perspective. For example, I spent some hours a few months ago debugging a problem with a new version of elasticsearch that caused our cluster to run out of memory and lock up every ~24 hours. Also, not having

Fellow Report - May 13, 2017

2017-05-13 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28178 - Allow applications that make optional use of contrib.gis to better silence the lack of a GDAL install (accepted) https://code.djangoproject.com/ticket/28179 - Unittest of a form with Multiselect not filling correctly (invalid) h

Are there use cases for storing null bytes in CharField/TextField?

2017-05-15 Thread Tim Graham
Does anyone know of a use case for using null bytes in CharField/TextField? psycopg2 2.7+ raises ValueError("A string literal cannot contain NUL (0x00) characters.") when trying to save null bytes [0] and this exception is unhandled in Django which allow malicious form submissions to crash [1].

Re: Why was CommaSeparatedIntegerField Deprecated?

2017-05-15 Thread Tim Graham
more concerned that it just > kind of slipped through without anyone really thinking about it. > > (To be clear, I don't begrudge Tim Graham, he was right to propose it, but > then there was no discussion on it at all that I saw) > -- You received this message because you are

Re: Contribution

2017-05-16 Thread Tim Graham
Hi Martin, have you read the contributing documentation? https://docs.djangoproject.com/en/dev/internals/contributing/new-contributors/ On Tuesday, May 16, 2017 at 8:34:30 AM UTC-4, Martin Gauthier wrote: > > Hi Everyone, > > I'm fairly new here , I have been using Django for past year and would

Re: two question, common template and mutiple user type

2017-05-19 Thread Tim Graham
Please don't post questions like this (about using Django) to this list (its topic is about developing Django). Use the django-users or the #django IRC channel list for that. On Thursday, May 18, 2017 at 6:58:59 AM UTC-4, Man Single wrote: > > Two question: > First: There are multiple type use

Re: Are there use cases for storing null bytes in CharField/TextField?

2017-05-19 Thread Tim Graham
of our > non-django apps). And that's to overcome limitation that Oracle doesn't > have real concept of empty string so we stored single null byte to mark > that. > > > On 15.05.2017 18:54, Tim Graham wrote: > > Does anyone know of a use case for using null bytes

Fellow Report - May 20, 2017

2017-05-20 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28204 - MultipleObjectMixin,paginate_queryset() crashes with UnicodeDecodeError if InvalidPage message contains non-ASCII (accepted) https://code.djangoproject.com/ticket/28205 - Document that ModelAdmin.prepopulated_fields only works on

Fellow Report - May 27, 2017

2017-05-27 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28243 - Renaming Base model in multi-table inheritance raises django.core.exceptions.FieldError: Auto-generated field clashes (duplicate) https://code.djangoproject.com/ticket/28244 - Exceptions derived from BaseException instead of Exce

Re: Are there use cases for storing null bytes in CharField/TextField?

2017-05-29 Thread Tim Graham
ation enhancements. On Friday, May 19, 2017 at 9:35:28 AM UTC-4, Tim Graham wrote: > > If CharField/TextField have a form validation error if null bytes are in > the input, are users going to be able to understand that error and fix it? > I'm not sure if it's a probable case

Re: Django db backend not FIPS compliant

2017-05-31 Thread Tim Graham
This usage generates a short, unique identifier for a database index name. The usage of md5 here isn't security sensitive. Changing it to some other hash could be backwards incompatible because Django would no longer know the names of indexes in existing projects. There are other usages of md5 i

should nonexistent template filter arguments resolve to string_if_invalid rather than raise VariableDoesNotExist?

2017-05-31 Thread Tim Graham
Should nonexistent template filter arguments raise an exception? Current behavior: {{ value|filter:nonexistent_template_var}} raises VariableDoesNotExist for nonexistent_template_var. I guess the proposal would be to make nonexistent_tempatle_var resolve to string_if_invalid. As for me, I thin

Re: Make bool(AnonymousUser) evaluate to false

2017-05-31 Thread Tim Graham
My thoughts from the ticket, "The Django test suite passes with the change but I feel like that could have some backwards compatibility concerns. Also "explicit is better than implicit"? On Wednesday, May 31, 2017 at 12:44:51 PM UTC-4, Linus Lewandowski wrote: > > I suggest adding __bool__() met

Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2017-06-01 Thread Tim Graham
ct A since its > initialized even before we a have access to self.liveserver_url" > > On Saturday, October 15, 2016 at 5:13:07 PM UTC+3, Tim Graham wrote: >> >> At the time of the implementation [0], no one raised that use case. >> Probably we can reopen the ticket and a

Django bugfix release: 1.11.2

2017-06-01 Thread Tim Graham
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2017/jun/01/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

Deprecating AuthenticationMiddleware

2017-06-02 Thread Tim Graham
Curtis started a PR [0] that replaces the functionality of AuthenticationMiddleware.process_request(): request.user = SimpleLazyObject(lambda: get_user(request)) with this line in AuthConfig.ready(): HttpRequest.user = cached_property(get_user, 'user') Before finishing the patch, I'd like to g

Re: Value of tightening URLValidator/EmailValidator regular expressions?

2017-06-02 Thread Tim Graham
Aymeric, did anything specific change your mind from your March 2016 mail: "Indeed, for some reason, the URL and email validators get anywhere from 2 to 8 changes in every Django version, and there’s no end in sight. (I contributed to this. Sorry.) Like James, I’m in favor of making the validat

Re: Incorrect escaping in Django SQL query

2017-06-02 Thread Tim Graham
I couldn't find any testing of TruncDay with Value(). Is there a difference between the query you're trying to construct and MyModel.objects.filter(created__lt=timezone.now().date()) ? On Thursday, June 1, 2017 at 7:35:25 AM UTC-4, Roshan Raghupathy wrote: > > Hi, > > I came across an issue yest

Re: migrate id field from integer to biginter (probable bug)

2017-06-02 Thread Tim Graham
Yes, it looks like a bug. The incorrect SQL is added here: https://github.com/django/django/blob/8149bd00d8b8af816a683e5ecc0e204f344616f5/django/db/backends/base/schema.py#L745-L749 On Wednesday, May 31, 2017 at 1:34:07 PM UTC-4, drakkan wrote: > > Hi, > > I have two models like these: > > class

Re: Tabs in Django Admin forms?

2017-06-02 Thread Tim Graham
I think Django can't reasonably add every feature under the sun to the admin. If you need a pixel perfect UI, use your own views. On Tuesday, May 30, 2017 at 4:50:16 AM UTC-4, Óscar M. Lage wrote: > > Oh, sorry, something like this: > > >

Re: Tests failing on postgres 9.6

2017-06-02 Thread Tim Graham
Closing the loop for anyone who finds this message and doesn't click through to the ticket: It seems to be a locale problem. Cleaned up everything (removed /usr/local/var/postgres), installed postgres again with export LC_ALL=en_US.UTF-8; export LANG=en_US.UTF-8 and it worked. On Tuesday, May

Re: Are there use cases for storing null bytes in CharField/TextField?

2017-06-02 Thread Tim Graham
ote: > > On Mon, May 15, 2017 at 10:30 AM, Tim Chase > wrote: > >> On 2017-05-15 08:54, Tim Graham wrote: >> > Does anyone know of a use case for using null bytes in >> > CharField/TextField? >> >> Is this not what BinaryField is for? It would

Re: Incorrect escaping in Django SQL query

2017-06-02 Thread Tim Graham
Cross posted to django-users: https://groups.google.com/d/msg/django-users/nNgcv2QajCI/hPRwIeVNBAAJ In the future, please keep the conversation in one place. django-users is fine for asking "is it a bug?" questions. On Friday, June 2, 2017 at 11:26:22 AM UTC-4, Tim Graham wrote: >

Fellow Report - June 3, 2017

2017-06-03 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28172 - Prevent nonexistent template filter arguments from raising VariableDoesNotExist (maybe) https://code.djangoproject.com/ticket/28217 - nested calls to functions decorated with sensitive_post_parameters produces unexpected results w

Re: Responsive admin

2017-06-08 Thread Tim Graham
A pull request is available for review: https://github.com/django/django/pull/8610 I don't have any experience writing responsive CSS so reviews from experts in that area would be welcome. On Tuesday, May 30, 2017 at 4:04:51 AM UTC-4, Óscar M. Lage wrote: > > Nice suggestion!, imho something li

Re: Default to BigAutoField

2017-06-09 Thread Tim Graham
I'm not sure how this could work with migrations. In a sense, it would involve making the auto-generated primary key "swappable", including foreign keys that point to it. This sounds like a headache. I haven't thought of a possible solution since Kenneth floated this idea in #django-dev yesterd

Fellow Report - June 10, 2017

2017-06-10 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28268 - Feature: Clear cached_property on related DB operations. (wontfix) https://code.djangoproject.com/ticket/28276 - debug.py loops over QueryDict['items'] instead of QueryDict.items() (duplicate) https://code.djangoproject.com/ticke

Re: Consider making asgi_rabbitmq an official Django project.

2017-06-14 Thread Tim Graham
>From my perspective, there's been little visibility into how things are going with the other channels related official projects. Who are the other maintainers there? I would present this question to those people (hopefully there are some others by now?) rather than to the Django maintainers whi

Re: Vendoring Select2

2017-06-14 Thread Tim Graham
To learn about some history of noConflict, I'd use this Google search: jquery noConflict site:code.djangoproject.com The first two results are some tickets with discussion: https://code.djangoproject.com/ticket/12882 - jQuery.noConflict() in admin breaks site specific code with jQuery https://co

Re: Admin browser support policy

2017-06-14 Thread Tim Graham
Django 1.11 dropped support for IE8 and below as those browsers are end of life. It looks like we could now drop support for IE<11 based on this from Microsoft: "Beginning January 12, 2016, only the most current version of Internet Explorer available for a supported operating system will receiv

Fellow Report - June 17, 2017

2017-06-17 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28299 - Adding a unique UUIDField to an existing model immediately fails with a database constraint error (duplicate) https://code.djangoproject.com/ticket/28302 - Separate authorisation from authentication (duplicate) https://code.djan

Re: should nonexistent template filter arguments resolve to string_if_invalid rather than raise VariableDoesNotExist?

2017-06-19 Thread Tim Graham
I think that to convince me to change the current behavior, you would have to present a compelling use case for relying on nonexistent variables as filter arguments. Wouldn't this behavior typically just hide bugs? On a related note, I proposed removing the logging of undefined template variabl

Re: should nonexistent template filter arguments resolve to string_if_invalid rather than raise VariableDoesNotExist?

2017-06-19 Thread Tim Graham
with variables like: > > Template('{{ foo|default:notreal1|date:notreal2 > }}').render(Context({'foo': '', notreal2: 'as'})). > > > El lunes, 19 de junio de 2017, 15:10:54 (UTC-3), Tim Graham escribió: >> >> I think that to convin

Re: should nonexistent template filter arguments resolve to string_if_invalid rather than raise VariableDoesNotExist?

2017-06-22 Thread Tim Graham
t, > Template('{{ foo|default:notreal|center:notreal2 > }}').render(Context({'foo': 'django', 'notreal2':'15' })) #so, the > output should be ' django' > > # and the same reasoning and analogous ex

Re: CheckboxSelectMultiple Widget Bug

2017-06-22 Thread Tim Graham
It's helpful if you can include steps to reproduce the issue. Here's what I see on master. I also see the same on 1.8, besides some whitespace differences due to template-based widget rendering that's new in Django 1.11. >>> from django.forms import CheckboxSelectMultiple >>> w = CheckboxSelect

Fellow Report - June 24, 2017

2017-06-24 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28321 - FormSet.full_clean() shouldn't validate deleted forms (accepted) https://code.djangoproject.com/ticket/28322 - Add support for mysql client certificates to dbshell (fixed) https://code.djangoproject.com/ticket/28326 - Allow provi

Re: Getting Started with Open Source and Finding a mentor

2017-06-26 Thread Tim Graham
You can use this mailing list: https://groups.google.com/forum/#!forum/django-core-mentorship It would be helpful to say what issue you're working on and the specifics of what help or advice you need. On Friday, June 23, 2017 at 10:35:58 PM UTC-4, Irindu Nugawela wrote: > > Hi, I am a computer

Django bugfix release: 1.11.3

2017-07-01 Thread Tim Graham
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2017/jul/01/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

Fellow Report - July 1, 2017

2017-07-01 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28340 - USE_THOUSAND_SEPARATOR=True causes primary key to include commas (wontfix) https://code.djangoproject.com/ticket/28335 - Add query expressions support for models meta ordering (duplicate) https://code.djangoproject.com/ticket/283

Fellow Report - July 8, 2017

2017-07-08 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28356 - Serializer got error when datetime field receive string instead datetime object (wontfix) https://code.djangoproject.com/ticket/28362 - Docs incorrectly state that time zone support is disabled by default (invalid) https://code.d

Fellow Report - July 15, 2017

2017-07-15 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28384 - ModelAdmin.lookup_allowed() incorrectly raises DisallowedModelAdminLookup lookup with foreign key as primary key (accepted) https://code.djangoproject.com/ticket/28388 - JSONField cannot be overridden to use OrderedDict as python

Fellow Report - July 22, 2017

2017-07-22 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28401 - Allow hashlib.md5() calls to work with FIPS kernels (accepted) https://code.djangoproject.com/ticket/28402 - Provide 'temporary_file_path' for InMemoryUploadedFile (wontfix) https://code.djangoproject.com/ticket/28408 - Incorrect

Re: Postgres backend introspection and the 'public' schema

2017-07-25 Thread Tim Graham
Here's are related tickets: https://code.djangoproject.com/ticket/22673 - inspectdb doesn't support database schema on postgresql with name different of "public" https://code.djangoproject.com/ticket/6148 - Add generic support for database schemas On Tuesday, July 25, 2017 at 8:53:40 AM UTC-4, N

Fellow Report - July 29, 2017

2017-07-29 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28431 - default='' (non-bytestring) on BinaryField crashes some migration operations (accepted) https://code.djangoproject.com/ticket/28430 - Response is not necessarily rendered when response middlewares are applied (worksforme) https://

Django bugfix release: 1.11.4

2017-08-01 Thread Tim Graham
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2017/aug/01/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

Fellow Report - August 5, 2017

2017-08-05 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/28460 - CharField primary keys with underscores are reversed incorrectly in admin links (duplicate) https://code.djangoproject.com/ticket/28461 - Clarify how UserManager.create_superuser() must be implemented with a ForeignKey in REQUIRE

Re: Request to contribute in Django

2024-09-20 Thread Tim Graham
Hi Anant, https://docs.djangoproject.com/en/dev/internals/contributing/new-contributors/ is a good place to start. On Monday, September 16, 2024 at 1:03:21 PM UTC-4 Anant Chitranshi wrote: > Dear All, > I am Anant Chitranshi. I wish to contribute to django. Can you please help > me to start? >

<    12   13   14   15   16   17