Fellow Report - October 29, 2016

2016-10-29 Thread Tim Graham
I will be in Amsterdam next week for the Django Under the Hood conference. Look forward to seeing many of you there. Triaged --- https://code.djangoproject.com/ticket/27377 - Clarify that prepopulated_fields doesn't work with OneToOneField (accepted) https://code.djangoproject.com/tick

[ANNOUNCE] Django security releases issued: 1.10.3, 1.9.11, and 1.8.16

2016-11-01 Thread Tim Graham
Today the Django team issued 1.10.3, 1.9.11, and 1.8.16 as part of our security process. These releases address two security issues, and we encourage all users to upgrade as soon as possible. Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2016/nov/01/se

Fellow Report - November 5, 2016

2016-11-05 Thread Tim Graham
Light week due to Django Under the Hood travel and attendance. Busy day of sprints today. Jenkins hasn’t yet recovered! Triaged --- https://code.djangoproject.com/ticket/27410 - Clarify staticfiles "is enabled (default)" in ref (fixed) https://code.djangoproject.com/ticket/27414 - Docum

Re: HttpResponse.headers public property

2016-11-08 Thread Tim Graham
Here's an accepted ticket for the idea: https://code.djangoproject.com/ticket/20147 It looks like there's rough consensus but a complete patch hasn't been provided. On Tuesday, November 8, 2016 at 11:04:53 AM UTC-5, roboslone wrote: > > Hi! > > Is there a reason why HttpResponse doesn't have p

Re: LiveServerTestCase change in Django 1.11 means can't run functional tests against external server?

2016-11-08 Thread Tim Graham
ecial on my account. do keep me posted if >> anyone does decide to write their own hack and feels like sharing it tho! >> >> hp >> >> (PS not sure if i'm on the django-dev mailing list, do forward my email >> if necessary) >> >> >> &g

Re: Uniform content type tables with multiple databases

2016-11-08 Thread Tim Graham
I'm not sure if anything could or should be done, but I noticed a warning in the documentation that Aymeric added: "If you’re synchronizing content types to more than one database, be aware that their primary keys may not match across databases. This may result in data corruption or data loss.

Re: HttpResponse.headers public property

2016-11-08 Thread Tim Graham
;)]) >>> response._headers {'content-type': ('Content-Type', 'text/html; charset=utf-8'), 'foo': ('foo', 'bar')} On Tuesday, November 8, 2016 at 12:08:49 PM UTC-5, roboslone wrote: > > Given ticket is about HttpRequest h

Fellow Report - November 12 ,2016

2016-11-12 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27444 - Django StaticLiveServerTestCase: view cannot query test-database properly (invalid) https://code.djangoproject.com/ticket/27457 - Cannot migrate ArrayField on SQLite (invalid) https://code.djangoproject.com/ticket/27451 - syndica

drop compatibility with Python < 2.7.8?

2016-11-14 Thread Tim Graham
Hi, I was wondering if Django could or should nudge Python 2 users toward the latest stable release of 2.7.x? For example, we could require at least 2.7.8 by removing the fallback pbkdf2() implementation in django.utils.crypto [0]. I guess part of my feeling is that if you're running 1.11 LTS

Re: drop compatibility with Python < 2.7.8?

2016-11-15 Thread Tim Graham
Okay, I'll drop the idea. On Tuesday, November 15, 2016 at 9:44:47 AM UTC-5, Shai Berger wrote: > > I would too, since the distros tend to patch the older Python versions > without > updating the version number (2.7.8-12 etc). > > On Tuesday 15 November 2016 11:01:42 Marc Tamlyn wrote: > > I'd

Re: Template-based widget rendering

2016-11-16 Thread Tim Graham
I took a stab at backwards-compatibility with respect to allowing the admin to work without adding 'django.forms' to INSTALLED_APPS. It seems to work for at least the simple TEMPLATES = 'BACKEND': 'django.template.backends.django.DjangoTemplates', ...} case, although I'm not proud of the code a

Re: Feature idea

2016-11-16 Thread Tim Graham
I don't think this registration model is common on most websites. On Wednesday, November 16, 2016 at 2:24:43 PM UTC-5, Bruno Ribeiro da Silva wrote: > > Hello everyone, > > I have this simple idea that I think django could benefit from, which > would be the option to create a user by an invitati

Fellow Report - November 19, 2016

2016-11-19 Thread Tim Graham
Triaged --- http://bugs.python.org/issue28563 - Arbitrary code execution in gettext.c2py (debugging a backwards-incompatbility that broke some Django tests) https://code.djangoproject.com/ticket/27492 - JsonResponse can't handle model_to_dict() with empty ImageField (invalid) https://c

[ANNOUNCE] Django security advisory: Vulnerability in password reset (master branch only)

2016-11-21 Thread Tim Graham
We don't normally give security advisories for issues that affect only the master branch, but in this case we've made an exception as the issue could be high impact. Please see the blog post for details: https://www.djangoproject.com/weblog/2016/nov/21/passwordresetconfirmview-security-advisory/

Re: Consider reverting or adding guidelines on how to use class based views for security sensitive features

2016-11-21 Thread Tim Graham
I haven't extended these views much, so I can't talk about the pain points of extending the function-based views compared to the ease of extending the classes. I'm certainly more confident about reasoning with function-based code. There was a draft patch [0] a few months ago that converted some

Re: Newbie's questions

2016-11-22 Thread Tim Graham
You may use a PDF editor to sign the contributor license agreement rather than printing and scanning. The contributing documentation describes the ticket triage process. If you have specific questions, please ask. On Monday, November 21, 2016 at 12:34:53 PM UTC-5, ranvir singh wrote: > > > > On

automating Django releases

2016-11-25 Thread Tim Graham
After doing releases about once a month for a while, I'm thinking it would be nice if releasing Django could be a bit more automated. As far as I know, the process hasn't changed too much in 10 years, while the state of Python packaging has improved. Currently doing a release requires bumping t

Fellow Report - November 26, 2016

2016-11-26 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27520 - sqlmigrate generates a duplicate DROP INDEX statement (duplicate) https://code.djangoproject.com/ticket/27483 - Add a login_required decorator for AJAX requests (wontfix) https://code.djangoproject.com/ticket/27498 - Filtering an

Re: CSRF_COOKIE_HTTPONLY is misleading and not useful

2016-11-28 Thread Tim Graham
Meanwhile, there's a ticket [0] asking to expand the documentation of the settings.CSRF_COOKIE_HTTPONLY. If this setting doesn't provide any value, then I figure we should remove the system check that suggests to enable it and deemphasize it in the documentation and/or remove it. Is there conse

django-formtools is neglected/unmaintained

2016-11-28 Thread Tim Graham
Hi, django-formtools seems neglected. It's been several months since the release of Django 1.10 but a compatible version of formtools hasn't been released to PyPI. Personally, I don't know if it's important to maintain it as an "official project." An alternative could be to "donate" it to Jazz

Re: Unable to run tests with git bisect run

2016-12-01 Thread Tim Graham
Hi, Try to get the tests working in a virtual environment as described in https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/unit-tests/ so you don't need the PYTHONPATH stuff. If you need help, join the #django-dev IRC channel. Thanks for contributing. On Thursday, De

[ANNOUNCE] Django bugfix releases issued: 1.10.4, 1.9.12, and 1.8.17

2016-12-01 Thread Tim Graham
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2016/dec/01/bugfix-releases/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

trouble with pull request builders

2016-12-02 Thread Tim Graham
This week the Jenkins pull request builders haven't been working correctly, probably due to an update in Jenkins itself or somewhere else. After migrating the Jenkins master from Ubuntu 12.04 to 16.04, I started configuring a different pull request builder plugin that Simon Charette recommended

Fellow Report - December 3, 2016

2016-12-03 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27533 - inspectdb crashes on unsupported unique_together constraints in PostgreSQL (accepted) https://code.djangoproject.com/ticket/27542 - Client.force_login() shouldn't use authentication backends without a get_user() method (accepted)

Re: Good morning Django team!

2016-12-07 Thread Tim Graham
Hi Adonys, If you want to help out, you can look at the "Patches needing review" queue (currently 28 issues) at https://dashboard.djangoproject.com/ and help to review those patches using the patch review checklist [0]. Reviewing patches isn't a task limited to members of the Django team. Anyon

Re: Template-based widget rendering

2016-12-07 Thread Tim Graham
This scheme seems to be working well so far. One thing you may not have thought of is that switching to JinjaTemplateRenderer is incompatible with the admin because jinja2 templates aren't provided for those widgets. I think the reasoning was that they're complicated to convert due to the use o

Re: Provide a simpler way to default runserver IP/port to 0.0.0.0:8000

2016-12-08 Thread Tim Graham
I've had a similar thought that it would be nice to have some way to specify some default command arguments for management commands (such as --keepdb when running tests), however, adding settings (and/or environment variables?) for every such use case doesn't feel like it'll keep things simple.

Fellow Report - December 10, 2016

2016-12-10 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27568 - Add new Entropy Password Validator to django.contrib.auth.password_validation (wontfix) https://code.djangoproject.com/ticket/27571 - Conditionally add TEST_DATABASE_PREFIX to db name (wontfix) https://code.djangoproject.com/tick

Re: PyCharm & tests/runtests.py

2016-12-10 Thread Tim Graham
Please add new operations to the existing migrations manually. See a previous commit on the file for an example: https://github.com/django/django/commit/094d630ae8d8e5e68817c313da0fd737898b216b I'm not a PyCharm user so I'm not sure about that part. On Saturday, December 10, 2016 at 11:20:17 AM

Re: migrations operation to alter model bases

2016-12-13 Thread Tim Graham
There are a few open tickets that may be related: https://code.djangoproject.com/ticket/23521 - removal of concrete Model from bases doesn't remove it from ModelState bases https://code.djangoproject.com/ticket/26488 - migrate raises InvalidBasesError if you rename a multitable inheritance base

Re: Template-based widget rendering

2016-12-14 Thread Tim Graham
the exception, should that behavior be eased by default? I think using a custom renderer (perhaps even one provided by the app itself) that uses DIRS would be a more explicit setup. On Wednesday, December 7, 2016 at 12:00:57 PM UTC-5, Carl Meyer wrote: > > Hi Tim, > > On 12/07/2016

Re: Template-based widget rendering

2016-12-14 Thread Tim Graham
My thinking is that there should typically be only one directory in each project that overrides built-in templates, otherwise if multiple apps provide overrides, they'll stomp on each other when using the app_directories loader. Are your projects usually set up that way? Using the app_directori

Re: Template-based widget rendering

2016-12-14 Thread Tim Graham
g patch will be ready for final reviews. On Wednesday, December 14, 2016 at 6:40:36 PM UTC-5, Carl Meyer wrote: > > Hi Tim, > > On 12/14/2016 12:50 PM, Tim Graham wrote: > > My thinking is that there should typically be only one directory in each > > project that overrid

Re: CSRF_COOKIE_HTTPONLY is misleading and not useful

2016-12-16 Thread Tim Graham
I've created a pull request to remove the check and update the docs: https://github.com/django/django/pull/7700 On Tuesday, November 29, 2016 at 5:15:24 AM UTC-5, Alasdair Nicol wrote: > > On Monday, 28 November 2016 21:38:14 UTC, Tim Graham wrote: >> >> Meanwhile, there&#

Re: Need help with MySQL 5.7 crashing on Django's Jenkins

2016-12-16 Thread Tim Graham
I've increased the tmpfs to 4GB -- we'll see if the problem reoccurs. On Saturday, August 6, 2016 at 8:54:29 AM UTC-4, gilberto dos santos alves wrote: > > great! > > 2016-08-05 19:19 GMT-03:00 Tim Graham >: > >> I spun up a new machine and haven't see

Considering removing support for ("iLmsu") regex groups in URLpatterns. Do you use them?

2016-12-16 Thread Tim Graham
Python deprecated usage of flags not at the start of a regular expression [0], e.g. 'CaseInsensitive(?i)' instead of '(?i)CaseInsensitive'. Deprecation warnings shows up in a few URL tests that are using (?i) to get case-insensitive matching of URLpatterns. However, because the URL resolver pre

Re: Please help me with "Writing your first patch for Django"

2016-12-17 Thread Tim Graham
1. As the tutorial says, "Some tests are specific to a particular database backend and will be skipped if not testing with that backend." No problem there. 2. Can you reproduce those failures on master? If not, it's nothing to worry about. On Saturday, December 17, 2016 at 10:49:21 AM UTC-5, C

Fellow Report - December 17, 2016

2016-12-17 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27588 - Avoid affixing colon to migration name in makemigrations output (fixed) https://code.djangoproject.com/ticket/27587 - Document str(QuerySet.query) (accepted) https://code.djangoproject.com/ticket/27595 - ForeignKey to model subcl

Re: Considering removing support for ("iLmsu") regex groups in URLpatterns. Do you use them?

2016-12-18 Thread Tim Graham
a deprecation path that would require > code to work in Python 3.6 that's equivalent to implementing the feature, > so why not keep said code around? > > On 16 December 2016 at 19:19, Tim Graham > > wrote: > >> Python deprecated usage of flags not at the start

Re: Does the javascript test runner need attention?

2016-12-19 Thread Tim Graham
/ajax/libs/openlayers/2.13.1/OpenLayers.js after cloudflare updated their cert today. On Thursday, August 25, 2016 at 11:27:39 AM UTC-4, Tim Graham wrote: > > Trey Hunner said [0], "Blanket and qunit are the only real requirements > here. We may be able to switch away from Grunt and

Re: Template-based widget rendering

2016-12-19 Thread Tim Graham
It's ready for review: Add 'POST_APP_DIRS' TEMPLATES option. https://github.com/django/django/pull/7693 Template based widget rendering: https://github.com/django/django/pull/6498 On Wednesday, December 14, 2016 at 6:59:16 PM UTC-5, Tim Graham wrote: > > I don't hav

Re: GeoDjango OffdbRasterField

2016-12-20 Thread Tim Graham
Daniel Wiesmann did all the work for RasterField. I'm not sure if he follows this list but you can find his email address in the Django commit longs and mail him to ask for his input. https://github.com/yellowcap On Tuesday, December 20, 2016 at 11:27:25 AM UTC-5, Piero Toffanin wrote: > > It's

Re: Template-based widget rendering

2016-12-20 Thread Tim Graham
/pull/6498#issuecomment-268120711 On Monday, December 19, 2016 at 5:53:23 PM UTC-5, Tim Graham wrote: > > It's ready for review: > > Add 'POST_APP_DIRS' TEMPLATES option. > https://github.com/django/django/pull/7693 > Template based widget rendering: > htt

Re: Template-based widget rendering

2016-12-20 Thread Tim Graham
ill also > > cache if it doesn't find anything, ie it will not do extra I/O for > > non-existing templates (after the initial round). As far as I understand > > the Jinja2 code, non-existing file are extra I/O every time, so that > > might be something to consider. >

Re: Template-based widget rendering

2016-12-20 Thread Tim Graham
plateEngines. On Tuesday, December 20, 2016 at 3:00:11 PM UTC-5, Carl Meyer wrote: > > Sure, I guess Florian mentioned dropping Jinja2TemplateRenderer, but I > don't really see a strong argument against keeping and documenting it. > As you say, cost is low. > > Carl > >

Re: Template-based widget rendering

2016-12-20 Thread Tim Graham
ettingEngines"? On Tuesday, December 20, 2016 at 4:35:45 PM UTC-5, Carl Meyer wrote: > > On 12/20/2016 01:26 PM, Tim Graham wrote: > > Okay I removed 'POST_APP_DIRS' from the PR. > > > > Next, we should discuss whether or not to make the ProjectTemp

Re: Template-based widget rendering

2016-12-20 Thread Tim Graham
TemplatesSetting seems okay to me (open to other consensus though). PR is updated: https://github.com/django/django/pull/6498 On Tuesday, December 20, 2016 at 5:19:32 PM UTC-5, Carl Meyer wrote: > > > On 12/20/2016 02:04 PM, Tim Graham wrote: > > I think it would be nice to be

is support for old cx_Oracle versions needed?

2016-12-21 Thread Tim Graham
The docs say, "Version 4.3.1 or higher of the `cx_Oracle`_ Python driver is required, although we recommend version 5.1.3 or later as these versions support Python 3." The advise of "4.3.1 or higher" hasn't changed since 2007 (Django 1.0). Shai contributed a bug fix for timedelta handling in cx

status of 1.11 release blockers

2016-12-21 Thread Tim Graham
Time to kickoff the progress tracker for the next major release! The 1.11 alpha is currently scheduled for January 16. My brother is getting married on the 15th, so it's unlikely I'll be doing much merging over that weekend. Maybe we can freeze at the end of the day on Friday and do the alpha r

Re: #26369: default formfield callback override

2016-12-22 Thread Tim Graham
Hi, It's not clear to me whether or not this proposal considers the concerns from the last time you raised the idea some months ago. Perhaps you could summarize that discussion so we don't rehash it. Thanks. https://groups.google.com/d/topic/django-developers/zG-JvS_opi4/discussion On Thursd

ending support for Oracle 11.2?

2016-12-22 Thread Tim Graham
Oracle's extended support for 11.2 ends Dec 2020. We don't currently have testing on the CI servers for 11.2, and I think the Developer Days VM for 11.2 is no longer available from Oracle (I have a local copy that I've used for testing). Making the GIS tests work on Oracle 11.2 and Oracle 12 is

Should SECRET_KEY be allowed to be bytes?

2016-12-22 Thread Tim Graham
There's debate in #24994 about whether or not settings.SECRET_KEY should or may be a bytestring. Some select quotes to summarize the discussion: 1. Aymeric Augustin, "Once Django drops support for Python 2 you'll have to go out of your way to put bytes in the SECRET_KEY. Currently, since the ty

Re: Should SECRET_KEY be allowed to be bytes?

2016-12-22 Thread Tim Graham
projects, that's certainly going to be possible, since it's just a string and you can create it however you like. The one that Django generates isn't inherently insecure, though." https://code.djangoproject.com/ticket/9687 On Thursday, December 22, 2016 at 3:18:52 PM UTC

Re: Considering removing support for ("iLmsu") regex groups in URLpatterns. Do you use them?

2016-12-23 Thread Tim Graham
Wednesday, December 21, 2016 at 10:21:04 AM UTC-5, Tim Graham wrote: > > I learned a couple more things: > - The end of the Python deprecation is TBA (not in 3.7 as I stated > before), perhaps not until Python 2.7 is unsupported (4 more years). > - Using (?i) in urlpatterns is prom

Re: Should SECRET_KEY be allowed to be bytes?

2016-12-23 Thread Tim Graham
I'm unsure of exactly how to proceed, probably due to my poor string encoding/unicode understanding. Is a system check warning to suggest basestring (py2) / str (py3) secret keys desirable? Aymeric, on the ticket you said, "Currently, since the type isn't enforced, every app that wants to do s

Re: Template-based widget rendering

2016-12-23 Thread Tim Graham
I'll delay the merge as needed. Thanks! https://github.com/django/django/pull/6498 On Tuesday, December 20, 2016 at 6:01:58 PM UTC-5, Tim Graham wrote: > > TemplatesSetting seems okay to me (open to other consensus though). > > PR is updated: https://github.com/django/django/pull/6

Re: Decoupling forms from models

2016-12-24 Thread Tim Graham
Hi, it seems like you keep starting new threads about the same topic without mentioning the previous threads and summarizing those discussions. For example, you should layout the problem in more detail and explain what "pretty much everybody would like to see a fix appear" means. I'm not sure w

Fellow Report - December 24, 2016

2016-12-24 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/25754 - Queryset repr is not displayed on IPython >= 3.0 REPL if a NotImplementedError is raised (invalid) https://code.djangoproject.com/ticket/27619 - Queries where column name includes a '%' character break when using MySQL (duplicate

Re: No 'Content-Type' header in response

2016-12-27 Thread Tim Graham
Don't worry about the unrelated failures, hopefully we'll get that other PR merged soon. On Tuesday, December 27, 2016 at 12:01:36 AM UTC-5, roboslone wrote: > > Okay, so I've submitted a pull-request > resolving this issue. But > tests for timesince

Django 2.0 Python version support (Python 3.6+ only?)

2016-12-27 Thread Tim Graham
When I drafted the 1.11 release notes in May, I wrote, "The next major release, Django 2.0, will only support Python 3.5+." Our Python version support policy is "Typically, we will support a Python version up to and including the first Django LTS release whose security support ends after securi

Re: Considering removing support for ("iLmsu") regex groups in URLpatterns. Do you use them?

2016-12-27 Thread Tim Graham
I created a ticket and pull request for the deprecation: https://code.djangoproject.com/ticket/27648 https://github.com/django/django/pull/7749 On Friday, December 23, 2016 at 10:22:40 AM UTC-5, Tim Graham wrote: > > I found a flask thread [0] where Armin Ronacher said this about

Re: Should SECRET_KEY be allowed to be bytes?

2016-12-27 Thread Tim Graham
Thanks Aymeric. How about this documentation addition: Uses of the key shouldn't assume that it's text or bytes. Every use should go through :func:`~django.utils.encoding.force_text` or :func:`~django.utils.encoding.force_bytes` to convert it to the desired type. https://github.com/django/dja

Re: Django 2.0 Python version support (Python 3.6+ only?)

2016-12-27 Thread Tim Graham
-- lets make > the Django 2.0 migration not more painful than it has to be (ie I do not > want to force people to upgrade existing supported systems just to get the > latest python and therefor Django). > > Cheers, > Florian > > On Tuesday, December 27, 2016 at 4:12:57

Re: Adding custom attributes to Django sitemaps framework

2016-12-27 Thread Tim Graham
I don't have a lot of experience with sitemaps so at least for me, it would be nice to see some proposed code changes to understand the idea a bit better. From my naive point of view, it looks like you need a custom template to output anyway? On Tuesday, December 27, 2016 at 2:37:20 PM UTC-5,

Re: Django 2.0 Python version support (Python 3.6+ only?)

2016-12-27 Thread Tim Graham
arguments to drop 3.4, lets keep it as long >> as it is not too much work. >> >> Either way, I am completely against dropping Python 3.5 now -- lets make >> the Django 2.0 migration not more painful than it has to be (ie I do not >> want to force people to upgr

Re: Django 2.0 Python version support (Python 3.6+ only?)

2016-12-27 Thread Tim Graham
> > > On Tue, Dec 27, 2016 at 3:52 PM Tim Graham > wrote: > >> Collin raised a fair point in #django-dev that Ubuntu 16.04 bundles >> Python 3.5. I guess 16.10 will include Python 3.6 -- that will be released >> before Django 2.0 in December 2017. >> >>

Re: Django 2.0 Python version support (Python 3.6+ only?)

2016-12-28 Thread Tim Graham
There may be a bug in Google Groups -- I've seen my own messages deleted like that. On Wednesday, December 28, 2016 at 2:41:59 PM UTC-5, Claude Paroz wrote: > > Any idea why my message in this thread was deleted? > > Claude > -- You received this message because you are subscribed to the Google

Re: is support for old cx_Oracle versions needed?

2016-12-29 Thread Tim Graham
I created a ticket and PR to bump the minimum cx_oracle version to 5.2. https://code.djangoproject.com/ticket/27649 https://github.com/django/django/pull/7752 On Thursday, December 22, 2016 at 3:11:33 AM UTC-5, Shai Berger wrote: > > On Thursday 22 December 2016 00:07:05 Josh Smeaton wrote: > >

Fellow Report - December 31, 2016

2016-12-31 Thread Tim Graham
I guess everyone reading this probably also reads the djangoproject.com weblog, but in case not, here is my retrospective for 2016: https://www.djangoproject.com/weblog/2016/dec/28/fellowship-2016-retrospective/. Triaged --- https://code.djangoproject.com/ticket/27635 - django.utils.cry

Re: Methodology for increasing the number of PBKDF2 iterations

2017-01-02 Thread Tim Graham
versions of Django: Django 1.8: 2 Django 1.9: 24000 Django 1.10: 3 Django 1.11: 36000 [0] https://docs.python.org/3/library/hashlib.html#hashlib.pbkdf2_hmac On Tuesday, September 22, 2015 at 5:15:37 PM UTC-4, Aymeric Augustin wrote: > > On 22 sept. 2015, at 21:21, Tim Graham > >

Re: Should we add a dependency on the multipledispatch library, or vendor it?

2017-01-02 Thread Tim Graham
The main question for me is what version specifier (if any) to use in Django's setup.py. One didn't seem appropriate for pytz since the latest version should always be fine and it doesn't follow semantic versioning anyway. I see multidispatch is now at version 0.4.9 but it's not clear to me in

Re: Should we add a dependency on the multipledispatch library, or vendor it?

2017-01-02 Thread Tim Graham
ing else depends on an incompatible minimum version number. >> Then users who want both libs hit a wall. >> >> To avoid unexpected upgrades, projects should pin their dependencies >> recursively, typically with pip-tools, and test when updating dependencies. >> This

Re: Test assertions for signals

2017-01-03 Thread Tim Graham
I agree with Carl's comment on the PR: "I don't think it would complicate the API too much to have a count=1 kwarg, and if count > 1 expect received_kwargs to be a list of lists instead of just a list. This keeps the API identical to what it is currently for the common case, but makes it possib

Re: Django 2.0 Python version support (Python 3.6+ only?)

2017-01-03 Thread Tim Graham
3 efforts? It looks like it > is/was close to 3.3 according to > https://morepypy.blogspot.co.at/2016/08/pypy-gets-funding-from-mozilla-for.html > > Cheers, > Florian > > On Tuesday, December 27, 2016 at 11:03:22 PM UTC+1, Tim Graham wrote: >> >> Yes, Django 1.1

Re: django-formtools is neglected/unmaintained

2017-01-03 Thread Tim Graham
ers, The fact is moving it to jazzband >> haven't increased the active co maintainers. >> >> Thanks, >> >> Asif >> >> On Tuesday, November 29, 2016 at 5:45:59 AM UTC+6, Tim Graham wrote: >>> >>> Hi, >>> >>> django-formtool

Re: Methodology for increasing the number of PBKDF2 iterations

2017-01-03 Thread Tim Graham
The PBKDF2 speed improvements are in Python 2.7.8 and 3.4+, so you'd need to use Python 2.7.7 or earlier to get the slower version. On Tuesday, January 3, 2017 at 7:56:35 PM UTC-5, Martin Koistinen wrote: > > H, I just tried this using a simple management command to do some > basic benchmark

Re: Working towards a simpler GCBV implementation?

2017-01-04 Thread Tim Graham
We typically shy away from endorsing third-party libraries in the Django docs. I don't think it makes much sense to stay something to the effect of "The built-in views are too complex so we recommend using other library instead." On Wednesday, January 4, 2017 at 7:30:54 AM UTC-5, Asif Saifuddin

[ANNOUNCE] Django bugfix release: 1.10.5

2017-01-04 Thread Tim Graham
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2017/jan/04/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

Changing {% include %} to strip a trailing newline

2017-01-04 Thread Tim Graham
Shortly after template widget rendering was merged, an issue about extra newlines appearing in the rendered output was reported [0]: For example, from django-money: UIC-Franc \n\n US Dollar \n\n The newlines aren't useful and they break assertions like this: US Dollar in form.as_p --- end rep

Re: Changing {% include %} to strip a trailing newline

2017-01-04 Thread Tim Graham
on the > include tag for each use of a template that requires it - it also work on a > normal (not included) template render as well, if that is wanted. > > An alternative tag could be {% endtemplate %} that can be placed anywhere > in the template, forcing the end of rendering? >

Re: Add custom autoreload file tracking options setting

2017-01-04 Thread Tim Graham
Could you give us a code snippet (sample view, perhaps) demonstrating how this caching happens? On Wednesday, January 4, 2017 at 3:57:31 PM UTC-5, Bobby Mozumder wrote: > > Hi, > > Right now, Django only tracks Python module files for autoreload during > development. As a project starts to incl

Re: Add custom autoreload file tracking options setting

2017-01-04 Thread Tim Graham
raise e > if MATERIALIZED_VIEWS: > file_name = sql_view_dir + '/prepare_materialized.sql' > try: > with open(file_name, 'r') as file: > sql_prepare=file.read().strip()

Re: Changing {% include %} to strip a trailing newline

2017-01-04 Thread Tim Graham
trong preference for 2 or 3, however, I have a strong > distaste for anything more complicated. > > Best regards, > > -- > Aymeric. > > On 4 Jan 2017, at 20:58, Tim Graham > > wrote: > > Shortly after template widget rendering was merged, an issue about extra &

Re: django-formtools is neglected/unmaintained

2017-01-04 Thread Tim Graham
to-date than django-formtools. (4) Is this a sign that people >> simply aren't using Django for this task, and are maybe instead using some >> kind of Javascript library instead? If you have any information these >> questions, please let me know. >> >> Thanks, &g

Re: Changing {% include %} to strip a trailing newline

2017-01-04 Thread Tim Graham
compatible option is probably necessary for some > more advanced uses of templates out there, e.g. templating whitespace > sensitive file formats. > > On 4 January 2017 at 22:53, Tim Graham > > wrote: > >> Aymeric, we have a difference of opinion. I feel that if {% inc

Re: Future of the development server's auto-reloading

2017-01-04 Thread Tim Graham
So this idea doesn't get lost, I created a ticket for "Allow autoreloader to use watchman" https://code.djangoproject.com/ticket/27685#ticket On Monday, June 27, 2016 at 8:23:05 PM UTC-4, Tim Graham wrote: > > A pull request is proposed to add a new setting to allow s

Re: Add custom autoreload file tracking options setting

2017-01-04 Thread Tim Graham
No, there's a cached template loader: https://docs.djangoproject.com/en/dev/ref/templates/api/#django.template.loaders.cached.Loader On Wednesday, January 4, 2017 at 7:00:31 PM UTC-5, Bobby Mozumder wrote: > > > On Jan 4, 2017, at 5:40 PM, Adam Johnson > > wrote: > > How do people serve develop

Re: Changing {% include %} to strip a trailing newline

2017-01-05 Thread Tim Graham
e > change > but I think it offers a better upgrade path than a global template option > or > a keep_trailing_newline kwarg. > > Simon > > Le mercredi 4 janvier 2017 14:58:42 UTC-5, Tim Graham a écrit : >> >> Shortly after template widget rendering was merged,

Re: Django 2.0 Python version support (Python 3.6+ only?)

2017-01-06 Thread Tim Graham
So you all want to do a one time exception to our guidance of of "Typically we will support a Python version up to and including the first Django LTS release whose security support ends after security support for that version of Python ends." and support Python 3.4 for how long? Or revise the g

Re: Changing {% include %} to strip a trailing newline

2017-01-06 Thread Tim Graham
iltins': ['django.template.future_include'], # put new include > in it's own module so that we don't add anything else in future. > } > > I'm not familiar with that code, so I don't know whether that would > override the old include tag. > >

Re: Django 2.0 Python version support (Python 3.6+ only?)

2017-01-06 Thread Tim Graham
Tom, I'm not following how Python 3.4 support in Django 2.0 will benefit you if you want to stick to LTS versions of Django? I think either you or I have a misunderstanding somewhere. I'll try to recap: Django 1.11 is the next LTS. It's supported until April 2020 and supports Python 3.4. The ne

Use of HTML autofocus attribute in admin (#27692)

2017-01-06 Thread Tim Graham
As part of removing inline JavaScript in the admin [0], snippets such as document.getElementById("id_old_password").focus() were replaced with the HTML5 autofocus attribute. This attribute has a possibly undesired behavior [1]: "*Warning*: this attribute will force a page scroll to the field wi

Re: optional middleware to eliminate cookies in request header

2017-01-06 Thread Tim Graham
It is a repost, let's use the first post: https://groups.google.com/d/msg/django-developers/4kwZP8Rq5IU/rQi5GgI6DgAJ All first time posters go through a moderation queue. On Friday, January 6, 2017 at 9:50:56 PM UTC-5, Jeff Willette wrote: > > I just posted this and I didn't see it pop up in the

Re: Django 2.0 Python version support (Python 3.6+ only?)

2017-01-06 Thread Tim Graham
I don't know if matters to anyone, but I guess as long as we support Python 3.4 we can't do the type hinting project (PEP 484) since that's new in 3.5? On Friday, January 6, 2017 at 12:08:07 PM UTC-5, Tim Graham wrote: > > Tom, I'm not following how Python 3.4 support

Re: Django 2.0 Python version support (Python 3.6+ only?)

2017-01-07 Thread Tim Graham
Daniele, here's my try at being more concrete than "It seems reasonable" and "decent ledge of overlap". Let me know if you meant something different! "Django 2.0 will be the last version of Django to support Python 3.4. This allows those running older operating systems with Python 3.4 (such as

Re: django-formtools is neglected/unmaintained

2017-01-07 Thread Tim Graham
formtools. > > Romain. > > Le mercredi 4 janvier 2017 23:20:40 UTC, eric@datalyticsolutions.com > a écrit : >> >> Thanks a lot, Tim! If you think I could help, then let me know. >> Otherwise, I'll just stay out of your way :) >> >> On Wednesday, Janu

Fellow Report - January 7, 2017

2017-01-07 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27675 - Django postgres JSONField encoding (needsinfo) https://code.djangoproject.com/ticket/27679 - Document that empty formsets display min_num+extra forms (accepted) https://code.djangoproject.com/ticket/27690 - remove sleep before dr

Re: Presenting DCP, a compatibility layer for Django (feedback welcome)

2017-01-09 Thread Tim Graham
Our new deprecation policy was designed to eliminate the need for this type of compatibility library. If you want to support more Django versions than what our guidelines recommend (which may involve supporting versions that no longer receive security updates), I guess this library could be usef

Re: Methodology for increasing the number of PBKDF2 iterations

2017-01-09 Thread Tim Graham
About "we cannot just assume that all Python 3 installs have a "fast" PBKDF2 implementation" -- I'd expect very few if any Django users to be compiling their own Python and doing so without OpenSSL. I'm guessing that any operating system Python will have the OpenSSL bindings. Or is that a bad a

settings.DEFAULT_CONTENT_TYPE incompatibility with admin

2017-01-10 Thread Tim Graham
According to ticket #23908 [0], By using the setting: DEFAULT_CONTENT_TYPE = "application/xhtml+xml" The admin site no longer renders correctly. Do you think we should try to fix this by having all the admin responses specify content_type="text/html"? That requires a lot of changes [1] --

<    10   11   12   13   14   15   16   17   >