Re: On adding comments to database schema

2020-03-23 Thread SoungRyoul Kim
i assign it to me https://code.djangoproject.com/ticket/18468 i will close this pullRequest caused by imperfection ​https://github.com/django/django/pull/12605 I will bring a new PullRequest as soon as possible. in at least a week -- You received this message because you are subscribed to

Re: On adding comments to database schema

2020-04-10 Thread SoungRyoul Kim
add parameter "db_column_comment" to Field() and. db_table_comment class AModel(models.Model): aaa = model.CharField(help_text="i am help_text", db_column_comment="i am db_comment",~~~) class Meta: db_table = "a_model_example_name" db_table_comment ="this

Re: On adding comments to database schema

2020-05-02 Thread SoungRyoul Kim
Hi felixxm I want this feature to be reflected in Django.3.1 I know this feature that many people won't use. but some people who communicate with DBA would be helpful this feature sometimes ORM take control from DBA *like these situation...* DBAs: we want to know comment(help_text) not to

Re: On adding comments to database schema

2020-05-02 Thread SoungRyoul Kim
I'm sorry if I sounded like I was pushing you. even missing checklist 2020년 5월 3일 일요일 오전 1시 42분 2초 UTC+9, Mariusz Felisiak 님의 말: > > Asking for a review on multiple channels doesn't help. You need to be > patient, we have many PRs in review queue. Please check "Patch review > checklist" [1].

How can I make testcase for new migration feature (DB Comment) #18468

2021-06-20 Thread SoungRyoul Kim
I think about how can I create testcase for DB Comment django already has test utility assertion like a "assertTableExists" or "assertColumnExists" , Index, Constraint etc... then. I think It seems appropriate that I make new assertion "assertDBCommentExists" but If I make "assertD