Admin patches

noack&component=django.contrib.admin Regards Sebastian Noack signature.asc Description: PGP signature

Re: Admin patches

failures and 37 errors [1]. Do I have configured my test environment wrong? Here is my settings.py [1]. [1] http://pastebin.org/321014 [2] http://pastebin.org/321027 Regards Sebastian NoacK signature.asc Description: PGP signature

Re: Admin patches

> > However i was able to run the test suite on a plain django 1.2.1 > > installation with sqlite, but got 11 failures and 37 errors ... > > Have you read [1]? Do you still get errors if you run: > ./runtests.py --settings=test_sqlite > from the tests/ directory? Ok, that works. All test pass

Re: Django ORM performance patch. Fixes #5420, #5768

ySet as filter for example selects related fields and furthermore this would enable to select the related field of a related field, as QuerySet.filter can do. Regards Sebastian Noack --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Googl

Re: Django ORM performance patch. Fixes #5420, #5768

please note, currently lookups with 2 underscores are used only > in **kwargs, because it don't have many sense as quoted string (even > current QuerySet.order_by() uses '.' instead of '__' as separator). So > from design and usability point of view my form of

Re: Django ORM performance patch. Fixes #5420, #5768

a few months bcak), we should also use > double underscores for selecting related values. That makes everything > nice and consistent across the board. In my previous message, I said that I agree with Dima's comment, but that was just because I trusted that it is true that this syntax is a

QuerySet.update improvement.

ebody thinks there are reasons to don't merge this patch? Or ideas ti even improve this patch? Thanks. Regards Sebastian Noack signature.asc Description: PGP signature

Re: QuerySet.update improvement.

arely convinced that code works unless there is a > comprehensive test suite to back it up. I know this. But there is no sense do this at the moment. As you already noted there are still a few points to discuss and probably things to change on this code. So I will write documentation and tests when this is finished, because of otherwise I have to do this work twice. Regards Sebastian Noack signature.asc Description: PGP signature

Re: QuerySet.update improvement.

ussel and I have to write test cases. I can't do this now, but I think I will do it in the next days. But it would be cool if somebody can already look on my latest patch, if it is ok. Thanks. Regards Sebastian Noack signature.asc Description: PGP signature

Re: QuerySet.update improvement.

p;, |, <<, >> and ~, for completeness. I still have to write tests and documentation, but I would like to hear from Russel or the other maintainers, what they think about the code. Regards Sebastian Noack signature.asc Description: PGP signature

Re: Manager-model reassignment on abstract subclassing

reements about whether that patch should be applied? Thanks. Although I wrote this patch, I have a disagreement. ;-P Tests are still missing. But I think I can wrote some test cases at the weekend or during next week. Regards Sebastian Noack signature.asc Description: PGP signature

Re: QuerySet.update improvement.

update. (3) I added a sanity check to update(), preventing updating sliced query sets, because of calling update() on a sliced query set will update all objects. Do not think about implemeting this feature. Although some DBMS might supports UPDATE with LIMIT and OFFSET, many don't or support

Re: QuerySet.update improvement.

fortunately, I'm not sure what caused it. I am pretty sure that this is not related to my patch. I get the same failure, and as far as I know I got it even before I wrote the patch. Thanks for testing. Regards Sebastian Noack signature.asc Description: PGP signature

Re: QuerySet.update improvement.

anymore, which might become rounded up- or downwards depending on the db engine. The result of the division test is 2.8 now. This should actually work. Furthermore I am using the operator module instead of eval, now. Thanks for this advice. I just forgot that I can use it for this test. Regards Sebastian Noack signature.asc Description: PGP signature

Re: QuerySet.update improvement.

On Fri, 23 May 2008 17:20:43 +0800 "Russell Keith-Magee" <[EMAIL PROTECTED]> wrote: > I'm currently sitting in an airport, so I won't have a chance to have > a good look until tomorrow at the earliest. However, here's some > immediate feedback. Most of them are in the category of "this probably > w

Re: Manager-model reassignment on abstract subclassing

, you should update now. I think the patch is ready to get merged into trunk now, but I can not decide this. What does the maintainers think? Regards Sebastian Noack signature.asc Description: PGP signature

Re: Add optional FOR UPDATE clause to QuerySets

d very well, by django at the moment. Regards Sebastian Noack signature.asc Description: PGP signature

Re: Want to have unit tests in multiple files

On Fri, 23 May 2008 13:32:45 -0500 "Gary Wilson Jr." <[EMAIL PROTECTED]> wrote: > In case you haven't figured this out already, it can be done by > importing your unit test classes from the test/*.py modules in > tests/__init__.py That is exactly what I have done at my work, just a few days ago.