Re: Test Framework Cleanup

2019-03-22 Thread Carlton Gibson
The suggestion involves the code in django.test. https://github.com/django/django/tree/master/django/test In particular see runner.py there. On Friday, 22 March 2019 13:29:05 UTC+1, Gourav Sardana wrote: > > Hey, > I am Gourav Sardana undergraduate computer science student. I am > interested

Re: Help for GSoC proposal (Formset improvements)

2019-03-28 Thread Carlton Gibson
ted? (#10403?) Which can you target? You don't have to solve them all (!) but a good goal for a 12 week project would be to become a total expert on django.forms, and to have handled a number of issues as part of that. HTH. Kind Regards, Carlton On Tuesday, 26 March 2019 18:

Re: GSoC Proposal

2019-03-28 Thread Carlton Gibson
Hi Sage. Yes. It never hurts to apply. If we get two good proposals for the same project, we can find a way to share or another project. We can cross that bridge as and when we come to it. ("Scale later" 🙂) Kind Regards, Carlton On Thursday, 28 March 2019 14:58:15 UTC+1, Sage

Re: gsoc proposal

2019-03-31 Thread Carlton Gibson
for the future. I wish you all the best, Kind Regards, Carlton On Friday, 29 March 2019 12:38:24 UTC+1, kartik garg wrote: > > I am a beginner in django and wanted to apply for GSOC but I don't know > how to apply for that. can anybody please help me. I haven't applied for &

Re: Fellow Reports -- March 2019

2019-03-31 Thread Carlton Gibson
.com/ticket/30196 -- Make FileResponse always set Content-Disposition header. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receivin

Django bugfix release 2.1.8

2019-04-01 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2019/apr/01/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

Django 2.2 released.

2019-04-01 Thread Carlton Gibson
Django 2.2, the next long-term support release, is now available: https://www.djangoproject.com/weblog/2019/apr/01/django-22-released/ With the release of Django 2.2, Django 2.1 has reached the end of mainstream support. The

Re: Django 2.2 released.

2019-04-01 Thread Carlton Gibson
Oops, typo there: > ...Django 2.0... That should say "Django 2.0 will receive security and data loss fixes until December 2019". C. On Monday, 1 April 2019 15:19:20 UTC+2, Carlton Gibson wrote: > > Django 2.2, the next long-term support release, is now av

Re: Django 2.2 released.

2019-04-01 Thread Carlton Gibson
Sigh... 2.1... (Sorry.) On Monday, 1 April 2019 15:23:11 UTC+2, Carlton Gibson wrote: > > Oops, typo there: > > > ...Django 2.0... > > That should say "Django 2.0 will receive security and data loss fixes > until December 2019". > C. > > On Monday,

Enable SESSION_COOKIE_SECURE by Default

2019-04-03 Thread Carlton Gibson
327bccae60319982254ee62f65bea11e> so I just wanted to check if there were any overriding *Whys*? Thanks. Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this gro

Re: Enable SESSION_COOKIE_SECURE by Default

2019-04-03 Thread Carlton Gibson
n, `LANGUAGE_` too. https://github.com/django/django/pull/11155 Thanks. C. On Wednesday, 3 April 2019 10:19:15 UTC+2, Matthias Kestenholz wrote: > > On Wed, Apr 3, 2019 at 10:02 AM Carlton Gibson > wrote: > >> Hi all. >> >> https://code.djangoproject.com/

Re: GSoC Proposal: Add Cross-DB JSONField, ArrayField, and HStoreField

2019-04-03 Thread Carlton Gibson
an ever. - you don't need to worry about two days off for holiday 🙂 Your contributions so far have been super. Thank you. Kind Regards, Carlton On Tuesday, 2 April 2019 13:41:37 UTC+2, Sage M.A. wrote: > > Hello, everyone! My name is Sage. I'm a 19-year-old co

Re: GSoC Proposal (FormSet Improvement)

2019-04-03 Thread Carlton Gibson
the formset gets the request and this is available where...? and so on: can you SHOW in your proposal that this WILL address the issues?) HTH. Kind Regards, Carlton On Monday, 1 April 2019 21:29:33 UTC+2, PARTH PATIL wrote: > > Here is a link to my GSoC proposal > Its a first draft s

Re: GSoC Proposal (FormSet Improvement)

2019-04-03 Thread Carlton Gibson
Yes, just pseudo code — so when reviewing your proposal next week it's easy to see that it'll be the right approach. 🙂 On Wednesday, 3 April 2019 17:51:18 UTC+2, PARTH PATIL wrote: > > > > On Wednesday, April 3, 2019 at 8:58:26 PM UTC+5:30, Carlton Gibson wrote: >>

Re: Should we backport adding support for psycopg2 2.8 to the 1.11.x and 2.1.x?

2019-04-05 Thread Carlton Gibson
OK, so for me, this should go into v2.2, but not v2.1 or v1.11. (I see you already backported to 2.2 so... 🙂) My general take here is that we could be half-a-notch more generous backporting to the current version (e.g. 2.2 now) but should be just as strict as we are once a version is out of mai

Re: Help for GSoC proposal (Formset improvements)

2019-04-07 Thread Carlton Gibson
Hi Parth. Well, the wizard (&co) got moved out to it's own app https://django-formtools.readthedocs.io/en/latest/ But yes, there's no reason why this sort of thing wouldn't potentially in scope. Kind Regards, Carlton On Sunday, 7 April 2019 23:47:23 UTC+2, PARTH PATIL

Re: Google "Season of Docs"

2019-04-10 Thread Carlton Gibson
was wondering if we got any traction on this. > > On Monday, March 18, 2019 at 5:27:47 AM UTC-5, Carlton Gibson wrote: >> >> Hi all, >> >> Parallel to GSoC, Google now have this "Season of Docs" programme: >> >> https://developers.google.com/season-of-do

Re: Proposal to format Django using black

2019-04-13 Thread Carlton Gibson
We spend a lot of time spotting small formatting errors and then asking for those to be fixed and then waiting for an update. This wastes reviewer time and slows down the feedback cycle. Many pull requests drag out because of it. For this reason I would be 100% behind adopting black, and applying

Re: GSOC Proposal : CrossDB JSON Field

2019-04-16 Thread Carlton Gibson
third-party implementation > that has most of the features: > https://github.com/raphaelm/django-jsonfallback > > I'm not sure what we do with regards to two GSOC proposals for the same > task, maybe Carlton or others would like to weigh in? > > Thanks, > > Adam >

Re: Proposal to format Django using black

2019-04-20 Thread Carlton Gibson
On Friday, 19 April 2019 20:33:13 UTC+2, Mariusz Felisiak wrote: > > > I don't think that our code style is any barrier for newcomers. ...we've > never blocked any patch due to stylistic nitpicks. I also don't believe > that it will increase the number of contributors, if I would like to > con

Re: Google "Season of Docs"

2019-04-22 Thread Carlton Gibson
roject.com/wiki/2019SeasonOfDocs If you have specific project ideas please add them. (TBH: "Take on the tickets" is what I'd really like 🙂) If you'd like to mentor, assuming we get accepted etc, please let me/Mariusz know. Kind Regards, Carlton -- You received this message becau

Re: UnicodeDecodeError: 'cp949' codec can't decode byte 0xe2 in position 9735: illegal multibyte sequence

2019-04-23 Thread Carlton Gibson
https://docs.python.org/3.7/using/cmdline.html#envvar-PYTHONIOENCODING HTH Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, se

Re: UnicodeDecodeError: 'cp949' codec can't decode byte 0xe2 in position 9735: illegal multibyte sequence

2019-04-23 Thread Carlton Gibson
On Tuesday, 23 April 2019 14:27:24 UTC+2, Carlton Gibson wrote: > > If you set the `PYTHONIOENCODING` to utf8 before launching... > Not actually sure this is sufficient. What IS the right way of setting the locale on Windows...? -- You received this message because you are subscrib

Re: UnicodeDecodeError: 'cp949' codec can't decode byte 0xe2 in position 9735: illegal multibyte sequence

2019-04-23 Thread Carlton Gibson
On Tuesday, 23 April 2019 14:30:48 UTC+2, Carlton Gibson wrote: > > > What IS the right way of setting the locale on Windows...? > Not sure if it's the only way but, on Windows 10 you can tick a "Use Unicode UTF-8 for worldwide language support", box in "Regio

Re: Proposal to format Django using black

2019-04-23 Thread Carlton Gibson
Thanks for the YAPF suggestion (and sample config!) I'll have a go with this this week. (If we can get auto-formatting, just on diffs(?), that matches the existing style...) On Monday, 22 April 2019 20:10:41 UTC+2, thinkwel...@gmail.com wrote: > > I wonder if there's a middle ground between min

Re: UnicodeDecodeError: 'cp949' codec can't decode byte 0xe2 in position 9735: illegal multibyte sequence

2019-04-23 Thread Carlton Gibson
h version 1.11 and 2.1 on Mac > Yes. OK. It will depend on your system locale. There was an implicit assumption of something using UTF-8. Either way resolved in 2.2.1. 🙂 Please open a new ticket if something else comes up. Thanks! Carlton -- You received this message because you a

Re: Proposal to format Django using black

2019-04-24 Thread Carlton Gibson
On Wednesday, 24 April 2019 08:58:57 UTC+2, Josh Smeaton wrote: > > lots of bikeshedding > Yeah. 🙂 But we've already got a style guide, so **IF** we can get a YAPF config to work to that then hopefully the arguments against using a formatter here would be moot. (Note that **IF** — I only said

Fellow Reports -- April 2019

2019-04-24 Thread Carlton Gibson
defined (Duplicate of 30254) Authored: https://github.com/django/django/pull/11184 -- Refs #30254 -- Added tests verifying model class __hash__() inheritance. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contri

Deferring "Sign the CLA"

2019-04-27 Thread Carlton Gibson
Hi all. The CLA makes two appearances in the docs: * New contributors: First Steps * Twice in Submitting Patches

Re: Deferring "Sign the CLA"

2019-04-27 Thread Carlton Gibson
> On 27 Apr 2019, at 18:51, Florian Apolloner wrote: > > I think the question is if we need those at all. This is something the DSF > should be able to answer. Ah, you’ve preempted a later question. 🙂 Right now I just wanted to move it down the page. Maybe some online signing service would

Re: Deferring "Sign the CLA"

2019-04-27 Thread Carlton Gibson
I had something like DocuSign or similar in mind. (But it’s just a Maybe... at this point.) The goal being to smooth away the barriers that stop people contributing before they’ve even started, IMO replacing “Find a Printer” with “Get set up with GPG” isn’t a step forwards. 😃 On Sat, 27 Apr 201

Re: Proposal to format Django using black

2019-04-29 Thread Carlton Gibson
s not a game changer. It's just more of the same. I'm pretty sure it's the motivation needed to up my git blame foo to the next level, at which point I'll likely save time ironically. For this reason, weighed against the benefits, I don't think the git history shoul

Re: Fellow Reports -- April 2019

2019-04-30 Thread Carlton Gibson
ies within AppConfig.ready() can cause issues with some Django db commands (Invalid) https://code.djangoproject.com/ticket/30426 -- Make security headers default (Accepted) Reviewed: https://code.djangoproject.com/ticket/30419 -- Minor improvements for docs related to Meta.indexes Kind Regard

Re: A different approach for the auto-reloader

2019-04-30 Thread Carlton Gibson
Kind Regards, Carlton On Wednesday, 24 April 2019 06:33:50 UTC+2, Ramiro Morales wrote: > > Hi all, > > I had a stab at a somewhat simpler development server automatic reloading > strategy > https://github.com/django/django/compare/master...ramiro:synch-reloader > >

Re: First ASGI pull request is ready for review

2019-04-30 Thread Carlton Gibson
M Mariusz Felisiak < > felisiak.mari...@gmail.com> wrote: > >> Thanks for this patch. Can you add a trac ticket? also Can you give me & >> Carlton few days for review? I should be able to do this somewhere in the >> next week. >> > > I can indeed. I was

Re: GSoC Proposal: Add Cross-DB JSONField, ArrayField, and HStoreField

2019-05-07 Thread Carlton Gibson
eriodically to django-developers here to report on progress, or if we need to ask questions more widely. Well done again. Kind Regards, Carlton On Tuesday, 7 May 2019 15:05:59 UTC+2, part...@gmail.com wrote: > > I had the same doubt in my mind, what is the best medium to contact >

Re: injecting settings

2019-05-07 Thread Carlton Gibson
Also see the django-appconf app: https://github.com/django-compressor/django-appconf This is used by django-compressor (hence it's home) and others to add (and allow overriding) per-app settings. -- You received this message because you are subscribed to the Google Groups "Django developers

Re: After #28321 len(formset.forms) != len(formset.errors) is possible

2019-05-08 Thread Carlton Gibson
Hi Carsten. Any chance you can put this into a failing test case in a PR? (Much easier to reason about code. 🙂) Thanks. C. On Wednesday, 8 May 2019 13:58:25 UTC+2, Carsten Fuchs wrote: > > Dear group, > > I just upgraded from Django 1.11 to 2+ and thereby found > https://code.djangoprojec

Re: Introduction

2019-05-08 Thread Carlton Gibson
core-mentorship <https://groups.google.com/forum/#!forum/django-core-mentorship> and we'll see if we can get you going. Good luck. Have fun! Carlton On Wednesday, 8 May 2019 13:59:36 UTC+2, Ruchit Vithani wrote: > > Hello developers! My name is Ruchit Vithani and I am a student at D

Re: Introduction

2019-05-11 Thread Carlton Gibson
Thank you Tobias. Good explanation. An additional point I picked up from Tim is that if you have a Reproduced at... but the bug is fixed on master then you have a starting point to git bisect where the issue was fixed. On Sat, 11 May 2019 at 15:28, Tobias Kunze wrote: > Hi Ruchit, > > On 19-05-

Fellow Reports -- May 2019

2019-05-28 Thread Carlton Gibson
ttps://github.com/django/django/pull/11189 -- Fixed #28780 -- Allowed specyfing a token parameter for password reset URLs. https://github.com/django/django/pull/11374 -- Fixed #30485: Fixed django.utils.http.urlencode in the doseq=False case Kind Regards, Carlton -- You received this messag

Re: Fellow Reports -- May 2019

2019-05-31 Thread Carlton Gibson
crashes with "A string literal cannot contain NUL (0x00) characters." on PostgreSQL https://github.com/django/django/pull/11432 -- Simplfied m2m_recursive.tests. https://github.com/django/django/pull/11414 -- Fixed #30509 -- Various FileResponse fixes and changes. Kind Regards,

Django security releases issued: 2.2.2, 2.1.9 and 1.11.21

2019-06-03 Thread Carlton Gibson
Today the Django team issued 2.2.2, 2.1.9, and 1.11.21 as part of our security process. These releases address security issues, and we encourage all users to upgrade as soon as possible: https://www.djangoproject.com/weblog/2019/jun/03/security-releases/ -- You received this message because y

Fellow Reports -- June 2019

2019-06-10 Thread Carlton Gibson
2019-11358. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@go

Re: How to test whether a formset instance is properly initialized

2019-06-15 Thread Carlton Gibson
got: it may be easier to help you there. Kind Regards, Carlton > On 15 Jun 2019, at 07:04, PARTH PATIL wrote: > > I'm currently working on ticket #10403 > <https://code.djangoproject.com/ticket/10403> -- Declarative syntax for > Formsets > > How to t

Re: Fellow Reports -- June 2019

2019-06-17 Thread Carlton Gibson
address to sanitize_email() tests cases. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django

Re: Thoughts on Django Model attribute (descriptor) inheritance.

2019-06-21 Thread Carlton Gibson
rings any bells... PR there was called: "Replaced dynamic classes with non-data descriptors for deferred instance loading." Related mailing list discussion: https://groups.google.com/forum/#!msg/django-developers/BDAlTyJwQeY/Fh2Qy07cAQAJ Thanks. Carlton -- You received thi

Re: Thoughts on Django Model attribute (descriptor) inheritance.

2019-06-21 Thread Carlton Gibson
Hi Ryan, That does look related, yes. On Friday, 21 June 2019 15:47:53 UTC+2, Ryan Hiebert wrote: > > Hopefully that's a correct connection, and I'm not sending you chasing > something irrelevant to your current task. > TBH any pointers are handy at this stage in the game. 🙂 Thanks! (Still

Re: Fellow Reports -- June 2019

2019-07-01 Thread Carlton Gibson
mSet & InlineFormSet Authored: https://github.com/django/django/commit/54d0f5e62f54c29a12dd96f44bacd810cbe03ac8 -- Fixed CVE-2019-12781 -- Made HttpRequest always trust SECURE_PROXY_SSL_HEADER if set. Calendar Week 26 -- ending 30 June. VACATION ⛺️ Kind Regards, Carlton

Fellow Reports -- July 2019

2019-07-15 Thread Carlton Gibson
ntax. https://github.com/django/django/pull/11543 -- Fixed #30619 -- runserver doesn't close connections when --nothreading is specified. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django

Re: Discuss https://github.com/django/django/pull/11157

2019-07-19 Thread Carlton Gibson
It's not really a recent discussion. 🙂 The original mailing list thread here was from 2015: https://groups.google.com/d/topic/django-developers/kuGeu7ffJsc/discussion I based my comments on the PR on a review + Aymeric and Tom's previous reviews there, which were never acted on. I quoted Tom

Re: Discuss https://github.com/django/django/pull/11157

2019-07-20 Thread Carlton Gibson
I’m exactly -1 on this, for exactly the reasons given. ALL it takes for you to implement this is to subclass TemplateView and override render_to_response(). That’s it. This was Tom’s point in his review four years ago: the ease of directly implementing it means the added API surface area isn’t w

Re: How do I override default date formats per locale in Django?

2019-07-25 Thread Carlton Gibson
from there isn’t working. Hopefully then you’ll get the help you need. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receivi

Re: Fellow Reports -- July 2019

2019-07-29 Thread Carlton Gibson
estDataTooBig is raised https://github.com/django/django/pull/11582 -- Fixed #23524 -- Allowed TIME_ZONE option on PostgreSQL. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" gr

Django security releases issued: 2.2.4, 2.1.11, and 1.11.23.

2019-08-01 Thread Carlton Gibson
Today the Django team issued 2.2.4, 2.1.11, and 1.11.23 as part of our security process. These releases address security issues, and we encourage all users to upgrade as soon as possible: https://www.djangoproject.com/weblog/2019/aug/01/security-releases/ -- You received this message because y

Re: Django Websocket Implementation Request

2019-08-01 Thread Carlton Gibson
it seems...) So I'm not sure we'd include support in core (vs keeping it in the third-party package.) I guess something to revisit after 3.0. Kind Regards, Carlton On Thursday, 1 August 2019 15:09:21 UTC+2, Confi Yobo wrote: > > This might be a little redundant as you would s

Re: Fellow Reports -- July 2019

2019-08-02 Thread Carlton Gibson
d Slice transforms to SQL params. https://code.djangoproject.com/ticket/30669 -- Can FILE_UPLOAD_MAX_MEMORY_SIZE be set to None? Authored: https://github.com/django/django/pull/11614 -- Refs #30669 -- Removed unused branch in ASGIHander.read_body(). Kind Regards, Carlton -- You received thi

Re: Cross-DB JSONField ready for review

2019-08-02 Thread Carlton Gibson
Hey Sage, Super stuff! Well done on your effort so far. (I can't say how excited I am about this feature. 💃) Kind Regards, Carlton On Friday, 2 August 2019 13:46:46 UTC+2, Sage M.A. wrote: > > Hello, everyone. > > As a follow-up to this message > <https://groups

Re: Cross-DB JSONField ready for review

2019-08-02 Thread Carlton Gibson
m right. > Maybe in a howto? > > On Saturday, 3 August 2019 01:23:25 UTC+7, Adam Johnson wrote: >> >> Sage, I think that should go in the main docs, in the docs/ folder in the >> repo, no? >> >> On Fri, 2 Aug 2019 at 18:09, Sage M.A. wrote: >> >>>

Re: Make Development More Accessible

2019-08-07 Thread Carlton Gibson
not the same, so there'll be substantial > differences. But it's worth familiarising oneself with prior art. > > For what it's worth I'd strongly support such a move just for the increase > in engagement. > > Carlton, Mariusz, how would you gauge the lev

Re: Make Development More Accessible

2019-08-08 Thread Carlton Gibson
Just on this point: > I agree with Andrew Godwins statement on Django loosing many contributors over the years and being in largely maintenance mode. First, I'm not sure Andrew actually said this. Rather I think he reported is a point raised. However... I hear this kind of thing said. It tie

Re: Expand the Scope of Pluggable Secret Keys Ticket

2019-08-08 Thread Carlton Gibson
launch with a new environment to "rotate"? i.e. What special handling would Django need to provide? Kind Regards, Carlton On Thursday, 8 August 2019 03:43:49 UTC+2, John Gooding wrote: > > Would it be possible to expand the scope of the recently accepted secret > key rotatio

Re: Django LTS support time

2019-08-09 Thread Carlton Gibson
.) FYI they’ll be a new release in the Autumn there, before Django 3.0, so a PR before then would be super. Kind Regards, Carlton > On 9 Aug 2019, at 09:29, ⁨אורי⁩ <⁨u...@speedy.net⁩> wrote: > > Django Developers, > > I would like to know why Django LTS support time is

Re: Proposing development discussion forums

2019-08-10 Thread Carlton Gibson
and we as a group of active folks said that that's where we'd hang out, I think it would work, and would unify those channels. So +1 What does it need from Ops? (Is there a `docker run-my-service`? Could we leverage djangoproject.com (and GitHub) logins, or are they always going to be s

Re: Django Websocket Implementation Request

2019-08-10 Thread Carlton Gibson
> > On 10 Aug 2019, at 18:51, Confi Yobo wrote: > > So it should not be expected in 3.0? @ Carlton Gibson No. As per the previous comments, it’s not something likely to be included in core. Certainly not for 3.0. -- You received this message because you are subscribed to the G

Creating a new "Triage & Review Team"

2019-08-12 Thread Carlton Gibson
on and found he couldn't. This struck me as a little absurd: if we weren't going to dissolve it, Nick should definitely be part of the old "Django Core". As such, I suggest create the team, and inviting Nick as the first member just to see how it goes. Can I ask if that seems s

Re: Creating a new "Triage & Review Team"

2019-08-12 Thread Carlton Gibson
Oh, one more thing. I'd like to make this a "Public" team. I think there should be some visibility and recognition for the folks who work so hard on keeping Django strong. As part of that I'd add it to the Teams list on djangoproject.com, and maintain a list of previous members, for those who

Re: Request for closing #25139 -- ModelFormSet: allow swapping unique values

2019-08-15 Thread Carlton Gibson
Maybe for now. If someone pops up with a solution we can look at that then. Kind Regards, Carlton On Sunday, 11 August 2019 09:20:49 UTC+2, PARTH PATIL wrote: > > Hey can someone please have look at this ticket, I feel the requested > feature is not really feasible to implement, also it

Re: Ideas for a new DEP on long-term Django API compatibility

2019-08-17 Thread Carlton Gibson
e. I’m sorry that we have a different approach than the one you’ve asked for, but hopefully you can accept the reasons that people have given, and, more importantly, that decisions are made in good faith, for the best outcome that we, as a group, can find. Kind Regards, Carlton -- You rece

Re: Creating a new "Triage & Review Team"

2019-08-19 Thread Carlton Gibson
while we're in this limbo stage, we're potentially > missing out on some good maintainers before a decision has even been made. > You can still put forward names for the core team if you think they'd make > good members, though I'd understand your hesitation. > >

Fellow Reports -- August 2019

2019-08-19 Thread Carlton Gibson
: https://github.com/django/djangoproject.com/pull/935 -- Re-added `invisible` captcha to donations form. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group a

Re: PEP 484 type hinting in Django

2019-08-26 Thread Carlton Gibson
On Monday, 26 August 2019 14:05:19 UTC+2, Maxim Kurnikov wrote: > > Carlton, is it possible to move discussion to Github somehow? > Drafting a DEP begins by making a PR against the drafts folder in the DEPs repo. I guess that could be a WIP PR, if felt beneficial/necessary. -- You

Re: Add Optional Slash Syntax for Path

2019-08-28 Thread Carlton Gibson
Hi Jason I think in this case “just use re_path()” is the way to go. (path() being a convenience, rather than a replacement.) For me, complicating the signature of path() for such a corner case wouldn’t be a good trade-off. Kind regards, Carlton. On Wed, 28 Aug 2019 at 20:47, Jason Brill

Re: Creating a new "Triage & Review Team"

2019-09-01 Thread Carlton Gibson
mbers always welcome back. * We'll keep a public record of current and past members. * ... to also include a list of Former members of Django Core. That's just a preliminary outline. Have a good week all. Kind Regards, Carlton -- You received this message because you are subscr

Re: Fellow Reports -- August 2019

2019-09-01 Thread Carlton Gibson
m/django/django/pull/11708 -- Removed shell=True from subprocess.run() where unnecessary. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this

Re: Redis cache support in core

2019-09-04 Thread Carlton Gibson
-redis-cache to see if they'd like to join in might be worth it. I'd be happy to help review a preliminary draft for a DEP. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)&quo

Status of 3.0 release blockers

2019-09-10 Thread Carlton Gibson
ate on any changes. To that, please test early and often. Thanks all for your super efforts on this release cycle! Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To u

Django 3.0 alpha 1 released

2019-09-10 Thread Carlton Gibson
We've made the first release on the way to Django's next major release, Django 3.0! With about two and a half months until the final release (scheduled for December 2nd), we'll need timely testing from the community to ensure an on-time, stable release. Check out the blog post: https://www

Re: Work in progress (WIP), ticket #28935, Template error raised in an {% extends %} child template shows incorrect source location on debug page

2019-09-12 Thread Carlton Gibson
Hello! Super. 🙂 Can I ask you to put it in a PR on GitHub, so it’s easier to test and review? Thanks. Kind Regards, Carlton > On 12 Sep 2019, at 19:09, Min ho Kim wrote: > > Hi, > I am trying to contribute to code. > > I picked my first issue to solve. > https://c

Fellow Reports -- September 2019

2019-09-18 Thread Carlton Gibson
ses. https://github.com/django/django/pull/11775 -- Increased the default PBKDF2 iterations for Django 3.1. https://github.com/django/django/pull/11774 -- Expanded notes on alphas in release How-to. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Gro

Re: Stalled tickets

2019-09-27 Thread Carlton Gibson
. 🙂) I hope that makes sense. And thanks for your super contributions this week. Welcome aboard! 🏅 Kind Regards, Carlton On Thursday, 26 September 2019 16:45:52 UTC-7, David Vaz wrote: > > Hi, > > I am playing around at the DjangoCon US 2019 Sprints and while trying to > do my

Re: Fellow Reports -- September 2019

2019-09-30 Thread Carlton Gibson
https://github.com/django/django/pull/11835 -- Fixes #30806 by configuring OBJC_DISABLE_INITIALIZE_FORK_SAFETY in tox. Authored: https://github.com/carltongibson/dcus2019sprints -- Notes for "Getting started contributing to Django" sprints workshop. Kind Regards, Carlton -

Django bugfix releases: 2.2.6, 2.1.13, and 1.11.25

2019-10-01 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2019/oct/01/bugfix-releases/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

Re: Suggestions on where to contribute

2019-10-01 Thread Carlton Gibson
se packages are under-maintained. I'd say "mature" means more surface area, rather than less. :) Hopefully that helps. Have a look around. Let me know if you need more guidance from there. Kind Regards, Carlton On Tuesday, 1 October 2019 13:13:41 UTC+2, Fredrik Malmfors wrote:

Re: Form customization

2019-10-08 Thread Carlton Gibson
n mind, it's hard to say... — By using a base form class in your project, overriding templates, and/or default field mappings, I would imagine everything you need is already possible. (Quite likely there's room for a deeper How To on advanced form customisation in the docs though.)

Re: Question about ticket #20456: Easier unit testing for class-based views

2019-10-08 Thread Carlton Gibson
Hi Felipe, Thanks for the question! For me, yes, this seems reasonable given that we already have the `setup()` hook. Please do proceed. Kind Regards, Carlton On Monday, 7 October 2019 09:20:12 UTC+2, Adam Johnson wrote: > > Moving the head=get line sounds sensible to me! > &g

Re: Explore integrating django-docker-box in some way?

2019-10-08 Thread Carlton Gibson
" is now likely the easiest route if you need to use a VM...) Thank you for your work maintaining the django-box project! Prior to Tom's work on django-docker-box, I was using the VM extensively, so much valued. 🎩 Kind Regards, Carlton On Friday, 4 October 2019 13:55:17 UTC+2, Jos

Fellow Reports -- October 2019

2019-10-08 Thread Carlton Gibson
efs #28699 -- Clarified CSRF middleware ordering in relation to RemoteUserMiddleware. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and s

Re: PEP 484 type hinting in Django

2019-10-08 Thread Carlton Gibson
Maxim Kurnikov has begun a draft DEP for adding hints into Django. https://github.com/django/deps/pull/65 Please contribute your thoughts there. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributio

Re: Explore integrating django-docker-box in some way?

2019-10-08 Thread Carlton Gibson
I’ll have a look.. 👀 On Tue, 8 Oct 2019 at 12:52, Josh Smeaton wrote: > I was going to archive the repo, but it seems I don't have the necessary > permissions. Carlton, do you? > > On Tuesday, 8 October 2019 21:45:22 UTC+11, Adam Johnson wrote: >> >> +1 to archivi

Re: Feature Request: Enabling hooking into the autodetector from a third-party app.

2019-10-08 Thread Carlton Gibson
assigned&status=new&component=Migrations&col=id&col=summary&col=status&col=owner&col=type&col=component&col=version&desc=1&order=id> that need somebody's love and attention. 🙂 Kind Regards, Carlton -- You received this message because you are

Re: Removing old branches from the Django Git repository.

2019-10-10 Thread Carlton Gibson
Tom’s Tag idea seems to hit the balance. I’d like to clean them out. I use git branch all day and they’re just noise there. Tags would keep the references we’d need to check them out, without the additional work of creating a separate repo, or learning new/arcane git features, which don’t merit t

Re: django-admin startproject settings.py has some security holes

2019-10-11 Thread Carlton Gibson
I can see a How-To explaining different patterns here being a valid addition to the docs. FWIW, there’s a PR to ease/enable SECRET_KEY rotation. It might mitigate some of the issues with first committing sensitive values to git when it lands. https://code.djangoproject.com/ticket/30360 -- Yo

Re: django-admin startproject settings.py has some security holes

2019-10-11 Thread Carlton Gibson
It's just scope: * Not clear we need to _replace_ the space for books, and blog posts, and so on, in the main docs. and bandwidth: * These things are difficult to get right, and it needs someone to do them. (PRs always warmly received!) On balance, I have to say, I think the default pr

Re: Form customization

2019-10-11 Thread Carlton Gibson
ly. Sounds like a moderate change... — what would it look like? — proof of concept. (As ever... :) Have a good weekend all. Kind Regards. Carlton On Thursday, 10 October 2019 22:18:03 UTC+2, Jacob Rief wrote: > > With Django-1.10 we got the ability to override form fields with our

Re: Form customization

2019-10-11 Thread Carlton Gibson
A better link for the CSS class issue is this one https://docs.djangoproject.com/en/2.2/ref/forms/widgets/ On Fri, 11 Oct 2019 at 20:54, Carlton Gibson wrote: > HI Alex, > > For label_suffix, I'd say a base form class for your project is exactly > the way to go. > You ca

Re: Fellow Reports -- October 2019

2019-10-14 Thread Carlton Gibson
Refs #27086 -- Corrections to unit testing contributor docs. https://github.com/django/django/pull/11889 -- Fixed #30858 -- Clarified that AdminEmailHandler processes all 5xx responses. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups &

Re: Stop QuerySet repr from executing queries

2019-10-15 Thread Carlton Gibson
rySet updating? Because you evaluated it in your class definition...) If you must have a different behaviour here, use a subclass. Kind Regards, Carlton On Tuesday, 15 October 2019 10:21:14 UTC+2, Mariusz Felisiak wrote: > > I'm -1 to this change. ... to be honest even with all of this fe

Re: #30864 Document and endorse django.utils.decorators.classproperty

2019-10-18 Thread Carlton Gibson
Thank you Adam! There's also a git repo for the workshop I did at DjangoCon US. https://github.com/carltongibson/dcus2019sprints (Christmas project: start pulling all these together... 🙂) On Friday, 18 October 2019 11:20:50 UTC+2, Adam Johnson wrote: > > Carlton wrote a messa

Participating in Google Code-in?

2019-10-18 Thread Carlton Gibson
-code-in/355 Please check this out and comment if it's of interest to you. Thanks. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this grou

<    2   3   4   5   6   7   8   >