Re: Fellow Reports - May 2023

2023-05-16 Thread Mariusz Felisiak
Week ending May 14, 2023 *Triaged:* https://code.djangoproject.com/ticket/34546 - Failed migration yields to unmigratable app:""OperationalError: (1050, "Table '' already exists") (invalid) https://code.djangoproject.com/ticket/34547 - Deprecate DatabaseOperations.field_cast_sql(). (cre

Re: Ticket #34555 ModelBase prevents addition of model Fields via __init_subclass__

2023-05-16 Thread charettes
Just wanted to publicly +1 here as well. I was skeptical that we could add support for it without invasive changes at first but it seems to be relatively straightforward to support. One ask I would add is that we explicitly document what is support and what isn't. For example, at the time `__in

Re: Ticket #34555 ModelBase prevents addition of model Fields via __init_subclass__

2023-05-16 Thread hottwaj
Thanks for this! Agree with your points and would be happy to add that documentation to the PR On your point about accessing `_meta` in `__init_subclass__`: in the interest of avoiding overcomplication I didn't bring it up in issue #34555, but now that the cat is out of the bag... :) I sepa