Re: Proposal for a transaction.on_before_commit

2021-10-12 Thread Raphael Michel
Hi Aymeric, thank you for the insightful reply. Indeed I have overlooked the issue with savepoints which makes it much more fragile. In our case, "not using savepoint rollbacks any more" would be a trade-off that we'd happily make (there are enough other problems with savepoints to begin with), bu

Re: Proposal for a transaction.on_before_commit

2021-10-12 Thread Raphael Michel
Hi, Am Sun, 10 Oct 2021 18:38:55 +0300 schrieb Shai Berger : > Why is a before-commit signal preferable to a vanilla Python > context-manager around the code? Or, if it is in the context of > requests, a middleware? basically mostly because you can forget to put the context manager around it and

Re: (Circa end of 2021) Localization issues with input type=date?

2021-10-12 Thread Carlton Gibson
Thank you all, yes — there's some good points there. (Some others raised on the PR and the ticket too.) It's looks like there are still some caveats, and describing those succinctly remains to do. 👍 Kind Regards, Carlton On Wednesday, 29 September 2021 at 21:13:51 UTC+2 Tobias Bengfort wro

Re: Fellow Reports - September 2021

2021-10-12 Thread Mariusz Felisiak
Week ending September 26, 2021 Released Django 4.0a1. *Triaged: * https://code.djangoproject.com/ticket/33120 - Add OGC-compliant models for GeoDjango running on MySQL 8.0 (accepted) https://code.djangoproject.com/ticket/33121 - Mention custom users in the tutorial 02. (wontfix) ht

Re: Fellow Reports - September 2021

2021-10-12 Thread Mariusz Felisiak
Week ending October 3, 2021 *Triaged: * https://code.djangoproject.com/ticket/33144 - get_elided_page_range() method doesn't work properly. (invalid) https://code.djangoproject.com/ticket/33146 - Wrong command in ASGI deployment-guide using uvicorn (invalid) https://code.djangoprojec

Fellow Reports - October 2021

2021-10-12 Thread Mariusz Felisiak
Week ending October 10, 2021 *Triaged:*     https://code.djangoproject.com/ticket/33164 - UUID URL converter should support uppercase hexadecimal digits (wontfix)     https://code.djangoproject.com/ticket/32888 - Document that select_for_update() doesn't lock tables when their columns are not