Re: Accessibility standards & contribution guidelines for Django

2021-06-15 Thread Carlton Gibson
Hi Thibaud. Thanks for this, and for your efforts here generally! 🥇 > ...a long-overdue follow up... This is the only bit I can't agree with 😀 — ticking along, slow-and-steady, is realistic/sustainable/desirable/... 🙂 You mention a lot of things, so that'll take a little while to absorb — li

Re: Removal of USE_L10N setting

2021-06-15 Thread Carlton Gibson
Hey Claude, thanks for this. This seems like a win to me... a nice clean-up. I have to say, I never once set `USE_L10N = False` — I don't imagine many people do, but my only concern would be whole swaths of folks that depend on this… — do such exist in numbers? 🤔 This comments seemed pertinent

Re: A base compression middleware class

2021-06-15 Thread Tom Carrick
It's also worth noting that the security issue mentioned in the docs[1] makes it unsuitable for many (most?) Django projects, unfortunately, and brotli is also susceptible to this attack. It's probably not something I'd be keen on encouraging the use of, though I also think the idea in principle i

Re: Accessibility standards & contribution guidelines for Django

2021-06-15 Thread Sarah A
Hi folks, I'm interested in accessibility lately, I discovered a tool that can probably be added to the list: pa11y . It was used for automated tests. I don't have enough experience to give my opinion but @Thibaud you might have an opinion on it. I wanted to check the issue

Re: Accessibility standards & contribution guidelines for Django

2021-06-15 Thread Tobias Bengfort
Hi Thibaud, thanks for the follow up. +1 on basically everything you wrote! On 15/06/2021 02.59, Thibaud Colas wrote: This distinction between "sites built with Django" and the "Django admin" highlights an important point, which is that for lots of sites the Django admin would be what accessib

Re: `Model.validate_unique` excluding partial unique constraint

2021-06-15 Thread charettes
FWIW I thought I'd give a timeboxed shot at 2. to make sure I don't send you towards a deep rabbit hole and it seems pretty straightforward! https://github.com/django/django/compare/main...charettes:query-empty-model Le lundi 14 juin 2021 à 03:09:35 UTC-4, gaga...@gmail.com a écrit : > Thanks,

Re: `Model.validate_unique` excluding partial unique constraint

2021-06-15 Thread charettes
I meant 1. in my previous email where sql.Query.model is allowed to be None. The tests happen to pass on SQLite, MySQL, and Postgres. Le mardi 15 juin 2021 à 20:02:28 UTC-4, charettes a écrit : > FWIW I thought I'd give a timeboxed shot at 2. to make sure I don't send > you towards a deep rabbi