Re: Changing widget rendering templates

2021-06-05 Thread Carlton Gibson
Hi David. Thanks for this. Sorry for the slow pick-up: DjangoCon this week. :) I'd say option 1: It's an accessibility change and we should just opt people into that. IIRC there are some small improvements to the current HTML (aria roles and such) that would improve accessibility even if not

Re: Changing widget rendering templates

2021-06-05 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
I think a breaking change for the widget HTML is fine too, if it improves everyone’s apps. Perhaps documenting in the release notes how to undo it (eg copy this template file into your project, reconfigure the widget to use the template like so) will make it easier for folks with incompatible CSS t

Re: What to do about formfield_callback?

2021-06-05 Thread James Bennett
On Fri, Jun 4, 2021 at 11:54 PM Carlton Gibson wrote: > I'm sympathetic to the suggestion here, but wary of expanding the Forms API, > which already has a number of different ways of holding it. > > > ...to impose uniform custom widget attributes and error messages across a > > bunch of ModelFor

Re: Changing widget rendering templates

2021-06-05 Thread Thibaud Colas
Hi all, I wanted to mention a couple more things that might help in the decision: - There is no direct accessibility issue *for end users* from `as_p` that I know of. The only issue is its propensity to making people create forms with invalid HTML (see #31189