Re: Should the docs suggest namespace packages?

2020-05-21 Thread Adam Johnson
+1 for reverting ccc25bf . On Wed, 20 May 2020 at 19:54, Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote: > Hello, > > Commit ccc25bf refers to ticket #23919 in the commit message. In that > ticket, I argued that the __init__.py files should be kept: > https://code.djangoproject.com/

Re: Admin accessibility

2020-05-21 Thread Adam Johnson
Hi Tom It's a laudable goal to make the admin accessible. Thank you for doing the research on currently laws and guidelines. I haven't audited the entire admin, but I have run a checker through some > pages. > Which checker did you use? I see Google's Lighthouse checks for many accessibility iss

Re: Admin accessibility

2020-05-21 Thread Tom Carrick
Hi Adam, > Which checker did you use? I had a brief check with a few. Firefox's devtools, Lighthouse, and WebAIM's WAVE browser extension. WAVE is quite nice in that it shows the problems directly on the page, but they all give more or less the same information. If Lighthouse can be integrated in

Adding json lines (jsonl) serializer to django

2020-05-21 Thread Ali Vakilzade
Hi! A while back I opened a pull request on this topic and there is no updates on the my request for a while. I know people might be busy and not having time to review but I'm sending this mail hoping to bring the pull request back up and not die on github. I think supporting "JSON lines" is a

Re: Adding json lines (jsonl) serializer to django

2020-05-21 Thread Tim Graham
Hi Ali, as I noted on the PR, the ticket isn't in the review queue because "needs tests" is checked. On Thursday, May 21, 2020 at 9:47:53 AM UTC-4, Ali Vakilzade wrote: > > Hi! > > A while back I opened a pull request on this topic and there is no updates > on the my request for a while. I know

Re: Admin accessibility

2020-05-21 Thread Kye Russell
Hi all, I am legally blind. Accessibility discussions tend to largely revolve around contrast and screen readers (which I do not use) as it’s easy to measure for (albeit poorly without actually trying to use a screen reader yourself, which nobody tends to do). I am unsure if I have any valuable /

Re: QuerySet.iterator together with prefetch_related because of chunk_size

2020-05-21 Thread 'Taylor Hakes' via Django developers (Contributions to Django itself)
That makes sense to me. It is a little weird, but it’s the best option. I will post a comment on the PR. I am happy to update the code if he’s not available. On Wed, May 20, 2020 at 9:59 PM charettes wrote: > Taylor, I think that 2. is the way forward. > > It looks like the linked PR doesn't en

Re: QuerySet.iterator together with prefetch_related because of chunk_size

2020-05-21 Thread Adam Johnson
After over a year, it's probably reasonable to create a new PR. You can use Co-Authored-By to credit the original author: https://github.blog/2018-01-29-commit-together-with-co-authors/ On Fri, 22 May 2020 at 05:43, 'Taylor Hakes' via Django developers (Contributions to Django itself) wrote: > T