Re: Clear all filters

2020-05-18 Thread Adam Johnson
I disagree Mariusz. I would NOT expect this. The "Clear all filters" button is grouped with the filters, visually separate from the search and sort controls. It's a very legitimate use case to clear the filters and maintain the search or sort, and quite a common workflow when trying to find a parti

Re: Clear all filters

2020-05-18 Thread Mariusz Felisiak
> > I disagree Mariusz. I would NOT expect this. The "Clear all filters" > button is grouped with the filters, visually separate from the search and > sort controls. It's a very legitimate use case to clear the filters and > maintain the search or sort, and quite a common workflow when trying t

Re: Fellow Reports - May 2020

2020-05-18 Thread Mariusz Felisiak
Week ending May 17, 2020. Released Django 3.1a1. *Triaged:* https://code.djangoproject.com/ticket/31557 - Use .assertTrue instead of .assertIs(..., True) in the unit testing section of the polls tutorial. (wontfix) https://code.djangoproject.com/ticket/31555 - Use .format() and f-strings in th

Re: Clear all filters

2020-05-18 Thread Markus Holtermann
I tend to agree with Adam. >From a UI/UX perspective, the location where the "Clear all filters" button >is, as well as the wording, suggest to me that it's only the filters on the >right side. The search query, while technically filtering the query set, >doesn't seem like a filter in the UI.

Re: Proposal for Table Functions

2020-05-18 Thread Ahmad A. Hussein
Concerning tests, I did not mean to comment about the tests you wrote. I used the third party py-test django app as an example of an app that does need work in core to function better, not as a comment about your usage of tests. You're more than free to work the way you want to :) (I like pytest

Re: Clear all filters

2020-05-18 Thread Mariusz Felisiak
OK, I added new ticket https://code.djangoproject.com/ticket/31603. Thanks y'all -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an em

GSoD - Google Season of Docs

2020-05-18 Thread Aksh Gupta
Hi, I'd love to improve the 'Contributing Guide' as a part of GSoD this year. I have gone through the Guide myself to start contributing to the project, and I agree that it is indeed overwhelming to follow. Getting new contributors is a crucial part of any big project. I would love to give my