Loading lzma compressed fixtures

2020-05-09 Thread Paolo Melchiorre
Hi all, Working at my latest merged PR [1] in Django I saw in the code the lack of support for lzma compressed fixture for loaddata command so I opened a ticket [2] and a related PR [3]. I think is a small PR to accept before Django 3.1 feature freeze but it can be a great improvement in loa

Re: Loading lzma compressed fixtures

2020-05-09 Thread Tim Graham
Hi Paolo, Please don't ask for code reviews on this mailing list. It just adds noise. Patches are reviewed from "Patches needing review" at https://dashboard.djangoproject.com/. At this time there are ~30 patches in the queue. Requesting your feature to be moved to the front of the review queue

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-09 Thread Aymeric Augustin
Hello, This is quite disruptive — says the guy who suggested to remove request.REQUEST a few years back — but I think we could go ahead and do it. The names proposed by Adam are good. I read the concerns about (e.g. for search forms) where form data ends up in query_params and not form_data.

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-09 Thread Florian Apolloner
On Saturday, May 9, 2020 at 1:41:41 PM UTC+2, Aymeric Augustin wrote: > > - Users who don't know that GET queries mustn't have side effects and who > don't want to bother will have an incentive to use a POST query to get the > data in form_data; this is the safe option with regards to CSRF; >

Re: Loading lzma compressed fixtures

2020-05-09 Thread Paolo Melchiorre
On 09/05/20 12:39, Tim Graham wrote: On Saturday, May 9, 2020 at 6:22:13 AM UTC-4, Paolo Melchiorre wrote: Working at my latest merged PR [1] in Django I saw in the code the lack of support for lzma compressed fixture for loaddata command so I opened a ticket [2] and a related PR [3]. I think is

Re: Removing url() ?

2020-05-09 Thread Aymeric Augustin
Hello, When proposing deprecations that require numerous but simple code changes, providing an automated upgrade path could reduce frustrations about "useless churn". Unfortunately, I don't know a great way to do that on Python code. Here are the options I'm aware of: - Writing 2to3 fixers is

Re: Removing url() ?

2020-05-09 Thread Adam Johnson
Automated upgrade tooling would be great. Developers end up building their own anyway. One more tool we could copy is pyupgrade ( https://pypi.org/project/pyupgrade/ ). It's based upon an extension to 'tokenize' by the author (Anthony Sottile) that allows roundtripping (which I guess would be usef

Re: Technical Board statement on type hints for Django

2020-05-09 Thread Aymeric Augustin
Sorry for the late answer, I didn't have time to read this mailing list for the last month :-( Here's my position on the matter. Adding type annotations only makes sense if a type checker checks them. Otherwise, they're unlikely to be correct and usable, so it would be counterproductive to add

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-09 Thread Tim Allen
I'm tentatively +1 on this change... but... While it may be a straightforward operation to do a case sensitive search and replace in most code bases, it is not trivial to do so on the rest of the web. If we're going to do this, we must realize that this will invalidate thousands of examples, tu

Re: Rename request.GET and POST, and lowercase COOKIES, FILES, and META

2020-05-09 Thread Tobias McNulty
Tim your point is well made. I'm left with the feeling that an imperfect convention is really not so bad, and possibly not worth the huge number of global developer hours it would cost to effect such a change. Plus (I make this argument mostly in jest), the new names, because they are more Python

Re: Management of static assets

2020-05-09 Thread Aymeric Augustin
Thanks David for investigating the topic thoroughly! I wasn't expecting all that when I filed a one-line ticket six years ago :-) So, here's a bunch of opinions. Before I start, I'd like to quote the intro to the Media class : > Rende