Fellow Reports - April 2020

2020-04-06 Thread Mariusz Felisiak
Week ending April 5, 2020. *Triaged:* https://code.djangoproject.com/ticket/31407 - RuntimeWarning when running AsyncHandlerRequestTests.test_unawaited_response. (accepted) https://code.djangoproject.com/ticket/31406 - Access date/time of request. (wontfix) https://code.djangoproject.com/ticket/

Re: Problema validacion pbkdf2_sha256 hash

2020-04-06 Thread Hasnat Jutt
Hello Beltran, If you want to convert hash to plain text use PBKDF2HMAC function, from cryptography.hazmat.primitives.kdf.pbkdf2 import PBKDF2HMAC On Mon, Apr 6, 2020 at 4:14 AM Rogers Andres Diaz Beltran < ing.rockerd...@gmail.com> wrote: > Buenas tardes, esta es la documenta

Subquery join support

2020-04-06 Thread Alexandr Tatarinov
Hello folks, Following the discussion https://groups.google.com/forum/#!topic/django-developers/b370mxfKCHg, I would like to suggest adding the ability to join QuerySet with a subquery clause to Django. The benefits are pretty much described and discussed in the linked topic, the only one I wo

Adding ability to choose AutoField type (signed vs unsigned)

2020-04-06 Thread Caio Ariede
Hi folks, I’ve been working on ticket #56 "Primary key columns should be UNSIGNED" (really old) for a while now. It’s cumbersome and hard to fix for some reasons, including backwards compatibility, nothing that a single PR can solve but I’ll try to summarize where things are at this moment. Ho

RE: Subquery join support

2020-04-06 Thread Matthew Pava
It is my opinion that the Subquery object that already exists in Django should act as a CTE. There is a ticket for this feature already: https://code.djangoproject.com/ticket/28919 I have noticed that several developers have proposed several different patches for CTEs, but I do not know why they

Re: Adding ability to choose AutoField type (signed vs unsigned)

2020-04-06 Thread Adam Johnson
I'm in favour of the move. The setting strategy seems appropriate. Simon's comment on the PR that this affects a small % of projects is true. But if your project does reach that scale, you're probably one of the bigger Django organizations in the world - hopefully key advocates for the framework.

Re: Adding ability to choose AutoField type (signed vs unsigned)

2020-04-06 Thread Jure Erznožnik
Sorry if I understand stuff incorrectly, but: I agree with Adam where he discusses migration issues, but I also don't see how "DEFAULT_AUTOFIELD" setting could leave tables out of the migration(s). My understanding is that it would cause immediate re-provisioning of all the pk fields, includ

Re: Adding ability to choose AutoField type (signed vs unsigned)

2020-04-06 Thread Adam Johnson
Jure - yes switching the setting should generate migrations for all affected models. The migration guide would cover changing models' primary key fields to PositiveBigAutoFields one at a time, perhaps with a mixin as you've suggested. Maybe Django should provide such a mixin to ease the migration.

Re: Problema validacion pbkdf2_sha256 hash

2020-04-06 Thread Adam Johnson
¡Hola! (Traducido con Google Translate, inglés al final) Creo que has encontrado la lista de correo incorrecta para esta publicación. Esta lista de correo es para discutir el desarrollo de Django en sí, no para el soporte con Django. Esto significa la discusión de errores y características en Djan

Re: [Probably BUG] set_password and check_password accept values other than string as parameters

2020-04-06 Thread Florian Apolloner
On Thursday, March 12, 2020 at 6:16:31 PM UTC+1, Dawid Czeluśniak wrote: > > I think that the root question here is: should we allow users to create > passwords from anything that is not str? > I would reduce it to allow strings & bytes and am willing to review a patch and push it through. It

Re: [Probably BUG] set_password and check_password accept values other than string as parameters

2020-04-06 Thread charettes
For the record a PR doing exactly that has been reviewed and merged already and should be of 3.1 https://github.com/django/django/pull/12627 Cheers, Simon Le lundi 6 avril 2020 13:54:27 UTC-4, Florian Apolloner a écrit : > > > > On Thursday, March 12, 2020 at 6:16:31 PM UTC+1, Dawid Czeluśniak

Re: [Probably BUG] set_password and check_password accept values other than string as parameters

2020-04-06 Thread Mariusz Felisiak
Hi Florian, We've already merged this change https://github.com/django/django/commit/8aa71f4e8706b6b3e4e60aaffb29d004e1378ae3.Please feel-free to review it and return any comments. Best, Mariusz -- You received this message because you are subscribed to the Google Groups "Django develop

Re: Subquery join support

2020-04-06 Thread Alexandr Tatarinov
Accidentally removed gist, new one is here https://gist.github.com/tatarinov1997/068fe786366401ed640dcbbbe5d959e4 On Monday, 6 April 2020 16:34:55 UTC+3, Alexandr Tatarinov wrote: > > Hello folks, > > Following the discussion > https://groups.google.com/forum/#!topic/django-developers/b370mxfKCH

Re: [Probably BUG] set_password and check_password accept values other than string as parameters

2020-04-06 Thread Florian Apolloner
oh, I somehow missed that. thanks for the heads-up. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsu

Re: Subquery join support

2020-04-06 Thread schinckel
Great work on this, Alexandr. I've been thinking a lot about doing joins in Django to subqueries. As you point out, when you are doing several subquery annotations of the same subquery, just with different columns, that can really hurt performance. Currently, I've been recommending doing a JSON