Re: Use "raise from" where appropriate, all over the codebase

2020-01-20 Thread Adam Johnson
Nice work Jon. I don't think we can generally apply R100 though - thre are definitely cases where "raise" inside an exception handler is not *caused* by the other exception - but maybe that's a sign refactoring is needed. On Sun, 19 Jan 2020 at 22:52, Jon Dufresne wrote: > > > I think it's rare

Re: Fellow Reports - January 2020

2020-01-20 Thread Mariusz Felisiak
Week ending January 19, 2020. *Triaged:* https://code.djangoproject.com/ticket/31161 - Remote User - user name with "\". (duplicate) https://code.djangoproject.com/ticket/31162 - GIS error logging when using WKT string as input to filter() query. (accepted) https://code.djangoproject.com/ticket/

Re: Use "raise from" where appropriate, all over the codebase

2020-01-20 Thread Ram Rachum
Jon: That's awesome! I also liked R101. I didn't think of that. Adam: I thought so too, but after going over dozens of R100 cases, I didn't find even one where a raise without "from" inside an except clause was justified. I challenge you to show me even one such example. On Mon, Jan 20, 2020 at 1

Re: ngettext_lazy and ngettext

2020-01-20 Thread אורי
Hi, Anyone wants to review PR #12332? אורי u...@speedy.net -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-develop