Re: Proposal to format Django using black

2019-04-29 Thread Carlton Gibson
Hi Alex. So I use git blame on Django *a lot: *a new ticket comes in, I have no idea at all how to triage it so I need to look at the history to make a sensible decision. I use git blame to find the commit, to find the original ticket, in which there's a discussion, which 🤞 explains why things

Re: Fellow Reports - April 2019

2019-04-29 Thread Mariusz Felisiak
Week ending April 28, 2019. *Triaged:* https://code.djangoproject.com/ticket/30387 - Move more Windows-specific docs to use Python official launcher. (accepted) https://code.djangoproject.com/ticket/30388 - inspectdb generates unique ForeignKey instead of OneToOneField. (accepted) https://code.d

Re: Proposal to format Django using black

2019-04-29 Thread Paveł Tyślacki
Just short hint about git blame. Github has functionality to get more deep git blame: https://help.github.com/en/articles/tracking-changes-in-a-file, more over pycharm has similar functionality too (potentially another editors and IDE have too). I suggest that git blame is more tooling issue, not

Re: Proposal to format Django using black

2019-04-29 Thread J. Pic
If you don't want to break git blame then I suppose you could create a branch to replay each commit with black. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiv

Re: Database Router Abstract Base Class (ABC)

2019-04-29 Thread Adam Johnson
I'm a bit ambivalent on adding such a class. Many features even in core Python don't provide base classes and instead rely on duck-typing + documentation. The amount of time saved globally will probably be less than the time we've spent discussing it so far. I think a more valuable piece of code w

Re: Support for CTAS statement with ORM API?

2019-04-29 Thread Adam Johnson
Hi Markus It seems that the functionality is already usable by this class library > in a convenient way. How do you think about the addition of a base class like “table” with the method “create(parameters)” (if it would not be provided so far)? To both of these - the Django ORM doesn't work i

Re: Support for CTAS statement with ORM API?

2019-04-29 Thread Markus Elfring
> To both of these - the Django ORM doesn't work in the same way as SQLAlchemy. I guess that it can become interesting to clarify software differences a bit more. > Django does not have such a representation, Thanks for such background information. > it bundles everything in the Query class.