Re: Simplify middlewares (again) and get rid of process_view

2018-05-30 Thread Carl Meyer
On 5/16/18 10:49 AM, Florian Apolloner wrote: > Hi Carl, > > On Wednesday, May 16, 2018 at 5:58:02 AM UTC+2, Carl Meyer wrote: > > I'm not sure this part is feasible. It's an intentional part of > middleware design AFAIK (and useful) that middleware can modify > request.path and have

Re: Fellow Reports -- May 2018

2018-05-30 Thread Carlton Gibson
Hi all. Calendar Week 20 -- ending 18th May. Reviewed Patches on: https://code.djangoproject.com/ticket/29408 -- ordering by field from related model does not validate if field exists https://code.djangoproject.com/ticket/28743 -- Clarify the term "deployment server" in the documentation htt

Re: #29433 New split template filter

2018-05-30 Thread Carlton Gibson
Hi Kamil, I'd think the preference here would be to NOT add new filters lightly — i.e. to close as wontfix — and recommend users create their own filters (or pull the logic into say a `get_context()` method) if they need this kind of thing. Slight aside: "Hi guys" may not fairly address ever

Re: #29433 New split template filter

2018-05-30 Thread Collin Anderson
There's been a few cases where I would have found a split filter to be useful. I don't remember them off the top of my head. I like that the behavior of it should be pretty well defined: just return obj.split() if val is None else obj.split(val) On Wed, May 30, 2018 at 6:32 AM, Carlton Gibson wr

Spaces between argument separator and argument in template filter generate error

2018-05-30 Thread oliver
In the template filter system now, spaces between augment separator and augments generate error. For example, the following template code generates the following error. {{ value | filter: "arg"}} TemplateSyntaxError at / Could not parse the remainder: ': "arg"' from 'value | filter: "arg"' ht