Re: ConnectionResetError in test_closes_connection_without_content_length

2017-09-20 Thread Adam Johnson
Hi Zhiqiang It's hard to tell what the problem is with more details. From your traceback it looks like you're running Python3.4 on MacOS but there's no indication of your database or other settings. If you run the tests on the 1.11 branch, does it pass? If so, you can bisect to find the regressio

Re: ConnectionResetError in test_closes_connection_without_content_length

2017-09-20 Thread Tom Forbes
I added this test for the keep-alive release blocker. It's possible that the exceptions raised in that test vary by OS at least on 3.4, the docs suggest that it should throw BadStatusLine instead. ConnectionResetError is also a correct exception to raise in that specific case, we should just add t

Re: status of 2.0 release blockers

2017-09-20 Thread Tim Graham
Thanks for the feedback. I think the indentation changes are correct, but please leave a comment on the PR so I can be sure which lines you're referring to. I added this text to the release notes per your suggestion: The ``django.conf.urls.url()`` function from previous versions is now availabl

Re: ConnectionResetError in test_closes_connection_without_content_length

2017-09-20 Thread Zhiqiang Liu
> > Yeah I believe it is a new test, so I can't test if it is working for 1.11. > I did get it to pass after adding except like this try: conn.request('GET', '/example_view/', headers={'Connection': 'keep-alive'}) response = conn.getresponse().read()

Re: status of 2.0 release blockers

2017-09-20 Thread Tim Graham
completed today: https://github.com/django/django/pull/7482 - Simplified URL routing syntax. (code) https://github.com/django/django/pull/9072 - Simplified URL routing syntax. (docs) https://github.com/django/django/pull/9100

New Feature: Allow password reset token to expire in under a day

2017-09-20 Thread Zhiqiang Liu
I need general consensus on how to proceed with supporting password expire time to be under a day. Currently it is not possible because we use PASSWORD_RESET_TIMEOUT_DAYS. In ticket 28622 we have two options. One is to continue to use the same set