To keep or not to keep: logging of undefined template variables

2017-03-16 Thread Tim Graham
Ticket #18773 [0] added logging of undefined template variables in Django 1.9 [1], however, I've seen several reports of users finding this logging more confusing than helpful. For example, admin templates log errors about missing is_popup variables [2] which is how the template are designed (i

Permission classes for Class Based Views

2017-03-16 Thread piotr . szpetkowski
Hello, my first post here! This post is about a new feature request I'd like to propose and it's about permission classes (just like I've stated in topic) for CBVs. I've provided most of the technical information at [0], because I think that such information is more ticket-specific, however I'm

Re: Permission classes for Class Based Views

2017-03-16 Thread Marc Tamlyn
I don't feel there is any need for this feature in Django. As you mention in the ticket, there are ways of approaching it used in DRF, there are other ways in django-braces[0], I personally have my own taste in how to handle it. The details will depend on the logic necessary - sometimes you need to