Channels: get IP address of client websocket

2017-02-17 Thread Fabien Millerand
As far as I know I cannot get client websocket public IP address with channels. I even looked into the sessions and couldn't find anything. Did I miss it? -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group

Re: Channels: get IP address of client websocket

2017-02-17 Thread Andrew Godwin
It's in the connect message, as message['client']: http://channels.readthedocs.io/en/latest/asgi.html#connection Andrew On Fri, Feb 17, 2017 at 10:05 AM, Fabien Millerand wrote: > As far as I know I cannot get client websocket public IP address with > channels. > > I even looked into the sessio

Re: Use signing backend for signed_cookie session engine

2017-02-17 Thread Tim Graham
These questions involving old code aren't always easily answered. I would try to answer it by looking through git blame and finding the relative commits and tickets to see if there's an explanation there. On Wednesday, February 15, 2017 at 8:07:45 PM UTC-5, Danielle Madeley wrote: > > Hi all, >

Extending Django models with Schevo

2017-02-17 Thread Etienne Robillard
Hi, I'm planning to extend django-hotsauce to support a generic "model" API. I would like to reuse the Django models API to support Schevo databases. Ideally, I would like to introspect into my reusable Django apps to discover configured features. Importing and exporting data from/to Schevo d

Re: Template handling of undefined variables

2017-02-17 Thread Tim Graham
After reviewing the pull request, I wonder if it would be better to raise exceptions when comparing nonexistent variables in {% if %} rather than altering the behavior. For existing projects, this would prevent possible inadvertent information leakage if some {% if %} starts evaluating differen

Re: Extending Django models with Schevo

2017-02-17 Thread Tim Graham
Hi Etienne, I'm not sure exactly what type of response you're looking for or if this is on-topic for the Django developers mailing list, which pertains to the development of Django itself. django-users seems more appropriate unless you're proposing some feature for Django. On Friday, February 1

Re: Django 2.0 Python version support (Python 3.6+ only?)

2017-02-17 Thread Tim Graham
Ok, I created a ticket to track cleanups and new Python features we can use when Python 3.4 support is removed: https://code.djangoproject.com/ticket/27857 We can evaluate that a bit later in the Django 2.0 release cycle and decide whether or not to keep Python 3.4 support for 1.11. On Wednesd

Re: Some thoughts about improving migration squashing

2017-02-17 Thread charettes
Hello Raphael, Thanks for your detailed explanation! You clearly expressed why it's safe to optimize through RemoveField operations and helped me lift any doubt about what was a wrong assumption[1]. I gave your two passes optimization strategy a try and I believe I managed to implement it correc