Re: Sonar for the Django rpoject

2016-09-05 Thread Hanne Moa
Is there a way to ignore django.utils.dateformat? That code is very straight forward, and it is not supposed to be called manually by humans. I can't see how a "fix" would improve things. Munging the second string in the getattr? Adding "upper" and "lower" or something similar to each method-name?

Re: Django default PK type setting

2016-09-05 Thread Marc Tamlyn
For what it's worth I think this is *much* harder than it appears on the surface. Whilst setting another field as the PK is easy, setting another base type as an "auto" field is surprisingly tricky - lots of AutoField assumes integers. However, I do think it has some merits. An obvious benefit to

Re: PEP 484 type hinting in Django

2016-09-05 Thread Daniel Moisset
Hi Graham, thanks for the support. I'm aiming at Django 1.10 right now, but given that APIs are more stable than implementation, you may have some success with other versions. This is just a guess, I haven't tried Best, D. On Sat, Aug 27, 2016 at 7:29 AM, Graham Wideman wrote: > First -- t

Re: status of 1.10 release blockers

2016-09-05 Thread Tim Graham
As usual, the monthly bug fix release (1.10.1) is planned for tomorrow, September 1. A remaining issue that could use some attention is about makemigrations and the new history consistency checks that were added in 1.10. These checks created problems in various multiple database setups, for exa

Re: Sonar for the Django rpoject

2016-09-05 Thread Aymeric Augustin
Hello Ivan, Given that both Django and Sonar are open-source, anyone should be able to reproduce your results easily… If there are security issues, please email them to secur...@djangoproject.com instead of publishing them. That’ll make them a bit less easy t

Helping a Newbie

2016-09-05 Thread Dávid Főző
Dear Devs, I would like to contribute to the Django code base as a python developer. I am a user of Django, but haven't delved on into the code itself that thoroughly. After I read through the documentation a couple times, it's still not clear how do you select the ticket. I mean how do you kno

Re: status of 1.10 release blockers

2016-09-05 Thread Tim Graham
As usual, the monthly bug fix release (1.10.1) is planned for tomorrow, September 1. There's one issue that could use some attention. The new migrations history consistency checks in makemigrations have triggered some problems in various multiple database setups, such as with a read-only non-de

Re: Add past/present/future validations for Date and DateTime types

2016-09-05 Thread Aymeric Augustin
I suppose Min / MaxValueValidator cannot be reused here because they expect a fixed bound, while past / future depends on the current date? The implementation Mariano provided looks simple enough to reproduce and adapt to each project’s requirements (even though I’d prefer duck typing to type c

Re: Sonar for the Django rpoject

2016-09-05 Thread Alex Gaynor
If these are what qualifies as critical, I don't think this is a good use of our time. Alex On Wed, Aug 31, 2016 at 1:50 PM, Ivan Sevastoyanov < ivan.sevastoya...@gmail.com> wrote: > >

Re: Django default PK type setting

2016-09-05 Thread Aymeric Augustin
I tend to agree with Marc. While I’m less than enthusiastic about the prospect of adding a new setting for this, I noticed a few times in the past that Django's support for UUID PKs was buggy, perhaps in the admin (I don’t remember the details and I can’t say if all these bugs have been fixed).

Re: Sonar for the Django rpoject

2016-09-05 Thread James Bennett
On Wed, Aug 31, 2016 at 10:55 AM, Alex Gaynor wrote: > If these are what qualifies as critical, I don't think this is a good use > of our time. > > > Agreed. If those are the critical things, then either Django is really really good, or there are things it's missing. I suspect there are things it

Re: Django default PK type setting

2016-09-05 Thread Emett Speer
I have not run into any issues with UUID PKs with Django 1.8 - 1.10 yet. If memory services me the UUIDFIeld in models is still relatively new at the moment. On Monday, September 5, 2016 at 7:12:35 AM UTC-7, Aymeric Augustin wrote: > > I tend to agree with Marc. > > While I’m less than enthusias

Re: Django default PK type setting

2016-09-05 Thread Emett Speer
I'm happy to hear that I'm not 100% alone on this one. I also agree that this would be a much harder add then it may appear. Though I'm not suggesting any modifications to the AutoField I'm suggesting a setting that would make undefined ID fields in models UUID's by default rather then an Int.

Re: PEP 484 type hinting in Django

2016-09-05 Thread Graham Wideman
Hi Daniel, thanks for replying. My question was less about what version of django you were targeting, and more about how a type-hints library such as this should be annotated to indicate what version(s) it targets. Since a type hints library may well be distributed separately from the code th