Adrian Holovaty wrote:
> This is a nice, clean approach -- good work! The patch is looking
> good. Go ahead and check it in at your leisure.
Checked in as http://code.djangoproject.com/changeset/5803
--~--~-~--~~~---~--~~
You received this message because you are
On 8/4/07, Gary Wilson <[EMAIL PROTECTED]> wrote:
> I attached a new patch which issues a PendingDeprecationWarning.
>
> The new patch also uses a metaclass for FormField and Field classes to
> decorate __init__ instead of having to call legacy_maxlength in almost
> every subclass's __init__. Thi
Jacob Kaplan-Moss wrote:
> On 7/30/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote:
>> That sounds like the best thing to do -- I don't see a huge need to
>> deprecate maxlength immediately, or even issue warnings about it. The
>> change gets a +1 from me.
>
> I'd say that making maxlength issue a
Thanks for updating, Gary. I was letting it slide until after newforms-
admin hit. Good to see it's got a committer champion now ;)
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post
On 7/30/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote:
> That sounds like the best thing to do -- I don't see a huge need to
> deprecate maxlength immediately, or even issue warnings about it. The
> change gets a +1 from me.
I'd say that making maxlength issue a PendingDeprecationWarning --
which
On 7/30/07, Gary Wilson <[EMAIL PROTECTED]> wrote:
> The patch actually still keeps maxlength around, raising an error only
> if both max_length and maxlength are used. Currently, there is no
> warning if maxlength is used, but that could be added.
That sounds like the best thing to do -- I don'
Jacob Kaplan-Moss wrote:
> Seems that making the change outright would annoy a whole host of
> people... IIRC, we'd decided to deprecate max_length and issue
> warnings... does that sound right?
The patch actually still keeps maxlength around, raising an error only
if both max_length and maxlengt
On 7/30/07, Gary Wilson <[EMAIL PROTECTED]> wrote:
> I brought the patch back in sync with trunk, and would like to make a
> call for some eyes, as this is a big, mostly boring, patch. I don't
> want to let this one get 6 months out of date again :)
Someone remind me -- did we decide what we wan
I brought the patch back in sync with trunk, and would like to make a
call for some eyes, as this is a big, mostly boring, patch. I don't
want to let this one get 6 months out of date again :)
Thanks,
Gary
--~--~-~--~~~---~--~~
You received this message because y
