Re: select_related() changes

2007-03-03 Thread Boris Erdmann
The main problem with depth=1 seems to be, that the query generator still spans over too many tables (watching the mysql.log i can see tables fully joined that definitvly do not belong to level 1). Thus the returned data set will surely confuse django. Looking at django/db/models/query.py reveals

Re: select_related() changes

2007-01-11 Thread David Cramer
It still seems to have a bug when just doing .select_related(depth=1), sometimes its filling the field w/ the wrong data, looking into it. On Jan 11, 11:31 am, "David Cramer" <[EMAIL PROTECTED]> wrote: > I retract my statement, we had some other random server configuration > error that just happe

Re: select_related() changes

2007-01-11 Thread David Cramer
I retract my statement, we had some other random server configuration error that just happened to appear at the same time as us putting this live :) On Jan 10, 8:34 pm, "David Cramer" <[EMAIL PROTECTED]> wrote: > It seems there are some issues with the code. Although I'm not sure why > it's happe

Re: select_related() changes

2007-01-10 Thread David Cramer
It seems there are some issues with the code. Although I'm not sure why it's happening, this was causing servers to get extremely loaded, and the SQL queries werent executing properly. I had no issues when running it on runserver before we pushed it onto a live environment though. Going to look i

Re: select_related() changes

2007-01-10 Thread Michael Radziej
David Cramer schrieb: > I can do the docs, but it'd be a great time saver if you could do the > tests. I'm up to my elbows in work at the moment so :) Fine for me, then I take the tests. Michael -- noris network AG - Deutschherrnstraße 15-19 - D-90429 Nürnberg - Tel +49-911-9352-0 - Fax +49-9

Re: select_related() changes

2007-01-10 Thread David Cramer
I can do the docs, but it'd be a great time saver if you could do the tests. I'm up to my elbows in work at the moment so :) On Jan 10, 4:37 pm, Michael Radziej <[EMAIL PROTECTED]> wrote: > Hi David, > > if you want me to write the docs or the tests, let me know. I > could deliver within a day or

Re: select_related() changes

2007-01-10 Thread Michael Radziej
Hi David, if you want me to write the docs or the tests, let me know. I could deliver within a day or two. Michael -- noris network AG - Deutschherrnstraße 15-19 - D-90429 Nürnberg - Tel +49-911-9352-0 - Fax +49-911-9352-100 http://www.noris.de - The IT-Outsourcing Company --~--~-~

Re: select_related() changes

2007-01-10 Thread Jacob Kaplan-Moss
On 1/10/07 9:23 AM, David Cramer wrote: > Not quite sure what to write in terms of the documentation :) Essentially you just need to add a few paragraphs and examples to the db_api doc (http://www.djangoproject.com/documentation/db_api/#select-related) explaining what the parameters are, and wh

Re: select_related() changes

2007-01-10 Thread David Cramer
Not quite sure what to write in terms of the documentation :) On Jan 10, 4:07 pm, "Waylan Limberg" <[EMAIL PROTECTED]> wrote: > On 1/10/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > > > I'd like this to become core functionality as I feel its needed.For that > > to happen, you will lik

Re: select_related() changes

2007-01-10 Thread Jacob Kaplan-Moss
On 1/10/07 9:07 AM, Waylan Limberg wrote: > On 1/10/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >> I'd like this to become core functionality as I feel its needed. On the surface it looks pretty good, so I'd say you're pretty close to getting this considered for inclusion. > For that to h

Re: select_related() changes

2007-01-10 Thread Michael Radziej
Waylan Limberg schrieb: > On 1/10/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >> I'd like this to become core functionality as I feel its needed. > > For that to happen, you will likely need to do everything listed here > [1]. That includes writing some unit tests for the new functionality

Re: select_related() changes

2007-01-10 Thread Waylan Limberg
On 1/10/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > I'd like this to become core functionality as I feel its needed. For that to happen, you will likely need to do everything listed here [1]. That includes writing some unit tests for the new functionality and documentation explaining ho

Re: select_related() changes

2007-01-10 Thread David Cramer
http://code.djangoproject.com/ticket/3275 Thanks :) On Jan 10, 2:50 pm, Nikolaus Schlemm <[EMAIL PROTECTED]> wrote: > > Any links to an example ticket so I can keep a normal format for what > > im going to post? :)take a look at the tickets with patches: > >http://code.djangoproject.com/

Re: select_related() changes

2007-01-10 Thread Nikolaus Schlemm
> Any links to an example ticket so I can keep a normal format for what > im going to post? :) take a look at the tickets with patches: http://code.djangoproject.com/report/12 -- cheers, Nikl --~--~-~--~~~---~--~~ You received this message becau

Re: select_related() changes

2007-01-10 Thread Michael Radziej
David Cramer schrieb: > Any links to an example ticket so I can keep a normal format for what > im going to post? :) General information about contributions: http://www.djangoproject.com/documentation/contributing/ There are plenty of tickets in the timeline: http://code.djangoproject.com/timeli

Re: select_related() changes

2007-01-10 Thread David Cramer
Any links to an example ticket so I can keep a normal format for what im going to post? :) On Jan 10, 11:40 am, "Honza Král" <[EMAIL PROTECTED]> wrote: > On 1/10/07, David Cramer <[EMAIL PROTECTED]> wrote: > > > > > What's the svn command for generating the diff?svn diff > > you go into the top-l

Re: select_related() changes

2007-01-10 Thread Honza Král
On 1/10/07, David Cramer <[EMAIL PROTECTED]> wrote: > > What's the svn command for generating the diff? svn diff you go into the top-level directory of your checked-out django, do svn diff and capture the output > > On Jan 10, 11:07 am, Michael Radziej <[EMAIL PROTECTED]> wrote: > > [EMAIL P

Re: select_related() changes

2007-01-10 Thread David Cramer
What's the svn command for generating the diff? On Jan 10, 11:07 am, Michael Radziej <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] schrieb: > > > Updated paste:http://dpaste.com/hold/4539/Thanks for your code, and I would > > have good use for some > improvements on select_related. But it's har

Re: select_related() changes

2007-01-10 Thread Michael Radziej
[EMAIL PROTECTED] schrieb: > Updated paste: http://dpaste.com/hold/4539/ Thanks for your code, and I would have good use for some improvements on select_related. But it's hard for me to see what changed in the paste. The common way to suggest or discuss changes on this list is to open a ticke

Re: select_related() changes

2007-01-10 Thread David Cramer
http://dpaste.com/hold/4541/ :) On Jan 10, 8:39 am, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > Updated paste:http://dpaste.com/hold/4539/ > > Should be no problems now :) > > On Jan 10, 8:22 am, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > > > Code Source:http://dpaste.com/hold/4538/ >

Re: select_related() changes

2007-01-09 Thread [EMAIL PROTECTED]
Updated paste: http://dpaste.com/hold/4539/ Should be no problems now :) On Jan 10, 8:22 am, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > Code Source:http://dpaste.com/hold/4538/ > > This replaces django/db/query.py and adds two arguments for > select_related(): > > depth=N, the recursion de

select_related() changes

2007-01-09 Thread [EMAIL PROTECTED]
Code Source: http://dpaste.com/hold/4538/ This replaces django/db/query.py and adds two arguments for select_related(): depth=N, the recursion depth, by default, infinite, follows any key where blank isn't True fields=[], a list of fields, right now only supports fields from the base table. I'd