Re: r15401 and removing star imports

2011-02-05 Thread Florian Apolloner
In previous Django versions it was necessary to import those; that's no longer the case. Cheers, Florian On Feb 5, 11:21 am, lucky wrote: > Look at > thehttp://code.djangoproject.com/browser/django/trunk/django/conf/urls/d... > . > There are __all__ = ['handler404', 'handler500', 'include', > '

Re: r15401 and removing star imports

2011-02-05 Thread lucky
Look at the http://code.djangoproject.com/browser/django/trunk/django/conf/urls/defaults.py#L4 . There are __all__ = ['handler404', 'handler500', 'include', 'patterns', 'url'] It seems as you forgot to add 'handler404' and 'handler500'. Whats about handlers? On Feb 4, 10:50 pm, Carl Meyer wrote:

Re: r15401 and removing star imports

2011-02-04 Thread Carl Meyer
Only reason I didn't add it to the import is that it's not used in any of the commented sample lines. But the better solution is to import it and demonstrate using it. Done in http://code.djangoproject.com/changeset/15415 Thanks for the suggestion. Carl -- You received this message because you

Re: r15401 and removing star imports

2011-02-03 Thread bpeschier
On 3 feb, 10:28, Florian Apolloner wrote: > I think the "url" function should get added to the imports > inhttp://code.djangoproject.com/changeset/15401since many people use it > by now. Any thoughts or objections? +1 on that, I think it would be beneficial even for beginners to see url included

r15401 and removing star imports

2011-02-03 Thread Florian Apolloner
Hi, I think the "url" function should get added to the imports in http://code.djangoproject.com/changeset/15401 since many people use it by now. Any thoughts or objections? Cheers, Florian -- You received this message because you are subscribed to the Google Groups "Django developers" group. T