Re: pull request: write feeds with ordered attributes

2017-02-13 Thread Georg Sauthoff
On Sun, Feb 12, 2017 at 10:01:28PM +, Adam Johnson wrote: > Ok, looks like the second version (conditionally sorting) is the most > sensible to go with. Ok, I've rebased the pull request such that it includes the conditional sorting: https://github.com/django/django/pull/8044 Best regards Ge

Re: pull request: write feeds with ordered attributes

2017-02-12 Thread Adam Johnson
Ok, looks like the second version (conditionally sorting) is the most sensible to go with. On 12 February 2017 at 16:27, Georg Sauthoff wrote: > On Sat, Feb 11, 2017 at 08:15:08PM +, Adam Johnson wrote: > > I can see the advantage from an operational perspective with files > matching > > byt

Re: pull request: write feeds with ordered attributes

2017-02-12 Thread Georg Sauthoff
On Sat, Feb 11, 2017 at 08:15:08PM +, Adam Johnson wrote: > I can see the advantage from an operational perspective with files matching > byte-for-byte. I know many API's do the same with sorting the keys in their > JSON output for the same reason. > I should think the performance impact isn'

Re: pull request: write feeds with ordered attributes

2017-02-11 Thread Adam Johnson
prove it's not disastrous. On 11 February 2017 at 11:36, Georg Sauthoff wrote: > (please CC me) > > Hello, > > I recently created this small pull request: > > write feeds with ordered attributes (#8044) > https://github.com/django/django/pull/8044 > > Tim Grah

pull request: write feeds with ordered attributes

2017-02-11 Thread Georg Sauthoff
(please CC me) Hello, I recently created this small pull request: write feeds with ordered attributes (#8044) https://github.com/django/django/pull/8044 Tim Graham suggested that I also write to the mailing list to reach a consensus. Thus, please have a look. Best regards Georg -- 'The