On Tue, 2007-05-22 at 21:52 +, SmileyChris wrote:
> > #3896 - pass value to field specific clean function [2]
>
> How expensive is a try/except?
>
> Call clean_foo passing the value as a parameter and if that fails, use
> the old method (setting the value in cleaned_data, then calling
> clea
> #3896 - pass value to field specific clean function [2]
How expensive is a try/except?
Call clean_foo passing the value as a parameter and if that fails, use
the old method (setting the value in cleaned_data, then calling
clean_foo with no parameters)
Seems backwards compatible to me.
--~--
>> #3718 - newforms.Form.clean should have access to field errors [1]
Would like to see this one, too. Some validation I do currently is based
on the not-in-cleaned_data-trick, but this is IMHO not very clean.
And may be due to other reasons. For example if the field-clean-method
you want to vali
On 5/22/07, Gary Wilson <[EMAIL PROTECTED]> wrote:
>
> I would like to request comments/suggestions about a few patches I have
> submitted recently for the newforms library that solve some issues that
> I encountered during the development of some newforms.
>
> #3718 - newforms.Form.clean should h
On Mon, 2007-05-21 at 23:14 -0500, Gary Wilson wrote:
> Malcolm Tredinnick wrote:
> >> #3718 - newforms.Form.clean should have access to field errors [1]
> >
> > I'm not sure what this really gains. Fixing the second part of #3896
> > means that all the necessary information is in cleaned_data. I
Malcolm Tredinnick wrote:
>> #3718 - newforms.Form.clean should have access to field errors [1]
>
> I'm not sure what this really gains. Fixing the second part of #3896
> means that all the necessary information is in cleaned_data. I'm -0 on
> this, because I feel it's pretty pointless, merely pr
On 5/21/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote:
> > #3896 - pass value to field specific clean function [2]
>
> Grr...don't put two issues in one ticket!
>
> I'm -1 on the first part because it's an unnecessary backwards
> incompatibility change for the most part. It's not like it's a ma
On Tue, 2007-05-22 at 11:24 +1000, Malcolm Tredinnick wrote:
> Hey Gary,
>
> On Mon, 2007-05-21 at 19:56 -0500, Gary Wilson wrote:
[...]
>
> > #3896 - pass value to field specific clean function [2]
>
> Grr...don't put two issues in one ticket!
>
> I'm -1 on the first part because it's an unne
Hey Gary,
On Mon, 2007-05-21 at 19:56 -0500, Gary Wilson wrote:
> I would like to request comments/suggestions about a few patches I have
> submitted recently for the newforms library that solve some issues that
> I encountered during the development of some newforms.
>
> #3718 - newforms.Form.c
I would like to request comments/suggestions about a few patches I have
submitted recently for the newforms library that solve some issues that
I encountered during the development of some newforms.
#3718 - newforms.Form.clean should have access to field errors [1]
#3896 - pass value to field spe
10 matches
Mail list logo
