Re: newforms-admin change history

2007-12-04 Thread Patryk Zawadzki
2007/12/4, Karen Tracey <[EMAIL PROTECTED]>: > Anyone want to register an opinion on how deep in the hierarchy this should > go? Seems to me it could be generally useful for BaseForm to be able to > report what fields' cleaned values are different from what was specified as > initial data. +1 fr

Re: newforms-admin change history

2007-12-04 Thread Karen Tracey
On 12/3/07, Joseph Kocherhans <[EMAIL PROTECTED]> wrote: > > > Didn't see one so I opened one, #6117. From a brief look it seems to me > the > > way to determine what has changed would be to compare the cleaned_data > > values for fields to the corresponding initial values? If you think > that's

Re: newforms-admin change history

2007-12-03 Thread Joseph Kocherhans
On 12/3/07, Karen Tracey <[EMAIL PROTECTED]> wrote: > On 12/3/07, Joseph Kocherhans <[EMAIL PROTECTED]> wrote: > > > > > On 12/3/07, Karen Tracey <[EMAIL PROTECTED]> wrote: > > > In testing out the latest (r6864) newforms-admin branch I noticed that > the > > > change history for items I changed a

Re: newforms-admin change history

2007-12-03 Thread Karen Tracey
On 12/3/07, Joseph Kocherhans <[EMAIL PROTECTED]> wrote: > > > On 12/3/07, Karen Tracey <[EMAIL PROTECTED]> wrote: > > In testing out the latest (r6864) newforms-admin branch I noticed that > the > > change history for items I changed always said "No fields changed." even > > though I was changing

Re: newforms-admin change history

2007-12-03 Thread Joseph Kocherhans
On 12/3/07, Karen Tracey <[EMAIL PROTECTED]> wrote: > In testing out the latest (r6864) newforms-admin branch I noticed that the > change history for items I changed always said "No fields changed." even > though I was changing fields. Looking at the code I see it's because the > old change histo

newforms-admin change history

2007-12-03 Thread Karen Tracey
In testing out the latest (r6864) newforms-admin branch I noticed that the change history for items I changed always said "No fields changed." even though I was changing fields. Looking at the code I see it's because the old change history code is commented out, with a big TODO comment. I don't k