Re: newforms: better table markup

2007-04-04 Thread Jason Davies
On Apr 2, 8:31 pm, "Adrian Holovaty" <[EMAIL PROTECTED]> wrote: > On 4/2/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > > > On 4/1/07, James Bennett <[EMAIL PROTECTED]> wrote: > > > Anyone have strong opinions against this before I whip up a patch? > > > +1 on adding "headers", -1 on adding

Re: newforms: better table markup

2007-04-02 Thread Adrian Holovaty
On 4/2/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > On 4/1/07, James Bennett <[EMAIL PROTECTED]> wrote: > > Anyone have strong opinions against this before I whip up a patch? > > +1 on adding "headers", -1 on adding (for the same reason we > leave out). -1 on for the same reason. As for

Re: newforms: better table markup

2007-04-02 Thread Ivan Sagalaev
James Bennett wrote: > Another possible improvement would be -- since we're outputting XHTML > here -- to also include the wrapping around the > output, since the 'tbody' element is not implied in XHTML (though > we're not providing the wrapping , or the wrapping > in as_list(), which seems weir

Re: newforms: better table markup

2007-04-02 Thread Jacob Kaplan-Moss
On 4/1/07, James Bennett <[EMAIL PROTECTED]> wrote: > Anyone have strong opinions against this before I whip up a patch? +1 on adding "headers", -1 on adding (for the same reason we leave out). Jacob --~--~-~--~~~---~--~~ You received this message because you a

newforms: better table markup

2007-04-01 Thread James Bennett
At the moment, BaseForm.as_table() does a fairly good job of presenting the form cleanly, but I think there are a couple things worth tweaking. Consider a simple example form: class SampleForm(forms.Form): name = forms.CharField() Calling as_table() will print out an instance of this form l