Re: newforms: apply_changes

2007-01-04 Thread SmileyChris
Patch created: http://code.djangoproject.com/ticket/3232 On Dec 30 2006, 8:45 am, "SmileyChris" <[EMAIL PROTECTED]> wrote: On Dec 29, 6:57 pm, "Adrian Holovaty" <[EMAIL PROTECTED]> wrote: > This wouldn't work, because self.fields is a dictionary of newforms > Field objects, *not* database Fiel

Re: newforms: apply_changes

2006-12-29 Thread SmileyChris
On Dec 29, 6:57 pm, "Adrian Holovaty" <[EMAIL PROTECTED]> wrote: This wouldn't work, because self.fields is a dictionary of newforms Field objects, *not* database Field objects. The "f.attname" wouldn't be available. It was just concept code to see if there was any merit in the idea. If you th

Re: newforms: apply_changes

2006-12-28 Thread Adrian Holovaty
On 12/28/06, SmileyChris <[EMAIL PROTECTED]> wrote: How about if form_for_instance just set something like `default_instance` for the form and apply_changes was made available to all Forms. New method for BaseForm: def apply_changes(self, instance=None, save=True): if not instance:

newforms: apply_changes

2006-12-28 Thread SmileyChris
It seems like the newly added apply_changes method (to form_for_instance) could be useful in other cases too if it was a bit more "open-minded". I don't see why apply_changes should bother about creating a field list again when that has already been done in form_for_instance. Can't it just use t