Re: media in ModelAdmin

2010-03-20 Thread Luca Sbardella
Now I know the best practice. I leave it as it is. Thanks On 20 Mar, 11:49, Russell Keith-Magee wrote: > On Sat, Mar 20, 2010 at 6:43 PM, Simon Meers wrote: > >> As documented here [1], the ticket is closed when the code is > > >> committed to SVN. If you think you've met all the requirements fo

Re: media in ModelAdmin

2010-03-20 Thread Russell Keith-Magee
On Sat, Mar 20, 2010 at 6:43 PM, Simon Meers wrote: >> As documented here [1], the ticket is closed when the code is >> >> committed to SVN. If you think you've met all the requirements for the >> code to be committed to trunk, you can mark a ticket >> ready-for-checkin. >> >> [1] http://docs.djan

Re: media in ModelAdmin

2010-03-20 Thread Simon Meers
> > As documented here [1], the ticket is closed when the code is > committed to SVN. If you think you've met all the requirements for the > code to be committed to trunk, you can mark a ticket > ready-for-checkin. > > [1] http://docs.djangoproject.com/en/1.1/internals/contributing/ > > The way I

Re: media in ModelAdmin

2010-03-20 Thread Russell Keith-Magee
On Sat, Mar 20, 2010 at 6:06 PM, Luca Sbardella wrote: > Hi Russell, > I made a couple of changes to forms.widgets in relation to your > comments. > Tests passed. Shall I close the ticket? (not sure about best practice) No. As documented here [1], the ticket is closed when the code is committed

Re: media in ModelAdmin

2010-03-20 Thread Luca Sbardella
Hi Russell, I made a couple of changes to forms.widgets in relation to your comments. Tests passed. Shall I close the ticket? (not sure about best practice) Thanks Luca On 19 Mar, 00:55, Russell Keith-Magee wrote: > On Thu, Mar 18, 2010 at 9:57 PM, Luca Sbardella > > > > > > wrote: > > Currently

Re: media in ModelAdmin

2010-03-18 Thread Russell Keith-Magee
On Thu, Mar 18, 2010 at 9:57 PM, Luca Sbardella wrote: > Currently, the media object is converted to safe string in both > "add_view" and "change_view" when added to the context dictionary > while in "changelist_view" is not (the correct approach). > Converting media to string means you cannot spl

media in ModelAdmin

2010-03-18 Thread Luca Sbardella
Currently, the media object is converted to safe string in both "add_view" and "change_view" when added to the context dictionary while in "changelist_view" is not (the correct approach). Converting media to string means you cannot split css from js in templates. What I'd like to do is ... {% for